сб, 14 сент. 2019 г. в 13:33, Niels Möller :
>
> Dmitry Eremin-Solenikov writes:
>
> > Any feedback on v2 of patchset?
>
> Looks good, merged onto a branch godthash94cp. Not sure what to do about
> the MD_UPDATE cleanup, though, maybe we need to revert that one out to
> not change the abi (unless
сб, 14 сент. 2019 г. в 13:47, Niels Möller :
>
> Daiki Ueno writes:
>
> > From: Daiki Ueno
> >
> > The changes from the previous series are:
> > - remove the global hmac_*_set_key_expanded functions
> > - leave out set_nonce member if the operation is not supported
> >
> > For the latter, I was
сб, 14 сент. 2019 г. в 13:33, Niels Möller :
>
> Dmitry Eremin-Solenikov writes:
>
> > Any feedback on v2 of patchset?
>
> Looks good, merged onto a branch godthash94cp. Not sure what to do about
> the MD_UPDATE cleanup, though, maybe we need to revert that one out to
> not change the abi (unless
Daiki Ueno writes:
> From: Daiki Ueno
>
> The changes from the previous series are:
> - remove the global hmac_*_set_key_expanded functions
> - leave out set_nonce member if the operation is not supported
>
> For the latter, I was wondering whether it is better to define a no-op
> set_nonce,
Dmitry Eremin-Solenikov writes:
> Any feedback on v2 of patchset?
Looks good, merged onto a branch godthash94cp. Not sure what to do about
the MD_UPDATE cleanup, though, maybe we need to revert that one out to
not change the abi (unless we decide to do an abi change for other
reasons).
Dmitry Eremin-Solenikov writes:
> --- a/gosthash94.h
> +++ b/gosthash94.h
> @@ -87,8 +87,9 @@ struct gosthash94_ctx
> {
>uint32_t hash[8]; /* algorithm 256-bit state */
>uint32_t sum[8]; /* sum of processed message blocks */
> - uint64_t length; /* number of processed bytes */
> -
