Re: [PATCH v2 0/6] Add meta interface for MAC algorithms

2019-11-15 Thread Dmitry Eremin-Solenikov
Hello, ср, 18 сент. 2019 г. в 08:38, Niels Möller : > > Dmitry Eremin-Solenikov writes: > > >> 2. What should be the behavior for usage like > >> > >>->set_key > >>->set_nonce > >>->update > >>->digest > >>->update > >>->digest > >> > >>with second set_nonce missing?

Re: [PATCH v2 0/6] Add meta interface for MAC algorithms

2019-09-17 Thread Niels Möller
Dmitry Eremin-Solenikov writes: >> 2. What should be the behavior for usage like >> >>->set_key >>->set_nonce >>->update >>->digest >>->update >>->digest >> >>with second set_nonce missing? >> >>Should it just keep the nonce from the first digest? (Sounds a bit >>

Re: [PATCH v2 0/6] Add meta interface for MAC algorithms

2019-09-16 Thread Dmitry Eremin-Solenikov
вс, 15 сент. 2019 г. в 10:28, Niels Möller : > > Dmitry Eremin-Solenikov writes: > > > There will be a nonce for GMAC. > > Ok. If we keep set_nonce, we have to clarify what it means. There are a > couple of cases, where the first two are relatively easy. > > nonce_size == 0, set_nonce == NULL: >

Re: [PATCH v2 0/6] Add meta interface for MAC algorithms

2019-09-16 Thread Daiki Ueno
Hello, ni...@lysator.liu.se (Niels Möller) writes: > Dmitry Eremin-Solenikov writes: > >> There will be a nonce for GMAC. > > Ok. If we keep set_nonce, we have to clarify what it means. There are a > couple of cases, where the first two are relatively easy. > > nonce_size == 0, set_nonce ==

Re: [PATCH v2 0/6] Add meta interface for MAC algorithms

2019-09-14 Thread Dmitry Eremin-Solenikov
сб, 14 сент. 2019 г. в 13:47, Niels Möller : > > Daiki Ueno writes: > > > From: Daiki Ueno > > > > The changes from the previous series are: > > - remove the global hmac_*_set_key_expanded functions > > - leave out set_nonce member if the operation is not supported > > > > For the latter, I was

Re: [PATCH v2 0/6] Add meta interface for MAC algorithms

2019-09-14 Thread Niels Möller
Daiki Ueno writes: > From: Daiki Ueno > > The changes from the previous series are: > - remove the global hmac_*_set_key_expanded functions > - leave out set_nonce member if the operation is not supported > > For the latter, I was wondering whether it is better to define a no-op > set_nonce,

Re: [PATCH v2 0/6] Add meta interface for MAC algorithms

2019-07-22 Thread Dmitry Eremin-Solenikov
пн, 22 июл. 2019 г. в 11:54, Daiki Ueno : > > From: Daiki Ueno > > The changes from the previous series are: > - remove the global hmac_*_set_key_expanded functions > - leave out set_nonce member if the operation is not supported > > For the latter, I was wondering whether it is better to define

[PATCH v2 0/6] Add meta interface for MAC algorithms

2019-07-22 Thread Daiki Ueno
From: Daiki Ueno The changes from the previous series are: - remove the global hmac_*_set_key_expanded functions - leave out set_nonce member if the operation is not supported For the latter, I was wondering whether it is better to define a no-op set_nonce, but given the fact that that the