Re: [PATCH] editor: don't show connections for missing device plugins

2016-01-22 Thread Dan Williams
On Fri, 2016-01-22 at 21:52 +0300, Mikhail Efremov wrote: > On Fri, 22 Jan 2016 21:51:08 +0300 Mikhail Efremov wrote: > > If device plugin is missing (e.g. not installed) then no use > > to show a connection of this type in the list of connections: > > it can't be used anyway. > > --- > >

[PATCH] editor: don't show connections for missing device plugins

2016-01-22 Thread Mikhail Efremov
If device plugin is missing (e.g. not installed) then no use to show a connection of this type in the list of connections: it can't be used anyway. --- src/connection-editor/connection-helpers.c | 43 ++ 1 file changed, 32 insertions(+), 11 deletions(-) diff --git

Re: [PATCH] editor: don't show connections for missing device plugins

2016-01-22 Thread Mikhail Efremov
On Fri, 22 Jan 2016 21:51:08 +0300 Mikhail Efremov wrote: > If device plugin is missing (e.g. not installed) then no use > to show a connection of this type in the list of connections: > it can't be used anyway. > --- > src/connection-editor/connection-helpers.c | 43 >

[PATCH] Fix nm-version-macro includes

2016-01-22 Thread Adrian Freihofer
nm-version-macros.h cannot be found since include directive has been changed from " to <. This breaks for example gnome-panel build: /usr/include/NetworkManager/NetworkManager.h:31:31: fatal error: nm-version-macros.h: No such file or directory. Signed-off-by: Adrian Freihofer

[PATCH] handle tls auth blobs correctly

2016-01-22 Thread Matthias Berndt
Hi Beniamino et al, networkmanager-openvpn doesn't currently handle blobs correctly. I've modified networkmanager-openvpn to support this functionality and fixed two minor bugs in the process. I'd be thrilled if you could comment on the patch. a presto, Matthias >From

Re: [PATCH] handle tls auth blobs correctly

2016-01-22 Thread Thomas Haller
On Fri, 2016-01-22 at 12:50 +0100, Matthias Berndt wrote: > Hi Beniamino et al, > > networkmanager-openvpn doesn't currently handle blobs > correctly. I've modified networkmanager-openvpn to support this > functionality and fixed two minor bugs in the process. I'd be > thrilled if you could

Re: [PATCH] handle tls auth blobs correctly

2016-01-22 Thread Beniamino Galvani
On Fri, Jan 22, 2016 at 12:50:49PM +0100, Matthias Berndt wrote: > Hi Beniamino et al, > > networkmanager-openvpn doesn't currently handle blobs correctly. > I've modified networkmanager-openvpn to support this functionality and fixed > two minor bugs in the process. I'd be thrilled if you

Re: networkmanager starts infinite number of VPN daemons

2016-01-22 Thread Dan Williams
On Fri, 2016-01-22 at 15:24 +0100, Thomas Haller wrote: > On Fri, 2016-01-22 at 14:48 +0100, Adrian Freihofer wrote: > > Hi, > > > > Setup an OpenVPN connection with NetworkManager 1.0.10 is not > > always painless... I ended up with a setup where an > > infinite number of openvpn daemons tried

Re: networkmanager starts infinite number of VPN daemons

2016-01-22 Thread Thomas Haller
On Fri, 2016-01-22 at 14:48 +0100, Adrian Freihofer wrote: > Hi, > > Setup an OpenVPN connection with NetworkManager 1.0.10 is not > always painless... I ended up with a setup where an > infinite number of openvpn daemons tried to connect to one single > server. > The problem seems to be that

networkmanager starts infinite number of VPN daemons

2016-01-22 Thread Adrian Freihofer
Hi, Setup an OpenVPN connection with NetworkManager 1.0.10 is not always  painless... I ended up with a setup where an infinite number of openvpn daemons tried to connect to one single server. The problem seems to be that NetworkManager does not (or at least not in any case) stop a VPN

[PATCH] configure.ac: Fix macro name

2016-01-22 Thread Mikhail Efremov
It is GLIB_GSETTINGS, not GLIB_SETTINGS. --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index ee130a4..25a98c7 100644 --- a/configure.ac +++ b/configure.ac @@ -142,7 +142,7 @@ dnl Check for gobject introspection

Re: [PATCH] configure.ac: Fix macro name

2016-01-22 Thread Mikhail Efremov
On Fri, 22 Jan 2016 17:42:27 +0300 Mikhail Efremov wrote: > It is GLIB_GSETTINGS, not GLIB_SETTINGS. > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This patch for network-manager-applet, to fix this error: ./configure: line 14774: GLIB_SETTINGS: command not found

Re: [PATCH] handle tls auth blobs correctly

2016-01-22 Thread Matthias Berndt
Hi Thomas, Please take a look at the attached patches, I think I've addressed your remarks. Cheers, Matthias>From 4c8233ef12eec9787536b9028618e76d188db372 Mon Sep 17 00:00:00 2001 From: Matthias Berndt Date: Fri, 22 Jan 2016 13:52:38 +0100 Subject: [PATCH 1/3] -

Re: [PATCH] handle tls auth blobs correctly

2016-01-22 Thread Matthias Berndt
Hi Beniamino et al, I have addressed your comments in the attached patches. Cheers, Matthias >From 4c8233ef12eec9787536b9028618e76d188db372 Mon Sep 17 00:00:00 2001 From: Matthias Berndt Date: Fri, 22 Jan 2016 13:52:38 +0100 Subject: [PATCH 1/3] - allow comment

Re: [PATCH] tests: use dbus-run-session instead of dbus-launch

2016-01-22 Thread Thomas Haller
On Thu, 2016-01-21 at 23:47 +0100, Michael Biebl wrote: > Am 21.01.2016 um 23:19 schrieb Michael Biebl: > > The dbus-run-session utility was designed to run a process within a > > D-Bus session, specifically for running regressions tests and is > > much > > better suited then dbus-launch. As an