Re: [PATCH] fix build: disable -Werror by default (Bug #679130)

2012-11-03 Thread Clemens Buchacher
On Fri, Nov 02, 2012 at 07:38:37PM +0100, Mathieu Trudel-Lapierre wrote: I actually did the porting in Ubuntu. The patch probably doesn't apply quite as cleanly on git master; but see the attached file which migrates the calls to gtk_table_* to gtk_grid_*. Applies cleanly on git master.

Re: [PATCH] fix build: disable -Werror by default (Bug #679130)

2012-11-02 Thread Clemens Buchacher
On Thu, Nov 01, 2012 at 07:32:14PM -0400, Pavel Simerda wrote: What is it supposed to fix? This patch is for network-manager-pptp (should have mentioned that). It does not build against current GTK: $ ./configure make [...] gcc -Wall -Werror [...] vpn-password-dialog.c vpn-password-dialog.c:

Re: [PATCH] fix build: disable -Werror by default (Bug #679130)

2012-11-02 Thread Colin Walters
On Fri, 2012-11-02 at 11:59 +0100, Clemens Buchacher wrote: So this has been an issue for a while, and the -Werror flag does not help anything besides breaking the build. You're going to have to learn how to pass options to configure if you're building software in general. It's really the

Re: [PATCH] fix build: disable -Werror by default (Bug #679130)

2012-11-02 Thread Clemens Buchacher
On Fri, Nov 02, 2012 at 09:16:29AM -0400, Colin Walters wrote: On Fri, 2012-11-02 at 11:59 +0100, Clemens Buchacher wrote: So this has been an issue for a while, and the -Werror flag does not help anything besides breaking the build. You're going to have to learn how to pass options to

Re: [PATCH] fix build: disable -Werror by default (Bug #679130)

2012-11-02 Thread Pavel Simerda
On Fri, Nov 02, 2012 at 09:16:29AM -0400, Colin Walters wrote: On Fri, 2012-11-02 at 11:59 +0100, Clemens Buchacher wrote: So this has been an issue for a while, and the -Werror flag does not help anything besides breaking the build. You're going to have to learn how to pass

Re: [PATCH] fix build: disable -Werror by default (Bug #679130)

2012-11-02 Thread Clemens Buchacher
On Fri, Nov 02, 2012 at 10:32:25AM -0400, Pavel Simerda wrote: On Fri, Nov 02, 2012 at 09:16:29AM -0400, Colin Walters wrote: On Fri, 2012-11-02 at 11:59 +0100, Clemens Buchacher wrote: So this has been an issue for a while, and the -Werror flag does not help anything besides

Re: [PATCH] fix build: disable -Werror by default (Bug #679130)

2012-11-02 Thread Pavel Simerda
And it is therefore not a solution to do nothing and force the package maintainers to deal with this issue. I still prefer a proper solution like the one from Dan Winship: https://bugzilla.gnome.org/show_bug.cgi?id=679130 ___ networkmanager-list

Re: [PATCH] fix build: disable -Werror by default (Bug #679130)

2012-11-02 Thread Clemens Buchacher
On Fri, Nov 02, 2012 at 11:36:46AM -0400, Pavel Simerda wrote: And it is therefore not a solution to do nothing and force the package maintainers to deal with this issue. I still prefer a proper solution like the one from Dan Winship: https://bugzilla.gnome.org/show_bug.cgi?id=679130

Re: [PATCH] fix build: disable -Werror by default (Bug #679130)

2012-11-02 Thread Mathieu Trudel-Lapierre
On Fri, Nov 2, 2012 at 3:43 PM, Clemens Buchacher dri...@aon.at wrote: On Fri, Nov 02, 2012 at 10:32:25AM -0400, Pavel Simerda wrote: On Fri, Nov 02, 2012 at 09:16:29AM -0400, Colin Walters wrote: On Fri, 2012-11-02 at 11:59 +0100, Clemens Buchacher wrote: So this has been an issue

[PATCH] fix build: disable -Werror by default (Bug #679130)

2012-11-01 Thread Clemens Buchacher
This fixes https://bugzilla.gnome.org/show_bug.cgi?id=679130. Signed-off-by: Clemens Buchacher dri...@aon.at --- m4/compiler_warnings.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/m4/compiler_warnings.m4 b/m4/compiler_warnings.m4 index 95ad3fb..ac21b89 100644 ---

Re: [PATCH] fix build: disable -Werror by default (Bug #679130)

2012-11-01 Thread Pavel Simerda
What is it supposed to fix? - Original Message - From: Clemens Buchacher dri...@aon.at To: networkmanager-list@gnome.org Sent: Thursday, November 1, 2012 6:58:05 PM Subject: [PATCH] fix build: disable -Werror by default (Bug #679130) This fixes https://bugzilla.gnome.org