Dear Colin,
thank you for the patch!
Am Dienstag, den 18.06.2013, 16:47 -0400 schrieb Colin Walters:
This code was broken when it landed with commit
fcc441622ae2632b9b36f352621cfd3baf34dc85 ; it was then later
updated with 2318b3c5252403a52973eae70c32ff715c7994e7
Hmm, I am not good at
On Tue, 2013-06-18 at 16:47 -0400, Colin Walters wrote:
This code was broken when it landed with commit
fcc441622ae2632b9b36f352621cfd3baf34dc85 ; it was then later
updated with 2318b3c5252403a52973eae70c32ff715c7994e7
But the assertion is just clearly wrong - if we're going to clear the
On Wed, 2013-06-19 at 08:11 -0500, Dan Williams wrote:
It's more there because it's potentially a bug
Ok, the logic seems odd because we're doing effectively:
if (condition)
{
if (condition)
warning ();
deal_with_it ();
}
If the code had looked like:
if (condition)
{
Ok, how about this patch?
From ab22ffd804ba7e91bd6d064cbf5627ab03981c3b Mon Sep 17 00:00:00 2001
From: Colin Walters walt...@verbum.org
Date: Wed, 19 Jun 2013 14:56:26 -0400
Subject: [PATCH] device: Queuing two transitions to the same state is not an error
Just ignore this, since it happens in
On Wed, 2013-06-19 at 16:01 -0400, Colin Walters wrote:
Ok, how about this patch?
Yeah, that's better.
Dan
___
networkmanager-list mailing list
networkmanager-list@gnome.org
https://mail.gnome.org/mailman/listinfo/networkmanager-list
On Wed, 2013-06-19 at 18:05 -0500, Dan Williams wrote:
On Wed, 2013-06-19 at 16:01 -0400, Colin Walters wrote:
Ok, how about this patch?
Yeah, that's better.
Pushed, thanks.
Dan
___
networkmanager-list mailing list
networkmanager-list@gnome.org
about
it.
---
src/devices/nm-device.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
From b485ce2c58e7d474392e8987fb834762beecc3ed Mon Sep 17 00:00:00 2001
From: Colin Walters walt...@verbum.org
Date: Tue, 18 Jun 2013 16:44:18 -0400
Subject: [PATCH] nm-device: Remove bogus warning
