Re: [MM PATCH] novatel-lte: increase the wait after SIM unlock to 3 seconds

2012-11-02 Thread Aleksander Morgado
On 01/11/12 05:31, Ben Chan wrote: > After repeated stress tests on a few Novatel E362 modems and SIM cards, > it is revealed that a 3-second wait after SIM unlock is necessary for > reliably reading ICCID and IMSI through the SIM interface. Pushed, thanks. BTW, Novatel LTE modems can now be hand

Re: [MM] CDMA base station location

2012-11-02 Thread Aleksander Morgado
> > I pushed a new 'cdma-location' branch to upstream MM git, which includes > a new 'CDMA Base Station' location source which may give, if known, the > Latitude and Longitude of the CDMA Base Station. This CDMA location is > enabled by default when the CDMA modem is enabled. Once registered to >

Re: [MM PATCH] iface-modem: load own numbers after SIM initialization

2012-11-02 Thread Aleksander Morgado
On 01/11/12 05:23, Ben Chan wrote: > In 3GPP, own numbers are loaded from the SIM card, the loading of own > numbers should be scheduled after the SIM card is ready. Pushed, thanks. > --- > src/mm-iface-modem.c | 34 +- > 1 files changed, 17 insertions(+), 17

Re: Initial integration of the new MM iface in NM

2012-11-02 Thread Aleksander Morgado
On 01/11/12 16:53, Aleksander Morgado wrote: > The 'cs' mode (circuit switched) was carried from some plugins which > allow configuring this kind of connection; instead of assuming 'cs' is > suported when '2g' is supported, I'll remove the 'cs' mode from all > those modems which don't really allow

Re: [PATCH] fix build: disable -Werror by default (Bug #679130)

2012-11-02 Thread Clemens Buchacher
On Thu, Nov 01, 2012 at 07:32:14PM -0400, Pavel Simerda wrote: > > What is it supposed to fix? This patch is for network-manager-pptp (should have mentioned that). It does not build against current GTK: $ ./configure && make [...] gcc -Wall -Werror [...] vpn-password-dialog.c vpn-password-dialog.

Re: [PATCH] fix path to auth-dialog (Bug #679225)

2012-11-02 Thread Clemens Buchacher
On Thu, Nov 01, 2012 at 06:59:13PM +0100, Clemens Buchacher wrote: > > nm-pptp-service.name.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This patch is for network-manager-pptp. If accepted I can provide analogous patches for network-manager-vpnc and network-manager-openconnect.

Re: [PATCH] fix build: disable -Werror by default (Bug #679130)

2012-11-02 Thread Colin Walters
On Fri, 2012-11-02 at 11:59 +0100, Clemens Buchacher wrote: > So this has been an issue for a while, and the -Werror flag does not > help anything besides breaking the build. You're going to have to learn how to pass options to "configure" if you're building software in general. It's really the

Re: [PATCH] fix build: disable -Werror by default (Bug #679130)

2012-11-02 Thread Clemens Buchacher
On Fri, Nov 02, 2012 at 09:16:29AM -0400, Colin Walters wrote: > On Fri, 2012-11-02 at 11:59 +0100, Clemens Buchacher wrote: > > > So this has been an issue for a while, and the -Werror flag does not > > help anything besides breaking the build. > > You're going to have to learn how to pass opti

Re: [PATCH] fix build: disable -Werror by default (Bug #679130)

2012-11-02 Thread Pavel Simerda
> On Fri, Nov 02, 2012 at 09:16:29AM -0400, Colin Walters wrote: > > On Fri, 2012-11-02 at 11:59 +0100, Clemens Buchacher wrote: > > > > > So this has been an issue for a while, and the -Werror flag does > > > not > > > help anything besides breaking the build. > > > > You're going to have to lea

Re: [PATCH] fix build: disable -Werror by default (Bug #679130)

2012-11-02 Thread Clemens Buchacher
On Fri, Nov 02, 2012 at 10:32:25AM -0400, Pavel Simerda wrote: > > On Fri, Nov 02, 2012 at 09:16:29AM -0400, Colin Walters wrote: > > > On Fri, 2012-11-02 at 11:59 +0100, Clemens Buchacher wrote: > > > > > > > So this has been an issue for a while, and the -Werror flag does > > > > not > > > > hel

Re: [PATCH] fix build: disable -Werror by default (Bug #679130)

2012-11-02 Thread Pavel Simerda
> And it is therefore not a solution to do nothing and force the > package maintainers to deal with this issue. I still prefer a proper solution like the one from Dan Winship: https://bugzilla.gnome.org/show_bug.cgi?id=679130 ___ networkmanager-list mai

Re: [PATCH] fix build: disable -Werror by default (Bug #679130)

2012-11-02 Thread Clemens Buchacher
On Fri, Nov 02, 2012 at 11:36:46AM -0400, Pavel Simerda wrote: > > And it is therefore not a solution to do nothing and force the > > package maintainers to deal with this issue. > > I still prefer a proper solution like the one from Dan Winship: > > https://bugzilla.gnome.org/show_bug.cgi?id=679

Re: [PATCH] fix build: disable -Werror by default (Bug #679130)

2012-11-02 Thread Mathieu Trudel-Lapierre
On Fri, Nov 2, 2012 at 3:43 PM, Clemens Buchacher wrote: > On Fri, Nov 02, 2012 at 10:32:25AM -0400, Pavel Simerda wrote: >> > On Fri, Nov 02, 2012 at 09:16:29AM -0400, Colin Walters wrote: >> > > On Fri, 2012-11-02 at 11:59 +0100, Clemens Buchacher wrote: >> > > >> > > > So this has been an issue