Re: [PATCH] Do not skip wifi slave connections

2017-05-19 Thread Thomas Haller
On Thu, 2017-05-18 at 12:33 -0400, Nikolay Martynov wrote: > > Anyway, the patch LGTM. > > Thanks! Hi, patch merged: https://git.gnome.org/browse/network-manager-applet/commit/?id=15187f557234ee63d2d4730a16ba1c78bc43a516 Thanks, Thomas signature.asc Description: This is a digitally signed

Re: [PATCH] Do not skip wifi slave connections

2017-05-18 Thread Nikolay Martynov
Hi. 2017-05-18 12:22 GMT-04:00 Beniamino Galvani : > On Thu, May 18, 2017 at 11:42:47AM -0400, Nikolay Martynov wrote: >> Just to clarify: this patch only affects wifi bonded connections. >> 'Classic' ethernet bond slaves are still skipped - so this change >> should not

Re: [PATCH] Do not skip wifi slave connections

2017-05-18 Thread Beniamino Galvani
On Thu, May 18, 2017 at 11:42:47AM -0400, Nikolay Martynov wrote: > Just to clarify: this patch only affects wifi bonded connections. > 'Classic' ethernet bond slaves are still skipped - so this change > should not affect existing users. > I think the intention of original patch was to hide

Re: [PATCH] Do not skip wifi slave connections

2017-05-18 Thread Nikolay Martynov
Hi. Thanks for your response! 2017-05-18 11:32 GMT-04:00 Thomas Haller : > On Tue, 2017-05-16 at 22:13 -0400, Nikolay Martynov wrote: >> If slave connection is a wifi connection we should still display it >> Otherwise this AP gets scanned regardless, but when user clicks it

Re: [PATCH] Do not skip wifi slave connections

2017-05-18 Thread Thomas Haller
On Tue, 2017-05-16 at 22:13 -0400, Nikolay Martynov wrote: > If slave connection is a wifi connection we should still display it > Otherwise this AP gets scanned regardless, but when user clicks it > new > network is created in NM's configuation - which is unlikely what user > desired Hi Nikolay,

[PATCH] Do not skip wifi slave connections

2017-05-16 Thread Nikolay Martynov
If slave connection is a wifi connection we should still display it Otherwise this AP gets scanned regardless, but when user clicks it new network is created in NM's configuation - which is unlikely what user desired Signed-off-by: Nikolay Martynov --- src/applet.c | 5