Re: [Nfs-ganesha-devel] [FSAL_VFS] Probable memory leak when deallocating handles

2018-01-09 Thread Frank Filz
> I would actually like to see the sub-FSAL removed, and xfs converted to a > stacked FSAL at some point, now that patfs is dead. But it's not high on my > list (especially with testing xfs...) I'll take a look at it for early V2.7, it should be quick. I have an XFS filesystem and export, so eas

Re: [Nfs-ganesha-devel] [FSAL_VFS] Probable memory leak when deallocating handles

2018-01-09 Thread Daniel Gryniewicz
I would actually like to see the sub-FSAL removed, and xfs converted to a stacked FSAL at some point, now that patfs is dead. But it's not high on my list (especially with testing xfs...) Daniel On Mon, Jan 8, 2018 at 3:15 PM, Frank Filz wrote: >> The problem is that the sub-FSAL interface was

Re: [Nfs-ganesha-devel] [FSAL_VFS] Probable memory leak when deallocating handles

2018-01-08 Thread Frank Filz
> The problem is that the sub-FSAL interface was never intended to be a > general interface. It was added specifically to allow certain features to be > added to panfs, so it only has the entrypoints needed for that work. > Realistically, if I were implementing it now, I'd use a stacked FSAL, but

Re: [Nfs-ganesha-devel] [FSAL_VFS] Probable memory leak when deallocating handles

2018-01-08 Thread Daniel Gryniewicz
The problem is that the sub-FSAL interface was never intended to be a general interface. It was added specifically to allow certain features to be added to panfs, so it only has the entrypoints needed for that work. Realistically, if I were implementing it now, I'd use a stacked FSAL, but at

Re: [Nfs-ganesha-devel] [FSAL_VFS] Probable memory leak when deallocating handles

2018-01-08 Thread sriram patil
so they don’t have to do additional > caching work…). > > > > Frank > > > > *From:* sriram patil [mailto:spsrirampa...@gmail.com] > *Sent:* Sunday, January 7, 2018 11:00 PM > *To:* nfs-ganesha-devel@lists.sourceforge.net > *Cc:* kcha...@vmware.com; sakt...@vmware

Re: [Nfs-ganesha-devel] [FSAL_VFS] Probable memory leak when deallocating handles

2018-01-08 Thread Frank Filz
] [FSAL_VFS] Probable memory leak when deallocating handles Hi, Sorry for the confusion here. The free should work fine because it is contagious memory allocated in single malloc/calloc call. The problem I wanted to address is, there is no corresponding vfs_sub_free_handle for

Re: [Nfs-ganesha-devel] [FSAL_VFS] Probable memory leak when deallocating handles

2018-01-07 Thread sriram patil
Hi, Sorry for the confusion here. The free should work fine because it is contagious memory allocated in single malloc/calloc call. The problem I wanted to address is, there is no corresponding vfs_sub_free_handle for vfs_sub_alloc_handle. I wanted to maintain a cache for every handle, once we re

[Nfs-ganesha-devel] [FSAL_VFS] Probable memory leak when deallocating handles

2018-01-07 Thread sriram patil
Hi, I was going through the vfs_fsal_obj_handle workflow. As part of the function alloc_handle we allocate the handle with the help of vfs_sub_alloc_handle. vfs_sub_alloc_handle allocates vfs_fsal_obj_handle and vfs_file_handle_t back to back. And when releasing the handle (obj_ops->release), it