Re: [Nfs-ganesha-devel] Dirent invalidation on up call

2017-02-16 Thread Daniel Gryniewicz
The dirents will get cleared out the next time a readdir happens. Daniel On 02/16/2017 12:20 AM, Frank Filz wrote: >> er, oh noes... > > The problem I think I see is that the directory never gets cleaned out in > this case... > > I get that we may not want to dispose of the dirents on the

Re: [Nfs-ganesha-devel] reg. FSAL_ACE_PERM_WRITE_DATA check in fsal_check_setattr_perms

2017-02-16 Thread Satya Prakash GS
Daniel/Frank, We are using v2.3-stable at the moment. I am yet to go through stackable fsals to understand your previous comments. Also, we want to make sure that we aren't hit when we upgrade to v2.4 or latest. I like the is_super_logic that Frank has proposed, can we have that in Ganesha. I

Re: [Nfs-ganesha-devel] how does ganesha limit number of FDs

2017-02-16 Thread Malahal Naineni
The only way for ganesha to close NFSv3 opens was with this fd count limit in an earlier release. Now, do we open for each NFSv3 read/write and close after the read/write? On Tue, Feb 14, 2017 at 12:51 AM, Frank Filz wrote: > Open fd tracking is an area Ganesha actually

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: [commonlib.c] optimize blkid cache handling.

2017-02-16 Thread GerritHub
>From Swen Schillig : Swen Schillig has uploaded a new change for review. ( https://review.gerrithub.io/349027 Change subject: [commonlib.c] optimize blkid cache handling. .. [commonlib.c] optimize blkid

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: FSAL_PROXY (support_ex without state) : pxy_reopen2

2017-02-16 Thread GerritHub
>From Patrice LUCAS : Patrice LUCAS has uploaded a new change for review. ( https://review.gerrithub.io/349039 Change subject: FSAL_PROXY (support_ex without state) : pxy_reopen2 .. FSAL_PROXY

Re: [Nfs-ganesha-devel] Dirent invalidation on up call

2017-02-16 Thread Frank Filz
Where does that happen? It wasn't clear to me. Frank Sent from my iPhone > On Feb 16, 2017, at 6:31 AM, Daniel Gryniewicz wrote: > > The dirents will get cleared out the next time a readdir happens. > > Daniel > > On 02/16/2017 12:20 AM, Frank Filz wrote: >>> er, oh

Re: [Nfs-ganesha-devel] Dirent invalidation on up call

2017-02-16 Thread Daniel Gryniewicz
mdcache_readdir() checks !mdc_dircache_trusted(), and calls mdcache_dirent_populate(), which calls mdcache_dirent_invalidate_all(). Daniel On 02/16/2017 11:23 AM, Frank Filz wrote: > Where does that happen? It wasn't clear to me. > > Frank > > Sent from my iPhone > >> On Feb 16, 2017, at 6:31

Re: [Nfs-ganesha-devel] Dirent invalidation on up call

2017-02-16 Thread Frank Filz
> On 02/16/2017 12:21 PM, Frank Filz wrote: > >> mdcache_readdir() checks !mdc_dircache_trusted(), and calls > >> mdcache_dirent_populate(), which calls mdcache_dirent_invalidate_all(). > > > > Ah, ok. Good. > > > > Path will be slightly re-worked with chunking, but will do that. > > > > I wonder

Re: [Nfs-ganesha-devel] Dirent invalidation on up call

2017-02-16 Thread Frank Filz
> mdcache_readdir() checks !mdc_dircache_trusted(), and calls > mdcache_dirent_populate(), which calls mdcache_dirent_invalidate_all(). Ah, ok. Good. Path will be slightly re-worked with chunking, but will do that. I wonder if we should just always mark contents un-trusted and then in readdir,

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Allow FSAL to determine if a user is superuser

2017-02-16 Thread GerritHub
>From Daniel Gryniewicz : Daniel Gryniewicz has uploaded a new change for review. ( https://review.gerrithub.io/349135 Change subject: Allow FSAL to determine if a user is superuser .. Allow FSAL to determine

Re: [Nfs-ganesha-devel] Dirent invalidation on up call

2017-02-16 Thread Daniel Gryniewicz
On 02/16/2017 12:21 PM, Frank Filz wrote: >> mdcache_readdir() checks !mdc_dircache_trusted(), and calls >> mdcache_dirent_populate(), which calls mdcache_dirent_invalidate_all(). > > Ah, ok. Good. > > Path will be slightly re-worked with chunking, but will do that. > > I wonder if we should just

Re: [Nfs-ganesha-devel] seek2 useless ?

2017-02-16 Thread Frank Filz
On 02/16/2017 02:41 AM, LUCAS Patrice wrote: > Hi Frank, > > > After a quick search, it seems that seek2 is never called and > implemented only by the two stackable fsals, mdcache and nullfs. > > > Can you confirm that it is useless to implement seek2 in the > support_ex version of FSAL_PROXY ? >

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Remove unneeded NULL pointer check

2017-02-16 Thread GerritHub
>From Malahal : Malahal has uploaded a new change for review. ( https://review.gerrithub.io/349147 Change subject: Remove unneeded NULL pointer check .. Remove unneeded NULL pointer check Fixes coverity