Re: [Nfs-ganesha-devel] RPC queue enqueued/dequeued counter size

2017-05-15 Thread Matt Benjamin
Hi Sachin, I'm pretty sure no decisions are made based on these values, they were added for diagnostics. I think you're probably right, however. I'd defer to the folks working on refactoring this part of the code as to whether these should or will exist in the medium-term future. Matt

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: 9P: fix big xattr handling

2017-05-15 Thread GerritHub
>From Dominique Martinet : Dominique Martinet has uploaded this change for review. ( https://review.gerrithub.io/360906 Change subject: 9P: fix big xattr handling .. 9P: fix big xattr handling

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: unlock mdc_init_lock on an export creation failure.

2017-05-15 Thread GerritHub
>From Malahal : Malahal has uploaded this change for review. ( https://review.gerrithub.io/360774 Change subject: unlock mdc_init_lock on an export creation failure. .. unlock mdc_init_lock on an export

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: FSAL_GLUSTER: Set caller credentials for setattrs

2017-05-15 Thread GerritHub
>From Soumya : Soumya has uploaded this change for review. ( https://review.gerrithub.io/360840 Change subject: FSAL_GLUSTER: Set caller credentials for setattrs .. FSAL_GLUSTER: Set caller credentials for

[Nfs-ganesha-devel] RPC queue enqueued/dequeued counter size

2017-05-15 Thread Sachin Punadikar
Hi, Recently I came across below 2 counters for RPC queue. static uint32_t enqueued_reqs; static uint32_t dequeued_reqs; Shouldn't the counter size be uint64_t ? Having size as uint32_t will allow the counters to grow until 4294967295. Increasing the size would help production environments. --