Re: [Nfs-ganesha-devel] Request to merge patches to V2.2-stable branch

2015-06-18 Thread Malahal Naineni
Soumya Koduri [skod...@redhat.com] wrote: I thought pthread_exit() always returns a pointer which gets assigned to retval of pthread_join(). I assume this is the flow -- pthread_exit() does take a void *, since it is void *, it is up to you whether to really pass some pointer or some casted

Re: [Nfs-ganesha-devel] Request to merge patches to V2.2-stable branch

2015-06-18 Thread Soumya Koduri
On 06/18/2015 10:33 PM, Malahal Naineni wrote: Soumya Koduri [skod...@redhat.com] wrote: I thought pthread_exit() always returns a pointer which gets assigned to retval of pthread_join(). I assume this is the flow -- pthread_exit() does take a void *, since it is void *, it is up to you

Re: [Nfs-ganesha-devel] Request to merge patches to V2.2-stable branch

2015-06-17 Thread Malahal Naineni
I didn't see GLUSTERFSAL_UP_Thread() returning anything other than NULL/0. I think passing NULL to pthread_join is even cleaner! Regards, Malahal. Malahal Naineni [mala...@us.ibm.com] wrote: Soumya Koduri [skod...@redhat.com] wrote: Hi Kaleb/Malahal, Request you to merge below

[Nfs-ganesha-devel] Request to merge patches to V2.2-stable branch

2015-06-17 Thread Soumya Koduri
Hi Kaleb/Malahal, Request you to merge below FSAL_GLUSTER patches into V2.2-stable branch - 366f71c - FSAL_GLUSTER: Fixed an issue with dereferencing a NULL ponter c4f33d6 - FSAL_GLUSTER : Improvements in acl feature b1df525 - FSAL_GLUSTER: Stop polling upcall events if not supported Thanks,

Re: [Nfs-ganesha-devel] Request to merge patches to V2.2-stable branch

2015-06-17 Thread Malahal Naineni
Soumya Koduri [skod...@redhat.com] wrote: Hi Kaleb/Malahal, Request you to merge below FSAL_GLUSTER patches into V2.2-stable branch - 366f71c - FSAL_GLUSTER: Fixed an issue with dereferencing a NULL ponter I just looked at the patch from your other mail. I have few questions on this patch.