Hi Sachin,
I'm pretty sure no decisions are made based on these values, they were added
for diagnostics. I think you're probably right, however. I'd defer to the
folks working on refactoring this part of the code as to whether these should
or will exist in the medium-term future.
Matt
- Original Message -
> From: "Sachin Punadikar" <punadikar.sac...@gmail.com>
> To: nfs-ganesha-devel@lists.sourceforge.net
> Sent: Monday, May 15, 2017 3:46:45 AM
> Subject: [Nfs-ganesha-devel] RPC queue enqueued/dequeued counter size
>
> Hi,
> Recently I came across below 2 counters for RPC queue.
> static uint32_t enqueued_reqs;
> static uint32_t dequeued_reqs;
>
> Shouldn't the counter size be uint64_t ?
> Having size as uint32_t will allow the counters to grow until 4294967295.
> Increasing the size would help production environments.
>
> --
> with regards,
> Sachin Punadikar
>
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> Nfs-ganesha-devel mailing list
> Nfs-ganesha-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
>
--
Matt Benjamin
Red Hat, Inc.
315 West Huron Street, Suite 140A
Ann Arbor, Michigan 48103
http://www.redhat.com/en/technologies/storage
tel. 734-821-5101
fax. 734-769-8938
cel. 734-216-5309
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
