Re: [Nfs-ganesha-devel] pre-commit refusals for ANSI formatted strings

2016-12-01 Thread Frank Filz
; Subject: Re: [Nfs-ganesha-devel] pre-commit refusals for ANSI formatted > strings > > > > > -Original Message- > > From: William Allen Simpson [mailto:william.allen.simp...@gmail.com] > > Sent: Monday, November 28, 2016 8:46 AM > > To: NFS Ganesha Developer

Re: [Nfs-ganesha-devel] pre-commit refusals for ANSI formatted strings

2016-11-29 Thread Frank Filz
> -Original Message- > From: William Allen Simpson [mailto:william.allen.simp...@gmail.com] > Sent: Monday, November 28, 2016 8:46 AM > To: NFS Ganesha Developers > Subject: [Nfs-ganesha-devel] pre-commit refusals for ANSI formatted strings > > If the printf string is on one line, I get

Re: [Nfs-ganesha-devel] pre-commit refusals for ANSI formatted strings

2016-11-29 Thread Daniel Gryniewicz
Sorry, I didn't mean to imply that breaks should occur at *all* PRIu32 instances, just that when breaks are necessary, they need to come before or after them, leaving quoted strings intact. Daniel On 11/29/2016 11:11 AM, Malahal Naineni wrote: > Forgot to include the mailing list in my previous

Re: [Nfs-ganesha-devel] pre-commit refusals for ANSI formatted strings

2016-11-29 Thread Malahal Naineni
Forgot to include the mailing list in my previous email, also my cut-paste garbled what I wanted to say, but you get the idea! On Tue, Nov 29, 2016 at 9:38 PM, Malahal Naineni wrote: > Bill indicated he didn't like splitting like this: > > "NFS DISPATCHER: FAILURE: Error while calling svc_sendrep

Re: [Nfs-ganesha-devel] pre-commit refusals for ANSI formatted strings

2016-11-29 Thread Daniel Gryniewicz
On 11/29/2016 02:37 AM, William Allen Simpson wrote: > On 11/28/16 1:28 PM, Malahal Naineni wrote: >> I think SPLIT_STRING is enabled by default. This supposedly helps some >> linux kernel hackers to map a given syslog message with the actual >> code line by simply grepping. Debatable as printk cou

Re: [Nfs-ganesha-devel] pre-commit refusals for ANSI formatted strings

2016-11-28 Thread William Allen Simpson
On 11/28/16 1:28 PM, Malahal Naineni wrote: > I think SPLIT_STRING is enabled by default. This supposedly helps some > linux kernel hackers to map a given syslog message with the actual > code line by simply grepping. Debatable as printk could contain string > symbols evading the matches. Enabling

Re: [Nfs-ganesha-devel] pre-commit refusals for ANSI formatted strings

2016-11-28 Thread Malahal Naineni
I think SPLIT_STRING is enabled by default. This supposedly helps some linux kernel hackers to map a given syslog message with the actual code line by simply grepping. Debatable as printk could contain string symbols evading the matches. Enabling this and the 80 character line limit is a mess! Both