Re: Add support for buffering is scripted logs

gt; wrote: > >> -Original Message- >> From: nginx-devel [mailto:nginx-devel-boun...@nginx.org] On Behalf Of Alexey >> Ivanov >> Sent: Monday, August 14, 2017 9:25 PM >> To: nginx-devel@nginx.org >> Subject: Re: Add support for buffering is scripted logs

RE: Add support for buffering is scripted logs

> -Original Message- > From: nginx-devel [mailto:nginx-devel-boun...@nginx.org] On Behalf Of Alexey > Ivanov > Sent: Monday, August 14, 2017 9:25 PM > To: nginx-devel@nginx.org > Subject: Re: Add support for buffering is scripted logs > > using syslog for that par

Re: Add support for buffering is scripted logs

devel@nginx.org > > Subject: Re: Add support for buffering is scripted logs > > > > > Ok, so is that a final 'no' for this whole feature, or is there is > > > anything else I can do to get this feature in? > > > > It is certainly not a "final no". A

Re: Add support for buffering is scripted logs

t; -Original Message- >> From: nginx-devel [mailto:nginx-devel-boun...@nginx.org] On Behalf Of Maxim >> Dounin >> Sent: Monday, August 14, 2017 8:34 PM >> To: nginx-devel@nginx.org >> Subject: Re: Add support for buffering is scripted logs >> >>> Ok, so

RE: Add support for buffering is scripted logs

> > -Original Message- > From: nginx-devel [mailto:nginx-devel-boun...@nginx.org] On Behalf Of Maxim > Dounin > Sent: Monday, August 14, 2017 8:34 PM > To: nginx-devel@nginx.org > Subject: Re: Add support for buffering is scripted logs > > > Ok, so is th

Re: Add support for buffering is scripted logs

Hello! On Mon, Aug 14, 2017 at 05:11:22PM +, Eran Kornblau wrote: > > -Original Message- > > From: nginx-devel [mailto:nginx-devel-boun...@nginx.org] On Behalf Of Maxim > > Dounin > > Sent: Monday, August 14, 2017 7:55 PM > > To: nginx-devel@nginx.or

RE: Add support for buffering is scripted logs

> -Original Message- > From: nginx-devel [mailto:nginx-devel-boun...@nginx.org] On Behalf Of Maxim > Dounin > Sent: Monday, August 14, 2017 7:55 PM > To: nginx-devel@nginx.org > Subject: Re: Add support for buffering is scripted logs > > Hello! > > On M

Re: Add support for buffering is scripted logs

Hello! On Mon, Aug 14, 2017 at 04:01:10PM +, Eran Kornblau wrote: > Thanks Maxim, comments inline. > > > Hello! > > > > On Mon, Aug 07, 2017 at 10:36:19AM +, Eran Kornblau wrote: > > > > Just a quick note: for me, the whole feature looks questionable, and the > > implementation is

RE: Add support for buffering is scripted logs

Thanks Maxim, comments inline. > Hello! > > On Mon, Aug 07, 2017 at 10:36:19AM +, Eran Kornblau wrote: > > Just a quick note: for me, the whole feature looks questionable, and the > implementation is far from being in a commitable state. > Why questionable? you would probably agree that

Re: Add support for buffering is scripted logs

Hello! On Mon, Aug 07, 2017 at 10:36:19AM +, Eran Kornblau wrote: > Hi all, > > The attached patch adds support for log buffering when using variables in the > access log file name. > > The use case is this - we use nginx to receive analytics beacons and write > them to the access log. >

RE: Add support for buffering in scripted logs

Ping Thanks Eran -Original Message- From: nginx-devel [mailto:nginx-devel-boun...@nginx.org] On Behalf Of Eran Kornblau Sent: Monday, August 7, 2017 2:09 PM To: nginx-devel@nginx.org Subject: RE: Add support for buffering in scripted logs Sorry for spamming... forgot to write

RE: Add support for buffering in scripted logs

Sorry for spamming... forgot to write - something that I know is missing in this patch is support for 'reopen files' (USR1) In order to handle that, I probably need to add an rbtree on cycle->open_files (the O(n) search that is currently performed in ngx_conf_open_file doesn't seem appropriate