Re: [PATCH] Configure: call make distclean for zlib only if Makefile exists

2014-04-24 Thread Piotr Sikora
Hey, Configure: call make distclean for zlib only if Makefile exists. This change allows to build nginx against git checkout of zlib. Actually, it looks that only our amd64-optimized version [1] doesn't ship with Makefile, the original repository [2] has a minimal one with distclean target,

[nginx] nginx-1.6.0-RELEASE

2014-04-24 Thread Maxim Dounin
details: http://hg.nginx.org/nginx/rev/daa5384fd526 branches: stable-1.6 changeset: 5671:daa5384fd526 user: Maxim Dounin mdou...@mdounin.ru date: Thu Apr 24 16:52:24 2014 +0400 description: nginx-1.6.0-RELEASE diffstat: docs/xml/nginx/changes.xml | 14 ++ 1 files

[nginx] release-1.6.0 tag

2014-04-24 Thread Maxim Dounin
details: http://hg.nginx.org/nginx/rev/622887a470d3 branches: stable-1.6 changeset: 5672:622887a470d3 user: Maxim Dounin mdou...@mdounin.ru date: Thu Apr 24 16:52:24 2014 +0400 description: release-1.6.0 tag diffstat: .hgtags | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)

[nginx] release-1.7.0 tag

2014-04-24 Thread Maxim Dounin
details: http://hg.nginx.org/nginx/rev/1b0c55d38d0b branches: changeset: 5674:1b0c55d38d0b user: Maxim Dounin mdou...@mdounin.ru date: Thu Apr 24 16:54:23 2014 +0400 description: release-1.7.0 tag diffstat: .hgtags | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diffs (8

[nginx] Version bump.

2014-04-24 Thread Valentin Bartenev
details: http://hg.nginx.org/nginx/rev/1710bf72243e branches: changeset: 5675:1710bf72243e user: Valentin Bartenev vb...@nginx.com date: Thu Apr 24 20:50:10 2014 +0400 description: Version bump. diffstat: src/core/nginx.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)

[PATCH 1 of 2] HTTP: Add client source port to any error that is logged

2014-04-24 Thread Quanah Gibson-Mount
# HG changeset patch # User Quanah Gibson-Mount qua...@zimbra.com # Date 1398357557 18000 # Node ID 4b7d2e503c06758330aabcc21ffbbab77f09568e # Parent 1b0c55d38d0b7ba69dcad79760a3fadc30696a9d HTTP: Add client source port to any error that is logged For TRAC ticket 531 diff -r 1b0c55d38d0b -r

[PATCH 0 of 2] TRAC 531 - Add source port logging for HTTP(S) error logging and all proxied email client connections

2014-04-24 Thread Quanah Gibson-Mount
The following patches ensure that the source port is logged for all client connections. This is to resolve TRAC issue 531. Belgium is mandating that the source port be logged for all client connections for Carrier Grade NAT. This may soon extend to the entire European Union.

Re: [PATCH 1 of 2] HTTP: Add client source port to any error that is logged

2014-04-24 Thread Maxim Dounin
Hello! On Thu, Apr 24, 2014 at 12:19:46PM -0500, Quanah Gibson-Mount wrote: # HG changeset patch # User Quanah Gibson-Mount qua...@zimbra.com # Date 1398357557 18000 # Node ID 4b7d2e503c06758330aabcc21ffbbab77f09568e # Parent 1b0c55d38d0b7ba69dcad79760a3fadc30696a9d HTTP: Add client

Re: [PATCH 1 of 2] HTTP: Add client source port to any error that is logged

2014-04-24 Thread Quanah Gibson-Mount
--On April 24, 2014 at 9:37:54 PM +0400 Maxim Dounin mdou...@mdounin.ru wrote: I tend to say No, thanks. If needed due to local regulations, $remote_port can be added to log_format. $remote_port in the log format section only covers errors logged to the access log, it does not cover

Re: [PATCH 1 of 2] HTTP: Add client source port to any error that is logged

2014-04-24 Thread Quanah Gibson-Mount
--On April 24, 2014 at 10:41:43 AM -0700 Quanah Gibson-Mount qua...@zimbra.com wrote: --On April 24, 2014 at 9:37:54 PM +0400 Maxim Dounin mdou...@mdounin.ru wrote: I tend to say No, thanks. If needed due to local regulations, $remote_port can be added to log_format. $remote_port in

Re: [PATCH 2 of 2] MAIL: Always log the source port of the client

2014-04-24 Thread Maxim Dounin
Hello! On Thu, Apr 24, 2014 at 12:19:47PM -0500, Quanah Gibson-Mount wrote: # HG changeset patch # User Quanah Gibson-Mount qua...@zimbra.com # Date 1398359069 18000 # Node ID 3c908c40acd15c8df020f95309b98d45f2b5e5de # Parent 4b7d2e503c06758330aabcc21ffbbab77f09568e MAIL: Always log the

Re: [PATCH 1 of 2] HTTP: Add client source port to any error that is logged

2014-04-24 Thread Maxim Dounin
Hello! On Thu, Apr 24, 2014 at 10:41:43AM -0700, Quanah Gibson-Mount wrote: --On April 24, 2014 at 9:37:54 PM +0400 Maxim Dounin mdou...@mdounin.ru wrote: I tend to say No, thanks. If needed due to local regulations, $remote_port can be added to log_format. $remote_port in the log

Re: [PATCH 1 of 2] HTTP: Add client source port to any error that is logged

2014-04-24 Thread Quanah Gibson-Mount
--On April 24, 2014 at 9:56:48 PM +0400 Maxim Dounin mdou...@mdounin.ru wrote: $remote_port in the log format section only covers errors logged to the access log, it does not cover errors in the error log. The submitted patch handles the error log. I understand the difference, thank you.

Re: [PATCH 1 of 2] HTTP: Add client source port to any error that is logged

2014-04-24 Thread Maxim Dounin
Hello! On Thu, Apr 24, 2014 at 11:06:29AM -0700, Quanah Gibson-Mount wrote: --On April 24, 2014 at 9:56:48 PM +0400 Maxim Dounin mdou...@mdounin.ru wrote: $remote_port in the log format section only covers errors logged to the access log, it does not cover errors in the error log. The

Re: [PATCH 1 of 2] HTTP: Add client source port to any error that is logged

2014-04-24 Thread Quanah Gibson-Mount
--On April 24, 2014 at 10:26:07 PM +0400 Maxim Dounin mdou...@mdounin.ru wrote: Yes, that is true, but why only implement a partial solution? With CGN, only logging the IP is fairly useless in all cases. To truly get useful information going forward, the IP + PORT of the client should

Re: [PATCH 2 of 2] MAIL: Always log the source port of the client

2014-04-24 Thread Quanah Gibson-Mount
--On April 24, 2014 at 9:47:39 PM +0400 Maxim Dounin mdou...@mdounin.ru wrote: Hello! Much like http-related counterpart, this looks like a hack for me. We may consider adding port to the client connected messages (not sure), but I don't think we have to do anything beyond that. For our

Re: [nginx] Adding Support for Weak ETags

2014-04-24 Thread Aaron Peschel
Hi Maxim, Is the draft patch the same as the one that your posted in the previous thread, or has more work been done since then? -Aaron Peschel On Mon, Apr 21, 2014 at 5:26 AM, Maxim Dounin mdou...@mdounin.ru wrote: Hello! On Thu, Apr 17, 2014 at 05:39:40PM -0700, Aaron Peschel wrote:

Re: [PATCH] Configure: call make distclean for zlib only if Makefile exists

2014-04-24 Thread Ryan Brown
Slightly off-topic, does cloudflare have a nginx fork publicly available? I only saw lua-nginx-cache-module On Thu, Apr 24, 2014 at 10:16 PM, Piotr Sikora pi...@cloudflare.com wrote: Hey, Configure: call make distclean for zlib only if Makefile exists. This change allows to build nginx

Re: [PATCH] Configure: call make distclean for zlib only if Makefile exists

2014-04-24 Thread Yichun Zhang (agentzh)
Hello! On Thu, Apr 24, 2014 at 7:47 PM, Ryan Brown wrote: Slightly off-topic, does cloudflare have a nginx fork publicly available? No. Actually we've been trying hard not to diverge from the official nginx core too far. That's why we've been working hard on the openresty bundle project: