Fix segv error when filename is zero length (data

2015-04-07 Thread Bart Warmerdam
# HG changeset patch # User Bart Warmerdam ba...@xs4all.nl # Date 1428423894 -7200 # Tue Apr 07 18:24:54 2015 +0200 # Branch ngx_files # Node ID 6f5542336a1a0487c8c8b05883596752019de4f5 # Parent a70af6f10942d7d21d140049b432081e8c76ba35 Change format of print string to ngx_str type. diff -r

Empty host header on http 1.1 results in invalid host header logging in error.log

2015-07-21 Thread Bart Warmerdam
Hello, Why does nginx logs an info log a message like ...client sent invalid host header while reading client request headers... request: GET /keepalive.html HTTP/1.1, host: if the host header is empty. According to the http 1.1 specification it is legal to send an empty host header so it

Error path does not close fd

2015-10-13 Thread Bart Warmerdam
Hello, In the ngx_daemon.c the dup2 result code is checked but the earlier opened /dev/null handle is not closed in case of an error. Please consider this path to add to the source base. Regards, B. # HG changeset patch # User Bart Warmerdam <ba...@xs4all.nl> # Date 1444773372

Resource leak on error paths in thread pools

2015-10-13 Thread Bart Warmerdam
It looks like in the error paths the attr variable is not destroyed. Please consider adding this patch to the source base. Regards, B. # HG changeset patch # User ba...@xs4all.nl # Date 1444770783 -7200 # Tue Oct 13 23:13:03 2015 +0200 # Branch thread_unrelease_attr # Node ID

Re: Unexpected behaviour "aio threads" option

2015-11-27 Thread Bart Warmerdam
A test with debug logging is scheduled for upcoming Monday. I hope to be able to deliver the logs by then. Thanks, B. On November 24, 2015 4:32:11 PM GMT+01:00, "Valentin V. Bartenev" <vb...@nginx.com> wrote: >On Tuesday 24 November 2015 15:10:12 Bart Warmerdam

Unexpected behaviour "aio threads" option

2015-11-24 Thread Bart Warmerdam
Hello, On a system with a load of about 500-600 URI/sec I see some unexpected behaviour when using "aio threads" option in the configuration. System setup: The system runs on RHEL6.6 with 3 workers running nginx 1.9.6 with thread support. Content is cached and populated by a proxied-upstream.

SSL Alternative Subject Name validation

2016-08-04 Thread Bart Warmerdam
Hello, According to src/event/ngx_event_openssl.c (line ~ 3094) /* * As per RFC6125 and RFC2818, we check subjectAltName extension, * and if it's not present - commonName in Subject is checked. */ But according to the https://tools.ietf.org/html/rfc6125 the validation

Re: [PATCH] Avoid using the result of i2d_SSL_SESSION when the session is invalid

2017-06-19 Thread Bart Warmerdam
thout the "len < 1" or-statement. Regards, B. On 2017-06-19 12:10, Ruslan Ermilov wrote: On Mon, Jun 19, 2017 at 08:08:38AM +0200, Bart Warmerdam wrote: # HG changeset patch # User Bart Warmerdam <ba...@xs4all.nl> # Date 1497852211 -7200 # Mon Jun 19 08:03:31 2017 +0200 #

[PATCH] Avoid using the result of i2d_SSL_SESSION when the session is invalid

2017-06-19 Thread Bart Warmerdam
# HG changeset patch # User Bart Warmerdam <ba...@xs4all.nl> # Date 1497852211 -7200 # Mon Jun 19 08:03:31 2017 +0200 # Branch i2d_ssl_session_length # Node ID 079afb2cb4be3ef06d07e96d1a54cc359b971631 # Parent d1816a2696de8c2faa1cd913a151e5f62a8620f3 Make sure to also take into a

[PATCH] Avoid memory leak on failure to allocate name during resolving

2017-06-19 Thread Bart Warmerdam
# HG changeset patch # User Bart Warmerdam <ba...@xs4all.nl> # Date 1497851445 -7200 # Mon Jun 19 07:50:45 2017 +0200 # Branch memleak_resolve_name # Node ID dd8c5ef0483cf0abe6f9f88b4bb9ba681aec7be4 # Parent d1816a2696de8c2faa1cd913a151e5f62a8620f3 Avoid leak on error allocating name