Re: [PATCH 1 of 2] HTTP: Add client source port to any error that is logged

2014-04-25 Thread Maxim Dounin
Hello! On Thu, Apr 24, 2014 at 04:37:31PM -0700, Quanah Gibson-Mount wrote: --On April 24, 2014 at 10:26:07 PM +0400 Maxim Dounin mdou...@mdounin.ru wrote: Yes, that is true, but why only implement a partial solution? With CGN, only logging the IP is fairly useless in all cases. To

[PATCH 1 of 2] HTTP: Add client source port to any error that is logged

2014-04-24 Thread Quanah Gibson-Mount
# HG changeset patch # User Quanah Gibson-Mount qua...@zimbra.com # Date 1398357557 18000 # Node ID 4b7d2e503c06758330aabcc21ffbbab77f09568e # Parent 1b0c55d38d0b7ba69dcad79760a3fadc30696a9d HTTP: Add client source port to any error that is logged For TRAC ticket 531 diff -r 1b0c55d38d0b -r

Re: [PATCH 1 of 2] HTTP: Add client source port to any error that is logged

2014-04-24 Thread Maxim Dounin
Hello! On Thu, Apr 24, 2014 at 12:19:46PM -0500, Quanah Gibson-Mount wrote: # HG changeset patch # User Quanah Gibson-Mount qua...@zimbra.com # Date 1398357557 18000 # Node ID 4b7d2e503c06758330aabcc21ffbbab77f09568e # Parent 1b0c55d38d0b7ba69dcad79760a3fadc30696a9d HTTP: Add client

Re: [PATCH 1 of 2] HTTP: Add client source port to any error that is logged

2014-04-24 Thread Quanah Gibson-Mount
--On April 24, 2014 at 9:37:54 PM +0400 Maxim Dounin mdou...@mdounin.ru wrote: I tend to say No, thanks. If needed due to local regulations, $remote_port can be added to log_format. $remote_port in the log format section only covers errors logged to the access log, it does not cover

Re: [PATCH 1 of 2] HTTP: Add client source port to any error that is logged

2014-04-24 Thread Quanah Gibson-Mount
--On April 24, 2014 at 10:41:43 AM -0700 Quanah Gibson-Mount qua...@zimbra.com wrote: --On April 24, 2014 at 9:37:54 PM +0400 Maxim Dounin mdou...@mdounin.ru wrote: I tend to say No, thanks. If needed due to local regulations, $remote_port can be added to log_format. $remote_port in

Re: [PATCH 1 of 2] HTTP: Add client source port to any error that is logged

2014-04-24 Thread Maxim Dounin
Hello! On Thu, Apr 24, 2014 at 10:41:43AM -0700, Quanah Gibson-Mount wrote: --On April 24, 2014 at 9:37:54 PM +0400 Maxim Dounin mdou...@mdounin.ru wrote: I tend to say No, thanks. If needed due to local regulations, $remote_port can be added to log_format. $remote_port in the log

Re: [PATCH 1 of 2] HTTP: Add client source port to any error that is logged

2014-04-24 Thread Quanah Gibson-Mount
--On April 24, 2014 at 9:56:48 PM +0400 Maxim Dounin mdou...@mdounin.ru wrote: $remote_port in the log format section only covers errors logged to the access log, it does not cover errors in the error log. The submitted patch handles the error log. I understand the difference, thank you.

Re: [PATCH 1 of 2] HTTP: Add client source port to any error that is logged

2014-04-24 Thread Maxim Dounin
Hello! On Thu, Apr 24, 2014 at 11:06:29AM -0700, Quanah Gibson-Mount wrote: --On April 24, 2014 at 9:56:48 PM +0400 Maxim Dounin mdou...@mdounin.ru wrote: $remote_port in the log format section only covers errors logged to the access log, it does not cover errors in the error log. The

Re: [PATCH 1 of 2] HTTP: Add client source port to any error that is logged

2014-04-24 Thread Quanah Gibson-Mount
--On April 24, 2014 at 10:26:07 PM +0400 Maxim Dounin mdou...@mdounin.ru wrote: Yes, that is true, but why only implement a partial solution? With CGN, only logging the IP is fairly useless in all cases. To truly get useful information going forward, the IP + PORT of the client should