Re:[patch] Slice filter: support for empty file.

Hi, >416 will be returned when the request has no Range HEADER and the target file >is >empty. Apparently, it does not conform to the HTTP protocol. Empty file seems >inevitable in the CDN service where Nginx is heavily used. > ># HG changeset patch ># User hucongcong >#

Re: [PATCH] Avoid using the result of i2d_SSL_SESSION when the session is invalid

Hello! On Mon, Jun 19, 2017 at 04:09:43PM +0200, Bart Warmerdam wrote: > According to the man-page of i2d_SSL_SESSION the result can be NULL or > 0, but case the actual result can also be -1 in case of a failed > CRYPTO_malloc. The call trace for this function is: > > Call chain: >

Re: [PATCH 4 of 4] HTTP/2: reject HTTP/2 requests with connection-specific headers

Hello! On Sat, Jun 17, 2017 at 01:57:38PM -0700, Piotr Sikora via nginx-devel wrote: [...] > > Unless there are practical reasons for these changes, I would > > rather reject the series. > > The practical reason is that other implementations (e.g. nghttp2) > reject requests with those headers,

[PATCH] HTTP/2: add debug logging of control frames

# HG changeset patch # User Piotr Sikora # Date 1490516711 25200 # Sun Mar 26 01:25:11 2017 -0700 # Node ID 1f1549823fba355a0dd1af49108be4b4898bf331 # Parent d1816a2696de8c2faa1cd913a151e5f62a8620f3 HTTP/2: add debug logging of control frames. Signed-off-by: Piotr

Re: [PATCH] HTTP/2: add debug logging of control frames

Hey Valentin, > Ok, I've already resigned myself to multiline output, but don't let it > look like an another SETTINGS frame. > > IMHO, something like that will be good enough: > >http2 send SETTINGS frame >http2 SETTINGS param MAX_CONCURRENT_STREAMS: 100 >http2 SETTINGS param

Re: [PATCH] Avoid using the result of i2d_SSL_SESSION when the session is invalid

According to the man-page of i2d_SSL_SESSION the result can be NULL or 0, but case the actual result can also be -1 in case of a failed CRYPTO_malloc. The call trace for this function is: Call chain: i2d_SSL_SESSION i2d_SSL_SESSION_ASN1 ASN1_item_i2d asn1_item_flags_i2d The

[PATCH] add reload_delay directive

exporting patch: # HG changeset patch # User RocFang # Date 1497882783 0 # Node ID 8b9e416ef7f9f8e7f96eaa53b479062683464481 # Parent a39bc74873faf9e5bea616561b43f6ecc55229f9 Introduced reload_delay. Previously, the master process will sleep 100ms before sending a

Re: [PATCH] add reload_delay directive

Hello! On Mon, Jun 19, 2017 at 11:09:58PM +0800, Peng Fang wrote: > # HG changeset patch > # User RocFang > # Date 1497882783 0 > # Node ID 8b9e416ef7f9f8e7f96eaa53b479062683464481 > # Parent a39bc74873faf9e5bea616561b43f6ecc55229f9 > Introduced reload_delay. > >

[patch] Http image_filter: return 405 when method is HEAD and body is empty.

Hi, Returning 415 does not conform to the HTTP protocol when image and proxy_pass configured in same location. # HG changeset patch # User hucongcong # Date 1497890354 -28800 # Tue Jun 20 00:39:14 2017 +0800 # Node ID af3a94de6a6549dec5e1205514eda1893313a14c # Parent

Re: [PATCH] add reload_delay directive

Hello, Maxim, Thanks for your detailed explanation and I truly agree with you. 2017-06-19 23:28 GMT+08:00 Maxim Dounin : > Hello! > > On Mon, Jun 19, 2017 at 11:09:58PM +0800, Peng Fang wrote: > > > # HG changeset patch > > # User RocFang > > # Date

Re: [PATCH] Proxy: add "proxy_ssl_alpn" directive

Hello! On Mon, Jun 19, 2017 at 07:31:11AM -0700, Piotr Sikora via nginx-devel wrote: > Hey Maxim, > > > It doesn't look like this patch make sense by its own. > > > > If this patch is a part of a larger work, please consider > > submitting a patch series with the whole feature instead. > >

Re: [patch] Http image_filter: return 405 when method is HEAD and body is empty.

Hello! On Tue, Jun 20, 2017 at 12:56:15AM +0800, 胡聪 (hucc) wrote: > Returning 415 does not conform to the HTTP protocol when image and proxy_pass > configured in same location. > > # HG changeset patch > # User hucongcong > # Date 1497890354 -28800 > # Tue Jun 20

Re: [patch] Http image_filter: return 405 when method is HEAD andbody is empty.

Hi, On Tuesday, Jun 20, 2017 1:21 AM +0300, Maxim Dounin wrote: >On Tue, Jun 20, 2017 at 12:56:15AM +0800, 胡聪 (hucc) wrote: > >> Returning 415 does not conform to the HTTP protocol when image and proxy_pass >> configured in same location. >> >> # HG changeset patch >> # User hucongcong

[nginx] slice module issue

Hi! Have a look at the following example first. server { listen 80; location / { slice 10; proxy_set_header Range $slice_range; proxy_pass http://127.0.0.1:81; } } server { listen 81; root html; } Then we start a request with

[patch] Slice filter: support for empty file.

Hi, 416 will be returned when the request has no Range HEADER and the target file is empty. Apparently, it does not conform to the HTTP protocol. Empty file seems inevitable in the CDN service where Nginx is heavily used. # HG changeset patch # User hucongcong # Date

Re: [PATCH] Avoid using the result of i2d_SSL_SESSION when the session is invalid

On Mon, Jun 19, 2017 at 08:08:38AM +0200, Bart Warmerdam wrote: > # HG changeset patch > # User Bart Warmerdam > # Date 1497852211 -7200 > # Mon Jun 19 08:03:31 2017 +0200 > # Branch i2d_ssl_session_length > # Node ID 079afb2cb4be3ef06d07e96d1a54cc359b971631 > # Parent

[PATCH] Avoid using the result of i2d_SSL_SESSION when the session is invalid

# HG changeset patch # User Bart Warmerdam # Date 1497852211 -7200 # Mon Jun 19 08:03:31 2017 +0200 # Branch i2d_ssl_session_length # Node ID 079afb2cb4be3ef06d07e96d1a54cc359b971631 # Parent d1816a2696de8c2faa1cd913a151e5f62a8620f3 Make sure to also take into account the

[PATCH] Avoid memory leak on failure to allocate name during resolving

# HG changeset patch # User Bart Warmerdam # Date 1497851445 -7200 # Mon Jun 19 07:50:45 2017 +0200 # Branch memleak_resolve_name # Node ID dd8c5ef0483cf0abe6f9f88b4bb9ba681aec7be4 # Parent d1816a2696de8c2faa1cd913a151e5f62a8620f3 Avoid leak on error allocating name diff

[nginx] Resolver: fixed allocation error handling while resolving SRV.

details: http://hg.nginx.org/nginx/rev/a39bc74873fa branches: changeset: 7039:a39bc74873fa user: Bart Warmerdam date: Mon Jun 19 14:25:42 2017 +0300 description: Resolver: fixed allocation error handling while resolving SRV. diffstat: src/core/ngx_resolver.c | 4

Re: [PATCH] Avoid memory leak on failure to allocate name during resolving

Hello Bart, On Mon, Jun 19, 2017 at 08:00:37AM +0200, Bart Warmerdam wrote: > > # HG changeset patch > # User Bart Warmerdam > # Date 1497851445 -7200 > # Mon Jun 19 07:50:45 2017 +0200 > # Branch memleak_resolve_name > # Node ID dd8c5ef0483cf0abe6f9f88b4bb9ba681aec7be4 >

[njs] Object.freeze() method.

details: http://hg.nginx.org/njs/rev/824fbb7fcd35 branches: changeset: 366:824fbb7fcd35 user: Dmitry Volyntsev date: Mon Jun 19 14:39:56 2017 +0300 description: Object.freeze() method. diffstat: njs/njs_array.c | 3 +- njs/njs_builtin.c| 2 +

[njs] Object.seal() method.

details: http://hg.nginx.org/njs/rev/cc5ab912d455 branches: changeset: 370:cc5ab912d455 user: Dmitry Volyntsev date: Mon Jun 19 14:46:39 2017 +0300 description: Object.seal() method. diffstat: njs/njs_object.c | 45

[njs] Object.isExtensible() method.

details: http://hg.nginx.org/njs/rev/bd6c05f66ea9 branches: changeset: 369:bd6c05f66ea9 user: Dmitry Volyntsev date: Mon Jun 19 14:46:34 2017 +0300 description: Object.isExtensible() method. diffstat: njs/njs_object.c | 28

[njs] Using njs_string_get() where appropriate.

details: http://hg.nginx.org/njs/rev/7ed74a2e4c50 branches: changeset: 365:7ed74a2e4c50 user: Dmitry Volyntsev date: Wed Jun 14 17:58:10 2017 +0300 description: Using njs_string_get() where appropriate. diffstat: njs/njs_object.c | 11 +-- njs/njs_vm.c

[njs] Object.isFrozen() method.

details: http://hg.nginx.org/njs/rev/b2ccd7673a5e branches: changeset: 368:b2ccd7673a5e user: Dmitry Volyntsev date: Mon Jun 19 14:41:03 2017 +0300 description: Object.isFrozen() method. diffstat: njs/njs_object.c | 56

[njs] Object.isSealed() method.

details: http://hg.nginx.org/njs/rev/bcd7a7256805 branches: changeset: 371:bcd7a7256805 user: Dmitry Volyntsev date: Mon Jun 19 14:46:46 2017 +0300 description: Object.isSealed() method. diffstat: njs/njs_object.c | 56

[njs] Object.preventExtensions() method.

details: http://hg.nginx.org/njs/rev/4d5a5d618fca branches: changeset: 367:4d5a5d618fca user: Dmitry Volyntsev date: Mon Jun 19 14:40:14 2017 +0300 description: Object.preventExtensions() method. diffstat: njs/njs_object.c | 25 +