RE: Restrictions to modifying request->headers_in.headers in NGX_HTTP_PREACCESS_PHASE?

> -Original Message- > From: nginx-devel [mailto:nginx-devel-boun...@nginx.org] On Behalf Of Ryan > Burn > Sent: Friday, March 30, 2018 5:30 PM > To: nginx-devel@nginx.org; rob...@cryptobells.com > Subject: Re: Restrictions to modifying request-&

Re: Restrictions to modifying request->headers_in.headers in NGX_HTTP_PREACCESS_PHASE?

The module is intended to support distributed tracing in a pluggable way. The key/values of the headers added are generated from the module. They're used to support cross process tracing (http://opentracing.io/documentation/pages/api/cross-process-tracing.html) so that the performance information

Re: Restrictions to modifying request->headers_in.headers in NGX_HTTP_PREACCESS_PHASE?

Hello, On Thu, Mar 29, 2018 at 11:06 AM, Ryan Burn wrote: > > > This module injects multiple headers and the number, keys, etc aren't > meant to be exposed to the user. > > (This module is mean to support tracing and the injected headers btw > correspond to a SpanContext: >

Re: Restrictions to modifying request->headers_in.headers in NGX_HTTP_PREACCESS_PHASE?

On Thu, Mar 29, 2018 at 9:40 AM, Maxim Dounin wrote: > Hello! > > On Wed, Mar 28, 2018 at 04:15:44PM -0400, Ryan Burn wrote: > >> > You are not allowed to modify r->headers_in, at any time. >> >> If I want to ensure that certain headers are added if the request is >> proxied

Re: Restrictions to modifying request->headers_in.headers in NGX_HTTP_PREACCESS_PHASE?

Hello! On Wed, Mar 28, 2018 at 04:15:44PM -0400, Ryan Burn wrote: > > You are not allowed to modify r->headers_in, at any time. > > If I want to ensure that certain headers are added if the request is > proxied upstream, is there any way to do that? Recommended approach is to export a variable

Re: Restrictions to modifying request->headers_in.headers in NGX_HTTP_PREACCESS_PHASE?

> > You are not allowed to modify r->headers_in, at any time. > If I want to ensure that certain headers are added if the request is proxied upstream, is there any way to do that? ___ nginx-devel mailing list nginx-devel@nginx.org

Re: Restrictions to modifying request->headers_in.headers in NGX_HTTP_PREACCESS_PHASE?

Hello! On Wed, Mar 28, 2018 at 03:47:04PM -0400, Ryan Burn wrote: > I have a module that registers a handler to run in > NGX_HTTP_PREACCESS_PHASE. The handler adds headers to > request->headers_in.headers. This works as I would expect most of the > time. But I am seeing cases of some crashes

Restrictions to modifying request->headers_in.headers in NGX_HTTP_PREACCESS_PHASE?

Hi, I have a module that registers a handler to run in NGX_HTTP_PREACCESS_PHASE. The handler adds headers to request->headers_in.headers. This works as I would expect most of the time. But I am seeing cases of some crashes when calling ngx_list_push(>headers_in.headers)); Are there any