Re: proposal: PTAL tag to make it clear that a PR is ready again for review

2020-05-17 Thread timothee
> > look at my stuff, my stuff is more important than all the other stuff by > > all the other contributors that's not the point at all, quite the opposite. The whole point is for triaging PRs and saving reviewer time by allowing them to filter from those 114 open PR's the ones that are in a

Re: proposal: PTAL tag to make it clear that a PR is ready again for review

2020-05-17 Thread miran
> Please no. +1 > All these title/tag changes are just noise and we've got enough of that > already. +1 > just ping the best person to review that PR Or, better yet, don't ping anybody and just be patient. At the time of writing this, we have 114 open PRs (and that's after two weeks of

Re: proposal: PTAL tag to make it clear that a PR is ready again for review

2020-05-17 Thread dom96
Please no. If you want someone to have a look at your PR then bump the PR so it gets put at the top of our notifications or just ping the best person to review that PR (if you know who they are). All these title/tag changes are just noise and we've got enough of that already.

proposal: PTAL tag to make it clear that a PR is ready again for review

2020-05-17 Thread timothee
Currently, looking at [https://github.com/nim-lang/Nim/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc](https://github.com/nim-lang/Nim/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc) it's not clear which PR's are ready for review vs still being worked on: * using draft vs not draft is not good