Re: [Nix-dev] reviewboard

2012-03-20 Thread Ludovic Courtès
Hi, Florian Friesdorf f...@chaoflow.net skribis: On Sun, 18 Mar 2012 22:07:44 +0100, l...@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) wrote: (..) There’s a Debbugs mode in Emacs that really rocks, because it’s specifically tailored for the job, has a convenient UI, and is well integrated

Re: [Nix-dev] reviewboard

2012-03-19 Thread Florian Friesdorf
#secure method=pgpmime mode=sign Hi Ludo’ On Sun, 18 Mar 2012 22:07:44 +0100, l...@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) wrote: (..) There’s a Debbugs mode in Emacs that really rocks, because it’s specifically tailored for the job, has a convenient UI, and is well integrated with

Re: [Nix-dev] reviewboard

2012-03-19 Thread Florian Friesdorf
#secure method=pgpmime mode=sign On Sun, 18 Mar 2012 11:55:44 -0700, Corey O'Connor coreyocon...@gmail.com wrote: Now, a web tool is likely to be too tedious for me to use, and I expect other hackers may not like having to jump to a browser to get the work done.  :-) xmonad + vimium is

Re: [Nix-dev] reviewboard

2012-03-18 Thread Ludovic Courtès
Hi, Yury G. Kudryashov urkud.ur...@gmail.com skribis: http://reviewboard.org FWIW, a “web-based code review tool” is never going to be powerful for me: using a web server puts me on the slow path. I would recommend keeping using email for that. In addition, Debbugs could be used to keep

Re: [Nix-dev] reviewboard

2012-03-18 Thread Corey O'Connor
2012/3/18 Ludovic Courtès l...@gnu.org: Hi, Yury G.  Kudryashov urkud.ur...@gmail.com skribis: http://reviewboard.org FWIW, a “web-based code review tool” is never going to be powerful for me: using a web server puts me on the slow path. I would recommend keeping using email for that.  

Re: [Nix-dev] reviewboard

2012-03-18 Thread Eelco Dolstra
Hi, On 18/03/12 18:01, Corey O'Connor wrote: IMO, use of git avoids some problems just by being distributed. The patches can be recorded to many repositories even if the submitting user does not have access to the master repository. And GitHub has pull requests and allows commenting on

Re: [Nix-dev] reviewboard

2012-03-18 Thread Ludovic Courtès
Hi, Corey O'Connor coreyocon...@gmail.com skribis: Patches submitted by email to the list get lost. Yes, I understand the problem, and I agree it’s important to fix it. Now, a web tool is likely to be too tedious for me to use, and I expect other hackers may not like having to jump to a

Re: [Nix-dev] reviewboard

2012-03-18 Thread Corey O'Connor
2012/3/18 Ludovic Courtès l...@gnu.org: Yes, I understand the problem, and I agree it’s important to fix it. Excellent! So long everybody agrees there is a problem then it is only a matter of time before we find a solution. ;-) Now, a web tool is likely to be too tedious for me to use, and I

Re: [Nix-dev] reviewboard

2012-03-18 Thread Ludovic Courtès
Hi! Corey O'Connor coreyocon...@gmail.com skribis: 2012/3/18 Ludovic Courtès l...@gnu.org: [...] Now, a web tool is likely to be too tedious for me to use, and I expect other hackers may not like having to jump to a browser to get the work done.  :-) xmonad + vimium is my recommendation

[Nix-dev] reviewboard ship it

2012-03-17 Thread Yury G. Kudryashov
Hi! If you look at a review, and find nothing bad, press Ship it, please. This is the only way I know about to distinguish nobody cares scenario from some people had a look, and found nothing bad. -- Yury G. Kudryashov, mailto: ur...@mccme.ru ___

Re: [Nix-dev] reviewboard

2012-03-17 Thread Yury G. Kudryashov
Marc Weber wrote: This would - shut up all people (like me :) asking for git all the time - stop people announcing yet another git mirror of nixos/nixpkgs - allow code sharing on github This won't shut up me disliking non-opensource github hosting. What features do you miss in, e.g.,

Re: [Nix-dev] reviewboard

2012-03-17 Thread Marc Weber
In reviewboard I can send a review request to a particular person, not to repository. Is it possible in github? Probably no. It looks like comments are sent to all members as email. But I'm not an expert. github has the network tab view which gitorious doesn't have, does it ? github just came

Re: [Nix-dev] reviewboard ship it

2012-03-17 Thread Corey O'Connor
On Sat, Mar 17, 2012 at 8:00 PM, Shea Levy s...@shealevy.com wrote: On 3/17/12 10:37 PM, Corey O'Connor wrote: Thanks for the info! What happens when we hit Ship It? It adds a review that basically means I don't mind if you commit this. In a 'no-reply-is-no-ok' project like NixOS this kind

Re: [Nix-dev] reviewboard ship it

2012-03-17 Thread Yury G. Kudryashov
Corey O'Connor wrote: On Sat, Mar 17, 2012 at 8:00 PM, Shea Levy s...@shealevy.com wrote: On 3/17/12 10:37 PM, Corey O'Connor wrote: Thanks for the info! What happens when we hit Ship It? It adds a review that basically means I don't mind if you commit this. In a 'no-reply-is-no-ok'

Re: [Nix-dev] reviewboard

2012-03-16 Thread Ludovic Courtès
Hi, Yury G. Kudryashov urkud.ur...@gmail.com skribis: I've set up a reviewboard at http://reviewboard.loegria.net/ What is it, and what would it be used for? Ludo’. ___ nix-dev mailing list nix-dev@lists.science.uu.nl

Re: [Nix-dev] reviewboard

2012-03-16 Thread Yury G. Kudryashov
Ludovic Courtès wrote: Hi, Yury G. Kudryashov urkud.ur...@gmail.com skribis: I've set up a reviewboard at http://reviewboard.loegria.net/ What is it, http://reviewboard.org and what would it be used for? Not loosing incoming patches while we're using svn for nixos and nixpkgs. --

Re: [Nix-dev] reviewboard

2012-03-16 Thread Yury G. Kudryashov
Cillian de Róiste wrote: Hi, It looks very useful. I just thought I'd mention that I was confused by the form question: Base Directory: The absolute path in the repository the diff was generated in. It is happy with /nixpkgs/trunk for relative patches created in /etc/nixos/nixpkgs I

Re: [Nix-dev] reviewboard

2012-03-15 Thread Yury G. Kudryashov
Corey O'Connor wrote: Thanks! Is reviewboard set up to email the list when a patch is posted for review? I think that would be great. No, I made no setup yet. Only registered nix svn repo. Actually, I'm not sure if mailing works at all. It tries to use localhost:25, and I have no idea if it

Re: [Nix-dev] reviewboard

2012-03-15 Thread Yury G. Kudryashov
Corey O'Connor wrote: Thanks! Is reviewboard set up to email the list when a patch is posted for review? This will work if someone will add nore...@reviewboard.loegria.net to whitelist. Eelco? I think that would be great. -- Yury G. Kudryashov, mailto: ur...@mccme.ru