[Nix-dev] reviewboard ship it

2012-03-17 Thread Yury G. Kudryashov
Hi! If you look at a review, and find nothing bad, press Ship it, please. This is the only way I know about to distinguish nobody cares scenario from some people had a look, and found nothing bad. -- Yury G. Kudryashov, mailto: ur...@mccme.ru ___

Re: [Nix-dev] reviewboard ship it

2012-03-17 Thread Corey O'Connor
On Sat, Mar 17, 2012 at 8:00 PM, Shea Levy s...@shealevy.com wrote: On 3/17/12 10:37 PM, Corey O'Connor wrote: Thanks for the info! What happens when we hit Ship It? It adds a review that basically means I don't mind if you commit this. In a 'no-reply-is-no-ok' project like NixOS this kind

Re: [Nix-dev] reviewboard ship it

2012-03-17 Thread Yury G. Kudryashov
Corey O'Connor wrote: On Sat, Mar 17, 2012 at 8:00 PM, Shea Levy s...@shealevy.com wrote: On 3/17/12 10:37 PM, Corey O'Connor wrote: Thanks for the info! What happens when we hit Ship It? It adds a review that basically means I don't mind if you commit this. In a 'no-reply-is-no-ok'