Re: sntp

[Tom Hughes]

On 14/12/15 12:08, Stephen Gallagher wrote:


I'd go so far as to say that we should propose a modification to the packaging 
guidelines to state this explicitly. Would you like me to prepare a draft?


Sounds good to me.

Sometimes modules have extra entry points that can be loaded with variants of 
require in which case those could be test loaded as well.


Could you give me an example of those variants?


I was going to say readable-stream, where you can do:

  require('readable-stream/transform')

but it turns out the main entry point also requires and exports that, so 
it is equivalent to:


  require('readable-stream').Transform

It illustrates the basic point though, that there can be other top level 
js files that you can require as module/file or test as:


  node -e "require('./file')"

Tom

--
Tom Hughes (t...@compton.nu)
http://compton.nu/
___
nodejs mailing list
nodejs@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/nodejs@lists.fedoraproject.org

Re: sntp

[Tom Hughes]

On 14/12/15 15:25, Jared K. Smith wrote:

I have packages either built or in process for the following:

balanced-match
brace-expansion
builtin-modules
concat-map
escape-string-regexp
graceful-readlink
has-ansi
is-builtin-module
jju
json-parse-helpfulerror
os-homedir
spdx-correct
spdx-exceptions
spdx-expression-parse
validate-npm-package-license

I'll double-check each of them and start creating review requests for
them today.


We should probably create a wiki page with list of all the packages and 
package updates that we know are needed along with bug numbers and/or 
who is working on them?


Tom

--
Tom Hughes (t...@compton.nu)
http://compton.nu/
___
nodejs mailing list
nodejs@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/nodejs@lists.fedoraproject.org

Re: sntp

[Jared K. Smith]

On Mon, Dec 14, 2015 at 11:05 AM, Tom Hughes  wrote:

> We should probably create a wiki page with list of all the packages and
> package updates that we know are needed along with bug numbers and/or who
> is working on them?



Quick and dirty wiki page created at
https://fedoraproject.org/wiki/Node.js/npm_update_status

-Jared
___
nodejs mailing list
nodejs@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/nodejs@lists.fedoraproject.org

Re: sntp

[Stephen Gallagher]

> On Dec 14, 2015, at 4:10 AM, Tom Hughes  wrote:
> 
>> On 14/12/15 08:05, Piotr Popieluch wrote:
>> 
>> I'm glad I'm not the only one feeling this way. As careful I am trying
>> to be I still end up overlooking some dependency. I wonder if it would
>> be possible to reuse the code from taskotron depcheck, or from the koji
>> depcheck to have a local depency check which could be run before pushing
>> to rawhide.
> 
> I was thinking about this last night, and much of the problem comes from 
> modules where for one reason or another we don't have the tests enabled.
> 
> It struck me that, in most cases, and at least with the recent issues with 
> both argparse and sntp, even just a simple attempt to load the module would 
> have caught them.
> 
> So my proposal is that if there are no proper tests, or we are not currently 
> able to enable them, then a simple %check along these lines should be 
> included:
> 
> %{__nodejs} -e 'require("./")'
> 
> It won't catch everything because sometimes a dependency is only loaded when 
> a particular feature is used, but in most cases they are loaded 
> unconditionally when the module is loaded.
> 


I'd actually argue that we probably want to do this whether or not there are 
other tests.  (It's always possible that upstream tests run against the source 
directory instead of the installed path, and therefore might not be entirely 
correct)

I'd go so far as to say that we should propose a modification to the packaging 
guidelines to state this explicitly. Would you like me to prepare a draft?


> Tom
> 
> -- 
> Tom Hughes (t...@compton.nu)
> http://compton.nu/
> ___
> nodejs mailing list
> nodejs@lists.fedoraproject.org
> http://lists.fedoraproject.org/admin/lists/nodejs@lists.fedoraproject.org
___
nodejs mailing list
nodejs@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/nodejs@lists.fedoraproject.org

Re: sntp

[Zuzana Svetlikova]

Are these just the packages needed for npm? I'm just asking because I don't see 
nodejs-foo listed as a npm dependency and it looks pretty dead to me.

- Original Message -
From: "Jared K. Smith" 
To: "Node.js on Fedora" 
Sent: Monday, December 14, 2015 5:31:46 PM
Subject: Re: sntp


On Mon, Dec 14, 2015 at 11:05 AM, Tom Hughes < t...@compton.nu > wrote: 


We should probably create a wiki page with list of all the packages and package 
updates that we know are needed along with bug numbers and/or who is working on 
them? 


Quick and dirty wiki page created at 
https://fedoraproject.org/wiki/Node.js/npm_update_status 

-Jared 

___
nodejs mailing list
nodejs@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/nodejs@lists.fedoraproject.org
___
nodejs mailing list
nodejs@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/nodejs@lists.fedoraproject.org