> On Dec 14, 2015, at 4:10 AM, Tom Hughes <[email protected]> wrote: > >> On 14/12/15 08:05, Piotr Popieluch wrote: >> >> I'm glad I'm not the only one feeling this way. As careful I am trying >> to be I still end up overlooking some dependency. I wonder if it would >> be possible to reuse the code from taskotron depcheck, or from the koji >> depcheck to have a local depency check which could be run before pushing >> to rawhide. > > I was thinking about this last night, and much of the problem comes from > modules where for one reason or another we don't have the tests enabled. > > It struck me that, in most cases, and at least with the recent issues with > both argparse and sntp, even just a simple attempt to load the module would > have caught them. > > So my proposal is that if there are no proper tests, or we are not currently > able to enable them, then a simple %check along these lines should be > included: > > %{__nodejs} -e 'require("./")' > > It won't catch everything because sometimes a dependency is only loaded when > a particular feature is used, but in most cases they are loaded > unconditionally when the module is loaded. >
I'd actually argue that we probably want to do this whether or not there are other tests. (It's always possible that upstream tests run against the source directory instead of the installed path, and therefore might not be entirely correct) I'd go so far as to say that we should propose a modification to the packaging guidelines to state this explicitly. Would you like me to prepare a draft? > Tom > > -- > Tom Hughes ([email protected]) > http://compton.nu/ > _______________________________________________ > nodejs mailing list > [email protected] > http://lists.fedoraproject.org/admin/lists/[email protected] _______________________________________________ nodejs mailing list [email protected] http://lists.fedoraproject.org/admin/lists/[email protected]
