Accumulo-Pull-Requests - Build # 1064 - Fixed
The Apache Jenkins build system has built Accumulo-Pull-Requests (build #1064) Status: Fixed Check console output at https://builds.apache.org/job/Accumulo-Pull-Requests/1064/ to view the results.
[GitHub] joshelser commented on a change in pull request #332: ACCUMULO-4826 Use the hadoop3 shaded jars
joshelser commented on a change in pull request #332: ACCUMULO-4826 Use the hadoop3 shaded jars URL: https://github.com/apache/accumulo/pull/332#discussion_r170426903 ## File path: assemble/pom.xml ## @@ -256,6 +234,28 @@ + +org.apache.maven.plugins +maven-dependency-plugin Review comment: Done This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] joshelser commented on a change in pull request #332: ACCUMULO-4826 Use the hadoop3 shaded jars
joshelser commented on a change in pull request #332: ACCUMULO-4826 Use the
hadoop3 shaded jars
URL: https://github.com/apache/accumulo/pull/332#discussion_r170426906
##
File path: assemble/bin/bootstrap_config.sh
##
@@ -383,6 +394,25 @@ elif [[ "${HADOOP_VERSION}" == "IOP4.1" ]]; then
sed -e 's///-->/' \
"${CONF_DIR}/$ACCUMULO_SITE" > temp
+ sed -e 's///-->/' \
+ "${CONF_DIR}/$ACCUMULO_SITE" > temp
+ mv temp "${CONF_DIR}/$ACCUMULO_SITE"
+elif [[ "${HADOOP_VERSION}" == "3" ]]; then
+ sed -e 's///-->/' \
+ "${CONF_DIR}/$ACCUMULO_SITE" > temp
+ sed -e 's///-->/' \
+ "${CONF_DIR}/$ACCUMULO_SITE" > temp
Review comment:
All of these were fixed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] joshelser commented on a change in pull request #332: ACCUMULO-4826 Use the hadoop3 shaded jars
joshelser commented on a change in pull request #332: ACCUMULO-4826 Use the hadoop3 shaded jars URL: https://github.com/apache/accumulo/pull/332#discussion_r170426869 ## File path: assemble/pom.xml ## @@ -323,5 +323,67 @@ + + hadoop2 + + + + !hadoop.profile + + + + commons-math3,commons-vfs2,gson,guava,htrace-core,javax.servlet-api,jcommander,jetty-http,jetty-io,jetty-security,jetty-server,jetty-servlet,jetty-util,jline,libthrift,protobuf-java,slf4j-api,slf4j-log4j12 + src/main/assemblies/binary-release.xml + + + + hadoop3 + + + hadoop.profile + 3 + + + + commons-cli,commons-codec,commons-collections,commons-configuration,commons-io,commons-lang,commons-logging,commons-math3,commons-vfs2,gson,guava,htrace-core,htrace-core4,javax.servlet-api,jcommander,jetty-http,jetty-io,jetty-security,jetty-server,jetty-servlet,jetty-util,jline,libthrift,protobuf-java,slf4j-api,slf4j-log4j12 + src/main/assemblies/binary-release-hadoop3.xml + + Review comment: Turns out we don't need any additions. The only artifact with an entry to NOTICE is about a file that's only in the test jar (and thus we don't need to include). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Accumulo-Pull-Requests - Build # 1063 - Unstable
The Apache Jenkins build system has built Accumulo-Pull-Requests (build #1063) Status: Unstable Check console output at https://builds.apache.org/job/Accumulo-Pull-Requests/1063/ to view the results.
[GitHub] joshelser commented on issue #332: ACCUMULO-4826 Use the hadoop3 shaded jars
joshelser commented on issue #332: ACCUMULO-4826 Use the hadoop3 shaded jars URL: https://github.com/apache/accumulo/pull/332#issuecomment-368240965 > I'm assuming most of the new assembly components file is identical to the old one, but for the bundled dependency changes There are only the dependency additions that have already been mentioned here. > We used to have an enforcer rule that guaranteed hadoop.profile had a valid value. That might be good to add back in now that we're reintroducing the property. Will look here too. > does Accumulo need recompiling or just repackaging to switch between Hadoop 2 and 3? Obviously, you can't build against Hadoop 3 without using Java 8. I've not noticed any required recompilation. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] joshelser commented on a change in pull request #332: ACCUMULO-4826 Use the hadoop3 shaded jars
joshelser commented on a change in pull request #332: ACCUMULO-4826 Use the hadoop3 shaded jars URL: https://github.com/apache/accumulo/pull/332#discussion_r170425669 ## File path: assemble/pom.xml ## @@ -323,5 +323,67 @@ + + hadoop2 + + + + !hadoop.profile + + + + commons-math3,commons-vfs2,gson,guava,htrace-core,javax.servlet-api,jcommander,jetty-http,jetty-io,jetty-security,jetty-server,jetty-servlet,jetty-util,jline,libthrift,protobuf-java,slf4j-api,slf4j-log4j12 + src/main/assemblies/binary-release.xml + + + + hadoop3 + + + hadoop.profile + 3 + + + + commons-cli,commons-codec,commons-collections,commons-configuration,commons-io,commons-lang,commons-logging,commons-math3,commons-vfs2,gson,guava,htrace-core,htrace-core4,javax.servlet-api,jcommander,jetty-http,jetty-io,jetty-security,jetty-server,jetty-servlet,jetty-util,jline,libthrift,protobuf-java,slf4j-api,slf4j-log4j12 + src/main/assemblies/binary-release-hadoop3.xml + + Review comment: Sadly, probably. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] joshelser commented on a change in pull request #332: ACCUMULO-4826 Use the hadoop3 shaded jars
joshelser commented on a change in pull request #332: ACCUMULO-4826 Use the hadoop3 shaded jars URL: https://github.com/apache/accumulo/pull/332#discussion_r170425661 ## File path: core/pom.xml ## @@ -282,5 +277,50 @@ + + hadoop2 + + + Review comment: I will change the comment for you This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] joshelser commented on a change in pull request #332: ACCUMULO-4826 Use the hadoop3 shaded jars
joshelser commented on a change in pull request #332: ACCUMULO-4826 Use the hadoop3 shaded jars URL: https://github.com/apache/accumulo/pull/332#discussion_r170425499 ## File path: pom.xml ## @@ -128,7 +128,9 @@ 3.0.5 1 +2 Review comment: > when we had a 1 and 2 profile, we had to create a third hadoop default profile I remembered this, but didn't look back in history to figure it out again. Let me re-add that. Would be better than having `-Dhadoop.profile=2` oddly not work. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
