[GitHub] [incubator-apisix] membphis commented on issue #1280: request help: 如何通过 apisix.yaml 配置文件开启插件

2020-03-15 Thread GitBox
membphis commented on issue #1280: request help: 如何通过 apisix.yaml 配置文件开启插件 URL: https://github.com/apache/incubator-apisix/issues/1280#issuecomment-599346550 you can take a look at the test cases: https://github.com/apache/incubator-apisix/tree/master/t/config-center-yaml

[GitHub] [incubator-apisix] membphis commented on issue #1279: feature: eureka integration

2020-03-15 Thread GitBox
membphis commented on issue #1279: feature: eureka integration URL: https://github.com/apache/incubator-apisix/issues/1279#issuecomment-599346293 related issue: https://github.com/apache/incubator-apisix/issues/804 This is

[GitHub] [incubator-apisix] xxm404 opened a new issue #1280: 如何通过 apisix.yaml 配置文件开启插件

2020-03-15 Thread GitBox
xxm404 opened a new issue #1280: 如何通过 apisix.yaml 配置文件开启插件 URL: https://github.com/apache/incubator-apisix/issues/1280 ### Issue description 如何在不使用 `etcd` 的模式下,开启插件 ### Environment * apisix version 1.1 * OS: Ubuntu

[GitHub] [incubator-apisix] qiujiayu opened a new issue #1279: feature: eureka integration

2020-03-15 Thread GitBox
qiujiayu opened a new issue #1279: feature: eureka integration URL: https://github.com/apache/incubator-apisix/issues/1279 This is an idea about integrating APISIX with eureka: 1. Added a discovery property to the `apisix.core` module to extend various service discovery components,

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1275: Add multiple etcd address support.

2020-03-15 Thread GitBox
membphis commented on a change in pull request #1275: Add multiple etcd address support. URL: https://github.com/apache/incubator-apisix/pull/1275#discussion_r392738555 ## File path: bin/apisix ## @@ -661,28 +661,32 @@ local function init_etcd(show_output) end

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1275: Add multiple etcd address support.

2020-03-15 Thread GitBox
membphis commented on a change in pull request #1275: Add multiple etcd address support. URL: https://github.com/apache/incubator-apisix/pull/1275#discussion_r392736830 ## File path: conf/config.yaml ## @@ -98,7 +98,10 @@ nginx_config: # config for

[GitHub] [incubator-apisix] membphis commented on issue #1275: Add multiple etcd address support.

2020-03-15 Thread GitBox
membphis commented on issue #1275: Add multiple etcd address support. URL: https://github.com/apache/incubator-apisix/pull/1275#issuecomment-599294660 I updated the resty-etcd right now. Please rebase your branch with APISIX master branch.

[GitHub] [incubator-apisix] membphis merged pull request #1278: update resty-etcd to version 0.9 .

2020-03-15 Thread GitBox
membphis merged pull request #1278: update resty-etcd to version 0.9 . URL: https://github.com/apache/incubator-apisix/pull/1278 This is an automated message from the Apache Git Service. To respond to the message, please log

[incubator-apisix] branch master updated: update resty-etcd to version 0.9 . (#1278)

2020-03-15 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new 9837b80 update resty-etcd to

[GitHub] [incubator-apisix] membphis opened a new pull request #1278: update resty-etcd to version 0.9 .

2020-03-15 Thread GitBox
membphis opened a new pull request #1278: update resty-etcd to version 0.9 . URL: https://github.com/apache/incubator-apisix/pull/1278 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-apisix] membphis commented on issue #1277: doc: add correct link address for "etcd Clustering Guide" of incubator-apisix/README_CN.md

2020-03-15 Thread GitBox
membphis commented on issue #1277: doc: add correct link address for "etcd Clustering Guide" of incubator-apisix/README_CN.md URL: https://github.com/apache/incubator-apisix/pull/1277#issuecomment-599286973 please update the English doc too

[GitHub] [incubator-apisix] Akayeshmantha edited a comment on issue #1275: Add multiple etcd address support.

2020-03-15 Thread GitBox
Akayeshmantha edited a comment on issue #1275: Add multiple etcd address support. URL: https://github.com/apache/incubator-apisix/pull/1275#issuecomment-599270894 Hi @membphis Most of the test cases fails with the below log https://pastebin.com/KbBD6h5s Hm I have no

[GitHub] [incubator-apisix] Akayeshmantha edited a comment on issue #1275: Add multiple etcd address support.

2020-03-15 Thread GitBox
Akayeshmantha edited a comment on issue #1275: Add multiple etcd address support. URL: https://github.com/apache/incubator-apisix/pull/1275#issuecomment-599270894 Hi @membphis Most of the test cases fails with the below log https://pastebin.com/KbBD6h5s Hm I have no

[GitHub] [incubator-apisix] Akayeshmantha edited a comment on issue #1275: Add multiple etcd address support.

2020-03-15 Thread GitBox
Akayeshmantha edited a comment on issue #1275: Add multiple etcd address support. URL: https://github.com/apache/incubator-apisix/pull/1275#issuecomment-599270894 Hi @membphis Most of the test cases fails with the below log should not match any line in error.log but matches

[GitHub] [incubator-apisix] Akayeshmantha edited a comment on issue #1275: Add multiple etcd address support.

2020-03-15 Thread GitBox
Akayeshmantha edited a comment on issue #1275: Add multiple etcd address support. URL: https://github.com/apache/incubator-apisix/pull/1275#issuecomment-599270894 Hi @membphis Most of the test cases fails with the below log ` should not match any line in error.log but

[GitHub] [incubator-apisix] Akayeshmantha commented on issue #1275: Add multiple etcd address support.

2020-03-15 Thread GitBox
Akayeshmantha commented on issue #1275: Add multiple etcd address support. URL: https://github.com/apache/incubator-apisix/pull/1275#issuecomment-599270894 Hi @membphis Most of the test cases fails with the below log `" should not match any line in error.log but matches line

[GitHub] [incubator-apisix] sbritocorral opened a new pull request #1277: doc: add correct link address for "etcd Clustering Guide" of incubator-apisix/README_CN.md

2020-03-15 Thread GitBox
sbritocorral opened a new pull request #1277: doc: add correct link address for "etcd Clustering Guide" of incubator-apisix/README_CN.md URL: https://github.com/apache/incubator-apisix/pull/1277 Resolves #1235 This is an

[GitHub] [incubator-apisix] membphis merged pull request #1258: Supplement admin-api-cn.md, add route/service/consumer/upstream/ssl definitions.

2020-03-15 Thread GitBox
membphis merged pull request #1258: Supplement admin-api-cn.md, add route/service/consumer/upstream/ssl definitions. URL: https://github.com/apache/incubator-apisix/pull/1258 This is an automated message from the Apache Git

[incubator-apisix] branch master updated: doc: add route/service/consumer/upstream/ssl definitions to Admin API (#1258)

2020-03-15 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new cade206 doc: add

[GitHub] [incubator-apisix] membphis commented on issue #1153: feature: support for proxy caching plugin based on disk.

2020-03-15 Thread GitBox
membphis commented on issue #1153: feature: support for proxy caching plugin based on disk. URL: https://github.com/apache/incubator-apisix/pull/1153#issuecomment-599217208 merged, many thx @agile6v This is an automated

[incubator-apisix] branch master updated: feature: support for proxy caching plugin based on disk. (#1153)

2020-03-15 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new 864aa16 feature: support for proxy

[GitHub] [incubator-apisix] membphis merged pull request #1153: feature: support for proxy caching plugin based on disk.

2020-03-15 Thread GitBox
membphis merged pull request #1153: feature: support for proxy caching plugin based on disk. URL: https://github.com/apache/incubator-apisix/pull/1153 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-apisix] membphis closed issue #1127: Feature: introduce proxy caching plugin

2020-03-15 Thread GitBox
membphis closed issue #1127: Feature: introduce proxy caching plugin URL: https://github.com/apache/incubator-apisix/issues/1127 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1258: Supplement admin-api-cn.md, add route/service/consumer/upstream/ssl definitions.

2020-03-15 Thread GitBox
membphis commented on a change in pull request #1258: Supplement admin-api-cn.md, add route/service/consumer/upstream/ssl definitions. URL: https://github.com/apache/incubator-apisix/pull/1258#discussion_r392678465 ## File path: doc/admin-api-cn.md ## @@ -71,7 +75,29 @@

[GitHub] [incubator-apisix] Miss-you commented on a change in pull request #1258: Supplement admin-api-cn.md, add route/service/consumer/upstream/ssl definitions.

2020-03-15 Thread GitBox
Miss-you commented on a change in pull request #1258: Supplement admin-api-cn.md, add route/service/consumer/upstream/ssl definitions. URL: https://github.com/apache/incubator-apisix/pull/1258#discussion_r392678155 ## File path: doc/admin-api-cn.md ## @@ -71,7 +75,29 @@

[GitHub] [incubator-apisix] membphis commented on issue #1153: feature: support for proxy caching plugin based on disk.

2020-03-15 Thread GitBox
membphis commented on issue #1153: feature: support for proxy caching plugin based on disk. URL: https://github.com/apache/incubator-apisix/pull/1153#issuecomment-599215439 LGTM, we can merge it after run the test cases.

[GitHub] [incubator-apisix] membphis commented on issue #1275: Add multiple etcd address support.

2020-03-15 Thread GitBox
membphis commented on issue #1275: Add multiple etcd address support. URL: https://github.com/apache/incubator-apisix/pull/1275#issuecomment-599210892 > is it a mock one or a real etcd db running ? It is a real etcd, the same as your local ENV.

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1153: feature: support for proxy caching plugin based on disk.

2020-03-15 Thread GitBox
membphis commented on a change in pull request #1153: feature: support for proxy caching plugin based on disk. URL: https://github.com/apache/incubator-apisix/pull/1153#discussion_r392673996 ## File path: t/plugin/proxy-cache.t ## @@ -0,0 +1,630 @@ +# +# Licensed to the

[GitHub] [incubator-apisix] Akayeshmantha commented on issue #1275: Add multiple etcd address support.

2020-03-15 Thread GitBox
Akayeshmantha commented on issue #1275: Add multiple etcd address support. URL: https://github.com/apache/incubator-apisix/pull/1275#issuecomment-599210432 @membphis test cases fails in https://github.com/apache/incubator-apisix/blob/master/lua/apisix/core/config_etcd.lua#L350

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1153: feature: support for proxy caching plugin based on disk.

2020-03-15 Thread GitBox
membphis commented on a change in pull request #1153: feature: support for proxy caching plugin based on disk. URL: https://github.com/apache/incubator-apisix/pull/1153#discussion_r392673846 ## File path: lua/apisix/plugins/proxy-cache.lua ## @@ -0,0 +1,259 @@ +-- +--

[GitHub] [incubator-apisix] agile6v commented on a change in pull request #1153: feature: support for proxy caching plugin based on disk.

2020-03-15 Thread GitBox
agile6v commented on a change in pull request #1153: feature: support for proxy caching plugin based on disk. URL: https://github.com/apache/incubator-apisix/pull/1153#discussion_r392672970 ## File path: t/plugin/proxy-cache.t ## @@ -0,0 +1,630 @@ +# +# Licensed to the

[GitHub] [incubator-apisix] sshniro commented on issue #1276: add more test cases for oauth plugin

2020-03-15 Thread GitBox
sshniro commented on issue #1276: add more test cases for oauth plugin URL: https://github.com/apache/incubator-apisix/issues/1276#issuecomment-599206961 Sure, will add a test case with a valid cert and a token with an indefinite expiry time,

[GitHub] [incubator-apisix] moonming merged pull request #1266: Adding support to public key based introspection for OAuth plugin

2020-03-15 Thread GitBox
moonming merged pull request #1266: Adding support to public key based introspection for OAuth plugin URL: https://github.com/apache/incubator-apisix/pull/1266 This is an automated message from the Apache Git Service. To

[incubator-apisix] branch master updated: feature: adding support to public key based introspection for OAuth plugin (#1266)

2020-03-15 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new c1df18f feature: adding support to

[GitHub] [incubator-apisix] moonming closed issue #1242: Feature: OAuth public key based introspection for APISIX

2020-03-15 Thread GitBox
moonming closed issue #1242: Feature: OAuth public key based introspection for APISIX URL: https://github.com/apache/incubator-apisix/issues/1242 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-apisix] moonming opened a new issue #1276: add more test cases for oauth plugin

2020-03-15 Thread GitBox
moonming opened a new issue #1276: add more test cases for oauth plugin URL: https://github.com/apache/incubator-apisix/issues/1276 we'd better add more test cases for this plugin. I will merge first. _Originally posted by @moonming in

[GitHub] [incubator-apisix] moonming commented on issue #1266: Adding support to public key based introspection for OAuth plugin

2020-03-15 Thread GitBox
moonming commented on issue #1266: Adding support to public key based introspection for OAuth plugin URL: https://github.com/apache/incubator-apisix/pull/1266#issuecomment-599205012 we'd better add more test cases for this plugin. I will merge first.

[GitHub] [incubator-apisix] agile6v commented on a change in pull request #1153: feature: support for proxy caching plugin based on disk.

2020-03-15 Thread GitBox
agile6v commented on a change in pull request #1153: feature: support for proxy caching plugin based on disk. URL: https://github.com/apache/incubator-apisix/pull/1153#discussion_r392669384 ## File path: lua/apisix/plugins/proxy-cache.lua ## @@ -0,0 +1,259 @@ +-- +--

[GitHub] [incubator-apisix] membphis merged pull request #1270: travis(osx): install the redis by brew.

2020-03-15 Thread GitBox
membphis merged pull request #1270: travis(osx): install the redis by brew. URL: https://github.com/apache/incubator-apisix/pull/1270 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-apisix] membphis closed issue #1213: bug(CI): failed to install redis in OSX system when running test cases.

2020-03-15 Thread GitBox
membphis closed issue #1213: bug(CI): failed to install redis in OSX system when running test cases. URL: https://github.com/apache/incubator-apisix/issues/1213 This is an automated message from the Apache Git Service. To

[incubator-apisix] branch master updated (12bf2b4 -> d347cae)

2020-03-15 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git. from 12bf2b4 update resty-radixtree to version v1.8. (#1271) add d347cae travis(osx): install the

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1153: feature: support for proxy caching plugin based on disk.

2020-03-15 Thread GitBox
membphis commented on a change in pull request #1153: feature: support for proxy caching plugin based on disk. URL: https://github.com/apache/incubator-apisix/pull/1153#discussion_r392666263 ## File path: lua/apisix/plugins/proxy-cache.lua ## @@ -0,0 +1,259 @@ +-- +--

[GitHub] [incubator-apisix] Akayeshmantha opened a new pull request #1275: Add multiple etcd address support.

2020-03-15 Thread GitBox
Akayeshmantha opened a new pull request #1275: Add multiple etcd address support. URL: https://github.com/apache/incubator-apisix/pull/1275 Add multiple etcd address support ### Issues resolved Fix #1231

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1153: feature: support for proxy caching plugin based on disk.

2020-03-15 Thread GitBox
membphis commented on a change in pull request #1153: feature: support for proxy caching plugin based on disk. URL: https://github.com/apache/incubator-apisix/pull/1153#discussion_r392666086 ## File path: t/plugin/proxy-cache.t ## @@ -0,0 +1,630 @@ +# +# Licensed to the

[GitHub] [incubator-apisix] agile6v commented on a change in pull request #1153: feature: support for proxy caching plugin based on disk.

2020-03-15 Thread GitBox
agile6v commented on a change in pull request #1153: feature: support for proxy caching plugin based on disk. URL: https://github.com/apache/incubator-apisix/pull/1153#discussion_r392660022 ## File path: t/plugin/proxy-cache.t ## @@ -0,0 +1,630 @@ +# +# Licensed to the

[GitHub] [incubator-apisix] agile6v commented on a change in pull request #1153: feature: support for proxy caching plugin based on disk.

2020-03-15 Thread GitBox
agile6v commented on a change in pull request #1153: feature: support for proxy caching plugin based on disk. URL: https://github.com/apache/incubator-apisix/pull/1153#discussion_r392659815 ## File path: t/plugin/proxy-cache.t ## @@ -0,0 +1,630 @@ +# +# Licensed to the

[GitHub] [incubator-apisix] agile6v commented on a change in pull request #1153: feature: support for proxy caching plugin based on disk.

2020-03-15 Thread GitBox
agile6v commented on a change in pull request #1153: feature: support for proxy caching plugin based on disk. URL: https://github.com/apache/incubator-apisix/pull/1153#discussion_r392659145 ## File path: lua/apisix/plugins/proxy-cache.lua ## @@ -0,0 +1,259 @@ +-- +--

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1153: feature: support for proxy caching plugin based on disk.

2020-03-15 Thread GitBox
membphis commented on a change in pull request #1153: feature: support for proxy caching plugin based on disk. URL: https://github.com/apache/incubator-apisix/pull/1153#discussion_r392658133 ## File path: t/plugin/proxy-cache.t ## @@ -0,0 +1,630 @@ +# +# Licensed to the

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1153: feature: support for proxy caching plugin based on disk.

2020-03-15 Thread GitBox
membphis commented on a change in pull request #1153: feature: support for proxy caching plugin based on disk. URL: https://github.com/apache/incubator-apisix/pull/1153#discussion_r392657923 ## File path: lua/apisix/plugins/proxy-cache.lua ## @@ -178,6 +158,91 @@ local

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1153: feature: support for proxy caching plugin based on disk.

2020-03-15 Thread GitBox
membphis commented on a change in pull request #1153: feature: support for proxy caching plugin based on disk. URL: https://github.com/apache/incubator-apisix/pull/1153#discussion_r392657840 ## File path: lua/apisix/plugins/proxy-cache.lua ## @@ -0,0 +1,259 @@ +-- +--

[GitHub] [incubator-apisix] agile6v commented on issue #1153: feature: support for proxy caching plugin based on disk.

2020-03-15 Thread GitBox
agile6v commented on issue #1153: feature: support for proxy caching plugin based on disk. URL: https://github.com/apache/incubator-apisix/pull/1153#issuecomment-599180094 > @agile6v It seems that you have to rebase your branch, this branch has conflicted with master branch.

[GitHub] [incubator-apisix-docker] moonming merged pull request #39: fixed bad link of centos.

2020-03-15 Thread GitBox
moonming merged pull request #39: fixed bad link of centos. URL: https://github.com/apache/incubator-apisix-docker/pull/39 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[incubator-apisix-docker] branch master updated: fixed bad link of centos. (#39)

2020-03-15 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix-docker.git The following commit(s) were added to refs/heads/master by this push: new 0d7e79c fixed bad link of

[GitHub] [incubator-apisix] membphis commented on issue #1272: Support JWT scopes to allow or reject requests in OAuth2 plugin

2020-03-15 Thread GitBox
membphis commented on issue #1272: Support JWT scopes to allow or reject requests in OAuth2 plugin URL: https://github.com/apache/incubator-apisix/issues/1272#issuecomment-599171946 can you provide an example? This is an