[GitHub] [incubator-apisix] moonming commented on a change in pull request #1386: enhance: plugin Zipkin add service name and report local server IP

2020-04-02 Thread GitBox
moonming commented on a change in pull request #1386: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1386#discussion_r402760953 ## File path: t/lib/server.lua ## @@ -115,6 +115,23 @@ function _M.mock_

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1386: enhance: plugin Zipkin add service name and report local server IP

2020-04-02 Thread GitBox
moonming commented on a change in pull request #1386: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1386#discussion_r402760554 ## File path: doc/plugins/zipkin-cn.md ## @@ -49,7 +51,9 @@ curl http://

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1386: enhance: plugin Zipkin add service name and report local server IP

2020-04-02 Thread GitBox
moonming commented on a change in pull request #1386: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1386#discussion_r402761127 ## File path: t/lib/server.lua ## @@ -115,6 +115,23 @@ function _M.mock_

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1386: enhance: plugin Zipkin add service name and report local server IP

2020-04-02 Thread GitBox
moonming commented on a change in pull request #1386: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1386#discussion_r402761155 ## File path: t/lib/server.lua ## @@ -115,6 +115,23 @@ function _M.mock_

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1380: add global name

2020-04-02 Thread GitBox
membphis commented on a change in pull request #1380: add global name URL: https://github.com/apache/incubator-apisix/pull/1380#discussion_r402745741 ## File path: conf/config.yaml ## @@ -15,6 +15,7 @@ # limitations under the License. # apisix: + name: APISIX

[GitHub] [incubator-apisix] membphis closed pull request #1380: add global name

2020-04-02 Thread GitBox
membphis closed pull request #1380: add global name URL: https://github.com/apache/incubator-apisix/pull/1380 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-apisix] membphis commented on issue #1366: bug:

2020-04-02 Thread GitBox
membphis commented on issue #1366: bug: URL: https://github.com/apache/incubator-apisix/issues/1366#issuecomment-608238748 need a title for this issue @csluoqi This is an automated message from the Apache Git Service. To re

[GitHub] [incubator-apisix] membphis edited a comment on issue #1355: Updating the UDP logger to use the batch processor util

2020-04-02 Thread GitBox
membphis edited a comment on issue #1355: Updating the UDP logger to use the batch processor util URL: https://github.com/apache/incubator-apisix/pull/1355#issuecomment-608234823 I have restarted Travis's job and failed before. --

[GitHub] [incubator-apisix] membphis commented on issue #1355: Updating the UDP logger to use the batch processor util

2020-04-02 Thread GitBox
membphis commented on issue #1355: Updating the UDP logger to use the batch processor util URL: https://github.com/apache/incubator-apisix/pull/1355#issuecomment-608234823 I have now restarted Travis's job and failed before.

[GitHub] [incubator-apisix] membphis commented on issue #1388: feat: add api aggreate

2020-04-02 Thread GitBox
membphis commented on issue #1388: feat: add api aggreate URL: https://github.com/apache/incubator-apisix/pull/1388#issuecomment-608233810 and please take a look at the output of Travis: https://travis-ci.org/github/apache/incubator-apisix/jobs/670393219#L817 --

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1388: feat: add api aggreate

2020-04-02 Thread GitBox
membphis commented on a change in pull request #1388: feat: add api aggreate URL: https://github.com/apache/incubator-apisix/pull/1388#discussion_r402740443 ## File path: apisix/plugins/api-aggregate.lua ## @@ -0,0 +1,144 @@ +-- +-- Licensed to the Apache Software Foundatio

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1388: feat: add api aggreate

2020-04-02 Thread GitBox
membphis commented on a change in pull request #1388: feat: add api aggreate URL: https://github.com/apache/incubator-apisix/pull/1388#discussion_r402739425 ## File path: apisix/plugins/api-aggregate.lua ## @@ -0,0 +1,144 @@ +-- +-- Licensed to the Apache Software Foundatio

[GitHub] [incubator-apisix] membphis commented on issue #1388: feat: add api aggreate

2020-04-02 Thread GitBox
membphis commented on issue #1388: feat: add api aggreate URL: https://github.com/apache/incubator-apisix/pull/1388#issuecomment-608232579 @ShiningRush missing test case with invalid arguments This is an automated message from

[GitHub] [incubator-apisix] membphis opened a new issue #1395: doc(k8s): add a link to `doc/README.md`

2020-04-02 Thread GitBox
membphis opened a new issue #1395: doc(k8s): add a link to `doc/README.md` URL: https://github.com/apache/incubator-apisix/issues/1395 https://github.com/apache/incubator-apisix/blob/master/doc/README.md And we need more comments: https://github.com/apache/incubator-apisix/pull/1218/

[incubator-apisix] branch master updated: feature: add example .yaml resource files which support to run Apache APISIX on kubernetes (#1218)

2020-04-02 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new f653c1b feature: add example .yaml

[GitHub] [incubator-apisix] membphis merged pull request #1218: feature: add example .yaml resource files which support to run Apache APISIX on kubernetes

2020-04-02 Thread GitBox
membphis merged pull request #1218: feature: add example .yaml resource files which support to run Apache APISIX on kubernetes URL: https://github.com/apache/incubator-apisix/pull/1218 This is an automated message from the A

[GitHub] [incubator-apisix] lilien1010 commented on issue #1386: enhance: plugin Zipkin add service name and report local server IP

2020-04-02 Thread GitBox
lilien1010 commented on issue #1386: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1386#issuecomment-608220200 @moonming It works fine now. This is an

[GitHub] [incubator-apisix] membphis commented on issue #1393: Refactor the way to run global rule in log/header filter/body filter

2020-04-02 Thread GitBox
membphis commented on issue #1393: Refactor the way to run global rule in log/header filter/body filter URL: https://github.com/apache/incubator-apisix/pull/1393#issuecomment-608214869 I do not know the reason. Can you get same error at you local machine? -

[GitHub] [incubator-apisix] rhubard commented on issue #1389: doc: add FAQ about redirect http To https

2020-04-02 Thread GitBox
rhubard commented on issue #1389: doc: add FAQ about redirect http To https URL: https://github.com/apache/incubator-apisix/pull/1389#issuecomment-608205952 > Can this feature be supported in rewrite plugin? ```shell [ { "uri": "/*", "host": "iresty.com",

[GitHub] [incubator-apisix] moonming commented on issue #1386: enhance: plugin Zipkin add service name and report local server IP

2020-04-02 Thread GitBox
moonming commented on issue #1386: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1386#issuecomment-608203456 @lilien1010 travis CI broken, please take a look. -

[GitHub] [incubator-apisix] moonming commented on issue #1362: request help: How to dump variable data for debugging

2020-04-02 Thread GitBox
moonming commented on issue #1362: request help: How to dump variable data for debugging URL: https://github.com/apache/incubator-apisix/issues/1362#issuecomment-608202513 > > I guess this can be added to the doc as well for reference? > > I am not sure. Anyone else have comments?

[incubator-apisix] branch master updated (eb358e9 -> d90e982)

2020-04-02 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git. from eb358e9 bugfix: plugin in header_filter/body_filter should be run like log phase (#1383) add d90e98

[GitHub] [incubator-apisix] moonming merged pull request #1356: Updating TCP logger to use the batch processor util

2020-04-02 Thread GitBox
moonming merged pull request #1356: Updating TCP logger to use the batch processor util URL: https://github.com/apache/incubator-apisix/pull/1356 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1380: add global name

2020-04-02 Thread GitBox
moonming commented on a change in pull request #1380: add global name URL: https://github.com/apache/incubator-apisix/pull/1380#discussion_r402707913 ## File path: conf/config.yaml ## @@ -15,6 +15,7 @@ # limitations under the License. # apisix: + name: APISIX

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1218: feature: add example .yaml resource files which support to run Apache APISIX on kubernetes

2020-04-02 Thread GitBox
moonming commented on a change in pull request #1218: feature: add example .yaml resource files which support to run Apache APISIX on kubernetes URL: https://github.com/apache/incubator-apisix/pull/1218#discussion_r402704622 ## File path: kubernetes/README.md ## @@ -0,0 +1

[GitHub] [incubator-apisix] moonming closed issue #1375: bug: restart apisix docker, show error log below

2020-04-02 Thread GitBox
moonming closed issue #1375: bug: restart apisix docker, show error log below URL: https://github.com/apache/incubator-apisix/issues/1375 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [incubator-apisix] moonming commented on issue #1366: bug:

2020-04-02 Thread GitBox
moonming commented on issue #1366: bug: URL: https://github.com/apache/incubator-apisix/issues/1366#issuecomment-608195925 @csluoqi Can you provide an example of a reproduction? I tested the digital password and it didn't come up. -

[GitHub] [incubator-apisix] lilien1010 commented on a change in pull request #1386: enhance: plugin Zipkin add service name and report local server IP

2020-04-02 Thread GitBox
lilien1010 commented on a change in pull request #1386: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1386#discussion_r402689673 ## File path: apisix/plugins/zipkin.lua ## @@ -44,6 +55,11 @@ local _M

[incubator-apisix] branch v1.2 created (now eb358e9)

2020-04-02 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a change to branch v1.2 in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git. at eb358e9 bugfix: plugin in header_filter/body_filter should be run like log phase (#1383) No new revisions

[GitHub] [incubator-apisix] sshniro commented on issue #1355: Updating the UDP logger to use the batch processor util

2020-04-02 Thread GitBox
sshniro commented on issue #1355: Updating the UDP logger to use the batch processor util URL: https://github.com/apache/incubator-apisix/pull/1355#issuecomment-608122373 @membphis rebased. This is an automated message from t

[GitHub] [incubator-apisix] sshniro commented on a change in pull request #1355: Updating the UDP logger to use the batch processor util

2020-04-02 Thread GitBox
sshniro commented on a change in pull request #1355: Updating the UDP logger to use the batch processor util URL: https://github.com/apache/incubator-apisix/pull/1355#discussion_r402630157 ## File path: lua/apisix/plugins/udp-logger.lua ## @@ -46,38 +51,85 @@ function _M.c

[GitHub] [incubator-apisix] sshniro commented on a change in pull request #1355: Updating the UDP logger to use the batch processor util

2020-04-02 Thread GitBox
sshniro commented on a change in pull request #1355: Updating the UDP logger to use the batch processor util URL: https://github.com/apache/incubator-apisix/pull/1355#discussion_r402149113 ## File path: lua/apisix/plugins/udp-logger.lua ## @@ -46,38 +51,85 @@ function _M.c

[GitHub] [incubator-apisix] sshniro closed pull request #1394: WIP: Http logger for APISIX

2020-04-02 Thread GitBox
sshniro closed pull request #1394: WIP: Http logger for APISIX URL: https://github.com/apache/incubator-apisix/pull/1394 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [incubator-apisix] Akayeshmantha commented on issue #1393: Refactor the way to run global rule in log/header filter/body filter

2020-04-02 Thread GitBox
Akayeshmantha commented on issue #1393: Refactor the way to run global rule in log/header filter/body filter URL: https://github.com/apache/incubator-apisix/pull/1393#issuecomment-608104597 @membphis @moonming @spacewander Any idea why this error happens its on prometheus plugin.

[GitHub] [incubator-apisix] sshniro opened a new pull request #1394: WIP: Http logger for APISIX

2020-04-02 Thread GitBox
sshniro opened a new pull request #1394: WIP: Http logger for APISIX URL: https://github.com/apache/incubator-apisix/pull/1394 ### Summary Resolves #965 Using the [lua-resty-http](https://github.com/ledgetech/lua-resty-http) package and also utilizing the `genericinterface` to co

[GitHub] [incubator-apisix] Akayeshmantha opened a new pull request #1393: Refactor the way to run global rule in log/header filter/body filter

2020-04-02 Thread GitBox
Akayeshmantha opened a new pull request #1393: Refactor the way to run global rule in log/header filter/body filter URL: https://github.com/apache/incubator-apisix/pull/1393 Fix #1369 This is an automated message fr

[GitHub] [incubator-apisix] Akayeshmantha closed pull request #1392: Refactor the way to run global rule in log/header filter/body filter …

2020-04-02 Thread GitBox
Akayeshmantha closed pull request #1392: Refactor the way to run global rule in log/header filter/body filter … URL: https://github.com/apache/incubator-apisix/pull/1392 This is an automated message from the Apache Git Servi

[GitHub] [incubator-apisix] Akayeshmantha opened a new pull request #1392: Refactor the way to run global rule in log/header filter/body filter …

2020-04-02 Thread GitBox
Akayeshmantha opened a new pull request #1392: Refactor the way to run global rule in log/header filter/body filter … URL: https://github.com/apache/incubator-apisix/pull/1392 Fix #1369 This is an automated message fr

[GitHub] [incubator-apisix] agile6v opened a new pull request #1391: Fixed some typos.

2020-04-02 Thread GitBox
agile6v opened a new pull request #1391: Fixed some typos. URL: https://github.com/apache/incubator-apisix/pull/1391 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-apisix] agile6v commented on issue #1389: doc: add FAQ about redirect http To https

2020-04-02 Thread GitBox
agile6v commented on issue #1389: doc: add FAQ about redirect http To https URL: https://github.com/apache/incubator-apisix/pull/1389#issuecomment-607830256 Can this feature be supported in rewrite plugin? This is an automated

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #159: Adding script to verify commit message

2020-04-02 Thread GitBox
juzhiyuan commented on issue #159: Adding script to verify commit message URL: https://github.com/apache/incubator-apisix-dashboard/pull/159#issuecomment-607811516 Ok This is an automated message from the Apache Git Service.

[incubator-apisix] branch master updated: bugfix: plugin in header_filter/body_filter should be run like log phase (#1383)

2020-04-02 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new eb358e9 bugfix: plugin in header_fi

[GitHub] [incubator-apisix] membphis closed issue #1365: Better to avoid responsing in header_filter_by_lua and body_filter_by_lua

2020-04-02 Thread GitBox
membphis closed issue #1365: Better to avoid responsing in header_filter_by_lua and body_filter_by_lua URL: https://github.com/apache/incubator-apisix/issues/1365 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-apisix] membphis commented on issue #1383: bugfix: plugin in header_filter/body_filter should be run like log phase

2020-04-02 Thread GitBox
membphis commented on issue #1383: bugfix: plugin in header_filter/body_filter should be run like log phase URL: https://github.com/apache/incubator-apisix/pull/1383#issuecomment-607726417 @spacewander merged, many thx This i

[GitHub] [incubator-apisix] membphis merged pull request #1383: bugfix: plugin in header_filter/body_filter should be run like log phase

2020-04-02 Thread GitBox
membphis merged pull request #1383: bugfix: plugin in header_filter/body_filter should be run like log phase URL: https://github.com/apache/incubator-apisix/pull/1383 This is an automated message from the Apache Git Service.

[GitHub] [incubator-apisix-dashboard] sshniro closed pull request #159: Adding script to verify commit message

2020-04-02 Thread GitBox
sshniro closed pull request #159: Adding script to verify commit message URL: https://github.com/apache/incubator-apisix-dashboard/pull/159 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-apisix-dashboard] sshniro commented on issue #159: Adding script to verify commit message

2020-04-02 Thread GitBox
sshniro commented on issue #159: Adding script to verify commit message URL: https://github.com/apache/incubator-apisix-dashboard/pull/159#issuecomment-607710799 Okay @juzhiyuan I'm currently closing the PR so anyone wishes are open to fixing this. I will try to attempt another issue from

[GitHub] [incubator-apisix] sshniro commented on a change in pull request #1355: Updating the UDP logger to use the batch processor util

2020-04-02 Thread GitBox
sshniro commented on a change in pull request #1355: Updating the UDP logger to use the batch processor util URL: https://github.com/apache/incubator-apisix/pull/1355#discussion_r402149234 ## File path: doc/plugins/udp-logger.md ## @@ -33,15 +33,21 @@ This will provide the

[GitHub] [incubator-apisix] sshniro commented on a change in pull request #1355: Updating the UDP logger to use the batch processor util

2020-04-02 Thread GitBox
sshniro commented on a change in pull request #1355: Updating the UDP logger to use the batch processor util URL: https://github.com/apache/incubator-apisix/pull/1355#discussion_r402149113 ## File path: lua/apisix/plugins/udp-logger.lua ## @@ -46,38 +51,85 @@ function _M.c

[GitHub] [incubator-apisix] sshniro commented on a change in pull request #1355: Updating the UDP logger to use the batch processor util

2020-04-02 Thread GitBox
sshniro commented on a change in pull request #1355: Updating the UDP logger to use the batch processor util URL: https://github.com/apache/incubator-apisix/pull/1355#discussion_r402148439 ## File path: lua/apisix/plugins/udp-logger.lua ## @@ -46,38 +51,85 @@ function _M.c

[GitHub] [incubator-apisix] sshniro commented on a change in pull request #1355: Updating the UDP logger to use the batch processor util

2020-04-02 Thread GitBox
sshniro commented on a change in pull request #1355: Updating the UDP logger to use the batch processor util URL: https://github.com/apache/incubator-apisix/pull/1355#discussion_r402146777 ## File path: lua/apisix/plugins/udp-logger.lua ## @@ -46,38 +51,85 @@ function _M.c