[incubator-apisix] branch master updated (c6f7af6 -> 2433152)

2020-07-29 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git. from c6f7af6 doc: update Chinese how-to-build.md (#1936) add 2433152 bugfix: fix limit-count plugin

[incubator-apisix-dashboard] branch master updated: feature: support run in mac system (#349)

2020-07-29 Thread kvn
This is an automated email from the ASF dual-hosted git repository. kvn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 8e805f0 feature: support run

[incubator-apisix] branch master updated: doc: update Chinese how-to-build.md (#1936)

2020-07-29 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new c6f7af6 doc: update Chinese

[incubator-apisix] branch master updated: doc: corrected some typo (#1938)

2020-07-29 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new f4aaf9a doc: corrected some typo

[incubator-apisix-dashboard] 01/01: feature: support run in mac system

2020-07-29 Thread liling
This is an automated email from the ASF dual-hosted git repository. liling pushed a commit to branch lilien1010-patch-1 in repository https://gitbox.apache.org/repos/asf/incubator-apisix-dashboard.git commit 346141a9e87ff3c9f40de029e7c39cd5096c0c04 Author: Lien AuthorDate: Thu Jul 30 12:20:39

[incubator-apisix-dashboard] branch lilien1010-patch-1 created (now 346141a)

2020-07-29 Thread liling
This is an automated email from the ASF dual-hosted git repository. liling pushed a change to branch lilien1010-patch-1 in repository https://gitbox.apache.org/repos/asf/incubator-apisix-dashboard.git. at 346141a feature: support run in mac system This branch includes the following new

[incubator-apisix] branch lilien1010-patch-1 updated: doc: fix typo

2020-07-29 Thread liling
This is an automated email from the ASF dual-hosted git repository. liling pushed a commit to branch lilien1010-patch-1 in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/lilien1010-patch-1 by this push: new 7e828fb

[incubator-apisix] branch lilien1010-patch-1 created (now 854b9e4)

2020-07-29 Thread liling
This is an automated email from the ASF dual-hosted git repository. liling pushed a change to branch lilien1010-patch-1 in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git. at 854b9e4 doc: fix typo This branch includes the following new commits: new 854b9e4

[incubator-apisix] 01/01: doc: fix typo

2020-07-29 Thread liling
This is an automated email from the ASF dual-hosted git repository. liling pushed a commit to branch lilien1010-patch-1 in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git commit 854b9e4140fc15b925eaf73a5f7fa468f71abbf9 Author: Lien AuthorDate: Thu Jul 30 11:39:23 2020 +0800

[incubator-apisix] branch master updated: doc: improvements for OSx unit tests (#1926)

2020-07-29 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new a7a4fbe doc: improvements for OSx

[GitHub] [incubator-apisix] shuaijinchao commented on a change in pull request #1928: bugfix: fix limit-count plugin redis.ttl error.

2020-07-29 Thread GitBox
shuaijinchao commented on a change in pull request #1928: URL: https://github.com/apache/incubator-apisix/pull/1928#discussion_r462309855 ## File path: apisix/plugins/limit-count/limit-count-redis.lua ## @@ -71,7 +71,8 @@ function _M.incoming(self, key) local remaining

[GitHub] [incubator-apisix-dashboard] juzhiyuan merged pull request #345: feat(i18n): pluginpage component

2020-07-29 Thread GitBox
juzhiyuan merged pull request #345: URL: https://github.com/apache/incubator-apisix-dashboard/pull/345 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-apisix] moonming closed issue #1870: config.yaml: update the wrong comments

2020-07-29 Thread GitBox
moonming closed issue #1870: URL: https://github.com/apache/incubator-apisix/issues/1870 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-apisix] membphis merged pull request #1766: feature: add a new option, decide if we remove the "/" at the end of …

2020-07-29 Thread GitBox
membphis merged pull request #1766: URL: https://github.com/apache/incubator-apisix/pull/1766 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-apisix] sshniro opened a new pull request #1927: batch processor name and error return type fix

2020-07-29 Thread GitBox
sshniro opened a new pull request #1927: URL: https://github.com/apache/incubator-apisix/pull/1927 - Fix #1522 - Fix #1521 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-apisix] membphis opened a new pull request #1925: test: old test case is unstable, running fail sometimes.

2020-07-29 Thread GitBox
membphis opened a new pull request #1925: URL: https://github.com/apache/incubator-apisix/pull/1925 ### What this PR does / why we need it: as title. unstable output: https://github.com/apache/incubator-apisix/runs/921554160?check_suite_focus=true#step:6:121

[GitHub] [incubator-apisix] membphis merged pull request #1916: doc: fix typos.

2020-07-29 Thread GitBox
membphis merged pull request #1916: URL: https://github.com/apache/incubator-apisix/pull/1916 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-apisix] nic-chen commented on a change in pull request #1888: change: add more prometheus metrics(etcd modify index)

2020-07-29 Thread GitBox
nic-chen commented on a change in pull request #1888: URL: https://github.com/apache/incubator-apisix/pull/1888#discussion_r462343820 ## File path: apisix/core/config_etcd.lua ## @@ -221,10 +221,22 @@ local function sync_data(self) return true end -local

[GitHub] [incubator-apisix] moonming commented on pull request #1929: update comment to 30 seconds

2020-07-29 Thread GitBox
moonming commented on pull request #1929: URL: https://github.com/apache/incubator-apisix/pull/1929#issuecomment-665722406 @swayamraina merged, thx This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-apisix] membphis merged pull request #1919: feature: allow to set `retries=0` for upstream object.

2020-07-29 Thread GitBox
membphis merged pull request #1919: URL: https://github.com/apache/incubator-apisix/pull/1919 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-apisix] swayamraina opened a new pull request #1929: update comment to 30 seconds

2020-07-29 Thread GitBox
swayamraina opened a new pull request #1929: URL: https://github.com/apache/incubator-apisix/pull/1929 ### What this PR does / why we need it: fixes https://github.com/apache/incubator-apisix/issues/1870 ### Pre-submission checklist: * [ ] Did you explain what problem does

[GitHub] [incubator-apisix] membphis merged pull request #1927: batch processor name and error return type fix

2020-07-29 Thread GitBox
membphis merged pull request #1927: URL: https://github.com/apache/incubator-apisix/pull/1927 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-apisix] membphis closed issue #1521: bug: invalid return value when fail to create new batch-processor object

2020-07-29 Thread GitBox
membphis closed issue #1521: URL: https://github.com/apache/incubator-apisix/issues/1521 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-apisix] membphis merged pull request #1913: fix: run `apisix start` several times will start multi nginx processes

2020-07-29 Thread GitBox
membphis merged pull request #1913: URL: https://github.com/apache/incubator-apisix/pull/1913 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-apisix] juzhiyuan closed issue #1898: bug:

2020-07-29 Thread GitBox
juzhiyuan closed issue #1898: URL: https://github.com/apache/incubator-apisix/issues/1898 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-apisix] sshniro closed issue #1897: Allow or Reject API calls based on arbitrary code execution

2020-07-29 Thread GitBox
sshniro closed issue #1897: URL: https://github.com/apache/incubator-apisix/issues/1897 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-apisix] sshniro commented on issue #1897: Allow or Reject API calls based on arbitrary code execution

2020-07-29 Thread GitBox
sshniro commented on issue #1897: URL: https://github.com/apache/incubator-apisix/issues/1897#issuecomment-665511785 Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-apisix] juzhiyuan commented on issue #1898: bug:

2020-07-29 Thread GitBox
juzhiyuan commented on issue #1898: URL: https://github.com/apache/incubator-apisix/issues/1898#issuecomment-665573865 OK, it looks like the problem has been resolved, feel free to reopen it if you find the related issue.

[GitHub] [incubator-apisix] moonming merged pull request #1929: update comment to 30 seconds

2020-07-29 Thread GitBox
moonming merged pull request #1929: URL: https://github.com/apache/incubator-apisix/pull/1929 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-apisix] membphis closed issue #1784: bug: /admin/routes return {"error_msg":"missing configurations"}

2020-07-29 Thread GitBox
membphis closed issue #1784: URL: https://github.com/apache/incubator-apisix/issues/1784 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-apisix] membphis closed issue #1765: feature: add a new option, decide if we remove the "/" at the end of the URI before route mathing

2020-07-29 Thread GitBox
membphis closed issue #1765: URL: https://github.com/apache/incubator-apisix/issues/1765 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-apisix] membphis closed issue #1522: change: `Batch_Processor` -> `batch_processor` (name style)

2020-07-29 Thread GitBox
membphis closed issue #1522: URL: https://github.com/apache/incubator-apisix/issues/1522 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1928: bugfix: fix limit-count plugin redis.ttl error.

2020-07-29 Thread GitBox
membphis commented on a change in pull request #1928: URL: https://github.com/apache/incubator-apisix/pull/1928#discussion_r462273477 ## File path: apisix/plugins/limit-count/limit-count-redis.lua ## @@ -71,7 +71,8 @@ function _M.incoming(self, key) local remaining

[GitHub] [incubator-apisix] shuaijinchao opened a new pull request #1932: doc: add `request-validation` plugin chinese document.

2020-07-29 Thread GitBox
shuaijinchao opened a new pull request #1932: URL: https://github.com/apache/incubator-apisix/pull/1932 ### What this PR does / why we need it: FIX #1882 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1888: change: add more prometheus metrics(etcd modify index)

2020-07-29 Thread GitBox
membphis commented on a change in pull request #1888: URL: https://github.com/apache/incubator-apisix/pull/1888#discussion_r462229428 ## File path: apisix/core/config_etcd.lua ## @@ -221,10 +221,22 @@ local function sync_data(self) return true end -local

[GitHub] [incubator-apisix] membphis commented on pull request #1927: batch processor name and error return type fix

2020-07-29 Thread GitBox
membphis commented on pull request #1927: URL: https://github.com/apache/incubator-apisix/pull/1927#issuecomment-665646735 many thx, merged @sshniro This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-apisix] membphis closed issue #1895: bug: ` make install ` did not install lua deps to apisix install dir

2020-07-29 Thread GitBox
membphis closed issue #1895: URL: https://github.com/apache/incubator-apisix/issues/1895 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-apisix-dashboard] juzhiyuan closed issue #341: route setting bug

2020-07-29 Thread GitBox
juzhiyuan closed issue #341: URL: https://github.com/apache/incubator-apisix-dashboard/issues/341 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-apisix] membphis merged pull request #1863: bugfix: read the request body from the temporary file if it was cached.

2020-07-29 Thread GitBox
membphis merged pull request #1863: URL: https://github.com/apache/incubator-apisix/pull/1863 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-apisix-dashboard] TikWind opened a new pull request #348: feat: combine import

2020-07-29 Thread GitBox
TikWind opened a new pull request #348: URL: https://github.com/apache/incubator-apisix-dashboard/pull/348 combine import This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-apisix] membphis merged pull request #1912: makefile: add comments for `install` command.

2020-07-29 Thread GitBox
membphis merged pull request #1912: URL: https://github.com/apache/incubator-apisix/pull/1912 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #346: 路由设置proxy-rewrite BUG

2020-07-29 Thread GitBox
juzhiyuan commented on issue #346: URL: https://github.com/apache/incubator-apisix-dashboard/issues/346#issuecomment-665574308 emmm Where is the actually data sent to API? This is an automated message from the Apache Git

[GitHub] [incubator-apisix] shuaijinchao opened a new pull request #1928: bugfix: fix limit-count plugin redis.ttl error.

2020-07-29 Thread GitBox
shuaijinchao opened a new pull request #1928: URL: https://github.com/apache/incubator-apisix/pull/1928 ### What this PR does / why we need it: FIX #1901 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been

[GitHub] [incubator-apisix-dashboard] membphis commented on pull request #347: fix: transform vars error

2020-07-29 Thread GitBox
membphis commented on pull request #347: URL: https://github.com/apache/incubator-apisix-dashboard/pull/347#issuecomment-665611673 you can add an action name like `fix` or `close`, then the related issue will be closed automatically after your PR was merged. ``` fix #341 ```

[GitHub] [incubator-apisix-dashboard] membphis edited a comment on pull request #347: fix: transform vars error

2020-07-29 Thread GitBox
membphis edited a comment on pull request #347: URL: https://github.com/apache/incubator-apisix-dashboard/pull/347#issuecomment-665611673 you can add an action name like `fix` or `close`, then the related issue will be closed automatically after your PR was merged. @LiteSun ```

[incubator-apisix] branch master updated: bugfix: update comment to 30 seconds in config.yaml (#1929)

2020-07-29 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new 0034c66 bugfix: update comment to

[incubator-apisix] branch master updated: plugin(batch): change processor name and error return type fix (#1927)

2020-07-29 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new 0ad813e plugin(batch): change

[incubator-apisix] branch master updated: feature: add a new option, decide if we remove the "/" at the end of … (#1766)

2020-07-29 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new f9a8a26 feature: add a new option,

[incubator-apisix] branch master updated: bugfix: read the request body from the temporary file if it was cached. (#1863)

2020-07-29 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new 20207c8 bugfix: read the request

[incubator-apisix] branch master updated: makefile: add comments for `install` command. (#1912)

2020-07-29 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new 3947f06 makefile: add comments for

[incubator-apisix] branch master updated: doc: fix typos. (#1916)

2020-07-29 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new 4c61baa doc: fix typos. (#1916)

[incubator-apisix] branch master updated: bugfix: run `apisix start` several times will start multi APISIX servers (#1913)

2020-07-29 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new 333962a bugfix: run `apisix start`

[incubator-apisix-dashboard] branch master updated: feat(i18n): pluginpage component (#345)

2020-07-29 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new ce1b3a1 feat(i18n):

[GitHub] [incubator-apisix] shuaijinchao commented on a change in pull request #1914: feature: health check supports custom host port.

2020-07-29 Thread GitBox
shuaijinchao commented on a change in pull request #1914: URL: https://github.com/apache/incubator-apisix/pull/1914#discussion_r461340753 ## File path: apisix/schema_def.lua ## @@ -78,6 +78,11 @@ local health_checker = { timeout = {type = "number", default =

[GitHub] [incubator-apisix] gxthrj opened a new issue #1923: feature: Divide config.yaml into two files config-custom.yaml & config-default.yaml

2020-07-29 Thread GitBox
gxthrj opened a new issue #1923: URL: https://github.com/apache/incubator-apisix/issues/1923 ### Issue description 1. When I deploy APISIX, only a small amount of configuration needs to be modified in conf.yaml. 2. When the APISIX version is upgraded, some configuration items may be

[GitHub] [incubator-apisix] Hmemories commented on issue #1838: bug: discovery Eureka cannot automatically proxy to a new node

2020-07-29 Thread GitBox
Hmemories commented on issue #1838: URL: https://github.com/apache/incubator-apisix/issues/1838#issuecomment-665085159 > @qiujiayu do you have time to take a look at this bug? Is this problem solved now? This is an

[GitHub] [incubator-apisix-dashboard] Rapiz1 edited a comment on issue #340: Lint failed on source

2020-07-29 Thread GitBox
Rapiz1 edited a comment on issue #340: URL: https://github.com/apache/incubator-apisix-dashboard/issues/340#issuecomment-664757182 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-apisix-dashboard] TikWind commented on a change in pull request #343: feat(i18n): actionbar component

2020-07-29 Thread GitBox
TikWind commented on a change in pull request #343: URL: https://github.com/apache/incubator-apisix-dashboard/pull/343#discussion_r461440752 ## File path: src/locales/en-US.ts ## @@ -1,4 +1,5 @@ import { PluginFormEnUS } from '@/components/PluginForm'; +import {

[GitHub] [incubator-apisix-docker] gxthrj commented on a change in pull request #68: [doc] change config.sh to gen-config-yaml.sh #67

2020-07-29 Thread GitBox
gxthrj commented on a change in pull request #68: URL: https://github.com/apache/incubator-apisix-docker/pull/68#discussion_r461307104 ## File path: example/gen-config-yaml.sh ## @@ -0,0 +1,11 @@ +#!/bin/sh + +export etcd_url='http://172.18.5.10:2379' Review comment:

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #340: Lint failed on source

2020-07-29 Thread GitBox
juzhiyuan commented on issue #340: URL: https://github.com/apache/incubator-apisix-dashboard/issues/340#issuecomment-664756791 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-apisix] membphis commented on pull request #1888: change: add more prometheus metrics(etcd modify index)

2020-07-29 Thread GitBox
membphis commented on pull request #1888: URL: https://github.com/apache/incubator-apisix/pull/1888#issuecomment-665122748 @nic-chen if you have fixed them, you can click this button, it means you have fixed it.

[GitHub] [incubator-apisix-docker] membphis closed issue #67: [doc] change `config.sh` to `gen-config-yaml.sh`

2020-07-29 Thread GitBox
membphis closed issue #67: URL: https://github.com/apache/incubator-apisix-docker/issues/67 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1917: add nacos support

2020-07-29 Thread GitBox
moonming commented on a change in pull request #1917: URL: https://github.com/apache/incubator-apisix/pull/1917#discussion_r462001247 ## File path: apisix/discovery/nacos.lua ## @@ -0,0 +1,279 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [incubator-apisix-dashboard] TikWind opened a new pull request #345: feat(i18n): pluginpage component

2020-07-29 Thread GitBox
TikWind opened a new pull request #345: URL: https://github.com/apache/incubator-apisix-dashboard/pull/345 i18n pluginpage component This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-apisix-dashboard] longshang opened a new issue #346: 路由设置proxy-rewrite BUG

2020-07-29 Thread GitBox
longshang opened a new issue #346: URL: https://github.com/apache/incubator-apisix-dashboard/issues/346 proxy-rewrite 界面设置如下图 ![image](https://user-images.githubusercontent.com/17903581/88691538-8dbf1600-d12f-11ea-9996-2e67b61aeb2d.png)

[GitHub] [incubator-apisix] membphis closed issue #1881: request-validation: check whether the input configuration is a valid JSON Schema.

2020-07-29 Thread GitBox
membphis closed issue #1881: URL: https://github.com/apache/incubator-apisix/issues/1881 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-apisix] CharlesSong opened a new pull request #1921: fixed deps check openresty-debug to openresty

2020-07-29 Thread GitBox
CharlesSong opened a new pull request #1921: URL: https://github.com/apache/incubator-apisix/pull/1921 ### What this PR does / why we need it: 源码编译安装时,make deps依赖openresty-debug,找不到debug。 ### Pre-submission checklist: * [ ] Did you explain what problem does this PR

[GitHub] [incubator-apisix-dashboard] Rapiz1 commented on issue #340: Lint failed on source

2020-07-29 Thread GitBox
Rapiz1 commented on issue #340: URL: https://github.com/apache/incubator-apisix-dashboard/issues/340#issuecomment-664754669 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-apisix-dashboard] longshang opened a new issue #341: route setting bug

2020-07-29 Thread GitBox
longshang opened a new issue #341: URL: https://github.com/apache/incubator-apisix-dashboard/issues/341 Set advanced route matching criteria, such as access_ Token on MySQL is correct, but the front end displays access. mysql as

[GitHub] [incubator-apisix] afghanistanyn opened a new pull request #1917: add nacos support

2020-07-29 Thread GitBox
afghanistanyn opened a new pull request #1917: URL: https://github.com/apache/incubator-apisix/pull/1917 ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added?

[GitHub] [incubator-apisix] shuaijinchao closed issue #1853: bug: The recommended value for worker_shutdown_timeout is 240 seconds.

2020-07-29 Thread GitBox
shuaijinchao closed issue #1853: URL: https://github.com/apache/incubator-apisix/issues/1853 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-apisix-docker] membphis merged pull request #68: [doc] change config.sh to gen-config-yaml.sh #67

2020-07-29 Thread GitBox
membphis merged pull request #68: URL: https://github.com/apache/incubator-apisix-docker/pull/68 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-apisix] ShiningRush commented on issue #1915: bug: cors should be at header_filter phase

2020-07-29 Thread GitBox
ShiningRush commented on issue #1915: URL: https://github.com/apache/incubator-apisix/issues/1915#issuecomment-664770392 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-apisix] membphis commented on issue #1881: request-validation: check whether the input configuration is a valid JSON Schema.

2020-07-29 Thread GitBox
membphis commented on issue #1881: URL: https://github.com/apache/incubator-apisix/issues/1881#issuecomment-664755964 many thx @shuaijinchao This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #346: 路由设置proxy-rewrite BUG

2020-07-29 Thread GitBox
juzhiyuan commented on issue #346: URL: https://github.com/apache/incubator-apisix-dashboard/issues/346#issuecomment-665391514 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-apisix-dashboard] juzhiyuan merged pull request #343: feat(i18n): actionbar component

2020-07-29 Thread GitBox
juzhiyuan merged pull request #343: URL: https://github.com/apache/incubator-apisix-dashboard/pull/343 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-apisix] membphis edited a comment on issue #1688: bug: 500 internal error after apisix reload

2020-07-29 Thread GitBox
membphis edited a comment on issue #1688: URL: https://github.com/apache/incubator-apisix/issues/1688#issuecomment-665086188 it has been fixed https://github.com/apache/incubator-apisix/blob/master/apisix/init.lua#L374-L378 then we can close this issue.

[GitHub] [incubator-apisix-dashboard] LiteSun commented on issue #341: route setting bug

2020-07-29 Thread GitBox
LiteSun commented on issue #341: URL: https://github.com/apache/incubator-apisix-dashboard/issues/341#issuecomment-665454875 Problem solved. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1920: change: add request-validation plugin input params schema valid.

2020-07-29 Thread GitBox
membphis commented on a change in pull request #1920: URL: https://github.com/apache/incubator-apisix/pull/1920#discussion_r461700477 ## File path: apisix/plugins/request-validation.lua ## @@ -42,7 +42,28 @@ local _M = { function _M.check_schema(conf) -return

[GitHub] [incubator-apisix-dashboard] Rapiz1 opened a new issue #340: Lint failed on source

2020-07-29 Thread GitBox
Rapiz1 opened a new issue #340: URL: https://github.com/apache/incubator-apisix-dashboard/issues/340 We should fix these issues before any attempt to set up a linter on Actions. ``` yarn run v1.22.4 warning package.json: "dependencies" has dependency "react-helmet-async" with

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in pull request #343: feat(i18n): actionbar component

2020-07-29 Thread GitBox
juzhiyuan commented on a change in pull request #343: URL: https://github.com/apache/incubator-apisix-dashboard/pull/343#discussion_r461392172 ## File path: src/locales/en-US.ts ## @@ -1,4 +1,5 @@ import { PluginFormEnUS } from '@/components/PluginForm'; +import {

[GitHub] [incubator-apisix] membphis commented on issue #1688: bug: 500 internal error after apisix reload

2020-07-29 Thread GitBox
membphis commented on issue #1688: URL: https://github.com/apache/incubator-apisix/issues/1688#issuecomment-665086188 it has been fixed https://github.com/apache/incubator-apisix/blob/master/apisix/init.lua#L374-L378 then we can close this PR.

[GitHub] [incubator-apisix] moorefu opened a new issue #1922: feature : support defined environment variable in config.yaml

2020-07-29 Thread GitBox
moorefu opened a new issue #1922: URL: https://github.com/apache/incubator-apisix/issues/1922 i think we can support defined environment variable in config.yaml like this ``` nginx_config: ... environment: TNS_ADMIN: DATACENTER_ID: 1 ``` and

[GitHub] [incubator-apisix-dashboard] juzhiyuan merged pull request #342: feat(i18n): route module

2020-07-29 Thread GitBox
juzhiyuan merged pull request #342: URL: https://github.com/apache/incubator-apisix-dashboard/pull/342 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-apisix] membphis commented on pull request #1920: change: add request-validation plugin input params schema valid.

2020-07-29 Thread GitBox
membphis commented on pull request #1920: URL: https://github.com/apache/incubator-apisix/pull/1920#issuecomment-665393769 @shuaijinchao merged, many thx This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-apisix] afghanistanyn commented on a change in pull request #1917: add nacos support

2020-07-29 Thread GitBox
afghanistanyn commented on a change in pull request #1917: URL: https://github.com/apache/incubator-apisix/pull/1917#discussion_r461981656 ## File path: apisix/discovery/nacos.lua ## @@ -165,7 +165,7 @@ local function fetch_instance(service) local json_str = res.body

[GitHub] [incubator-apisix] shuaijinchao commented on pull request #1920: change: add request-validation plugin input params schema valid.

2020-07-29 Thread GitBox
shuaijinchao commented on pull request #1920: URL: https://github.com/apache/incubator-apisix/pull/1920#issuecomment-665152246 @membphis already fixed, please recheck. This is an automated message from the Apache Git

[GitHub] [incubator-apisix-dashboard] TikWind opened a new pull request #342: feat(i18n): route module

2020-07-29 Thread GitBox
TikWind opened a new pull request #342: URL: https://github.com/apache/incubator-apisix-dashboard/pull/342 i18n route module This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1917: add nacos support

2020-07-29 Thread GitBox
membphis commented on a change in pull request #1917: URL: https://github.com/apache/incubator-apisix/pull/1917#discussion_r461473614 ## File path: apisix/discovery/nacos.lua ## @@ -0,0 +1,280 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [incubator-apisix-dashboard] juzhiyuan merged pull request #347: fix: transform vars error

2020-07-29 Thread GitBox
juzhiyuan merged pull request #347: URL: https://github.com/apache/incubator-apisix-dashboard/pull/347 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-apisix-dashboard] longshang commented on issue #346: 路由设置proxy-rewrite BUG

2020-07-29 Thread GitBox
longshang commented on issue #346: URL: https://github.com/apache/incubator-apisix-dashboard/issues/346#issuecomment-665393783 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-apisix] Yangzcy423911 commented on issue #1898: bug:

2020-07-29 Thread GitBox
Yangzcy423911 commented on issue #1898: URL: https://github.com/apache/incubator-apisix/issues/1898#issuecomment-665475283 Thank you for your answer At present, the latest master branch has been used. This problem has been solved, and a stable version of the front end is expected

[GitHub] [incubator-apisix] moonming commented on issue #1922: feature : support defined environment variable in config.yaml

2020-07-29 Thread GitBox
moonming commented on issue #1922: URL: https://github.com/apache/incubator-apisix/issues/1922#issuecomment-665437224 sounds good to me, welcome PR This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-apisix-dashboard] juzhiyuan merged pull request #344: doc: sync config.yaml from the latest version of APISIX

2020-07-29 Thread GitBox
juzhiyuan merged pull request #344: URL: https://github.com/apache/incubator-apisix-dashboard/pull/344 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-apisix-dashboard] LiteSun opened a new pull request #347: fix: transform vars error

2020-07-29 Thread GitBox
LiteSun opened a new pull request #347: URL: https://github.com/apache/incubator-apisix-dashboard/pull/347 - fix: MatchingRules wrong unequal value - fix: transform vars error This is an automated message from

[GitHub] [incubator-apisix] membphis opened a new pull request #1919: feature: allow to set `retries=0` for upstream object.

2020-07-29 Thread GitBox
membphis opened a new pull request #1919: URL: https://github.com/apache/incubator-apisix/pull/1919 ### What this PR does / why we need it: allow setting `retries=0` for an upstream object, this means there is no need to retry. ### Pre-submission checklist: * [

[GitHub] [incubator-apisix] juzhiyuan commented on issue #1898: bug:

2020-07-29 Thread GitBox
juzhiyuan commented on issue #1898: URL: https://github.com/apache/incubator-apisix/issues/1898#issuecomment-665453856 1. Please make sure you are using the latest codes from master branch by `git pull` 2. It seems you are under development mode from your snapshot, if you are using

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in pull request #345: feat(i18n): pluginpage component

2020-07-29 Thread GitBox
juzhiyuan commented on a change in pull request #345: URL: https://github.com/apache/incubator-apisix-dashboard/pull/345#discussion_r461999236 ## File path: src/components/PluginPage/locales/en-US.ts ## @@ -1,163 +1,172 @@ export default { -

[GitHub] [incubator-apisix] shuaijinchao commented on issue #1853: bug: The recommended value for worker_shutdown_timeout is 240 seconds.

2020-07-29 Thread GitBox
shuaijinchao commented on issue #1853: URL: https://github.com/apache/incubator-apisix/issues/1853#issuecomment-665153889 the problem has been fixed, I will close this issue. This is an automated message from the Apache Git

[GitHub] [incubator-apisix] membphis opened a new pull request #1916: doc: fix typos.

2020-07-29 Thread GitBox
membphis opened a new pull request #1916: URL: https://github.com/apache/incubator-apisix/pull/1916 ### What this PR does / why we need it: url -> URL . ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features

  1   2   >