[GitHub] [apisix] lizeming commented on issue #2468: request help: The problem of rewriting HTTP request header ‘Host’

2020-10-28 Thread GitBox
lizeming commented on issue #2468: URL: https://github.com/apache/apisix/issues/2468#issuecomment-718400583 We tried the proxy-rewrite plugin to add custom header fields, and then overwrite them with custom fields in the business proxy. This is indeed feasible. But apisix-dashboard

[GitHub] [apisix] idbeta opened a new pull request #2559: Fix2558

2020-10-28 Thread GitBox
idbeta opened a new pull request #2559: URL: https://github.com/apache/apisix/pull/2559 ### What this PR does / why we need it: #2558 ping @membphis ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added?

[GitHub] [apisix] moonming commented on issue #2377: bug:Use zipkin plugin and limit-req plugin together, zipkin plugin can not work when is limit

2020-10-28 Thread GitBox
moonming commented on issue #2377: URL: https://github.com/apache/apisix/issues/2377#issuecomment-718395097 > But if the plugin order support self define, the priority may be not work, please confirm. @nic-chen please confirm this question, thx -

[GitHub] [apisix] spacewander closed issue #2553: bug: jwt-auth add consumer_schema to the _M

2020-10-28 Thread GitBox
spacewander closed issue #2553: URL: https://github.com/apache/apisix/issues/2553 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[apisix] branch master updated: fix: jwt-auth add consumer_schema to the _M (#2555)

2020-10-28 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 61bcb18 fix: jwt-auth add consumer_schema

[GitHub] [apisix] spacewander merged pull request #2555: fix: jwt-auth add consumer_schema to the _M

2020-10-28 Thread GitBox
spacewander merged pull request #2555: URL: https://github.com/apache/apisix/pull/2555 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] moonming commented on pull request #2499: bugfix: fix zipkin plugin error when used with limit count plugin

2020-10-28 Thread GitBox
moonming commented on pull request #2499: URL: https://github.com/apache/apisix/pull/2499#issuecomment-718390987 I don't think it is a good idea to modify the priority. I will take a look again This is an automated message f

[GitHub] [apisix] membphis commented on issue #2533: request help: failed to set server peer [some-k8s-svc.default.svc.cluster.local:5202] err: no host allowed

2020-10-28 Thread GitBox
membphis commented on issue #2533: URL: https://github.com/apache/apisix/issues/2533#issuecomment-718390939 > [some-k8s-svc.default.svc.cluster.local:5202] err: no host allowed while this domain should be parsed into IP address. 1. Do we set the right DNS resolver? 2. We sh

[GitHub] [apisix-dashboard] moonming commented on issue #614: proposal: UI autotest

2020-10-28 Thread GitBox
moonming commented on issue #614: URL: https://github.com/apache/apisix-dashboard/issues/614#issuecomment-718389460 This proposal looks good to me. If it is added to github actions, I suggest that each type of test use a separate action, so that it can be processed in parallel ---

[GitHub] [apisix] membphis commented on issue #2558: doc: English style, " , " -> ", "

2020-10-28 Thread GitBox
membphis commented on issue #2558: URL: https://github.com/apache/apisix/issues/2558#issuecomment-718389155 good luck This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #619: feat: added frontend e2e test

2020-10-28 Thread GitBox
juzhiyuan commented on a change in pull request #619: URL: https://github.com/apache/apisix-dashboard/pull/619#discussion_r514013342 ## File path: src/e2e/Login.e2e.js ## @@ -0,0 +1,39 @@ +/* eslint-disable import/no-extraneous-dependencies */ +const puppeteer = require('puppet

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #619: feat: added frontend e2e test

2020-10-28 Thread GitBox
juzhiyuan commented on a change in pull request #619: URL: https://github.com/apache/apisix-dashboard/pull/619#discussion_r514012072 ## File path: .github/workflows/frontend-e2e-test.yml ## @@ -0,0 +1,31 @@ +name: Front-end e2e test + +on: + push: +branches: + - maste

[GitHub] [apisix] idbeta commented on issue #2558: doc: English style, " , " -> ", "

2020-10-28 Thread GitBox
idbeta commented on issue #2558: URL: https://github.com/apache/apisix/issues/2558#issuecomment-718388035 I will try to fix it. This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [apisix] Yangzcy423911 closed issue #2551: apisix 2.X 支持etcd ssl配置吗,想共用k8s集群中的etcd

2020-10-28 Thread GitBox
Yangzcy423911 closed issue #2551: URL: https://github.com/apache/apisix/issues/2551 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] moonming commented on issue #2533: request help: failed to set server peer [some-k8s-svc.default.svc.cluster.local:5202] err: no host allowed

2020-10-28 Thread GitBox
moonming commented on issue #2533: URL: https://github.com/apache/apisix/issues/2533#issuecomment-718386861 I copy the error msg: ``` kubectl --namespace apisix exec -it apisix-ctznq -- cat logs/error.log # 2020/10/27 02:39:56 [warn] 1#1: low address bits of 172.17.0.0/12 are mean

[GitHub] [apisix] Yangzcy423911 commented on issue #2551: apisix 2.X 支持etcd ssl配置吗,想共用k8s集群中的etcd

2020-10-28 Thread GitBox
Yangzcy423911 commented on issue #2551: URL: https://github.com/apache/apisix/issues/2551#issuecomment-718386663 明白了,谢谢您! This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [apisix] membphis opened a new issue #2558: doc: English style, " , " -> ", "

2020-10-28 Thread GitBox
membphis opened a new issue #2558: URL: https://github.com/apache/apisix/issues/2558 should remove the first space in doc for `" , "` ```shell $ find ./doc -name "*.md" | xargs grep " , " ./doc/architecture-design.md:* `Absolute match `: Complete match for the given `u

[GitHub] [apisix] membphis commented on a change in pull request #2389: feat: upgrade skywalking plugin to support skywalking 8.0 .

2020-10-28 Thread GitBox
membphis commented on a change in pull request #2389: URL: https://github.com/apache/apisix/pull/2389#discussion_r514005987 ## File path: apisix/plugins/skywalking.lua ## @@ -55,26 +76,74 @@ end function _M.rewrite(conf, ctx) core.log.debug("rewrite phase of skywalking pl

[GitHub] [apisix] membphis opened a new issue #2557: chore: merge the similar code in plugins

2020-10-28 Thread GitBox
membphis opened a new issue #2557: URL: https://github.com/apache/apisix/issues/2557 https://github.com/apache/apisix/pull/2389/files#r513940449 we can move funtion `try_read_attr` to `apisix.core.table`, then we can reuse this function between different plugin. ---

[GitHub] [apisix-dashboard] nic-chen opened a new pull request #625: feat: support custom server host, port and DAG lib path

2020-10-28 Thread GitBox
nic-chen opened a new pull request #625: URL: https://github.com/apache/apisix-dashboard/pull/625 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance ___ ###

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #614: proposal: UI autotest

2020-10-28 Thread GitBox
juzhiyuan commented on issue #614: URL: https://github.com/apache/apisix-dashboard/issues/614#issuecomment-718382945 3. Route a. Please adjust those cases' order, it should be: create, get, put, search, delete, get b. how to generate 200+ records? through Puppeteer or admin API?

[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #614: proposal: UI autotest

2020-10-28 Thread GitBox
juzhiyuan edited a comment on issue #614: URL: https://github.com/apache/apisix-dashboard/issues/614#issuecomment-718382945 3. Route a. Please adjust those cases' order, it should be: create, get, put, search, delete, get b. how to generate 200+ records? through Puppeteer or admin AP

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #619: feat: added frontend e2e test

2020-10-28 Thread GitBox
juzhiyuan commented on pull request #619: URL: https://github.com/apache/apisix-dashboard/pull/619#issuecomment-718379418 Your CI failed because of License issues, fix them first. This is an automated message from the Apache

[GitHub] [apisix-dashboard] juzhiyuan closed issue #622: Dashboard Release 2.0 RC3

2020-10-28 Thread GitBox
juzhiyuan closed issue #622: URL: https://github.com/apache/apisix-dashboard/issues/622 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #622: Dashboard Release 2.0 RC3

2020-10-28 Thread GitBox
juzhiyuan commented on issue #622: URL: https://github.com/apache/apisix-dashboard/issues/622#issuecomment-718378718 I will close this issue due to the duplicate one #598 This is an automated message from the Apache Git Ser

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #619: feat: added frontend e2e test

2020-10-28 Thread GitBox
juzhiyuan commented on a change in pull request #619: URL: https://github.com/apache/apisix-dashboard/pull/619#discussion_r513919280 ## File path: .github/workflows/frontend-e2e-test.yml ## @@ -0,0 +1,31 @@ +name: Front-end e2e test + +on: + push: +branches: + - maste

[GitHub] [apisix-docker] juzhiyuan commented on pull request #81: feat: remove Dashboard

2020-10-28 Thread GitBox
juzhiyuan commented on pull request #81: URL: https://github.com/apache/apisix-docker/pull/81#issuecomment-718377923 > please confirm we run `alpine/Dockerfile` in CI https://github.com/apache/apisix-docker/blob/feat-remove-dashboard/example/docker-compose-alpine.yml#L7 ---

[GitHub] [apisix] membphis commented on pull request #2549: doc:update install-dependencies.md

2020-10-28 Thread GitBox
membphis commented on pull request #2549: URL: https://github.com/apache/apisix/pull/2549#issuecomment-718377817 @htwdjqr many thx for your contribution ^_^ This is an automated message from the Apache Git Service. To respond

[GitHub] [apisix] membphis commented on pull request #2556: feature:support multi service discovery

2020-10-28 Thread GitBox
membphis commented on pull request #2556: URL: https://github.com/apache/apisix/pull/2556#issuecomment-718377287 @shoogoome please take a look at the output of CI: https://github.com/apache/apisix/pull/2556/checks?check_run_id=1324835665#step:10:187 ---

[GitHub] [apisix] membphis commented on pull request #2556: feature:support multi service discovery

2020-10-28 Thread GitBox
membphis commented on pull request #2556: URL: https://github.com/apache/apisix/pull/2556#issuecomment-718377017 @qiujiayu do you have time to look at this PR? This is an automated message from the Apache Git Service. To resp

[GitHub] [apisix-dashboard] juzhiyuan closed issue #623: apisix-dashboard 403 Forbidden

2020-10-28 Thread GitBox
juzhiyuan closed issue #623: URL: https://github.com/apache/apisix-dashboard/issues/623 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #623: apisix-dashboard 403 Forbidden

2020-10-28 Thread GitBox
juzhiyuan commented on issue #623: URL: https://github.com/apache/apisix-dashboard/issues/623#issuecomment-718376662 2.0 is totally different from 1.5, 2.0 doesn't have MySQL anymore, it's lighter and clearer, once you find any question, feel free to open issues and tell us. This i

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #623: apisix-dashboard 403 Forbidden

2020-10-28 Thread GitBox
juzhiyuan commented on issue #623: URL: https://github.com/apache/apisix-dashboard/issues/623#issuecomment-718375523 Hi @wangxunfan, we are refactoring the new Dashboard 2.0, and it's under the 2.0 RC2 stage, would you like to have a try on the newer dashboard? Here is the milestone

[GitHub] [apisix-docker] membphis commented on pull request #81: feat: remove Dashboard

2020-10-28 Thread GitBox
membphis commented on pull request #81: URL: https://github.com/apache/apisix-docker/pull/81#issuecomment-718375264 please confirm we run `alpine/Dockerfile` in CI This is an automated message from the Apache Git Service. To

[apisix-docker] branch feat-remove-dashboard updated (2e575ff -> 7206f89)

2020-10-28 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feat-remove-dashboard in repository https://gitbox.apache.org/repos/asf/apisix-docker.git. from 2e575ff Update Dockerfile add 7219ea2 featL remove dashboard build-stage add 720

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #614: proposal: UI autotest

2020-10-28 Thread GitBox
juzhiyuan commented on issue #614: URL: https://github.com/apache/apisix-dashboard/issues/614#issuecomment-718372805 Just hold on, give us no longer than 3 days to check this issue. This is an automated message from the Apac

[apisix-docker] branch feat-remove-dashboard updated (eb2c14b -> 2e575ff)

2020-10-28 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feat-remove-dashboard in repository https://gitbox.apache.org/repos/asf/apisix-docker.git. from eb2c14b feat: remove Dashboard add 2e575ff Update Dockerfile No new revisions were a

[GitHub] [apisix-dashboard] juzhiyuan closed issue #546: [refactor] license issue of refactored `api`

2020-10-28 Thread GitBox
juzhiyuan closed issue #546: URL: https://github.com/apache/apisix-dashboard/issues/546 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] LiteSun commented on issue #546: [refactor] license issue of refactored `api`

2020-10-28 Thread GitBox
LiteSun commented on issue #546: URL: https://github.com/apache/apisix-dashboard/issues/546#issuecomment-718371164 We need to remove `api/internal/core/store/validate_mock.go` and `api/internal/core/storage/storage_mock.go` manually before releasing. -

[GitHub] [apisix-dashboard] juzhiyuan opened a new issue #624: Architecture about How dashboard works with APISIX

2020-10-28 Thread GitBox
juzhiyuan opened a new issue #624: URL: https://github.com/apache/apisix-dashboard/issues/624 TODO This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #624: Architecture about How dashboard works with APISIX

2020-10-28 Thread GitBox
juzhiyuan commented on issue #624: URL: https://github.com/apache/apisix-dashboard/issues/624#issuecomment-718370682 cc @membphis @gxthrj This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix-dashboard] LiteSun commented on issue #614: proposal: UI autotest

2020-10-28 Thread GitBox
LiteSun commented on issue #614: URL: https://github.com/apache/apisix-dashboard/issues/614#issuecomment-718369685 Any suggestions for this e2e test solution? @liuxiran @bzp2010 This is an automated message from the Apac

[GitHub] [apisix] Jaycean commented on a change in pull request #2555: fix: jwt-auth add consumer_schema to the _M

2020-10-28 Thread GitBox
Jaycean commented on a change in pull request #2555: URL: https://github.com/apache/apisix/pull/2555#discussion_r513983451 ## File path: t/plugin/jwt-auth.t ## @@ -519,3 +519,23 @@ GET /t \{"error_msg":"failed to check the configuration of plugin jwt-auth err: additional prop

[GitHub] [apisix] shoogoome opened a new pull request #2556: feature:support multi service discovery

2020-10-28 Thread GitBox
shoogoome opened a new pull request #2556: URL: https://github.com/apache/apisix/pull/2556 ### What this PR does / why we need it: support multi service discovery ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have

[GitHub] [apisix-dashboard] wangxunfan opened a new issue #623: apisix-dashboard 403 Forbidden

2020-10-28 Thread GitBox
wangxunfan opened a new issue #623: URL: https://github.com/apache/apisix-dashboard/issues/623 Please answer these questions before submitting your issue. - Why do you submit this issue? - [√ ] Question or discussion - [√] Bug - [ ] Requirements - [ ] Feature or performanc

[GitHub] [apisix] moonming merged pull request #2549: doc:update install-dependencies.md

2020-10-28 Thread GitBox
moonming merged pull request #2549: URL: https://github.com/apache/apisix/pull/2549 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[apisix] branch master updated (d2aa1d8 -> 87ce6af)

2020-10-28 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from d2aa1d8 feat: get schema by schema_type (#2509) add 87ce6af update install-dependencies.md (#2549) No new re

[GitHub] [apisix-docker] moonming commented on a change in pull request #81: feat: remove Dashboard

2020-10-28 Thread GitBox
moonming commented on a change in pull request #81: URL: https://github.com/apache/apisix-docker/pull/81#discussion_r513959976 ## File path: alpine/Dockerfile ## @@ -7,10 +7,6 @@ RUN set -x \ && apk add --no-cache --virtual .build-deps git \ && git clone -b ${APISIX_V

[GitHub] [apisix] Jaycean commented on a change in pull request #2555: fix: jwt-auth add consumer_schema to the _M

2020-10-28 Thread GitBox
Jaycean commented on a change in pull request #2555: URL: https://github.com/apache/apisix/pull/2555#discussion_r513949482 ## File path: t/plugin/jwt-auth.t ## @@ -519,3 +519,23 @@ GET /t \{"error_msg":"failed to check the configuration of plugin jwt-auth err: additional prop

[GitHub] [apisix-docker] juzhiyuan commented on a change in pull request #81: feat: remove Dashboard

2020-10-28 Thread GitBox
juzhiyuan commented on a change in pull request #81: URL: https://github.com/apache/apisix-docker/pull/81#discussion_r513947957 ## File path: alpine/Dockerfile ## @@ -7,10 +7,6 @@ RUN set -x \ && apk add --no-cache --virtual .build-deps git \ && git clone -b ${APISIX_

[GitHub] [apisix-docker] juzhiyuan commented on a change in pull request #81: feat: remove Dashboard

2020-10-28 Thread GitBox
juzhiyuan commented on a change in pull request #81: URL: https://github.com/apache/apisix-docker/pull/81#discussion_r513947957 ## File path: alpine/Dockerfile ## @@ -7,10 +7,6 @@ RUN set -x \ && apk add --no-cache --virtual .build-deps git \ && git clone -b ${APISIX_

[GitHub] [apisix-website] juzhiyuan closed issue #79: Added APISIX 2.0 Download link

2020-10-28 Thread GitBox
juzhiyuan closed issue #79: URL: https://github.com/apache/apisix-website/issues/79 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] spacewander commented on a change in pull request #2555: fix: jwt-auth add consumer_schema to the _M

2020-10-28 Thread GitBox
spacewander commented on a change in pull request #2555: URL: https://github.com/apache/apisix/pull/2555#discussion_r513945321 ## File path: t/plugin/jwt-auth.t ## @@ -519,3 +519,23 @@ GET /t \{"error_msg":"failed to check the configuration of plugin jwt-auth err: additional

[GitHub] [apisix-docker] juzhiyuan opened a new pull request #81: feat: remove Dashboard

2020-10-28 Thread GitBox
juzhiyuan opened a new pull request #81: URL: https://github.com/apache/apisix-docker/pull/81 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[apisix-docker] 01/01: feat: remove Dashboard

2020-10-28 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch feat-remove-dashboard in repository https://gitbox.apache.org/repos/asf/apisix-docker.git commit eb2c14b91cacd306fe10f99cc9a8c5824b066df2 Author: juzhiyuan AuthorDate: Thu Oct 29 12:05:51 2020

[apisix-docker] branch feat-remove-dashboard created (now eb2c14b)

2020-10-28 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feat-remove-dashboard in repository https://gitbox.apache.org/repos/asf/apisix-docker.git. at eb2c14b feat: remove Dashboard This branch includes the following new commits: new e

[GitHub] [apisix] liuxiran commented on pull request #2555: fix: jwt-auth add consumer_schema to the _M

2020-10-28 Thread GitBox
liuxiran commented on pull request #2555: URL: https://github.com/apache/apisix/pull/2555#issuecomment-718345936 add a test case: get jwt-auth schema would be better @Jaycean :) This is an automated message from the Apache G

[GitHub] [apisix-dashboard] juzhiyuan opened a new issue #622: Dashboard Release 2.0 RC3

2020-10-28 Thread GitBox
juzhiyuan opened a new issue #622: URL: https://github.com/apache/apisix-dashboard/issues/622 This one will track all issues related to 2.0 RC3 - [ ] https://github.com/apache/apisix-dashboard/issues/615 This is an aut

[GitHub] [apisix] spacewander commented on a change in pull request #2389: feat: upgrade skywalking plugin to support skywalking 8.0 .

2020-10-28 Thread GitBox
spacewander commented on a change in pull request #2389: URL: https://github.com/apache/apisix/pull/2389#discussion_r513896783 ## File path: doc/plugins/skywalking.md ## @@ -67,59 +64,97 @@ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f1 }

[apisix-website] branch asf-site updated: Deploy to GitHub pages

2020-10-28 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/asf-site by this push: new c6ed083 Deploy to GitHub pages

[GitHub] [apisix-website] moonming merged pull request #80: doc: add 2.0 release.

2020-10-28 Thread GitBox
moonming merged pull request #80: URL: https://github.com/apache/apisix-website/pull/80 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix-website] branch master updated: doc: add 2.0 release. (#80)

2020-10-28 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new 4eae07f doc: add 2.0 release. (#80) 4e

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #615: v2.0-rc2 Build docker image error.

2020-10-28 Thread GitBox
juzhiyuan commented on issue #615: URL: https://github.com/apache/apisix-dashboard/issues/615#issuecomment-718343149 After discussions, we are going to fix this in 2.0 RC3, it will take no longer than 3 days. This is an aut

[GitHub] [apisix-dashboard] nic-chen opened a new issue #621: requirement: Support custom listening IP and port for manager api

2020-10-28 Thread GitBox
nic-chen opened a new issue #621: URL: https://github.com/apache/apisix-dashboard/issues/621 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [x] Requirements - [ ] Feature or performance i

[GitHub] [apisix] thekingofworld edited a comment on issue #2554: request help: abnormal output after using echo plugin

2020-10-28 Thread GitBox
thekingofworld edited a comment on issue #2554: URL: https://github.com/apache/apisix/issues/2554#issuecomment-718339899 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [apisix] thekingofworld commented on issue #2554: request help: abnormal output after using echo plugin

2020-10-28 Thread GitBox
thekingofworld commented on issue #2554: URL: https://github.com/apache/apisix/issues/2554#issuecomment-718339899 @spacewander > The plugin doesn't set Content-Length correctly. It seems to be the problem. This is an auto

[GitHub] [apisix] dabue commented on a change in pull request #2488: feat: add error-log-logger plugin

2020-10-28 Thread GitBox
dabue commented on a change in pull request #2488: URL: https://github.com/apache/apisix/pull/2488#discussion_r513924200 ## File path: apisix/plugins/error-log-logger.lua ## @@ -0,0 +1,235 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contrib

[GitHub] [apisix] spacewander commented on issue #2554: request help: abnormal output after using echo plugin

2020-10-28 Thread GitBox
spacewander commented on issue #2554: URL: https://github.com/apache/apisix/issues/2554#issuecomment-718337888 It is a known issue. > NOTE: echo plugin is written as an example. There are some unhandled cases and you should not use it in the production! https://github.com/apache/a

[GitHub] [apisix-dashboard] nic-chen opened a new issue #620: requirement: issues to be solved after the `manager api` refactoring

2020-10-28 Thread GitBox
nic-chen opened a new issue #620: URL: https://github.com/apache/apisix-dashboard/issues/620 After the manager api refactoring, there are still many problems, as follow: 1. Access log: Save to a local file, and can customize the path Support log rotate Support custom log form

[GitHub] [apisix-website] moonming opened a new pull request #80: doc: add 2.0 release.

2020-10-28 Thread GitBox
moonming opened a new pull request #80: URL: https://github.com/apache/apisix-website/pull/80 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[apisix-website] branch release-2.0 created (now 312cc68)

2020-10-28 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a change to branch release-2.0 in repository https://gitbox.apache.org/repos/asf/apisix-website.git. at 312cc68 doc: add 2.0 release. This branch includes the following new commits: new 312cc68 doc:

[apisix-website] 01/01: doc: add 2.0 release.

2020-10-28 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a commit to branch release-2.0 in repository https://gitbox.apache.org/repos/asf/apisix-website.git commit 312cc68704bc161dc5e9a5a430164eb0a9b7b3fa Author: WenMing AuthorDate: Thu Oct 29 11:30:20 2020 +0800 d

[GitHub] [apisix] thekingofworld commented on issue #2554: request help: abnormal output after using echo plugin

2020-10-28 Thread GitBox
thekingofworld commented on issue #2554: URL: https://github.com/apache/apisix/issues/2554#issuecomment-718336780 the upstream `127.0.0.1:8080` is a simple http server, implemented through `Go` language ![image](https://user-images.githubusercontent.com/8169665/97522169-1755dc80-19da-11

[GitHub] [apisix] thekingofworld commented on issue #2554: request help: abnormal output after using echo plugin

2020-10-28 Thread GitBox
thekingofworld commented on issue #2554: URL: https://github.com/apache/apisix/issues/2554#issuecomment-718334757 @moonming OK, here is text ``` curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -d ' { "plugins": {

[GitHub] [apisix] moonming commented on issue #2554: request help: abnormal output after using echo plugin

2020-10-28 Thread GitBox
moonming commented on issue #2554: URL: https://github.com/apache/apisix/issues/2554#issuecomment-718332935 @thekingofworld Can you copy the text of the command line? The picture is not easy to debug This is an automated mes

[GitHub] [apisix] moonming commented on issue #2554: request help: abnormal output after using echo plugin

2020-10-28 Thread GitBox
moonming commented on issue #2554: URL: https://github.com/apache/apisix/issues/2554#issuecomment-718332608 @Akayeshmantha do you have time to take a look? thx This is an automated message from the Apache Git Service. To resp

[GitHub] [apisix] htwdjqr commented on a change in pull request #2549: doc:update install-dependencies.md

2020-10-28 Thread GitBox
htwdjqr commented on a change in pull request #2549: URL: https://github.com/apache/apisix/pull/2549#discussion_r513908283 ## File path: doc/zh-cn/install-dependencies.md ## @@ -40,15 +40,21 @@ CentOS 7 wget http://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm

[GitHub] [apisix] Jaycean opened a new pull request #2555: fix: jwt-auth add consumer_schema to the _M

2020-10-28 Thread GitBox
Jaycean opened a new pull request #2555: URL: https://github.com/apache/apisix/pull/2555 Signed-off-by: Jaycean ### What this PR does / why we need it: fix: #2553 - jwt-auth add consumer_schema to the _M ### Pre-submission checklist: * [x] Did you explain what pr

[GitHub] [apisix] lizeming commented on issue #2468: request help: The problem of rewriting HTTP request header ‘Host’

2020-10-28 Thread GitBox
lizeming commented on issue #2468: URL: https://github.com/apache/apisix/issues/2468#issuecomment-718328570 This is one of the business request chains. This business has been around for a long time. Request chain: client -> internet address(2xx.xxx.xxx.xx9:8096) -> pre-agent

[GitHub] [apisix-dashboard] Caelebs commented on issue #615: v2.0-rc2 Build docker image error.

2020-10-28 Thread GitBox
Caelebs commented on issue #615: URL: https://github.com/apache/apisix-dashboard/issues/615#issuecomment-718326560 Before the 2.1 version is released, how should I modify the source code to build the manager-api docker image file? @juzhiyuan --

[GitHub] [apisix] thekingofworld opened a new issue #2554: request help: abnormal output after using echo plugin

2020-10-28 Thread GitBox
thekingofworld opened a new issue #2554: URL: https://github.com/apache/apisix/issues/2554 ### Issue description After adding the official echo plugin, the output content did not meet expectations. ![image](https://user-images.githubusercontent.com/8169665/97518800-f1790980-19d2-11eb

[GitHub] [apisix] LY-GO commented on issue #2477: request help: add service_id as key to plugin limit-*

2020-10-28 Thread GitBox
LY-GO commented on issue #2477: URL: https://github.com/apache/apisix/issues/2477#issuecomment-718314185 > welcome to submit PR to support `service_id` for `limit-conn` or `limit-req`. > > they were should be the same as `limit-count`. How ca i require service_id through Euerk

[GitHub] [apisix] LY-GO edited a comment on issue #2477: request help: add service_id as key to plugin limit-*

2020-10-28 Thread GitBox
LY-GO edited a comment on issue #2477: URL: https://github.com/apache/apisix/issues/2477#issuecomment-718314185 > welcome to submit PR to support `service_id` for `limit-conn` or `limit-req`. > > they were should be the same as `limit-count`. How can i require service_id throu

[GitHub] [apisix] tokers commented on issue #2551: apisix 2.X 支持etcd ssl配置吗,想共用k8s集群中的etcd

2020-10-28 Thread GitBox
tokers commented on issue #2551: URL: https://github.com/apache/apisix/issues/2551#issuecomment-718312030 > 您好,没有找到关于TLS KEY的配置 I bet you mean the client cert, key and ca certificate? This is an automated message from

[GitHub] [apisix] tokers commented on issue #2551: apisix 2.X 支持etcd ssl配置吗,想共用k8s集群中的etcd

2020-10-28 Thread GitBox
tokers commented on issue #2551: URL: https://github.com/apache/apisix/issues/2551#issuecomment-718311862 @Yangzcy423911 Even after #2548 is merged, APISIX still cannot support the **mutual** TLS connection with etcd. This i

[GitHub] [apisix] Jaycean opened a new issue #2553: bug: jwt-auth add consumer_schema to the _M

2020-10-28 Thread GitBox
Jaycean opened a new issue #2553: URL: https://github.com/apache/apisix/issues/2553 ### Issue description after this pr: #2509 merged, jwt-auth also needs to add consumer_schema to the _M I think the new `consumer_schema` can be reminded to add when it is added, it is very easy

[GitHub] [apisix] liuxiran edited a comment on issue #2441: plugin(hmac-auth): update the schema

2020-10-28 Thread GitBox
liuxiran edited a comment on issue #2441: URL: https://github.com/apache/apisix/issues/2441#issuecomment-714330623 ok, based on the results of the discussion above, I think this issue contains at least two modifications: - [x] admin-api provides api like: * `/apisix/admin/s

[GitHub] [apisix-dashboard] LiteSun opened a new pull request #619: feat: added frontend e2e test

2020-10-28 Thread GitBox
LiteSun opened a new pull request #619: URL: https://github.com/apache/apisix-dashboard/pull/619 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - Related i

[GitHub] [apisix] juzhiyuan commented on pull request #2509: feat: get schema by schema_type

2020-10-28 Thread GitBox
juzhiyuan commented on pull request #2509: URL: https://github.com/apache/apisix/pull/2509#issuecomment-718301456 > LGTM > > tips: > after this pr merged, jwt-auth also needs to add `consumer_schema` to the `_M` @Jaycean > https://github.com/apache/apisix/blob/1dfc4cdacd620e6d

[apisix] branch master updated (1dfc4cd -> d2aa1d8)

2020-10-28 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 1dfc4cd CI: move etcd cluster in docker (#2225) add d2aa1d8 feat: get schema by schema_type (#2509) No new

[GitHub] [apisix] juzhiyuan merged pull request #2509: feat: get schema by schema_type

2020-10-28 Thread GitBox
juzhiyuan merged pull request #2509: URL: https://github.com/apache/apisix/pull/2509 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] Jaycean commented on pull request #2509: feat: get schema by schema_type

2020-10-28 Thread GitBox
Jaycean commented on pull request #2509: URL: https://github.com/apache/apisix/pull/2509#issuecomment-718301182 > LGTM > > tips: > after this pr merged, jwt-auth also needs to add `consumer_schema` to the `_M` @Jaycean > https://github.com/apache/apisix/blob/1dfc4cdacd620e6d59

[GitHub] [apisix] juzhiyuan closed issue #2441: plugin(hmac-auth): update the schema

2020-10-28 Thread GitBox
juzhiyuan closed issue #2441: URL: https://github.com/apache/apisix/issues/2441 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] spacewander opened a new pull request #2552: change: rename APIX_WORKER_PROCESSES to APISIX_WORKER_PROCESSES

2020-10-28 Thread GitBox
spacewander opened a new pull request #2552: URL: https://github.com/apache/apisix/pull/2552 Close #2517. ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been

[GitHub] [apisix] Yangzcy423911 commented on issue #2551: apisix 2.X 支持etcd ssl配置吗,想共用k8s集群中的etcd

2020-10-28 Thread GitBox
Yangzcy423911 commented on issue #2551: URL: https://github.com/apache/apisix/issues/2551#issuecomment-718300433 您好,没有找到关于TLS KEY的配置 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix] liuxiran edited a comment on issue #2082: request help: Update plugin's schema

2020-10-28 Thread GitBox
liuxiran edited a comment on issue #2082: URL: https://github.com/apache/apisix/issues/2082#issuecomment-698736589 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [apisix] spacewander commented on issue #2551: apisix 2.X 支持etcd ssl配置吗,想共用k8s集群中的etcd

2020-10-28 Thread GitBox
spacewander commented on issue #2551: URL: https://github.com/apache/apisix/issues/2551#issuecomment-718298247 See https://github.com/apache/apisix/pull/2548 This is an automated message from the Apache Git Service. To respon

[GitHub] [apisix] liuxiran commented on pull request #2509: feat: get schema by schema_type

2020-10-28 Thread GitBox
liuxiran commented on pull request #2509: URL: https://github.com/apache/apisix/pull/2509#issuecomment-718296772 LGTM tips: after this pr merged, jwt-auth also needs to add `consumer_schema` to the `_M` @Jaycean https://github.com/apache/apisix/blob/1dfc4cdacd620e6d59c3d4c755

[GitHub] [apisix] zhangguanzhang commented on issue #2530: request help: [doc] need qucik-start

2020-10-28 Thread GitBox
zhangguanzhang commented on issue #2530: URL: https://github.com/apache/apisix/issues/2530#issuecomment-718296485 This part of the information is too little, a more complete entry process document is needed This is an automa

[GitHub] [apisix] juzhiyuan commented on a change in pull request #2524: CI : yaml style

2020-10-28 Thread GitBox
juzhiyuan commented on a change in pull request #2524: URL: https://github.com/apache/apisix/pull/2524#discussion_r513843881 ## File path: .github/workflows/build.yml ## @@ -12,7 +12,12 @@ jobs: fail-fast: false matrix: platform: [ubuntu-18.04] -o

  1   2   >