[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

2021-01-13 Thread GitBox
codecov-io edited a comment on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-757579417 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=h1) Report > Merging

[GitHub] [apisix] 18210212423 commented on issue #3262: request help: without network install apisix

2021-01-13 Thread GitBox
18210212423 commented on issue #3262: URL: https://github.com/apache/apisix/issues/3262#issuecomment-759991609 > @18210212423 pls feel free to reopen this issue if you still have problem OK,Thank you very much for your reply

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1278: bug(fe): route created with service can not use the service upstream

2021-01-13 Thread GitBox
juzhiyuan commented on issue #1278: URL: https://github.com/apache/apisix-dashboard/issues/1278#issuecomment-759990971 ping This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [apisix] yangxikun opened a new issue #3286: bug: apisix/plugin.lua init_worker prometheus.exporter init should happen before _M.load()

2021-01-13 Thread GitBox
yangxikun opened a new issue #3286: URL: https://github.com/apache/apisix/issues/3286 ### Issue description Our custom plugins rely on `apisix.plugins.prometheus.exporter.get_prometheus()` return an initialized prometheus instance to create metrics. ### Environment *

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1240: feat(fe): import and export routes

2021-01-13 Thread GitBox
liuxiran commented on a change in pull request #1240: URL: https://github.com/apache/apisix-dashboard/pull/1240#discussion_r557112618 ## File path: web/src/pages/Route/locales/zh-CN.ts ## @@ -125,8 +125,8 @@ export default { 'page.route.TabPane.authentication': '认证',

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1240: feat(fe): import and export routes

2021-01-13 Thread GitBox
liuxiran commented on a change in pull request #1240: URL: https://github.com/apache/apisix-dashboard/pull/1240#discussion_r557111729 ## File path: web/src/pages/Route/List.tsx ## @@ -18,29 +18,70 @@ import React, { useRef, useEffect, useState } from 'react'; import {

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1240: feat(fe): import and export routes

2021-01-13 Thread GitBox
liuxiran commented on a change in pull request #1240: URL: https://github.com/apache/apisix-dashboard/pull/1240#discussion_r557110778 ## File path: web/src/pages/Route/List.tsx ## @@ -63,6 +104,84 @@ const Page: React.FC = () => { }); }; + const handleExport =

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1240: feat(fe): import and export routes

2021-01-13 Thread GitBox
liuxiran commented on a change in pull request #1240: URL: https://github.com/apache/apisix-dashboard/pull/1240#discussion_r557111316 ## File path: web/src/pages/Route/List.tsx ## @@ -63,6 +104,84 @@ const Page: React.FC = () => { }); }; + const handleExport =

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1240: feat(fe): import and export routes

2021-01-13 Thread GitBox
codecov-io edited a comment on pull request #1240: URL: https://github.com/apache/apisix-dashboard/pull/1240#issuecomment-756554309 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1240?src=pr=h1) Report > Merging

[GitHub] [apisix] Yangzcy423911 commented on issue #3266: bug: apisix 2.2 base Tengine trun on prometheus error

2021-01-13 Thread GitBox
Yangzcy423911 commented on issue #3266: URL: https://github.com/apache/apisix/issues/3266#issuecomment-759984174 After I use the etcd cluster's highest privilege configuration and restart the service, the calling interface returns normal data, which should be the problem of etcd cluster's

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #174: doc: refine installation documents

2021-01-13 Thread GitBox
gxthrj commented on a change in pull request #174: URL: https://github.com/apache/apisix-ingress-controller/pull/174#discussion_r557103503 ## File path: docs/samples/index.md ## @@ -0,0 +1,24 @@ + + +# Ingress APISIX Use Examples + +This is an index page about use examples of

[GitHub] [apisix] spacewander commented on a change in pull request #3282: docs: 'how-to-build' add a troubleshooting of luasocket

2021-01-13 Thread GitBox
spacewander commented on a change in pull request #3282: URL: https://github.com/apache/apisix/pull/3282#discussion_r557101191 ## File path: doc/how-to-build.md ## @@ -109,6 +109,49 @@ Makefile rules: Environment variable can be used to configure APISIX. Please take a look at

[GitHub] [apisix] jbampton commented on pull request #3247: feat: add basic EditorConfig file to help maintain consistent coding …

2021-01-13 Thread GitBox
jbampton commented on pull request #3247: URL: https://github.com/apache/apisix/pull/3247#issuecomment-759981662 If the contributors don't care and don't install the EditorConfig plugin then it won't bother them. But most editors already provide support. Yes we can lint on the CI

[GitHub] [apisix] spacewander commented on a change in pull request #3278: feat: support hash on vars_combinations

2021-01-13 Thread GitBox
spacewander commented on a change in pull request #3278: URL: https://github.com/apache/apisix/pull/3278#discussion_r557099723 ## File path: apisix/balancer/chash.lua ## @@ -39,8 +39,10 @@ local function fetch_chash_hash_key(ctx, upstream) elseif hash_on == "cookie" then

[GitHub] [apisix] spacewander merged pull request #3275: docs: fix Markdown heading

2021-01-13 Thread GitBox
spacewander merged pull request #3275: URL: https://github.com/apache/apisix/pull/3275 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix] branch master updated (a57a18d -> e00893e)

2021-01-13 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from a57a18d docs: remove unneeded table of contents entry (#3279) add e00893e docs: fix Markdown heading

[GitHub] [apisix] Yangzcy423911 commented on issue #3266: bug: apisix 2.2 base Tengine trun on prometheus error

2021-01-13 Thread GitBox
Yangzcy423911 commented on issue #3266: URL: https://github.com/apache/apisix/issues/3266#issuecomment-759980224 Call the interface / apimix / Prometheus / metrics to read the key information in etcd. I have modified the prefix. Normally, there is no permission problem

[GitHub] [apisix] fukiki commented on a change in pull request #3282: docs: 'how-to-build' add a troubleshooting of luasocket

2021-01-13 Thread GitBox
fukiki commented on a change in pull request #3282: URL: https://github.com/apache/apisix/pull/3282#discussion_r557092774 ## File path: doc/how-to-build.md ## @@ -109,6 +109,49 @@ Makefile rules: Environment variable can be used to configure APISIX. Please take a look at

[GitHub] [apisix-dashboard] nic-chen commented on issue #1227: The API for fetching all plugins should return `disable` property

2021-01-13 Thread GitBox
nic-chen commented on issue #1227: URL: https://github.com/apache/apisix-dashboard/issues/1227#issuecomment-759977383 > @nic-chen anything we need to do for this issue? oh, we need to sync the schema to dashboard since the PR has been merged.

[GitHub] [apisix] Yangzcy423911 commented on issue #3266: bug: apisix 2.2 base Tengine trun on prometheus error

2021-01-13 Thread GitBox
Yangzcy423911 commented on issue #3266: URL: https://github.com/apache/apisix/issues/3266#issuecomment-759977009 about apisix with connected etcd config etcd: host: # it's possible to define multiple etcd hosts addresses of the same etcd cluster. -

[GitHub] [apisix] Yangzcy423911 commented on issue #3266: bug: apisix 2.2 base Tengine trun on prometheus error

2021-01-13 Thread GitBox
Yangzcy423911 commented on issue #3266: URL: https://github.com/apache/apisix/issues/3266#issuecomment-759976088 Restart and re access the node. The error log is as follows 2021/01/14 15:11:25 [error] 25657#25657: *651 [lua] http.lua:951: request_uri(): unread data in buffer,

[GitHub] [apisix-ingress-controller] membphis commented on a change in pull request #174: doc: refine installation documents

2021-01-13 Thread GitBox
membphis commented on a change in pull request #174: URL: https://github.com/apache/apisix-ingress-controller/pull/174#discussion_r557081970 ## File path: docs/samples/index.md ## @@ -0,0 +1,24 @@ + + +# Ingress APISIX Use Examples + +This is an index page about use examples

[GitHub] [apisix] fukiki commented on a change in pull request #3282: docs: 'how-to-build' add a troubleshooting of luasocket

2021-01-13 Thread GitBox
fukiki commented on a change in pull request #3282: URL: https://github.com/apache/apisix/pull/3282#discussion_r557087052 ## File path: doc/how-to-build.md ## @@ -109,6 +109,49 @@ Makefile rules: Environment variable can be used to configure APISIX. Please take a look at

[GitHub] [apisix] Firstsawyou opened a new pull request #3285: chore(traffic-split): add additionalProperties field to restrict plugin configuration

2021-01-13 Thread GitBox
Firstsawyou opened a new pull request #3285: URL: https://github.com/apache/apisix/pull/3285 ### What this PR does / why we need it: I check the schema for plugin traffic-split, it doesn't have additionalProperties = false to limit config, could we add this limit. so

[GitHub] [apisix] Yangzcy423911 commented on issue #3266: bug: apisix 2.2 base Tengine trun on prometheus error

2021-01-13 Thread GitBox
Yangzcy423911 commented on issue #3266: URL: https://github.com/apache/apisix/issues/3266#issuecomment-759974310 I will modifying file /usr/share/lua/5.1/apisix/core/etcd.lua and Add the code you provided above and restart the service. Won't adding this code affect the use of other

[GitHub] [apisix-ingress-controller] membphis commented on a change in pull request #174: doc: refine installation documents

2021-01-13 Thread GitBox
membphis commented on a change in pull request #174: URL: https://github.com/apache/apisix-ingress-controller/pull/174#discussion_r557081970 ## File path: docs/samples/index.md ## @@ -0,0 +1,24 @@ + + +# Ingress APISIX Use Examples + +This is an index page about use examples

[GitHub] [apisix] spacewander commented on a change in pull request #3278: feat: support hash on vars_combinations

2021-01-13 Thread GitBox
spacewander commented on a change in pull request #3278: URL: https://github.com/apache/apisix/pull/3278#discussion_r557081297 ## File path: apisix/balancer/chash.lua ## @@ -38,6 +38,9 @@ local function fetch_chash_hash_key(ctx, upstream) chash_key = ctx.var["http_"

[GitHub] [apisix] spacewander merged pull request #3279: docs: remove unneeded table of contents entry

2021-01-13 Thread GitBox
spacewander merged pull request #3279: URL: https://github.com/apache/apisix/pull/3279 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix] branch master updated (1a1fe09 -> a57a18d)

2021-01-13 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 1a1fe09 fix: always inject disable field into plugin schema (#3272) add a57a18d docs: remove unneeded

[GitHub] [apisix] spacewander commented on issue #3266: bug: apisix 2.2 base Tengine trun on prometheus error

2021-01-13 Thread GitBox
spacewander commented on issue #3266: URL: https://github.com/apache/apisix/issues/3266#issuecomment-759971185 Just replace the corresponding file and restart the service is enough. This is an automated message from the

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #174: doc: refine installation documents

2021-01-13 Thread GitBox
gxthrj commented on a change in pull request #174: URL: https://github.com/apache/apisix-ingress-controller/pull/174#discussion_r557079544 ## File path: docs/samples/index.md ## @@ -0,0 +1,24 @@ + + +# Ingress APISIX Use Examples + +This is an index page about use examples of

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #174: doc: refine installation documents

2021-01-13 Thread GitBox
gxthrj commented on a change in pull request #174: URL: https://github.com/apache/apisix-ingress-controller/pull/174#discussion_r557067101 ## File path: README.md ## @@ -117,10 +117,15 @@ We welcome all kinds of contributions from the open-source community, individual ##

[GitHub] [apisix] spacewander commented on issue #3147: allow user to configure a fallback SSL cert

2021-01-13 Thread GitBox
spacewander commented on issue #3147: URL: https://github.com/apache/apisix/issues/3147#issuecomment-759970517 I already replied you: > I think you can submit it as PR, so that we can see why it doesn't work. APISIX is an open source project. We welcome everyone who contributes to

[GitHub] [apisix] Yangzcy423911 commented on issue #3266: bug: apisix 2.2 base Tengine trun on prometheus error

2021-01-13 Thread GitBox
Yangzcy423911 commented on issue #3266: URL: https://github.com/apache/apisix/issues/3266#issuecomment-759968852 Do you want to recompile APISIX directly after modifying the code or just replace the corresponding file and restart the service

[GitHub] [apisix-dashboard] imjoey commented on pull request #1289: fix: Support string type for the script field in Route

2021-01-13 Thread GitBox
imjoey commented on pull request #1289: URL: https://github.com/apache/apisix-dashboard/pull/1289#issuecomment-759968325 @starsz @juzhiyuan All tests passed. Thank for suggestions. This is an automated message from the

[GitHub] [apisix] membphis commented on a change in pull request #3282: docs: 'how-to-build' add a troubleshooting of luasocket

2021-01-13 Thread GitBox
membphis commented on a change in pull request #3282: URL: https://github.com/apache/apisix/pull/3282#discussion_r557076636 ## File path: doc/how-to-build.md ## @@ -109,6 +109,49 @@ Makefile rules: Environment variable can be used to configure APISIX. Please take a look at

[GitHub] [apisix] fukiki commented on pull request #3282: docs: 'how-to-build' add a troubleshooting of luasocket

2021-01-13 Thread GitBox
fukiki commented on pull request #3282: URL: https://github.com/apache/apisix/pull/3282#issuecomment-759965768 > ci failed,you need to deal with the spaces at the end of the line. > > ``` > Scan detected 7 error(s) in 2 file(s): > [./doc/how-to-build.md]: > 121: line

[GitHub] [apisix] xujl930 commented on issue #3276: bug: the plugin limit-req reached threshold response with error code 503 by Apache Benchmark

2021-01-13 Thread GitBox
xujl930 commented on issue #3276: URL: https://github.com/apache/apisix/issues/3276#issuecomment-759960239 > and if you got 5xx response, you can check your error log first: `apisix/logs/error.log`, we can get more useful information there is no info output in error.log, the

[GitHub] [apisix] dickens7 removed a comment on issue #2006: bug(cors): attempt to concatenate field 'conf_id' (a nil value)

2021-01-13 Thread GitBox
dickens7 removed a comment on issue #2006: URL: https://github.com/apache/apisix/issues/2006#issuecomment-759957902 upgrade to `2.2` the problem remains unresolved Steps to reproduce 1. add global_rules ``` curl -X PUT \

[GitHub] [apisix] dickens7 opened a new issue #3284: bug: (global_rules cors) invalid value (nil) at index 1 in table for 'concat'

2021-01-13 Thread GitBox
dickens7 opened a new issue #3284: URL: https://github.com/apache/apisix/issues/3284 #2006 upgrade to `2.2` the problem remains unresolved Steps to reproduce 1. add global_rules ``` curl -X PUT \ http://127.0.0.1:9080/apisix/admin/global_rules/1 \ -H

[GitHub] [apisix-ingress-controller] gxthrj closed issue #85: leaderelection

2021-01-13 Thread GitBox
gxthrj closed issue #85: URL: https://github.com/apache/apisix-ingress-controller/issues/85 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix-ingress-controller] gxthrj closed issue #11: [TODO] Active / standby deployment to improve availability

2021-01-13 Thread GitBox
gxthrj closed issue #11: URL: https://github.com/apache/apisix-ingress-controller/issues/11 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix-ingress-controller] gxthrj merged pull request #173: feat: controller leader election

2021-01-13 Thread GitBox
gxthrj merged pull request #173: URL: https://github.com/apache/apisix-ingress-controller/pull/173 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[apisix-ingress-controller] branch master updated: feat: controller leader election (#173)

2021-01-13 Thread kvn
This is an automated email from the ASF dual-hosted git repository. kvn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new 396cae2 feat: controller

[GitHub] [apisix] xujl930 commented on issue #3276: bug: the plugin limit-req reached threshold response with error code 503 by Apache Benchmark

2021-01-13 Thread GitBox
xujl930 commented on issue #3276: URL: https://github.com/apache/apisix/issues/3276#issuecomment-759958419 > `ab` uses short connections by default, you need to use the `-k` parameter. > > https://httpd.apache.org/docs/2.4/programs/ab.html: > > `-k Use HTTP KeepAlive feature`

[GitHub] [apisix] dickens7 commented on issue #2006: bug(cors): attempt to concatenate field 'conf_id' (a nil value)

2021-01-13 Thread GitBox
dickens7 commented on issue #2006: URL: https://github.com/apache/apisix/issues/2006#issuecomment-759957902 upgrade to `2.2` the problem remains unresolved Steps to reproduce 1. add global_rules ``` curl -X PUT \ http://127.0.0.1:9080/apisix/admin/global_rules/1 \

[GitHub] [apisix] nanamikon commented on a change in pull request #3278: feat: support hash on vars_combinations

2021-01-13 Thread GitBox
nanamikon commented on a change in pull request #3278: URL: https://github.com/apache/apisix/pull/3278#discussion_r557068976 ## File path: apisix/balancer/chash.lua ## @@ -38,6 +38,9 @@ local function fetch_chash_hash_key(ctx, upstream) chash_key = ctx.var["http_" ..

[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #173: feat: controller leader election

2021-01-13 Thread GitBox
gxthrj commented on pull request #173: URL: https://github.com/apache/apisix-ingress-controller/pull/173#issuecomment-759956644 > > We'd better link related issues. > > Already linked it. See the PR's overview.

[GitHub] [apisix] highkay commented on issue #3147: allow user to configure a fallback SSL cert

2021-01-13 Thread GitBox
highkay commented on issue #3147: URL: https://github.com/apache/apisix/issues/3147#issuecomment-759956037 anything updated? @spacewander This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix] fukiki commented on a change in pull request #3282: docs: 'how-to-build' add a troubleshooting of luasocket

2021-01-13 Thread GitBox
fukiki commented on a change in pull request #3282: URL: https://github.com/apache/apisix/pull/3282#discussion_r557067980 ## File path: doc/how-to-build.md ## @@ -109,6 +109,49 @@ Makefile rules: Environment variable can be used to configure APISIX. Please take a look at

[GitHub] [apisix-ingress-controller] tokers commented on pull request #173: feat: controller leader election

2021-01-13 Thread GitBox
tokers commented on pull request #173: URL: https://github.com/apache/apisix-ingress-controller/pull/173#issuecomment-759954112 > We'd better link related issues. Already linked it. See the PR's overview. This is an

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #173: feat: controller leader election

2021-01-13 Thread GitBox
tokers commented on a change in pull request #173: URL: https://github.com/apache/apisix-ingress-controller/pull/173#discussion_r557066783 ## File path: test/e2e/scaffold/httpbin.go ## @@ -112,3 +115,32 @@ func (s *Scaffold) ScaleHTTPBIN(desired int) error { }

[GitHub] [apisix] fukiki commented on a change in pull request #3282: docs: 'how-to-build' add a troubleshooting of luasocket

2021-01-13 Thread GitBox
fukiki commented on a change in pull request #3282: URL: https://github.com/apache/apisix/pull/3282#discussion_r557066519 ## File path: doc/how-to-build.md ## @@ -109,6 +109,49 @@ Makefile rules: Environment variable can be used to configure APISIX. Please take a look at

[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #173: feat: controller leader election

2021-01-13 Thread GitBox
gxthrj commented on pull request #173: URL: https://github.com/apache/apisix-ingress-controller/pull/173#issuecomment-759953069 We'd better link related issues. This is an automated message from the Apache Git Service. To

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #173: feat: controller leader election

2021-01-13 Thread GitBox
gxthrj commented on a change in pull request #173: URL: https://github.com/apache/apisix-ingress-controller/pull/173#discussion_r557064424 ## File path: test/e2e/scaffold/httpbin.go ## @@ -112,3 +115,32 @@ func (s *Scaffold) ScaleHTTPBIN(desired int) error { }

[GitHub] [apisix] unbeatablekb commented on a change in pull request #3084: feat: add proxy_ssl_server_name

2021-01-13 Thread GitBox
unbeatablekb commented on a change in pull request #3084: URL: https://github.com/apache/apisix/pull/3084#discussion_r557064216 ## File path: conf/config-default.yaml ## @@ -174,6 +174,8 @@ nginx_config: # config for render the template to generate n

[GitHub] [apisix] Firstsawyou commented on issue #3270: apisix连接外部tls etcd集群报错

2021-01-13 Thread GitBox
Firstsawyou commented on issue #3270: URL: https://github.com/apache/apisix/issues/3270#issuecomment-759950039 > https://github.com/apache/apisix/search?q=got+malformed+version+message=issues > > @Firstsawyou @dw-3 you can search this question in the issue, then you'll find the

[GitHub] [apisix] membphis commented on a change in pull request #3282: docs: 'how-to-build' add a troubleshooting of luasocket

2021-01-13 Thread GitBox
membphis commented on a change in pull request #3282: URL: https://github.com/apache/apisix/pull/3282#discussion_r557063549 ## File path: doc/how-to-build.md ## @@ -109,6 +109,49 @@ Makefile rules: Environment variable can be used to configure APISIX. Please take a look at

[GitHub] [apisix] nanamikon commented on a change in pull request #3278: feat: support hash on vars_combinations

2021-01-13 Thread GitBox
nanamikon commented on a change in pull request #3278: URL: https://github.com/apache/apisix/pull/3278#discussion_r557063221 ## File path: t/node/chash-hashon.t ## @@ -625,3 +625,90 @@ chash_key: "chash_val_3" chash_key: "chash_val_4" chash_key: "chash_val_5" chash_key:

[GitHub] [apisix] nanamikon commented on a change in pull request #3278: feat: support hash on vars_combinations

2021-01-13 Thread GitBox
nanamikon commented on a change in pull request #3278: URL: https://github.com/apache/apisix/pull/3278#discussion_r557063174 ## File path: t/node/chash-hashon.t ## @@ -625,3 +625,90 @@ chash_key: "chash_val_3" chash_key: "chash_val_4" chash_key: "chash_val_5" chash_key:

[GitHub] [apisix] membphis commented on issue #3276: bug: the plugin limit-req reached threshold response with error code 503 by Apache Benchmark

2021-01-13 Thread GitBox
membphis commented on issue #3276: URL: https://github.com/apache/apisix/issues/3276#issuecomment-759948933 and if you got 5xx response, you can check your error log first: `apisix/logs/error.log`, we can get more useful information

[GitHub] [apisix] membphis commented on issue #3276: bug: the plugin limit-req reached threshold response with error code 503 by Apache Benchmark

2021-01-13 Thread GitBox
membphis commented on issue #3276: URL: https://github.com/apache/apisix/issues/3276#issuecomment-759948674 `ab` uses short connections by default, you need to use the `-k` parameter. https://httpd.apache.org/docs/2.4/programs/ab.html: `-k Use HTTP KeepAlive

[GitHub] [apisix] Firstsawyou commented on pull request #3282: docs: 'how-to-build' add a troubleshooting of luasocket

2021-01-13 Thread GitBox
Firstsawyou commented on pull request #3282: URL: https://github.com/apache/apisix/pull/3282#issuecomment-759948000 ci failed,you need to deal with the spaces at the end of the line. ``` Scan detected 7 error(s) in 2 file(s): [./doc/how-to-build.md]: 121: line has

[GitHub] [apisix-dashboard] starsz commented on issue #1288: chore: reduce the size of the compiled binary file of manager-api

2021-01-13 Thread GitBox
starsz commented on issue #1288: URL: https://github.com/apache/apisix-dashboard/issues/1288#issuecomment-759947740 IMO, I think we should add another make option that will ignore the debug info and disable the symbol table. Because the debug info and symbol table may be useful for

[GitHub] [apisix] membphis commented on issue #3211: Feature: implement p2c balancer with random, ewma, leastloaded

2021-01-13 Thread GitBox
membphis commented on issue #3211: URL: https://github.com/apache/apisix/issues/3211#issuecomment-759946384 the performance is enough, welcome PR @hnlq715 This is an automated message from the Apache Git Service. To respond

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1293: route vars support IN operator

2021-01-13 Thread GitBox
juzhiyuan commented on issue #1293: URL: https://github.com/apache/apisix-dashboard/issues/1293#issuecomment-759945590 all right, we will support this feature in M2.4[1] [1] https://github.com/apache/apisix-dashboard/milestone/10

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1227: The API for fetching all plugins should return `disable` property

2021-01-13 Thread GitBox
juzhiyuan commented on issue #1227: URL: https://github.com/apache/apisix-dashboard/issues/1227#issuecomment-759945337 @nic-chen anything we need to do for this issue? This is an automated message from the Apache Git

[GitHub] [apisix] membphis closed issue #3262: request help: without network install apisix

2021-01-13 Thread GitBox
membphis closed issue #3262: URL: https://github.com/apache/apisix/issues/3262 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] membphis commented on issue #3262: request help: without network install apisix

2021-01-13 Thread GitBox
membphis commented on issue #3262: URL: https://github.com/apache/apisix/issues/3262#issuecomment-759944798 @18210212423 pls feel free to reopen this issue if you still have problem This is an automated message from the

[GitHub] [apisix] 18210212423 edited a comment on issue #3262: request help: without network install apisix

2021-01-13 Thread GitBox
18210212423 edited a comment on issue #3262: URL: https://github.com/apache/apisix/issues/3262#issuecomment-759393744 i have found it, ``` apisix: node_listen: 9080# APISIX listening port enable_admin: true enable_admin_cors: true # Admin

[GitHub] [apisix] membphis commented on a change in pull request #3278: feat: support hash on vars_combinations

2021-01-13 Thread GitBox
membphis commented on a change in pull request #3278: URL: https://github.com/apache/apisix/pull/3278#discussion_r557057858 ## File path: t/node/chash-hashon.t ## @@ -625,3 +625,90 @@ chash_key: "chash_val_3" chash_key: "chash_val_4" chash_key: "chash_val_5" chash_key:

[GitHub] [apisix] Firstsawyou commented on a change in pull request #3278: feat: support hash on vars_combinations

2021-01-13 Thread GitBox
Firstsawyou commented on a change in pull request #3278: URL: https://github.com/apache/apisix/pull/3278#discussion_r557057131 ## File path: t/node/chash-hashon.t ## @@ -625,3 +625,90 @@ chash_key: "chash_val_3" chash_key: "chash_val_4" chash_key: "chash_val_5" chash_key:

[GitHub] [apisix-ingress-controller] membphis commented on pull request #173: feat: controller leader election

2021-01-13 Thread GitBox
membphis commented on pull request #173: URL: https://github.com/apache/apisix-ingress-controller/pull/173#issuecomment-759939560 @gxthrj ping This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix] starsz commented on issue #3281: Document how-to-build.md should add a troubleshooting of luasocket

2021-01-13 Thread GitBox
starsz commented on issue #3281: URL: https://github.com/apache/apisix/issues/3281#issuecomment-759939122 I think we can use luajit to interprets the bootstrap. We can update the [Shebang](https://en.wikipedia.org/wiki/Shebang_%28Unix%29)

[GitHub] [apisix] spacewander commented on a change in pull request #3278: feat: support hash on vars_combinations

2021-01-13 Thread GitBox
spacewander commented on a change in pull request #3278: URL: https://github.com/apache/apisix/pull/3278#discussion_r557052944 ## File path: apisix/balancer/chash.lua ## @@ -38,6 +38,9 @@ local function fetch_chash_hash_key(ctx, upstream) chash_key = ctx.var["http_"

[GitHub] [apisix] membphis merged pull request #3272: fix: always inject disable field into plugin schema

2021-01-13 Thread GitBox
membphis merged pull request #3272: URL: https://github.com/apache/apisix/pull/3272 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix-dashboard] membphis closed issue #1227: The API for fetching all plugins should return `disable` property

2021-01-13 Thread GitBox
membphis closed issue #1227: URL: https://github.com/apache/apisix-dashboard/issues/1227 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[apisix] branch master updated (90be57f -> 1a1fe09)

2021-01-13 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 90be57f docs: update rpm package to 2.2 (#3280) add 1a1fe09 fix: always inject disable field into plugin

[GitHub] [apisix] membphis commented on a change in pull request #3278: feat: support hash on vars_combinations

2021-01-13 Thread GitBox
membphis commented on a change in pull request #3278: URL: https://github.com/apache/apisix/pull/3278#discussion_r557052181 ## File path: apisix/balancer/chash.lua ## @@ -38,6 +38,9 @@ local function fetch_chash_hash_key(ctx, upstream) chash_key = ctx.var["http_" ..

[GitHub] [apisix] membphis commented on a change in pull request #3278: feat: support hash on vars_combinations

2021-01-13 Thread GitBox
membphis commented on a change in pull request #3278: URL: https://github.com/apache/apisix/pull/3278#discussion_r557051593 ## File path: apisix/balancer/chash.lua ## @@ -38,6 +38,9 @@ local function fetch_chash_hash_key(ctx, upstream) chash_key = ctx.var["http_" ..

[GitHub] [apisix] spacewander closed issue #3270: apisix连接外部tls etcd集群报错

2021-01-13 Thread GitBox
spacewander closed issue #3270: URL: https://github.com/apache/apisix/issues/3270 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] spacewander commented on issue #3270: apisix连接外部tls etcd集群报错

2021-01-13 Thread GitBox
spacewander commented on issue #3270: URL: https://github.com/apache/apisix/issues/3270#issuecomment-759935443 Same as https://github.com/apache/apisix/issues/3225 And see https://github.com/apache/apisix/issues/3283 This

[GitHub] [apisix] spacewander commented on issue #3225: request help: apisix connected use tls with etcd

2021-01-13 Thread GitBox
spacewander commented on issue #3225: URL: https://github.com/apache/apisix/issues/3225#issuecomment-759935197 We also need to support it with lua-resty-etcd, not just fix it when running the command. I have created an issue for it: https://github.com/apache/apisix/issues/3283

[GitHub] [apisix] starsz edited a comment on issue #3283: Support disable ssl verify for etcd connection

2021-01-13 Thread GitBox
starsz edited a comment on issue #3283: URL: https://github.com/apache/apisix/issues/3283#issuecomment-759935084 Got it. Please assign it to me. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix] starsz commented on issue #3283: Support disable ssl verify for etcd connection

2021-01-13 Thread GitBox
starsz commented on issue #3283: URL: https://github.com/apache/apisix/issues/3283#issuecomment-759935084 OK. Please assign it to me. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix] spacewander commented on issue #3283: Support disable ssl verify for etcd connection

2021-01-13 Thread GitBox
spacewander commented on issue #3283: URL: https://github.com/apache/apisix/issues/3283#issuecomment-759934771 @starsz This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix] spacewander commented on issue #3283: Support disable ssl verify for etcd connection

2021-01-13 Thread GitBox
spacewander commented on issue #3283: URL: https://github.com/apache/apisix/issues/3283#issuecomment-759934601 This feature will solve https://github.com/apache/apisix/issues/3225 This is an automated message from the Apache

[GitHub] [apisix] spacewander opened a new issue #3283: Support disable ssl verify for etcd connection

2021-01-13 Thread GitBox
spacewander opened a new issue #3283: URL: https://github.com/apache/apisix/issues/3283 Currently when people want to connect etcd cluster via TLS, there is no way to disable SSL verify. We need to solve it in two aspects: 1. allow disabling SSL verify in apisix/cli with

[GitHub] [apisix-dashboard] belongwqz commented on issue #1293: route vars support IN operator

2021-01-13 Thread GitBox
belongwqz commented on issue #1293: URL: https://github.com/apache/apisix-dashboard/issues/1293#issuecomment-759932691 > @LiteSun Please take a look at this issue, and leave some steps to achieve this issue. Then @belongwqz would you like to implement this issue? My most familiar

[apisix] branch master updated: docs: update rpm package to 2.2 (#3280)

2021-01-13 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 90be57f docs: update rpm package to 2.2

[GitHub] [apisix] spacewander merged pull request #3280: docs: update rpm package to 2.2

2021-01-13 Thread GitBox
spacewander merged pull request #3280: URL: https://github.com/apache/apisix/pull/3280 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] spacewander commented on a change in pull request #3282: docs: 'how-to-build' add a troubleshooting of luasocket

2021-01-13 Thread GitBox
spacewander commented on a change in pull request #3282: URL: https://github.com/apache/apisix/pull/3282#discussion_r557036331 ## File path: doc/how-to-build.md ## @@ -109,6 +109,49 @@ Makefile rules: Environment variable can be used to configure APISIX. Please take a look at

[GitHub] [apisix-dashboard] Firstsawyou commented on issue #1294: request help: traffic-split plugin does not work

2021-01-13 Thread GitBox
Firstsawyou commented on issue #1294: URL: https://github.com/apache/apisix-dashboard/issues/1294#issuecomment-759916042 > > @Firstsawyou > > I check the schema for plugin `traffic-split`, it doesn't have `additionalProperties = false` to limit config, could we add this limit ? so

[GitHub] [apisix-dashboard] Firstsawyou commented on issue #1294: request help: traffic-split plugin does not work

2021-01-13 Thread GitBox
Firstsawyou commented on issue #1294: URL: https://github.com/apache/apisix-dashboard/issues/1294#issuecomment-759914531 > @Firstsawyou > > I check the schema for plugin `traffic-split`, it doesn't have `additionalProperties = false` to limit config, could we add this limit ? so

[GitHub] [apisix] juzhiyuan commented on a change in pull request #3278: feat: support hash on vars_combinations

2021-01-13 Thread GitBox
juzhiyuan commented on a change in pull request #3278: URL: https://github.com/apache/apisix/pull/3278#discussion_r557033494 ## File path: t/node/chash-hashon.t ## @@ -625,3 +625,90 @@ chash_key: "chash_val_3" chash_key: "chash_val_4" chash_key: "chash_val_5" chash_key:

[GitHub] [apisix] moonming commented on a change in pull request #3280: docs: update rpm package to 2.2

2021-01-13 Thread GitBox
moonming commented on a change in pull request #3280: URL: https://github.com/apache/apisix/pull/3280#discussion_r557031736 ## File path: doc/how-to-build.md ## @@ -49,7 +49,7 @@ make deps ### Installation via RPM package (CentOS 7) ```shell -sudo yum install -y

[GitHub] [apisix] fukiki opened a new pull request #3282: doc: 'how-to-build' add a troubleshooting of luasocket

2021-01-13 Thread GitBox
fukiki opened a new pull request #3282: URL: https://github.com/apache/apisix/pull/3282 Signed-off-by: fukiki ### What this PR does / why we need it: Document how-to-build.md should add a troubleshooting of luasocket fix #3281 fix #3216 ### Pre-submission

[GitHub] [apisix] spacewander commented on pull request #2546: feat:health check for stream proxy

2021-01-13 Thread GitBox
spacewander commented on pull request #2546: URL: https://github.com/apache/apisix/pull/2546#issuecomment-759911961 @redynasc Do you have time to continue? This is an automated message from the Apache Git Service. To

[GitHub] [apisix] spacewander commented on issue #3281: Document how-to-build.md should add a troubleshooting of luasocket

2021-01-13 Thread GitBox
spacewander commented on issue #3281: URL: https://github.com/apache/apisix/issues/3281#issuecomment-759911338 @starsz This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix] spacewander commented on a change in pull request #3280: docs: update rpm package to 2.2

2021-01-13 Thread GitBox
spacewander commented on a change in pull request #3280: URL: https://github.com/apache/apisix/pull/3280#discussion_r557030552 ## File path: doc/how-to-build.md ## @@ -49,7 +49,7 @@ make deps ### Installation via RPM package (CentOS 7) ```shell -sudo yum install -y

  1   2   3   4   >