[GitHub] [apisix] spacewander merged pull request #3337: docs: delete the `http` part to avoid ambiguity

2021-01-18 Thread GitBox
spacewander merged pull request #3337: URL: https://github.com/apache/apisix/pull/3337 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix] branch master updated (ebab4de -> 3d85240)

2021-01-18 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from ebab4de docs: fix Markdown headings and remove unneeded TOC link (#3331) add 3d85240 docs: delete the `h

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1304: test(FE): e2e test for plugin page

2021-01-18 Thread GitBox
codecov-io edited a comment on pull request #1304: URL: https://github.com/apache/apisix-dashboard/pull/1304#issuecomment-760687643 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1304?src=pr&el=h1) Report > Merging [#1304](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #176: chore: caching

2021-01-18 Thread GitBox
tokers commented on a change in pull request #176: URL: https://github.com/apache/apisix-ingress-controller/pull/176#discussion_r559972425 ## File path: pkg/seven/state/solver.go ## @@ -57,92 +57,58 @@ func (s *ApisixCombination) Solver() (string, error) { func (s *ApisixComb

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #176: chore: caching

2021-01-18 Thread GitBox
tokers commented on a change in pull request #176: URL: https://github.com/apache/apisix-ingress-controller/pull/176#discussion_r559971926 ## File path: pkg/apisix/cluster.go ## @@ -85,20 +89,129 @@ func newCluster(o *ClusterOptions) (Cluster, error) {

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #176: chore: caching

2021-01-18 Thread GitBox
gxthrj commented on a change in pull request #176: URL: https://github.com/apache/apisix-ingress-controller/pull/176#discussion_r559965159 ## File path: pkg/seven/state/builder.go ## @@ -227,64 +221,18 @@ func SolverSingleUpstream(u *v1.Upstream, swg ServiceWorkerGroup, wg *s

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1333: chore: add stop subcommand

2021-01-18 Thread GitBox
nic-chen commented on pull request #1333: URL: https://github.com/apache/apisix-dashboard/pull/1333#issuecomment-762661299 > @tokers , thank you for this. Just FYI, the file `api/manager` is in this PR. 😄 yes, we should not submit the binary

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1333: chore: add stop subcommand

2021-01-18 Thread GitBox
nic-chen commented on a change in pull request #1333: URL: https://github.com/apache/apisix-dashboard/pull/1333#discussion_r559966953 ## File path: api/internal/utils/pid.go ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contr

[GitHub] [apisix] spacewander commented on a change in pull request #3224: feat: support dubbo

2021-01-18 Thread GitBox
spacewander commented on a change in pull request #3224: URL: https://github.com/apache/apisix/pull/3224#discussion_r559963431 ## File path: t/plugin/dubbo-proxy/route.t ## @@ -0,0 +1,314 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] [apisix-ingress-controller] pahud opened a new pull request #181: chore(doc): Update aws.md

2021-01-18 Thread GitBox
pahud opened a new pull request #181: URL: https://github.com/apache/apisix-ingress-controller/pull/181 rename AWS EKS to Amazon EKS Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [ ] New feature provided -

[GitHub] [apisix] membphis commented on a change in pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX

2021-01-18 Thread GitBox
membphis commented on a change in pull request #3335: URL: https://github.com/apache/apisix/pull/3335#discussion_r559962469 ## File path: Makefile ## @@ -56,6 +57,9 @@ ifeq ($(LUAROCKS_VER),luarocks 3.) else luarocks install rockspec/apisix-master-0.rockspec --tree=dep

[GitHub] [apisix] spacewander commented on a change in pull request #3337: doc: delete the `http` part to avoid ambiguity

2021-01-18 Thread GitBox
spacewander commented on a change in pull request #3337: URL: https://github.com/apache/apisix/pull/3337#discussion_r559957109 ## File path: doc/admin-api.md ## @@ -73,7 +73,7 @@ |upstream |False |Upstream|Enabled Upstream configuration, see [Upstream](architecture-design.md#

[GitHub] [apisix-dashboard] imjoey commented on pull request #1333: chore: add stop subcommand

2021-01-18 Thread GitBox
imjoey commented on pull request #1333: URL: https://github.com/apache/apisix-dashboard/pull/1333#issuecomment-762649134 @tokers , thank you for this. Just FYI, the file `api/manager` is in this PR. 😄 This is an automated m

[GitHub] [apisix-dashboard] tokers commented on pull request #1333: chore: add stop subcommand

2021-01-18 Thread GitBox
tokers commented on pull request #1333: URL: https://github.com/apache/apisix-dashboard/pull/1333#issuecomment-762646578 @starsz This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix-dashboard] tokers opened a new pull request #1333: chore: add stop subcommand

2021-01-18 Thread GitBox
tokers opened a new pull request #1333: URL: https://github.com/apache/apisix-dashboard/pull/1333 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport

[apisix] branch membphis/patch-1 updated (964f34d -> a91355e)

2021-01-18 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch membphis/patch-1 in repository https://gitbox.apache.org/repos/asf/apisix.git. from 964f34d doc: delete the `http` part to avoid ambiguity add a91355e doc: sync Chinese version. No

[GitHub] [apisix-ingress-controller] tokers commented on pull request #176: chore: caching

2021-01-18 Thread GitBox
tokers commented on pull request #176: URL: https://github.com/apache/apisix-ingress-controller/pull/176#issuecomment-762640268 @gxthrj Please take a look when you have time. This is an automated message from the Apache Git

[GitHub] [apisix] membphis opened a new pull request #3337: doc: delete the `http` part to avoid ambiguity

2021-01-18 Thread GitBox
membphis opened a new pull request #3337: URL: https://github.com/apache/apisix/pull/3337 ### What this PR does / why we need it: - [ ] update the Chinese doc ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new feature

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1102: feat: import route from OpenAPI Specification3.0

2021-01-18 Thread GitBox
juzhiyuan commented on a change in pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102#discussion_r559947748 ## File path: api/test/testdata/import-test-plugins.yaml ## @@ -61,17 +61,17 @@ paths: 'application/x-www-form-urlencoded':

[apisix] branch membphis/patch-1 created (now 964f34d)

2021-01-18 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch membphis/patch-1 in repository https://gitbox.apache.org/repos/asf/apisix.git. at 964f34d doc: delete the `http` part to avoid ambiguity This branch includes the following new commits:

[apisix] 01/01: doc: delete the `http` part to avoid ambiguity

2021-01-18 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch membphis/patch-1 in repository https://gitbox.apache.org/repos/asf/apisix.git commit 964f34d18c089f7f6e6904a559215660a8056234 Author: YuanSheng Wang AuthorDate: Tue Jan 19 14:50:36 2021 +0800

[GitHub] [apisix] TkClark commented on issue #487: Who is using APISIX?(欢迎使用 APISIX 的个人和公司在此留言)

2021-01-18 Thread GitBox
TkClark commented on issue #487: URL: https://github.com/apache/apisix/issues/487#issuecomment-762639580 组织:明源云客 地址:中国深圳 联系方式:zhou...@mingyuanyun.com 使用场景:全局流量网关,服务网格网关 This is an automated message from the Apache Gi

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1326: fix(fe): update url regexp in online debug

2021-01-18 Thread GitBox
juzhiyuan commented on a change in pull request #1326: URL: https://github.com/apache/apisix-dashboard/pull/1326#discussion_r559947379 ## File path: web/cypress/integration/route/online-debug.spec.js ## @@ -42,6 +42,7 @@ context('Online debug', () => { // input uri with

[GitHub] [apisix] fukiki commented on a change in pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX

2021-01-18 Thread GitBox
fukiki commented on a change in pull request #3335: URL: https://github.com/apache/apisix/pull/3335#discussion_r559945716 ## File path: Makefile ## @@ -56,6 +57,9 @@ ifeq ($(LUAROCKS_VER),luarocks 3.) else luarocks install rockspec/apisix-master-0.rockspec --tree=deps

[GitHub] [apisix-dashboard] moonming commented on pull request #1270: Chore:add e2e test coverage

2021-01-18 Thread GitBox
moonming commented on pull request #1270: URL: https://github.com/apache/apisix-dashboard/pull/1270#issuecomment-762636121 ping @ShiningRush @nic-chen any update? This is an automated message from the Apache Git Service. To r

[GitHub] [apisix] 18210212423 commented on issue #3316: request help: How to modify and return JSON instead of code

2021-01-18 Thread GitBox
18210212423 commented on issue #3316: URL: https://github.com/apache/apisix/issues/3316#issuecomment-762635043 > Any interested students are welcome to contribute this PR I come to PR, but does that coding need to be handled uniformly

[GitHub] [apisix] membphis commented on issue #3336: feat: support to specify the scheme(http/https) in upstream

2021-01-18 Thread GitBox
membphis commented on issue #3336: URL: https://github.com/apache/apisix/issues/3336#issuecomment-762634497 @shuaijinchao This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix] membphis opened a new issue #3336: feat: support to specify the scheme(http/https) in upstream

2021-01-18 Thread GitBox
membphis opened a new issue #3336: URL: https://github.com/apache/apisix/issues/3336 we can specify the schema by the plugin: https://github.com/apache/apisix/blob/master/doc/plugins/proxy-rewrite.md This function is too common, I think we should support this option in the upstream

[GitHub] [apisix] moonming merged pull request #3331: docs: fix Markdown headings and remove unneeded TOC link

2021-01-18 Thread GitBox
moonming merged pull request #3331: URL: https://github.com/apache/apisix/pull/3331 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[apisix] branch master updated (a815391 -> ebab4de)

2021-01-18 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from a815391 fix: APISIX runs in the `/root` directory and reports errors (#3220) add ebab4de docs: fix Markdown

[GitHub] [apisix-dashboard] imjoey opened a new issue #1332: feat: Improve testing coverage for the POST and PATCH methods of the resources

2021-01-18 Thread GitBox
imjoey opened a new issue #1332: URL: https://github.com/apache/apisix-dashboard/issues/1332 # Feature request ## Please describe your feature At present, most test cases in Backend E2E and Unit-test cases are using `PUT` method for creating and updating the resource, which le

[GitHub] [apisix] membphis commented on issue #3307: to many redirect

2021-01-18 Thread GitBox
membphis commented on issue #3307: URL: https://github.com/apache/apisix/issues/3307#issuecomment-762621291 you can set the upstream node by IP, it is an easy way. ``` "upstream":{ "nodes":[ { "host":"10.10.100.26", "p

[GitHub] [apisix-dashboard] imjoey opened a new issue #1331: feat: Better design for the Create and Update methods of Store interface

2021-01-18 Thread GitBox
imjoey opened a new issue #1331: URL: https://github.com/apache/apisix-dashboard/issues/1331 # Feature request ## Please describe your feature This issue is originated from discussions with @ShiningRush in #1322 , current definition of `Update` methods in Store interface `Upda

[GitHub] [apisix] dw-3 edited a comment on issue #3307: to many redirect

2021-01-18 Thread GitBox
dw-3 edited a comment on issue #3307: URL: https://github.com/apache/apisix/issues/3307#issuecomment-761996983 > @dw-3 Could you format the JSON string, it's somewhat hard to read now. ```json { "id":"337510371847832908", "create_time":1610701458, "update_time"

[GitHub] [apisix] tokers commented on a change in pull request #3224: feat: support dubbo

2021-01-18 Thread GitBox
tokers commented on a change in pull request #3224: URL: https://github.com/apache/apisix/pull/3224#discussion_r559923511 ## File path: README.md ## @@ -79,6 +79,7 @@ A/B testing, canary release, blue-green deployment, limit rate, defense against - **Multi protocols** -

[GitHub] [apisix] Firstsawyou commented on issue #3307: to many redirect

2021-01-18 Thread GitBox
Firstsawyou commented on issue #3307: URL: https://github.com/apache/apisix/issues/3307#issuecomment-762613768 > > > > Hi, @dw-3 > > > > According to the log information you provided, this is a normal behavior. Because the upstream information is directly set in the traffic-split plugin

[GitHub] [apisix] tghfly commented on issue #3334: request help: 测试hmac-auth插件时提示Invalid signature

2021-01-18 Thread GitBox
tghfly commented on issue #3334: URL: https://github.com/apache/apisix/issues/3334#issuecomment-762612537 我在生成签名的shell脚本里有带上 /index.html ,/ 和 /index.html生成签名都试过,仍然提示无效 This is an automated message from the Apache Git Service.

[GitHub] [apisix] membphis commented on issue #3334: request help: 测试hmac-auth插件时提示Invalid signature

2021-01-18 Thread GitBox
membphis commented on issue #3334: URL: https://github.com/apache/apisix/issues/3334#issuecomment-762612126 @tghfly you can take a look at the test case, it may help you: https://github.com/apache/apisix/blob/master/t/plugin/hmac-auth.t#L325 ---

[GitHub] [apisix] tokers commented on issue #3268: How to do service discovery based on etcd or consul? The documents on our GitHub don't look very smoothrequest help:

2021-01-18 Thread GitBox
tokers commented on issue #3268: URL: https://github.com/apache/apisix/issues/3268#issuecomment-762609767 > @membphis does the consul based routing respect weights set in the consul SRV record? We don't have special process for SRV record, i think it's necessary in this case.

[GitHub] [apisix] membphis commented on issue #2315: request help: Nginx integrated skywalking acquisition function, TPS decreased significantly

2021-01-18 Thread GitBox
membphis commented on issue #2315: URL: https://github.com/apache/apisix/issues/2315#issuecomment-762608963 we can close this issue now. This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [apisix] membphis closed issue #2315: request help: Nginx integrated skywalking acquisition function, TPS decreased significantly

2021-01-18 Thread GitBox
membphis closed issue #2315: URL: https://github.com/apache/apisix/issues/2315 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [apisix] membphis commented on a change in pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX

2021-01-18 Thread GitBox
membphis commented on a change in pull request #3335: URL: https://github.com/apache/apisix/pull/3335#discussion_r559914991 ## File path: Makefile ## @@ -56,6 +57,9 @@ ifeq ($(LUAROCKS_VER),luarocks 3.) else luarocks install rockspec/apisix-master-0.rockspec --tree=dep

[GitHub] [apisix] Firstsawyou commented on issue #3334: request help: 测试hmac-auth插件时提示Invalid signature

2021-01-18 Thread GitBox
Firstsawyou commented on issue #3334: URL: https://github.com/apache/apisix/issues/3334#issuecomment-762606776 > ping @Firstsawyou you can take a look when you have time, many thx Okay, I am troubleshooting this issue.

[GitHub] [apisix-dashboard] membphis commented on issue #1330: bug: Forward the request to the stale upstream node

2021-01-18 Thread GitBox
membphis commented on issue #1330: URL: https://github.com/apache/apisix-dashboard/issues/1330#issuecomment-762606719 need more information from the user. This is an automated message from the Apache Git Service. To respond

[GitHub] [apisix-dashboard] membphis opened a new issue #1330: bug: Forward the request to the stale upstream node

2021-01-18 Thread GitBox
membphis opened a new issue #1330: URL: https://github.com/apache/apisix-dashboard/issues/1330 # Bug report ![image](https://user-images.githubusercontent.com/6814606/104990711-1c19b200-5a58-11eb-8cb0-4a870f543fbd.png) ![image](https://user-images.githubusercontent.com/6814606/10

[GitHub] [apisix] membphis commented on issue #3334: request help: 测试hmac-auth插件时提示Invalid signature

2021-01-18 Thread GitBox
membphis commented on issue #3334: URL: https://github.com/apache/apisix/issues/3334#issuecomment-762605472 ![image](https://user-images.githubusercontent.com/6814606/104990553-d5c45300-5a57-11eb-95e8-63801c79d7ad.png) T

[GitHub] [apisix] membphis commented on issue #3334: request help: 测试hmac-auth插件时提示Invalid signature

2021-01-18 Thread GitBox
membphis commented on issue #3334: URL: https://github.com/apache/apisix/issues/3334#issuecomment-762605131 ping @Firstsawyou you can take a look when you have time, many thx This is an automated message from the Apache Git S

[GitHub] [apisix] membphis commented on a change in pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX

2021-01-18 Thread GitBox
membphis commented on a change in pull request #3335: URL: https://github.com/apache/apisix/pull/3335#discussion_r559914991 ## File path: Makefile ## @@ -56,6 +57,9 @@ ifeq ($(LUAROCKS_VER),luarocks 3.) else luarocks install rockspec/apisix-master-0.rockspec --tree=dep

[GitHub] [apisix] tokers commented on issue #3323: apisix2.2 traffic-split 支持header中添加-横线报错

2021-01-18 Thread GitBox
tokers commented on issue #3323: URL: https://github.com/apache/apisix/issues/3323#issuecomment-762601962 Consider it had been solved. This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [apisix] tokers closed issue #3323: apisix2.2 traffic-split 支持header中添加-横线报错

2021-01-18 Thread GitBox
tokers closed issue #3323: URL: https://github.com/apache/apisix/issues/3323 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [apisix-ingress-controller] tokers commented on pull request #180: doc: add document to explain how to run on GKE

2021-01-18 Thread GitBox
tokers commented on pull request #180: URL: https://github.com/apache/apisix-ingress-controller/pull/180#issuecomment-762600421 @moonming @membphis @gxthrj Please take a look when you have time. This is an automated message

[GitHub] [apisix] fukiki opened a new pull request #3335: fix:Use luajit or lua 5.1 by default when run APISIX

2021-01-18 Thread GitBox
fukiki opened a new pull request #3335: URL: https://github.com/apache/apisix/pull/3335 Signed-off-by: fukiki ### What this PR does / why we need it: When run APISIX, use LuaJIT or Lua 5.1 by default. If the local lua version is not 5.1, running `make deps` will change

[GitHub] [apisix] tghfly opened a new issue #3334: request help: 测试hmac-auth插件时提示Invalid signature

2021-01-18 Thread GitBox
tghfly opened a new issue #3334: URL: https://github.com/apache/apisix/issues/3334 ### Issue description 在测试 hmac-auth插件时一直提示Invalid signature ### Environment * apisix version:2.2 * OS: Linux apisix01 3.10.0-327.4.5.el7.x86_64 #1 SMP Mon Jan 25 22:07:14 UTC 2016 x86_64 x

[GitHub] [apisix-dashboard] imjoey commented on pull request #1322: feat: Add returning value for HTTP PUT and PATCH methods

2021-01-18 Thread GitBox
imjoey commented on pull request #1322: URL: https://github.com/apache/apisix-dashboard/pull/1322#issuecomment-762590726 > ok, we may create an issue to track this if needed :) @juzhiyuan @ShiningRush Thanks. Then I will commit an issue for tracking the `Create`/`Update` methods of

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1304: test(FE): e2e test for plugin page

2021-01-18 Thread GitBox
codecov-io edited a comment on pull request #1304: URL: https://github.com/apache/apisix-dashboard/pull/1304#issuecomment-760687643 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1304?src=pr&el=h1) Report > Merging [#1304](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix] spacewander commented on issue #3333: bug: test case failed in t/admin/plugin-metadata.t

2021-01-18 Thread GitBox
spacewander commented on issue #: URL: https://github.com/apache/apisix/issues/#issuecomment-762587694 Try to solve it in https://github.com/apache/apisix/pull/3329 I will keep running it repeatedly today, and will mark it ready if things go well. --

[GitHub] [apisix] spacewander closed issue #3207: apisix-2.1/apisix/init.lua:89: module 'resty.worker.events' not found:

2021-01-18 Thread GitBox
spacewander closed issue #3207: URL: https://github.com/apache/apisix/issues/3207 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix] spacewander merged pull request #3220: fix: APISIX runs in the `/root` directory and reports errors

2021-01-18 Thread GitBox
spacewander merged pull request #3220: URL: https://github.com/apache/apisix/pull/3220 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix] branch master updated: fix: APISIX runs in the `/root` directory and reports errors (#3220)

2021-01-18 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new a815391 fix: APISIX runs in the `/root` di

[GitHub] [apisix] membphis commented on issue #3268: How to do service discovery based on etcd or consul? The documents on our GitHub don't look very smoothrequest help:

2021-01-18 Thread GitBox
membphis commented on issue #3268: URL: https://github.com/apache/apisix/issues/3268#issuecomment-762586918 > @membphis does the consul based routing respect weights set in the consul SRV record? need @moonming to confirm this detail. thx ---

[GitHub] [apisix] hnlq715 opened a new issue #3333: bug: test case failed

2021-01-18 Thread GitBox
hnlq715 opened a new issue #: URL: https://github.com/apache/apisix/issues/ ### Issue description ### Environment * apisix version (cmd: `apisix version`): * OS: (cmd: `uname -a`) * OpenResty / Nginx version: (cmd: `nginx -V` or `openresty -V`) https://gith

[GitHub] [apisix] hnlq715 commented on a change in pull request #3300: feat: ewma use p2c to improve performance

2021-01-18 Thread GitBox
hnlq715 commented on a change in pull request #3300: URL: https://github.com/apache/apisix/pull/3300#discussion_r559895428 ## File path: apisix/balancer/ewma.lua ## @@ -3,105 +3,125 @@ -- Inspiration drawn from: -- https://github.com/twitter/finagle/blob/1bc837c4feafc0096e43

[GitHub] [apisix] spacewander opened a new pull request #3332: fix: set conf info when global rule is hit without matched rule

2021-01-18 Thread GitBox
spacewander opened a new pull request #3332: URL: https://github.com/apache/apisix/pull/3332 Fix #3330 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve?

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1326: fix(fe): update url regexp in online debug

2021-01-18 Thread GitBox
liuxiran commented on a change in pull request #1326: URL: https://github.com/apache/apisix-dashboard/pull/1326#discussion_r559894208 ## File path: web/cypress/integration/route/online-debug.spec.js ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [apisix] jbampton opened a new pull request #3331: docs: fix Markdown headings and remove unneeded TOC link

2021-01-18 Thread GitBox
jbampton opened a new pull request #3331: URL: https://github.com/apache/apisix/pull/3331 ### What this PR does / why we need it: Standardizes the Markdown files. ### Pre-submission checklist: * [X] Did you explain what problem does this PR solve? Or what new features h

[GitHub] [apisix-dashboard] Jaycean commented on pull request #1102: feat: import route from OpenAPI Specification3.0

2021-01-18 Thread GitBox
Jaycean commented on pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-762579150 > > > > Hi, the two functions of import and export are closely related, so I want to discuss the name of the folder with you. I personally think that the two files are

[GitHub] [apisix] dw-3 commented on issue #3307: to many redirect

2021-01-18 Thread GitBox
dw-3 commented on issue #3307: URL: https://github.com/apache/apisix/issues/3307#issuecomment-762577735 > > > Hi, @dw-3 > > > According to the log information you provided, this is a normal behavior. Because the upstream information is directly set in the traffic-split plugin, when the

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1102: feat: import route from OpenAPI Specification3.0

2021-01-18 Thread GitBox
nic-chen commented on pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-762577575 > > > Hi, the two functions of import and export are closely related, so I want to discuss the name of the folder with you. I personally think that the two files are u

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #180: doc: add document to explain how to run on GKE

2021-01-18 Thread GitBox
gxthrj commented on a change in pull request #180: URL: https://github.com/apache/apisix-ingress-controller/pull/180#discussion_r559890195 ## File path: docs/deployments/gke.md ## @@ -0,0 +1,75 @@ + + +# Install Ingress APISIX on Google Cloud GKE + +This document explains how

[GitHub] [apisix] dw-3 commented on issue #3323: apisix2.2 traffic-split 支持header中添加-横线报错

2021-01-18 Thread GitBox
dw-3 commented on issue #3323: URL: https://github.com/apache/apisix/issues/3323#issuecomment-762574806 > > > Hi, @dw-3 > > > If you want to use it in the v2.2 version, you need to modify this line of code in the traffic-split plugin as follows: > > > https://github.com/apache/apisix

[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1326: fix(fe): update url regexp in online debug

2021-01-18 Thread GitBox
LiteSun commented on a change in pull request #1326: URL: https://github.com/apache/apisix-dashboard/pull/1326#discussion_r559888558 ## File path: web/cypress/integration/route/online-debug.spec.js ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [apisix-ingress-controller] tokers opened a new pull request #180: doc: add document to explain how to run on GKE

2021-01-18 Thread GitBox
tokers opened a new pull request #180: URL: https://github.com/apache/apisix-ingress-controller/pull/180 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] B

[GitHub] [apisix] hnlq715 commented on a change in pull request #3300: feat: ewma use p2c to improve performance

2021-01-18 Thread GitBox
hnlq715 commented on a change in pull request #3300: URL: https://github.com/apache/apisix/pull/3300#discussion_r559884772 ## File path: apisix/balancer/ewma.lua ## @@ -3,105 +3,125 @@ -- Inspiration drawn from: -- https://github.com/twitter/finagle/blob/1bc837c4feafc0096e43

[GitHub] [apisix] hnlq715 commented on a change in pull request #3300: feat: ewma use p2c to improve performance

2021-01-18 Thread GitBox
hnlq715 commented on a change in pull request #3300: URL: https://github.com/apache/apisix/pull/3300#discussion_r559884772 ## File path: apisix/balancer/ewma.lua ## @@ -3,105 +3,125 @@ -- Inspiration drawn from: -- https://github.com/twitter/finagle/blob/1bc837c4feafc0096e43

[GitHub] [apisix-dashboard] nic-chen opened a new issue #1329: bug: non-json data causes error logs

2021-01-18 Thread GitBox
nic-chen opened a new issue #1329: URL: https://github.com/apache/apisix-dashboard/issues/1329 # Bug report ## Describe the bug json parse failed log in error.log ## How to Reproduce 1. start Manager API (new installation) 2. start APISIX (new installation)

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1304: test(FE): e2e test for plugin page

2021-01-18 Thread GitBox
codecov-io edited a comment on pull request #1304: URL: https://github.com/apache/apisix-dashboard/pull/1304#issuecomment-760687643 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1304?src=pr&el=h1) Report > Merging [#1304](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix] ElvinEfendi edited a comment on issue #3268: How to do service discovery based on etcd or consul? The documents on our GitHub don't look very smoothrequest help:

2021-01-18 Thread GitBox
ElvinEfendi edited a comment on issue #3268: URL: https://github.com/apache/apisix/issues/3268#issuecomment-762566452 @membphis does the consul based routing respect weights set in the consul SRV record? This is an automated

[GitHub] [apisix] ElvinEfendi commented on issue #3268: How to do service discovery based on etcd or consul? The documents on our GitHub don't look very smoothrequest help:

2021-01-18 Thread GitBox
ElvinEfendi commented on issue #3268: URL: https://github.com/apache/apisix/issues/3268#issuecomment-762566452 @membphis does the consul based routing respect weights set in the consul SVC record? This is an automated messag

[GitHub] [apisix-dashboard] nic-chen opened a new issue #1328: test: add e2e test for dubbo

2021-01-18 Thread GitBox
nic-chen opened a new issue #1328: URL: https://github.com/apache/apisix-dashboard/issues/1328 after PR https://github.com/apache/apisix/pull/3224 merged, we should add some test cases for it. and we need build a test env for it. -

[GitHub] [apisix-website] juzhiyuan commented on pull request #148: upgrade: docusaurusV2

2021-01-18 Thread GitBox
juzhiyuan commented on pull request #148: URL: https://github.com/apache/apisix-website/pull/148#issuecomment-762565224 @guoqqqi Please have a try to review this PR. This is an automated message from the Apache Git Service. T

[GitHub] [apisix-dashboard] starsz commented on pull request #1318: feat: add store mock

2021-01-18 Thread GitBox
starsz commented on pull request #1318: URL: https://github.com/apache/apisix-dashboard/pull/1318#issuecomment-762561224 @ShiningRush @nic-chen Thanks for your advice. Sorry, I don't think too much about it. Maybe we can discuss it. @juzhiyuan This PR is WIP now. -

[GitHub] [apisix-dashboard] juzhiyuan edited a comment on pull request #1326: fix(fe): update url regexp in online debug

2021-01-18 Thread GitBox
juzhiyuan edited a comment on pull request #1326: URL: https://github.com/apache/apisix-dashboard/pull/1326#issuecomment-762559771 @guoqqqi Please have a try on this PR, if anything you are not clear, you could leave comments. --

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1318: feat: add store mock

2021-01-18 Thread GitBox
juzhiyuan commented on pull request #1318: URL: https://github.com/apache/apisix-dashboard/pull/1318#issuecomment-762560004 ping @starsz Please resolve those conflicts. This is an automated message from the Apache Git Service

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1326: fix(fe): update url regexp in online debug

2021-01-18 Thread GitBox
juzhiyuan commented on pull request #1326: URL: https://github.com/apache/apisix-dashboard/pull/1326#issuecomment-762559771 @guoqqqi Please take a look at this PR, if anything you are not clear, you could leave comments. Thi

[apisix-dashboard] branch master updated (4cf46b0 -> 749eeb5)

2021-01-18 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 4cf46b0 feat: Add returning value for HTTP PUT and PATCH methods (#1322) add 749eeb5 chore: fix

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1327: chore: fix spelling

2021-01-18 Thread GitBox
juzhiyuan merged pull request #1327: URL: https://github.com/apache/apisix-dashboard/pull/1327 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1322: feat: Add returning value for HTTP PUT and PATCH methods

2021-01-18 Thread GitBox
juzhiyuan merged pull request #1322: URL: https://github.com/apache/apisix-dashboard/pull/1322 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[apisix-dashboard] branch master updated: feat: Add returning value for HTTP PUT and PATCH methods (#1322)

2021-01-18 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 4cf46b0 feat: Add returning value

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1322: feat: Add returning value for HTTP PUT and PATCH methods

2021-01-18 Thread GitBox
juzhiyuan commented on pull request #1322: URL: https://github.com/apache/apisix-dashboard/pull/1322#issuecomment-762558139 ok, we may create an issue to track this if needed :) This is an automated message from the Apache Gi

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1290: Switch Language doesn't work 🤔

2021-01-18 Thread GitBox
juzhiyuan commented on issue #1290: URL: https://github.com/apache/apisix-dashboard/issues/1290#issuecomment-762557438 @guoqqqi Test! This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [apisix] to2false opened a new issue #3330: bug: /apisix/prometheus/metrics cannot access

2021-01-18 Thread GitBox
to2false opened a new issue #3330: URL: https://github.com/apache/apisix/issues/3330 ### Issue description ### Environment * apisix version (cmd: `apisix version`): 2.2 * OS: (cmd: `uname -a`) Linux gateway 3.10.0-957.el7.x86_64 #1 SMP Thu Nov 8 23:39:32 UTC 2018 x86_64 x86

[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #176: chore: caching

2021-01-18 Thread GitBox
codecov-io commented on pull request #176: URL: https://github.com/apache/apisix-ingress-controller/pull/176#issuecomment-762555613 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/176?src=pr&el=h1) Report > Merging [#176](https://codecov.io/gh/apache/apisix-ing

[GitHub] [apisix-dashboard] Jaycean commented on pull request #1102: feat: import route from OpenAPI Specification3.0

2021-01-18 Thread GitBox
Jaycean commented on pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-762555156 > > Hi, the two functions of import and export are closely related, so I want to discuss the name of the folder with you. I personally think that the two files are ulti

[apisix-website] branch asf-site updated: deploy: 90f9f3e45e27934e5bd4888d9705596f17dc4634

2021-01-18 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/asf-site by this push: new cd00770 deploy: 90f9f3e45e27934

[GitHub] [apisix-dashboard] LiteSun closed issue #1290: Switch Language doesn't work 🤔

2021-01-18 Thread GitBox
LiteSun closed issue #1290: URL: https://github.com/apache/apisix-dashboard/issues/1290 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-website] moonming merged pull request #149: docs: fix spelling and grammar

2021-01-18 Thread GitBox
moonming merged pull request #149: URL: https://github.com/apache/apisix-website/pull/149 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-dashboard] LiteSun merged pull request #1321: fix: upgrade @umijs/preset-react >= 1.7.11

2021-01-18 Thread GitBox
LiteSun merged pull request #1321: URL: https://github.com/apache/apisix-dashboard/pull/1321 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[apisix-dashboard] branch master updated: fix: upgrade @umijs/preset-react >= 1.7.11 (#1321)

2021-01-18 Thread sunyi
This is an automated email from the ASF dual-hosted git repository. sunyi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 0b28c12 fix: upgrade @umijs/preset-rea

[apisix-website] branch master updated: docs: fix spelling and grammar (#149)

2021-01-18 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new 90f9f3e docs: fix spelling and grammar

[GitHub] [apisix] spacewander opened a new pull request #3329: test: make ci stable

2021-01-18 Thread GitBox
spacewander opened a new pull request #3329: URL: https://github.com/apache/apisix/pull/3329 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new featu

  1   2   3   >