membphis merged pull request #3329:
URL: https://github.com/apache/apisix/pull/3329
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
membphis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 319c3eb test: make ci stable (#3329)
319c3eb
Firstsawyou commented on issue #3351:
URL: https://github.com/apache/apisix/issues/3351#issuecomment-763411301
The `patch` method cannot use subpaths.
By the way, the `local data = {"update1.com", "update2.com"}` data in your
test case 2 is invalid, you need to be like test 1: `local
gxthrj commented on a change in pull request #176:
URL:
https://github.com/apache/apisix-ingress-controller/pull/176#discussion_r560724048
##
File path: pkg/apisix/apisix.go
##
@@ -73,39 +81,28 @@ type Upstream interface {
// Service is the specific client interface to take
nanamikon edited a comment on issue #3351:
URL: https://github.com/apache/apisix/issues/3351#issuecomment-763393960
Thanks for reply, so I can't update snis with sub path here , because the
snis is array but not object
refer to
nanamikon commented on issue #3351:
URL: https://github.com/apache/apisix/issues/3351#issuecomment-763393960
Thanks for reply, so I can't update snis with sub path here , because the
snis is array but not object
refer to
Caelebs opened a new issue #1337:
URL: https://github.com/apache/apisix-dashboard/issues/1337
I added a custom plugin. I want to add a logo when displaying the plugin in
the dashboard. What do I need to do? For example, the jwt-auth plugin has a
corresponding logo.
gxthrj commented on a change in pull request #183:
URL:
https://github.com/apache/apisix-ingress-controller/pull/183#discussion_r560722168
##
File path: docs/deployments/ack.md
##
@@ -0,0 +1,76 @@
+
+
+# Install Ingress APISIX on ACK
+
+This document explains how to install
Firstsawyou commented on issue #3351:
URL: https://github.com/apache/apisix/issues/3351#issuecomment-763388065
> Test 2
The test case 2 should look like this:
nanamikon edited a comment on issue #3351:
URL: https://github.com/apache/apisix/issues/3351#issuecomment-763379950
I write a test case for this situation
Test 1 success， but Test 2 fail because of 400
```
=== TEST 1: not unwanted data, PUT
--- config
location /t {
fukiki commented on pull request #3335:
URL: https://github.com/apache/apisix/pull/3335#issuecomment-763380652
@membphis Could you review [commit
065a44](https://github.com/apache/apisix/pull/3335/commits/065a44e8166976333f0eaa9684157e00880e3881)
for me? Thank you.
By the way,
nanamikon commented on issue #3351:
URL: https://github.com/apache/apisix/issues/3351#issuecomment-763379950
I write a test case for this situation
```
=== TEST 1: not unwanted data, PUT
--- config
location /t {
content_by_lua_block {
local
idbeta opened a new issue #3355:
URL: https://github.com/apache/apisix/issues/3355
### Issue description
```
# Failed test 'TEST 56: set route with size 36k (temporary file to store
request body) - pattern "a client request body is buffered to a temporary file"
should match a
tokers commented on a change in pull request #176:
URL:
https://github.com/apache/apisix-ingress-controller/pull/176#discussion_r560713624
##
File path: pkg/seven/state/builder.go
##
@@ -227,64 +221,18 @@ func SolverSingleUpstream(u *v1.Upstream, swg
ServiceWorkerGroup, wg
codecov-io edited a comment on pull request #176:
URL:
https://github.com/apache/apisix-ingress-controller/pull/176#issuecomment-762555613
#
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/176?src=pr=h1)
Report
> Merging
tokers commented on a change in pull request #183:
URL:
https://github.com/apache/apisix-ingress-controller/pull/183#discussion_r560713116
##
File path: docs/deployments/ack.md
##
@@ -0,0 +1,76 @@
+
+
+# Install Ingress APISIX on ACK
+
+This document explains how to install
codecov-io commented on pull request #185:
URL:
https://github.com/apache/apisix-ingress-controller/pull/185#issuecomment-763377097
#
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/185?src=pr=h1)
Report
> Merging
tokers commented on pull request #185:
URL:
https://github.com/apache/apisix-ingress-controller/pull/185#issuecomment-763375788
@membphis @moonming @gxthrj
This is an automated message from the Apache Git Service.
To
tokers opened a new pull request #185:
URL: https://github.com/apache/apisix-ingress-controller/pull/185
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ]
spacewander closed issue #3353:
URL: https://github.com/apache/apisix/issues/3353
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
gxthrj merged pull request #184:
URL: https://github.com/apache/apisix-ingress-controller/pull/184
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
kvn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new e11f7e0 docs: add flowcharts
gxthrj commented on pull request #183:
URL:
https://github.com/apache/apisix-ingress-controller/pull/183#issuecomment-763371166
cc @tokers @membphis @moonming
This is an automated message from the Apache Git Service.
To
spacewander commented on issue #3353:
URL: https://github.com/apache/apisix/issues/3353#issuecomment-763371114
Proxy gRPC in C is different from communication via gRPC in Lua.
BTW, we are not the maintainer of skywalking. We don't own
https://github.com/apache/skywalking-nginx-lua.
gxthrj merged pull request #180:
URL: https://github.com/apache/apisix-ingress-controller/pull/180
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
kvn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new 5d3f1b3 doc: add document to
spacewander opened a new pull request #3354:
URL: https://github.com/apache/apisix/pull/3354
Signed-off-by: spacewander
### What this PR does / why we need it:
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new
xingren23 opened a new issue #3353:
URL: https://github.com/apache/apisix/issues/3353
### Issue description
之前实现skywalking-nginx-lua模块时
lua还不支持http协议，现在apisix已经支持的gRPC协议代理，是不是可以用gRPC协议取代HTTP1.1 协议来上报trace信息？
https://github.com/apache/skywalking/issues/1071
###
spacewander commented on a change in pull request #3352:
URL: https://github.com/apache/apisix/pull/3352#discussion_r560699688
##
File path: apisix/plugins/grpc-transcode.lua
##
@@ -31,7 +31,7 @@ local pb_option_def = {
},
{ description = "int64 as result",
hnlq715 opened a new pull request #3352:
URL: https://github.com/apache/apisix/pull/3352
### What this PR does / why we need it:
### Pre-submission checklist:
* [] Did you explain what problem does this PR solve? Or what new features
have been added?
* [ ] Have you
belongwqz opened a new issue #1336:
URL: https://github.com/apache/apisix-dashboard/issues/1336
# Feature request
## Please describe your feature
Support subpath to use the reverse proxy
## Describe the solution you'd like
When start dashboard via manager-api,
starsz commented on a change in pull request #1333:
URL: https://github.com/apache/apisix-dashboard/pull/1333#discussion_r560693660
##
File path: api/cmd/managerapi.go
##
@@ -119,5 +132,28 @@ func NewManagerAPICommand() *cobra.Command {
}
codecov-io edited a comment on pull request #176:
URL:
https://github.com/apache/apisix-ingress-controller/pull/176#issuecomment-762555613
#
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/176?src=pr=h1)
Report
> Merging
tokers commented on pull request #176:
URL:
https://github.com/apache/apisix-ingress-controller/pull/176#issuecomment-763348403
> Unit-test CI failed @tokers Please have a look.
Fixed.
This is an automated message
spacewander commented on a change in pull request #3345:
URL: https://github.com/apache/apisix/pull/3345#discussion_r560689656
##
File path: t/plugin/proxy-rewrite.t
##
@@ -297,6 +297,7 @@ passed
=== TEST 9: rewrite host + scheme
+--- LAST
Review comment:
Fixed
tokers merged pull request #3350:
URL: https://github.com/apache/apisix/pull/3350
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
tokers pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new da99a03 test: add more test to check if
tokers merged pull request #3346:
URL: https://github.com/apache/apisix/pull/3346
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
tokers closed issue #3334:
URL: https://github.com/apache/apisix/issues/3334
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
This is an automated email from the ASF dual-hosted git repository.
tokers pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git.
from b78c87a fix: set conf info when global rule is hit without matched
rule (#3332)
add 801e56c docs: improve
tokers commented on a change in pull request #180:
URL:
https://github.com/apache/apisix-ingress-controller/pull/180#discussion_r560689039
##
File path: docs/deployments/gke.md
##
@@ -0,0 +1,76 @@
+
+
+# Install Ingress APISIX on Google Cloud GKE
+
+This document explains how
tokers commented on a change in pull request #3345:
URL: https://github.com/apache/apisix/pull/3345#discussion_r560687578
##
File path: t/plugin/proxy-rewrite.t
##
@@ -297,6 +297,7 @@ passed
=== TEST 9: rewrite host + scheme
+--- LAST
Review comment:
Is this for
gxthrj commented on pull request #176:
URL:
https://github.com/apache/apisix-ingress-controller/pull/176#issuecomment-763342296
Unit-test CI failed @tokers Please have a look.
This is an automated message from the Apache
starsz opened a new pull request #151:
URL: https://github.com/apache/apisix-website/pull/151
Fixes: #[Add issue number here]
Changes:
Screenshots of the change:
This is an automated message from the
gxthrj commented on pull request #184:
URL:
https://github.com/apache/apisix-ingress-controller/pull/184#issuecomment-763338884
> @gxthrj The CI failed.
Fixed
This is an automated message from the Apache Git Service.
codecov-io commented on pull request #184:
URL:
https://github.com/apache/apisix-ingress-controller/pull/184#issuecomment-763337185
#
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/184?src=pr=h1)
Report
> Merging
imjoey opened a new pull request #150:
URL: https://github.com/apache/apisix-website/pull/150
Signed-off-by: imjoey
Changes:
Add the new committer `majunjie` into committer list in team.md.
This is an
spacewander commented on a change in pull request #3345:
URL: https://github.com/apache/apisix/pull/3345#discussion_r560666155
##
File path: apisix/control/v1.lua
##
@@ -49,11 +54,62 @@ function _M.schema()
end
+local function iter_and_add_checker(infos, values, src)
+
spacewander commented on pull request #3084:
URL: https://github.com/apache/apisix/pull/3084#issuecomment-763317564
@unbeatablekb
You need to add `proxy_ssl_server_name` in t/APISIX.pm.
You can take a look at
unbeatablekb commented on pull request #3084:
URL: https://github.com/apache/apisix/pull/3084#issuecomment-763314013
@tokers Thanks for giving help. I will add test for it after learning nginx
test which would be done within this weeks.
spacewander closed issue #3330:
URL: https://github.com/apache/apisix/issues/3330
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
spacewander merged pull request #3332:
URL: https://github.com/apache/apisix/pull/3332
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new b78c87a fix: set conf info when global
Firstsawyou commented on pull request #3350:
URL: https://github.com/apache/apisix/pull/3350#issuecomment-763298120
LGTM.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Caelebs opened a new issue #1335:
URL: https://github.com/apache/apisix-dashboard/issues/1335
# Bug report
## Describe the bug
I deployed the latest version of dashboard v2.3, and found that the `Server
Info` in the left menu bar is not aligned, and the icons and text titles
tokers commented on a change in pull request #180:
URL:
https://github.com/apache/apisix-ingress-controller/pull/180#discussion_r560640310
##
File path: docs/deployments/gke.md
##
@@ -0,0 +1,76 @@
+
+
+# Install Ingress APISIX on Google Cloud GKE
+
+This document explains how
spacewander merged pull request #3347:
URL: https://github.com/apache/apisix/pull/3347
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git.
from e3601e6 feat: support dubbo (#3224)
add 746345a docs: fix the example in skywalking doc (#3347)
No new
spacewander commented on issue #3351:
URL: https://github.com/apache/apisix/issues/3351#issuecomment-763289064
> 1.intsert ssl with snis
> 2.patch snis
Could you show us how you send the requests?
This is an
LiteSun commented on issue #1299:
URL:
https://github.com/apache/apisix-dashboard/issues/1299#issuecomment-763284611
ping
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
membphis commented on a change in pull request #180:
URL:
https://github.com/apache/apisix-ingress-controller/pull/180#discussion_r560631763
##
File path: docs/deployments/gke.md
##
@@ -0,0 +1,76 @@
+
+
+# Install Ingress APISIX on Google Cloud GKE
+
+This document explains
juzhiyuan commented on issue #1291:
URL:
https://github.com/apache/apisix-dashboard/issues/1291#issuecomment-763284068
fine
This is an automated message from the Apache Git Service.
To respond to the message, please log on
spacewander commented on issue #2798:
URL: https://github.com/apache/apisix/issues/2798#issuecomment-763278334
So we can get the check & upstream's configuration, the healthy nodes
(unhealthy nodes can be found via `nodes` - `healthy nodes`).
codecov-io commented on pull request #180:
URL:
https://github.com/apache/apisix-ingress-controller/pull/180#issuecomment-763275532
#
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/180?src=pr=h1)
Report
> Merging
codecov-io edited a comment on pull request #1333:
URL: https://github.com/apache/apisix-dashboard/pull/1333#issuecomment-763274597
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1333?src=pr=h1)
Report
> Merging
tokers commented on a change in pull request #180:
URL:
https://github.com/apache/apisix-ingress-controller/pull/180#discussion_r560622732
##
File path: docs/deployments/gke.md
##
@@ -0,0 +1,75 @@
+
+
+# Install Ingress APISIX on Google Cloud GKE
+
+This document explains how
codecov-io commented on pull request #1333:
URL: https://github.com/apache/apisix-dashboard/pull/1333#issuecomment-763274597
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1333?src=pr=h1)
Report
> Merging
liuxiran commented on issue #1291:
URL:
https://github.com/apache/apisix-dashboard/issues/1291#issuecomment-763273719
Thanks for the instruction which teach me how to use `cypress intercept`, it
will be very useful to write this test spec. @juzhiyuan @LiteSun
and if we did not run
Firstsawyou commented on issue #3351:
URL: https://github.com/apache/apisix/issues/3351#issuecomment-763273196
Please check if there is a problem with your configuration. According to
your error message, it is likely that your configuration is incorrect.
codecov-io edited a comment on pull request #1326:
URL: https://github.com/apache/apisix-dashboard/pull/1326#issuecomment-762690400
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1326?src=pr=h1)
Report
> Merging
spacewander merged pull request #3224:
URL: https://github.com/apache/apisix/pull/3224
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
spacewander closed issue #89:
URL: https://github.com/apache/apisix/issues/89
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new e3601e6 feat: support dubbo (#3224)
spacewander commented on issue #2798:
URL: https://github.com/apache/apisix/issues/2798#issuecomment-763265836
@gzhsnail
There is not concept of "主动检查是否健康" and "被动检查是否健康".
There is only two state: "healthy" and "unhealthy". Both "active check" and
"passive check" can change a node
tokers commented on a change in pull request #1333:
URL: https://github.com/apache/apisix-dashboard/pull/1333#discussion_r560616623
##
File path: api/internal/utils/pid.go
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
tokers commented on pull request #1333:
URL: https://github.com/apache/apisix-dashboard/pull/1333#issuecomment-763265319
> @tokers , thank you for this. Just FYI, the file `api/manager` is in this
PR.
Oh my gosh, i'll remove it, sorry~
tokers commented on pull request #3084:
URL: https://github.com/apache/apisix/pull/3084#issuecomment-763264689
@unbeatablekb Should have test cases for it, you can prepare a keypair that
the SNI is not matched with the backend server and assert the proxy is aborted.
tokers commented on issue #3344:
URL: https://github.com/apache/apisix/issues/3344#issuecomment-763261714
The SNI pass should be supported in advance, with the related issue #2988 .
This is an automated message from the
liuxiran commented on a change in pull request #1334:
URL: https://github.com/apache/apisix-dashboard/pull/1334#discussion_r560091428
##
File path: web/cypress/integration/lang/switch-language.spec.js
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
nanamikon opened a new issue #3351:
URL: https://github.com/apache/apisix/issues/3351
### Issue description
Fail to update snis using PATCH
### Environment
* apisix version: 2.2
* OS: ubuntu
* OpenResty / Nginx version:1.19
### Minimal test code / Steps to
Firstsawyou commented on a change in pull request #3345:
URL: https://github.com/apache/apisix/pull/3345#discussion_r560611587
##
File path: apisix/control/v1.lua
##
@@ -49,11 +54,62 @@ function _M.schema()
end
+local function iter_and_add_checker(infos, values, src)
+
tokers commented on pull request #184:
URL:
https://github.com/apache/apisix-ingress-controller/pull/184#issuecomment-763259738
@gxthrj The CI failed.
This is an automated message from the Apache Git Service.
To respond to
tokers commented on pull request #184:
URL:
https://github.com/apache/apisix-ingress-controller/pull/184#issuecomment-763259650
Great, we need a "How to Works" doc to incorporate with this flowcharts.
This is an automated
tokers commented on a change in pull request #3345:
URL: https://github.com/apache/apisix/pull/3345#discussion_r560609236
##
File path: apisix/control/v1.lua
##
@@ -49,11 +54,62 @@ function _M.schema()
end
+local function iter_and_add_checker(infos, values, src)
+if
spacewander opened a new pull request #3350:
URL: https://github.com/apache/apisix/pull/3350
Signed-off-by: spacewander
### What this PR does / why we need it:
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new
spacewander merged pull request #3338:
URL: https://github.com/apache/apisix/pull/3338
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new e40eeae docs: fix some incomplete shell
spacewander commented on a change in pull request #3332:
URL: https://github.com/apache/apisix/pull/3332#discussion_r560603025
##
File path: t/config-center-yaml/global-rule.t
##
@@ -112,3 +112,18 @@ global_rules:
- /h*
#END
--- error_code: 403
+
+
+
juzhiyuan commented on a change in pull request #1334:
URL: https://github.com/apache/apisix-dashboard/pull/1334#discussion_r560602544
##
File path: web/cypress/integration/route/search-route.spec.js
##
@@ -89,8 +89,8 @@ context('Create and Search Route', () => {
juzhiyuan commented on a change in pull request #1334:
URL: https://github.com/apache/apisix-dashboard/pull/1334#discussion_r560602383
##
File path: web/cypress/integration/route/search-route.spec.js
##
@@ -89,8 +89,8 @@ context('Create and Search Route', () => {
guoqqqi commented on a change in pull request #148:
URL: https://github.com/apache/apisix-website/pull/148#discussion_r560582382
##
File path: website/.docusaurus/docusaurus.config.js
##
@@ -0,0 +1,214 @@
+export default {
+ "title": "Apache APISIX™",
+ "tagline": "Apache
guoqqqi commented on pull request #148:
URL: https://github.com/apache/apisix-website/pull/148#issuecomment-763216683
> > Hi , The changes which were committed with the 1 st commit , are done
when running automated migration using CLI.
>
>
>
> 