[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1605: fix: fix the uptime translation error

2021-03-19 Thread GitBox
codecov-io edited a comment on pull request #1605: URL: https://github.com/apache/apisix-dashboard/pull/1605#issuecomment-803253569 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1605?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1585: feat: use menu and menu item to wrap buttons

2021-03-19 Thread GitBox
codecov-io commented on pull request #1585: URL: https://github.com/apache/apisix-dashboard/pull/1585#issuecomment-803254276 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1585?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1605: fix: fix the uptime translation error

2021-03-19 Thread GitBox
codecov-io edited a comment on pull request #1605: URL: https://github.com/apache/apisix-dashboard/pull/1605#issuecomment-803253569 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1605?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1610: feat: improve the config plugin button enable disable status

2021-03-19 Thread GitBox
codecov-io edited a comment on pull request #1610: URL: https://github.com/apache/apisix-dashboard/pull/1610#issuecomment-803254054 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1610: feat: improve the config plugin button enable disable status

2021-03-19 Thread GitBox
codecov-io commented on pull request #1610: URL: https://github.com/apache/apisix-dashboard/pull/1610#issuecomment-803254054 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1605: fix: fix the uptime translation error

2021-03-19 Thread GitBox
codecov-io commented on pull request #1605: URL: https://github.com/apache/apisix-dashboard/pull/1605#issuecomment-803253569 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1605?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] stu01509 commented on pull request #1605: fix: fix the uptime translation error

2021-03-19 Thread GitBox
stu01509 commented on pull request #1605: URL: https://github.com/apache/apisix-dashboard/pull/1605#issuecomment-803253332 Hi @guoqqqi Update the commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1597: test: add the create and delete plugin in drawer

2021-03-19 Thread GitBox
codecov-io edited a comment on pull request #1597: URL: https://github.com/apache/apisix-dashboard/pull/1597#issuecomment-799889165 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr=h1) Report > Merging

[GitHub] [apisix] tokers commented on pull request #3871: docs: admin-api.md document adds configuration https example

2021-03-19 Thread GitBox
tokers commented on pull request #3871: URL: https://github.com/apache/apisix/pull/3871#issuecomment-803253112 I cannot capture whether the https is used in client and admin api or the apisix to upstream. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1597: test: add the create and delete plugin in drawer

2021-03-19 Thread GitBox
codecov-io edited a comment on pull request #1597: URL: https://github.com/apache/apisix-dashboard/pull/1597#issuecomment-799889165 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1597: test: add the create and delete plugin in drawer

2021-03-19 Thread GitBox
codecov-io edited a comment on pull request #1597: URL: https://github.com/apache/apisix-dashboard/pull/1597#issuecomment-799889165 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr=h1) Report > Merging

[GitHub] [apisix-docker] tokers commented on pull request #152: feat: add apisix-dashboard dockerfile & CI

2021-03-19 Thread GitBox
tokers commented on pull request #152: URL: https://github.com/apache/apisix-docker/pull/152#issuecomment-803252343 LGTM in my side. But the CI failed, please fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [apisix-dashboard] stu01509 commented on pull request #1597: test: add the create and delete plugin in drawer

2021-03-19 Thread GitBox
stu01509 commented on pull request #1597: URL: https://github.com/apache/apisix-dashboard/pull/1597#issuecomment-803252310 Hi @guoqqqi and @juzhiyuan Update the commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix-docker] tokers commented on a change in pull request #152: feat: add apisix-dashboard dockerfile & CI

2021-03-19 Thread GitBox
tokers commented on a change in pull request #152: URL: https://github.com/apache/apisix-docker/pull/152#discussion_r598065541 ## File path: compose/dashboard-compose.yaml ## @@ -0,0 +1,35 @@ +version: "3" Review comment: Got it. -- This is an automated message

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1620: feat: update yarn.lock

2021-03-19 Thread GitBox
codecov-io edited a comment on pull request #1620: URL: https://github.com/apache/apisix-dashboard/pull/1620#issuecomment-802638797 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1558: feat:Support duplicate one existing Route

2021-03-19 Thread GitBox
codecov-io edited a comment on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-791913462 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1558: feat:Support duplicate one existing Route

2021-03-19 Thread GitBox
codecov-io edited a comment on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-791913462 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1605: fix: fix the uptime translation error

2021-03-19 Thread GitBox
guoqqqi commented on pull request #1605: URL: https://github.com/apache/apisix-dashboard/pull/1605#issuecomment-803250090 Hi, When you have time, please update the master code to fix the error. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix-dashboard] guoqqqi edited a comment on pull request #1610: feat: improve the config plugin button enable disable status

2021-03-19 Thread GitBox
guoqqqi edited a comment on pull request #1610: URL: https://github.com/apache/apisix-dashboard/pull/1610#issuecomment-803249476 The test failed because when the button was clicked, the button became Disable and the Disable button was not found. You can fix line 59 by changing

[GitHub] [apisix-dashboard] guoqqqi edited a comment on pull request #1610: feat: improve the config plugin button enable disable status

2021-03-19 Thread GitBox
guoqqqi edited a comment on pull request #1610: URL: https://github.com/apache/apisix-dashboard/pull/1610#issuecomment-803249476 The test failed because when the button was clicked, the button became Disable and the Disable button was not found. You can fix line 59 by changing

[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1610: feat: improve the config plugin button enable disable status

2021-03-19 Thread GitBox
guoqqqi commented on pull request #1610: URL: https://github.com/apache/apisix-dashboard/pull/1610#issuecomment-803249476 The test failed because when the button was clicked, the button became Disable and the Disable button was not found. You can fix line 59 by changing

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1620: feat: update yarn.lock

2021-03-19 Thread GitBox
codecov-io edited a comment on pull request #1620: URL: https://github.com/apache/apisix-dashboard/pull/1620#issuecomment-802638797 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] Jaycean opened a new issue #1624: Discussion: when creating a route, is route name required

2021-03-19 Thread GitBox
Jaycean opened a new issue #1624: URL: https://github.com/apache/apisix-dashboard/issues/1624 ## Issue description - Fe create route `name` field is required. - However, in BE, the `name` field is still optional. PR: #1606 adds the BE judgment on whether the `name` field is

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1620: feat: update yarn.lock

2021-03-19 Thread GitBox
codecov-io edited a comment on pull request #1620: URL: https://github.com/apache/apisix-dashboard/pull/1620#issuecomment-802638797 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1597: test: add the create and delete plugin in drawer

2021-03-19 Thread GitBox
guoqqqi commented on pull request #1597: URL: https://github.com/apache/apisix-dashboard/pull/1597#issuecomment-803246224 CI error: https://github.com/apache/apisix-dashboard/pull/1597/checks?check_run_id=2148899222 This CI error has been fixed in #1584. -- This is an automated

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1558: feat:Support duplicate one existing Route

2021-03-19 Thread GitBox
codecov-io edited a comment on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-791913462 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1558: feat:Support duplicate one existing Route

2021-03-19 Thread GitBox
codecov-io edited a comment on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-791913462 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1620: feat: update yarn.lock

2021-03-19 Thread GitBox
codecov-io edited a comment on pull request #1620: URL: https://github.com/apache/apisix-dashboard/pull/1620#issuecomment-802638797 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1558: feat:Support duplicate one existing Route

2021-03-19 Thread GitBox
codecov-io edited a comment on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-791913462 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] juzhiyuan closed pull request #1622: chore: support Netlify

2021-03-19 Thread GitBox
juzhiyuan closed pull request #1622: URL: https://github.com/apache/apisix-dashboard/pull/1622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1622: chore: support Netlify

2021-03-19 Thread GitBox
juzhiyuan commented on pull request #1622: URL: https://github.com/apache/apisix-dashboard/pull/1622#issuecomment-803241104 closed due to https://github.com/apache/apisix-dashboard/pull/1620 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix-dashboard] JackLiMEM opened a new issue #1623: create route error

2021-03-19 Thread GitBox
JackLiMEM opened a new issue #1623: URL: https://github.com/apache/apisix-dashboard/issues/1623 ![图片](https://user-images.githubusercontent.com/20733031/111858400-993ba780-8973-11eb-8b9d-57389a528ab5.png) -- This is an automated message from the Apache Git Service. To

[apisix-dashboard] branch juzhiyuan-patch-1 updated (35a0483 -> 52d99e3)

2021-03-19 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch juzhiyuan-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 35a0483 chore: support Netlify add 52d99e3 Update netlify.toml No new revisions were

[GitHub] [apisix-dashboard] juzhiyuan opened a new pull request #1622: chore: support Netlify

2021-03-19 Thread GitBox
juzhiyuan opened a new pull request #1622: URL: https://github.com/apache/apisix-dashboard/pull/1622 Please answer these questions before submitting a pull request **Why submit this pull request?** - [x] New feature provided support Netlify to preview FE PRs. -- This is

[apisix-dashboard] branch juzhiyuan-patch-1 created (now 35a0483)

2021-03-19 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch juzhiyuan-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. at 35a0483 chore: support Netlify This branch includes the following new commits: new

[apisix-dashboard] 01/01: chore: support Netlify

2021-03-19 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch juzhiyuan-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git commit 35a0483d37fda040ec8332931d35f06eb8a64384 Author: 琚致远 AuthorDate: Sat Mar 20 11:46:38 2021 +0800

[GitHub] [apisix-dashboard] batman-ezio commented on a change in pull request #1558: feat:Support duplicate one existing Route

2021-03-19 Thread GitBox
batman-ezio commented on a change in pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#discussion_r598056887 ## File path: web/config/routes.ts ## @@ -39,6 +39,10 @@ const routes = [ path: '/routes/:rid/edit', component: './Route/Create',

[GitHub] [apisix-website] bzp2010 edited a comment on pull request #263: feat: broken link checker script

2021-03-19 Thread GitBox
bzp2010 edited a comment on pull request #263: URL: https://github.com/apache/apisix-website/pull/263#issuecomment-803233610 > `.lua` to github original file 樂 I need to try. Due to the problem of not copying other files, the correct file location relationship may not be

[GitHub] [apisix-website] bzp2010 commented on pull request #263: feat: broken link checker script

2021-03-19 Thread GitBox
bzp2010 commented on pull request #263: URL: https://github.com/apache/apisix-website/pull/263#issuecomment-803233610 > `.lua` to github original file 樂 I need to try. Due to problems other than documents that are not copied, the correct file location relationship may not be

[GitHub] [apisix] spacewander edited a comment on issue #3865: bug: Routing priority matching bug

2021-03-19 Thread GitBox
spacewander edited a comment on issue #3865: URL: https://github.com/apache/apisix/issues/3865#issuecomment-803232266 The default router (radixtree_uri) is a path first, host second matcher. If you prefer host first, path second, you can switch to `radixtree_host_uri`:

[GitHub] [apisix] spacewander commented on issue #3865: bug: Routing priority matching bug

2021-03-19 Thread GitBox
spacewander commented on issue #3865: URL: https://github.com/apache/apisix/issues/3865#issuecomment-803232266 The default router (radixtree_uri) is a path first, host second matcher. If you prefer a host first, path second, you can switch to `radixtree_host_uri`:

[GitHub] [apisix-website] juzhiyuan commented on pull request #263: feat: broken link checker script

2021-03-19 Thread GitBox
juzhiyuan commented on pull request #263: URL: https://github.com/apache/apisix-website/pull/263#issuecomment-803231601 `.lua` to github original file 樂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix] Firstsawyou commented on issue #3859: request help: Error: Could not satisfy dependency lua-resty-hmac-ffi 0.05: No results matching query were found for Lua 5.3. make: *** [Makefile

2021-03-19 Thread GitBox
Firstsawyou commented on issue #3859: URL: https://github.com/apache/apisix/issues/3859#issuecomment-803231281 The installation of lua-resty-hmac-ffi depends on lua 5.1, try to install lua 5.1 . -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix-website] bzp2010 commented on pull request #263: feat: broken link checker script

2021-03-19 Thread GitBox
bzp2010 commented on pull request #263: URL: https://github.com/apache/apisix-website/pull/263#issuecomment-803230175 > yes, could we redirect users to the original site? (apisix's GitHub I mean) Redirect no `.md` files to GitHub page? -- This is an automated message from the

[GitHub] [apisix-website] juzhiyuan commented on pull request #263: feat: broken link checker script

2021-03-19 Thread GitBox
juzhiyuan commented on pull request #263: URL: https://github.com/apache/apisix-website/pull/263#issuecomment-803227996 yes, could we redirect users to the original site? (apisix's GitHub I mean) -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix] membphis commented on issue #3873: docs: add more example about how to use the router `radixtree-uri`

2021-03-19 Thread GitBox
membphis commented on issue #3873: URL: https://github.com/apache/apisix/issues/3873#issuecomment-803227176 related issue https://github.com/apache/apisix/issues/3865 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [apisix] membphis opened a new issue #3873: docs: add more example about how to use the router `radixtree-uri`

2021-03-19 Thread GitBox
membphis opened a new issue #3873: URL: https://github.com/apache/apisix/issues/3873 for examples: > eg: 1. different routes with the same values. 2. different routes with the same URI, eg: `/*`. 3. different routes with different URI, eg: `/test/*`, `/*`. help

[GitHub] [apisix-website] bzp2010 edited a comment on pull request #263: feat: broken link checker script

2021-03-19 Thread GitBox
bzp2010 edited a comment on pull request #263: URL: https://github.com/apache/apisix-website/pull/263#issuecomment-803226396 Those `.lua` files were not copied to the document directory, which prevented it from being checked. Therefore, it will be regarded as a broken link. -- This is

[GitHub] [apisix-website] bzp2010 commented on pull request #263: feat: broken link checker script

2021-03-19 Thread GitBox
bzp2010 commented on pull request #263: URL: https://github.com/apache/apisix-website/pull/263#issuecomment-803226396 Those `.lua` files were not copied to the document directory, which prevented it from being checked. -- This is an automated message from the Apache Git Service. To

[GitHub] [apisix] membphis commented on issue #3865: bug: Routing priority matching bug

2021-03-19 Thread GitBox
membphis commented on issue #3865: URL: https://github.com/apache/apisix/issues/3865#issuecomment-803225177 this is not a bug. I confirmed. @ShaoZeMing the router `a`, `b`, `c` have same uri `/*` and `priority`, you'd better to specify a different `priority`. `/test/*` always

[GitHub] [apisix] anyforever commented on issue #3859: request help: Error: Could not satisfy dependency lua-resty-hmac-ffi 0.05: No results matching query were found for Lua 5.3. make: *** [Makefile:

2021-03-19 Thread GitBox
anyforever commented on issue #3859: URL: https://github.com/apache/apisix/issues/3859#issuecomment-803224899 我也出现这个问题,Centos 8下编译。 开始装的lua 5.4,提示不行,退回了5.3,然后 $ cd apisix $ make deps 时,出现此报错 ` Error: Could not satisfy dependency lua-resty-hmac-ffi 0.05: No results

[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #1619: fix: (route_online_debug)Change the appended Content-type data to overlay to ensure that the Content-type is unique

2021-03-19 Thread GitBox
liuxiran edited a comment on pull request #1619: URL: https://github.com/apache/apisix-dashboard/pull/1619#issuecomment-803208395 mark fe e2e errors: * search route error: https://github.com/apache/apisix-dashboard/pull/1619/checks?check_run_id=2146696140 * create-edit-delete

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1558: feat:Support duplicate one existing Route

2021-03-19 Thread GitBox
codecov-io edited a comment on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-791913462 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1558: feat:Support duplicate one existing Route

2021-03-19 Thread GitBox
codecov-io edited a comment on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-791913462 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1558: feat:Support duplicate one existing Route

2021-03-19 Thread GitBox
codecov-io edited a comment on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-791913462 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] liuxiran commented on pull request #1619: fix: (route_online_debug)Change the appended Content-type data to overlay to ensure that the Content-type is unique

2021-03-19 Thread GitBox
liuxiran commented on pull request #1619: URL: https://github.com/apache/apisix-dashboard/pull/1619#issuecomment-803208395 mark fe e2e errors: * search route error: https://github.com/apache/apisix-dashboard/pull/1619/checks?check_run_id=2146696140 * create-edit-delete consumer

[GitHub] [apisix] moonming commented on issue #3865: bug: Routing priority matching bug

2021-03-19 Thread GitBox
moonming commented on issue #3865: URL: https://github.com/apache/apisix/issues/3865#issuecomment-803185212 @membphis @spacewander please take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-dashboard] bisakhmondal commented on issue #1303: Doc: a better doc about how to write and run e2e test and unit test for Backend

2021-03-19 Thread GitBox
bisakhmondal commented on issue #1303: URL: https://github.com/apache/apisix-dashboard/issues/1303#issuecomment-802965217 Thank you for addressing this. Sure, I'll definitely put down the information as much elaborative as I can. -- This is an automated message from the Apache Git

[GitHub] [apisix-dashboard] nic-chen commented on issue #1303: Doc: a better doc about how to write and run e2e test and unit test for Backend

2021-03-19 Thread GitBox
nic-chen commented on issue #1303: URL: https://github.com/apache/apisix-dashboard/issues/1303#issuecomment-802948252 hi, @bisakhmondal Thanks for working on this issue! > Currently the environment setup with docker-compose is not elaborative (back-end-e2e.md), I am

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1576: fix: config proxy-rewrite out of the plugin market in route module

2021-03-19 Thread GitBox
codecov-io edited a comment on pull request #1576: URL: https://github.com/apache/apisix-dashboard/pull/1576#issuecomment-795836615 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1576: fix: config proxy-rewrite out of the plugin market in route module

2021-03-19 Thread GitBox
liuxiran commented on a change in pull request #1576: URL: https://github.com/apache/apisix-dashboard/pull/1576#discussion_r597786636 ## File path: web/src/pages/Route/Create.tsx ## @@ -93,6 +95,10 @@ const Page: React.FC = (props) => { } }, []); + const

[GitHub] [apisix-dashboard] liuxiran commented on pull request #1612: add more fe e2e test cases for online debug

2021-03-19 Thread GitBox
liuxiran commented on pull request #1612: URL: https://github.com/apache/apisix-dashboard/pull/1612#issuecomment-802923650 > still failed https://github.com/apache/apisix-dashboard/pull/1612/checks?check_run_id=2146684625 yep, just waiting for #1619, which has another fe e2e test

[GitHub] [apisix-website] juzhiyuan commented on pull request #263: feat: broken link checker script

2021-03-19 Thread GitBox
juzhiyuan commented on pull request #263: URL: https://github.com/apache/apisix-website/pull/263#issuecomment-802919989 I noticed that there have some files end with `.lua` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1576: fix: config proxy-rewrite out of the plugin market in route module

2021-03-19 Thread GitBox
juzhiyuan commented on a change in pull request #1576: URL: https://github.com/apache/apisix-dashboard/pull/1576#discussion_r597774968 ## File path: web/src/pages/Route/Create.tsx ## @@ -93,6 +95,10 @@ const Page: React.FC = (props) => { } }, []); + const

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1612: add more fe e2e test cases for online debug

2021-03-19 Thread GitBox
juzhiyuan commented on pull request #1612: URL: https://github.com/apache/apisix-dashboard/pull/1612#issuecomment-802918581 still failed https://github.com/apache/apisix-dashboard/pull/1612/checks?check_run_id=2146684625 -- This is an automated message from the Apache Git Service. To

[GitHub] [apisix] Firstsawyou edited a comment on issue #3865: bug: Routing priority matching bug

2021-03-19 Thread GitBox
Firstsawyou edited a comment on issue #3865: URL: https://github.com/apache/apisix/issues/3865#issuecomment-802893821 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1303: Doc: a better doc about how to write and run e2e test and unit test for Backend

2021-03-19 Thread GitBox
juzhiyuan commented on issue #1303: URL: https://github.com/apache/apisix-dashboard/issues/1303#issuecomment-802916573 cc @nic-chen @starsz to help @bisakhmondal -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix-dashboard] bisakhmondal commented on issue #1303: Doc: a better doc about how to write and run e2e test and unit test for Backend

2021-03-19 Thread GitBox
bisakhmondal commented on issue #1303: URL: https://github.com/apache/apisix-dashboard/issues/1303#issuecomment-802913757 Hey guys!! Interested in working on this issue. Could you please elaborate, how do we wish to help the newcomer? for eg. 1. Currently the environment setup with

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1604: fix: fix the button margin space

2021-03-19 Thread GitBox
codecov-io commented on pull request #1604: URL: https://github.com/apache/apisix-dashboard/pull/1604#issuecomment-802904399 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1604?src=pr=h1) Report > Merging

[GitHub] [apisix] Firstsawyou commented on issue #3865: bug: Routing priority matching bug

2021-03-19 Thread GitBox
Firstsawyou commented on issue #3865: URL: https://github.com/apache/apisix/issues/3865#issuecomment-802893821 Hi, @ShaoZeMing Thank you for your report. After testing, I found that there are problems with the use of `hsot + header` and `host` when different routes have the same uri.

[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1597: test: add the create and delete plugin in drawer

2021-03-19 Thread GitBox
guoqqqi commented on pull request #1597: URL: https://github.com/apache/apisix-dashboard/pull/1597#issuecomment-802855150 Hi,you can find it in the Create, Configure Plugin step. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix-dashboard] stu01509 commented on pull request #1597: test: add the create and delete plugin in drawer

2021-03-19 Thread GitBox
stu01509 commented on pull request #1597: URL: https://github.com/apache/apisix-dashboard/pull/1597#issuecomment-802847983 > Hi, We need to test the functionality not only on the plug-in page but also on the route page and the service page to make sure it works. Hi Actually,

[GitHub] [apisix] moonming commented on a change in pull request #3871: docs: admin-api.md document adds configuration https example

2021-03-19 Thread GitBox
moonming commented on a change in pull request #3871: URL: https://github.com/apache/apisix/pull/3871#discussion_r597679185 ## File path: docs/en/latest/admin-api.md ## @@ -657,12 +659,32 @@ After the execution is successful, nodes will not retain the original data, and

[GitHub] [apisix-dashboard] bzp2010 commented on a change in pull request #1576: fix: config proxy-rewrite out of the plugin market in route module

2021-03-19 Thread GitBox
bzp2010 commented on a change in pull request #1576: URL: https://github.com/apache/apisix-dashboard/pull/1576#discussion_r597677125 ## File path: web/src/pages/Route/Create.tsx ## @@ -93,6 +95,10 @@ const Page: React.FC = (props) => { } }, []); + const

[GitHub] [apisix-website] bzp2010 commented on pull request #263: feat: broken link checker script

2021-03-19 Thread GitBox
bzp2010 commented on pull request #263: URL: https://github.com/apache/apisix-website/pull/263#issuecomment-802828050 Updated 2021-3-19 - add local markdown file checking function Tips - links starting with `http://` or `https://` and ending with `.md` are checked

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1584: feat: save Service list page's meta status

2021-03-19 Thread GitBox
codecov-io edited a comment on pull request #1584: URL: https://github.com/apache/apisix-dashboard/pull/1584#issuecomment-797880776 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr=h1) Report > Merging

[GitHub] [apisix] juzhiyuan commented on a change in pull request #3871: docs: admin-api.md document adds configuration https example

2021-03-19 Thread GitBox
juzhiyuan commented on a change in pull request #3871: URL: https://github.com/apache/apisix/pull/3871#discussion_r597657304 ## File path: docs/en/latest/admin-api.md ## @@ -571,12 +571,16 @@ Config Example: "key": "", "name": "upstream-for-test", "desc": "hello

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1482: how to delete the historical version of the APISIX node.

2021-03-19 Thread GitBox
juzhiyuan commented on issue #1482: URL: https://github.com/apache/apisix-dashboard/issues/1482#issuecomment-802814756 Good design  But I'm still concerned if we have necessary to add this API? let's wait for others :) -- This is an automated message from the Apache Git Service. To

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1589: feat: searching upstream by users input while creating new routes

2021-03-19 Thread GitBox
juzhiyuan commented on pull request #1589: URL: https://github.com/apache/apisix-dashboard/pull/1589#issuecomment-802813367 > > LGTM for the code , it would be better to add test case for this nice new feature > > Thanks. Yeah, it's a nice but really minor addition to the codebase.

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1601: feat: add rawDataEditor in route

2021-03-19 Thread GitBox
juzhiyuan commented on pull request #1601: URL: https://github.com/apache/apisix-dashboard/pull/1601#issuecomment-802813000 also cc @guoqqqi to review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1597: test: add the create and delete plugin in drawer

2021-03-19 Thread GitBox
juzhiyuan commented on a change in pull request #1597: URL: https://github.com/apache/apisix-dashboard/pull/1597#discussion_r597654278 ## File path: web/cypress/integration/plugin/create-delete-in-drawer-plugin.spec.js ## @@ -45,7 +45,6 @@ context('Create and Delete Plugin

[GitHub] [apisix] juzhiyuan commented on issue #3865: bug: Routing priority matching bug

2021-03-19 Thread GitBox
juzhiyuan commented on issue #3865: URL: https://github.com/apache/apisix/issues/3865#issuecomment-802810667 @ShaoZeMing Thanks for your report, that's the data we need. @Firstsawyou will follow and reply to this issue once he finds out what happened. -- This is an automated message

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1620: feat: update yarn.lock

2021-03-19 Thread GitBox
juzhiyuan commented on pull request #1620: URL: https://github.com/apache/apisix-dashboard/pull/1620#issuecomment-802809346 Once this PR merged, Netlify will pass. This PR mainly fixes the wrong download links in yarn.lock. -- This is an automated message from the Apache Git Service. To

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1620: feat: update yarn.lock

2021-03-19 Thread GitBox
juzhiyuan commented on pull request #1620: URL: https://github.com/apache/apisix-dashboard/pull/1620#issuecomment-802808974 @nic-chen @LiteSun Hi, Netlify is not required before merging. Please fix the FE E2E first. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [apisix-website] guoqqqi closed pull request #265: feat: added the ApacheCon in APISIX

2021-03-19 Thread GitBox
guoqqqi closed pull request #265: URL: https://github.com/apache/apisix-website/pull/265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [apisix-website] guoqqqi opened a new pull request #265: feat: added the ApacheCon in APISIX

2021-03-19 Thread GitBox
guoqqqi opened a new pull request #265: URL: https://github.com/apache/apisix-website/pull/265 Changes: added the ApacheCon in APISIX. ![image](https://user-images.githubusercontent.com/72343596/111778080-1b35bd00-88ef-11eb-967b-6a9542317e4e.png) -- This is an

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1584: feat: save Service list page's meta status

2021-03-19 Thread GitBox
codecov-io edited a comment on pull request #1584: URL: https://github.com/apache/apisix-dashboard/pull/1584#issuecomment-797880776 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr=h1) Report > Merging

[GitHub] [apisix] spacewander commented on a change in pull request #3848: feat: add dump for consul_kv

2021-03-19 Thread GitBox
spacewander commented on a change in pull request #3848: URL: https://github.com/apache/apisix/pull/3848#discussion_r597598980 ## File path: apisix/discovery/consul_kv.lua ## @@ -244,7 +244,7 @@ end local function read_dump_srvs() local data, err =

[GitHub] [apisix-dashboard] guoqqqi opened a new issue #1621: feat: Related

2021-03-19 Thread GitBox
guoqqqi opened a new issue #1621: URL: https://github.com/apache/apisix-dashboard/issues/1621 # Feature request Related #1584 Currently, a paginator has been added to each listing page and it is hoped that this state paginator can be made into a component that can be easily

[GitHub] [apisix] Firstsawyou commented on issue #3865: bug: Routing priority matching bug

2021-03-19 Thread GitBox
Firstsawyou commented on issue #3865: URL: https://github.com/apache/apisix/issues/3865#issuecomment-802756878 > Hi, Here are the routing rules a, b, c, d @ShaoZeMing Thank you for the information, I will reproduce it later. -- This is an automated message from the Apache Git

[GitHub] [apisix-dashboard] bisakhmondal commented on a change in pull request #1615: feat: manual deletion of apisix node data

2021-03-19 Thread GitBox
bisakhmondal commented on a change in pull request #1615: URL: https://github.com/apache/apisix-dashboard/pull/1615#discussion_r597597026 ## File path: api/test/e2e/server_info_delete_test.go ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [apisix-dashboard] LiteSun commented on pull request #1620: feat: update yarn.lock

2021-03-19 Thread GitBox
LiteSun commented on pull request #1620: URL: https://github.com/apache/apisix-dashboard/pull/1620#issuecomment-802755794 > ![image](https://user-images.githubusercontent.com/33000667/111769664-71e9c980-88e4-11eb-979d-ef267815eea0.png) > > These checks suddenly appear today and

[GitHub] [apisix-dashboard] nic-chen commented on issue #1482: how to delete the historical version of the APISIX node.

2021-03-19 Thread GitBox
nic-chen commented on issue #1482: URL: https://github.com/apache/apisix-dashboard/issues/1482#issuecomment-802751148 @bisakhmondal Great! Thanks for sharing your thoughts. I think we can discuss further. But in version 2.5 we could prompt the user first. -- This is

[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #1584: feat: save Service list page's meta status

2021-03-19 Thread GitBox
guoqqqi commented on a change in pull request #1584: URL: https://github.com/apache/apisix-dashboard/pull/1584#discussion_r597591311 ## File path: web/cypress/integration/service/save-paginator-status.spec.js ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software

[GitHub] [apisix] Firstsawyou commented on pull request #3871: docs: admin-api.md document adds configuration https example

2021-03-19 Thread GitBox
Firstsawyou commented on pull request #3871: URL: https://github.com/apache/apisix/pull/3871#issuecomment-802747734 @moonming Please have a look when you are free. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1615: feat: manual deletion of apisix node data

2021-03-19 Thread GitBox
nic-chen commented on a change in pull request #1615: URL: https://github.com/apache/apisix-dashboard/pull/1615#discussion_r597591008 ## File path: api/test/e2e/server_info_delete_test.go ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1620: feat: update yarn.lock

2021-03-19 Thread GitBox
nic-chen commented on pull request #1620: URL: https://github.com/apache/apisix-dashboard/pull/1620#issuecomment-802739969 ![image](https://user-images.githubusercontent.com/33000667/111769664-71e9c980-88e4-11eb-979d-ef267815eea0.png) These checks suddenly appear today and every

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1597: test: add the create and delete plugin in drawer

2021-03-19 Thread GitBox
nic-chen commented on pull request #1597: URL: https://github.com/apache/apisix-dashboard/pull/1597#issuecomment-802733202 ping @stu01509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] ShaoZeMing commented on issue #3865: bug: Routing priority matching bug

2021-03-19 Thread GitBox
ShaoZeMing commented on issue #3865: URL: https://github.com/apache/apisix/issues/3865#issuecomment-802732450 Hi, Here are the routing rules a, b, c, d router a: ``` { "code":0, "message":"", "data":{ "id":"346524199914832835",

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1584: feat: save Service list page's meta status

2021-03-19 Thread GitBox
nic-chen commented on a change in pull request #1584: URL: https://github.com/apache/apisix-dashboard/pull/1584#discussion_r597570655 ## File path: web/cypress/integration/service/save-paginator-status.spec.js ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software

  1   2   >