[GitHub] [apisix] ShaoZeMing commented on issue #3865: bug: Routing priority matching bug

2021-03-19 Thread GitBox
ShaoZeMing commented on issue #3865: URL: https://github.com/apache/apisix/issues/3865#issuecomment-802728346 > @ShaoZeMing Hi, thanks for your report, let's try to resolve your issue. And please try the following steps: > > In dashboard 2.4, we don't support showing route

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1615: feat: manual deletion of apisix node data

2021-03-19 Thread GitBox
starsz commented on a change in pull request #1615: URL: https://github.com/apache/apisix-dashboard/pull/1615#discussion_r597560799 ## File path: api/test/e2e/server_info_delete_test.go ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1615: feat: manual deletion of apisix node data

2021-03-19 Thread GitBox
starsz commented on a change in pull request #1615: URL: https://github.com/apache/apisix-dashboard/pull/1615#discussion_r597560799 ## File path: api/test/e2e/server_info_delete_test.go ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [apisix-dashboard] Jaycean commented on pull request #1619: fix: (route_online_debug)Change the appended Content-type data to overlay to ensure that the Content-type is unique

2021-03-19 Thread GitBox
Jaycean commented on pull request #1619: URL: https://github.com/apache/apisix-dashboard/pull/1619#issuecomment-802708104 cc @liuxiran @LiteSun @juzhiyuan FE CI Failed PTAL. Thks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix-dashboard] liuxiran commented on pull request #1612: add more fe e2e test cases for online debug

2021-03-19 Thread GitBox
liuxiran commented on pull request #1612: URL: https://github.com/apache/apisix-dashboard/pull/1612#issuecomment-802700710 also cc @guoqqqi to review when you have time, thanks a lot -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix] yongboy commented on a change in pull request #3848: feat: add dump for consul_kv

2021-03-19 Thread GitBox
yongboy commented on a change in pull request #3848: URL: https://github.com/apache/apisix/pull/3848#discussion_r597519487 ## File path: apisix/discovery/consul_kv.lua ## @@ -244,7 +244,7 @@ end local function read_dump_srvs() local data, err =

[GitHub] [apisix-dashboard] liuxiran commented on pull request #1612: add more fe e2e test cases for online debug

2021-03-19 Thread GitBox
liuxiran commented on pull request #1612: URL: https://github.com/apache/apisix-dashboard/pull/1612#issuecomment-802684898 https://github.com/apache/apisix-dashboard/pull/1612/checks?check_run_id=2146684625 just waiting for #1619 to solve this ci error -- This is an automated message

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1612: add more fe e2e test cases for online debug

2021-03-19 Thread GitBox
liuxiran commented on a change in pull request #1612: URL: https://github.com/apache/apisix-dashboard/pull/1612#discussion_r597520254 ## File path: web/cypress/fixtures/route-json-data.json ## @@ -0,0 +1,30 @@ +{ + "debugPostJson": { +"name": "test_https", +"status":

[GitHub] [apisix] yongboy commented on a change in pull request #3848: feat: add dump for consul_kv

2021-03-19 Thread GitBox
yongboy commented on a change in pull request #3848: URL: https://github.com/apache/apisix/pull/3848#discussion_r597519487 ## File path: apisix/discovery/consul_kv.lua ## @@ -244,7 +244,7 @@ end local function read_dump_srvs() local data, err =

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1619: fix: (route_online_debug)Change the appended Content-type data to overlay to ensure that the Content-type is unique

2021-03-19 Thread GitBox
codecov-io edited a comment on pull request #1619: URL: https://github.com/apache/apisix-dashboard/pull/1619#issuecomment-802512861 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1619?src=pr=h1) Report > Merging

[GitHub] [apisix] spacewander opened a new pull request #3872: test: use longer timeout for internet DNS query

2021-03-19 Thread GitBox
spacewander opened a new pull request #3872: URL: https://github.com/apache/apisix/pull/3872 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1619: fix: (route_online_debug)Change the appended Content-type data to overlay to ensure that the Content-type is unique

2021-03-19 Thread GitBox
codecov-io edited a comment on pull request #1619: URL: https://github.com/apache/apisix-dashboard/pull/1619#issuecomment-802512861 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1619?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1612: add more fe e2e test cases for online debug

2021-03-19 Thread GitBox
codecov-io edited a comment on pull request #1612: URL: https://github.com/apache/apisix-dashboard/pull/1612#issuecomment-801563633 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr=h1) Report > Merging

[apisix-dashboard] branch master updated (f4f27d1 -> 1ba32d9)

2021-03-19 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from f4f27d1 feat: check if the service is used by route when deleting (#1598) add 1ba32d9 feat:

[GitHub] [apisix-dashboard] membphis merged pull request #1617: feat: remove unnecessary cookie session

2021-03-19 Thread GitBox
membphis merged pull request #1617: URL: https://github.com/apache/apisix-dashboard/pull/1617 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [apisix-dashboard] membphis closed issue #1609: Backend API Cookie secret

2021-03-19 Thread GitBox
membphis closed issue #1609: URL: https://github.com/apache/apisix-dashboard/issues/1609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [apisix] spacewander commented on a change in pull request #3848: feat: add dump for consul_kv

2021-03-19 Thread GitBox
spacewander commented on a change in pull request #3848: URL: https://github.com/apache/apisix/pull/3848#discussion_r597481993 ## File path: apisix/discovery/consul_kv.lua ## @@ -244,7 +244,7 @@ end local function read_dump_srvs() local data, err =

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1619: fix: (route_online_debug)Change the appended Content-type data to overlay to ensure that the Content-type is unique

2021-03-19 Thread GitBox
codecov-io edited a comment on pull request #1619: URL: https://github.com/apache/apisix-dashboard/pull/1619#issuecomment-802512861 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1619?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1620: feat: update yarn.lock

2021-03-19 Thread GitBox
codecov-io edited a comment on pull request #1620: URL: https://github.com/apache/apisix-dashboard/pull/1620#issuecomment-802638797 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1620: feat: update yarn.lock

2021-03-19 Thread GitBox
codecov-io commented on pull request #1620: URL: https://github.com/apache/apisix-dashboard/pull/1620#issuecomment-802638797 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr=h1) Report > Merging

[GitHub] [apisix] Firstsawyou commented on issue #3865: bug: Routing priority matching bug

2021-03-19 Thread GitBox
Firstsawyou commented on issue #3865: URL: https://github.com/apache/apisix/issues/3865#issuecomment-802634629 > @Firstsawyou > > [#3865 (comment)](https://github.com/apache/apisix/issues/3865#issuecomment-802452402) is exported as `OpenAPI v3`. okay. -- This is an

[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1589: feat: searching upstream by users input while creating new routes

2021-03-19 Thread GitBox
bisakhmondal commented on pull request #1589: URL: https://github.com/apache/apisix-dashboard/pull/1589#issuecomment-802631419 > LGTM for the code , it would be better to add test case for this nice new feature Thanks. Yeah, it's a nice but really minor addition to the codebase. Hey

[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #1576: fix: config proxy-rewrite out of the plugin market in route module

2021-03-19 Thread GitBox
liuxiran edited a comment on pull request #1576: URL: https://github.com/apache/apisix-dashboard/pull/1576#issuecomment-802621063 > @liuxiran just ignored it, Netlify still has some issues to resolve, I'm working on it. got it, thanks. then since all the errors fixed, please

[GitHub] [apisix-dashboard] liuxiran commented on pull request #1576: fix: config proxy-rewrite out of the plugin market in route module

2021-03-19 Thread GitBox
liuxiran commented on pull request #1576: URL: https://github.com/apache/apisix-dashboard/pull/1576#issuecomment-802621063 > @liuxiran just ignored it, Netlify still has some issues to resolve, I'm working on it. got > @liuxiran just ignored it, Netlify still has some issues

[GitHub] [apisix-dashboard] bisakhmondal commented on issue #1482: how to delete the historical version of the APISIX node.

2021-03-19 Thread GitBox
bisakhmondal commented on issue #1482: URL: https://github.com/apache/apisix-dashboard/issues/1482#issuecomment-802620825 > Hi, after discuss with @nic-chen @starsz @LiteSun, we have a new way to support this feature. > > How about only adding one extra message that tells users:

[GitHub] [apisix-dashboard] LiteSun opened a new pull request #1620: feat: update yarn.lock

2021-03-19 Thread GitBox
LiteSun opened a new pull request #1620: URL: https://github.com/apache/apisix-dashboard/pull/1620 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [x] Improve performance - [ ]

[GitHub] [apisix] Firstsawyou opened a new pull request #3871: docs: admin-api.md document adds configuration https example

2021-03-19 Thread GitBox
Firstsawyou opened a new pull request #3871: URL: https://github.com/apache/apisix/pull/3871 ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ]

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1576: fix: config proxy-rewrite out of the plugin market in route module

2021-03-19 Thread GitBox
juzhiyuan commented on pull request #1576: URL: https://github.com/apache/apisix-dashboard/pull/1576#issuecomment-802617293 @liuxiran just ignored it, Netlify still has some issues to resolve, I'm working on it. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [apisix-dashboard] liuxiran commented on pull request #1576: fix: config proxy-rewrite out of the plugin market in route module

2021-03-19 Thread GitBox
liuxiran commented on pull request #1576: URL: https://github.com/apache/apisix-dashboard/pull/1576#issuecomment-802616705 ![Screenshot_20210319_150946](https://user-images.githubusercontent.com/2561857/111743827-368bd280-88c5-11eb-9115-f388d92b13fa.jpg)

[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #308: feat: traffic split

2021-03-19 Thread GitBox
codecov-io edited a comment on pull request #308: URL: https://github.com/apache/apisix-ingress-controller/pull/308#issuecomment-802563470 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/308?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1601: feat: add rawDataEditor in route

2021-03-19 Thread GitBox
codecov-io edited a comment on pull request #1601: URL: https://github.com/apache/apisix-dashboard/pull/1601#issuecomment-800291441 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1601?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1601: feat: add rawDataEditor in route

2021-03-19 Thread GitBox
codecov-io edited a comment on pull request #1601: URL: https://github.com/apache/apisix-dashboard/pull/1601#issuecomment-800291441 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1601?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1601: feat: add rawDataEditor in route

2021-03-19 Thread GitBox
codecov-io edited a comment on pull request #1601: URL: https://github.com/apache/apisix-dashboard/pull/1601#issuecomment-800291441 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1601?src=pr=h1) Report > Merging

[GitHub] [apisix-ingress-controller] tokers opened a new issue #309: We should clarify the compatibility between APISIX and apisix-ingress-controller

2021-03-19 Thread GitBox
tokers opened a new issue #309: URL: https://github.com/apache/apisix-ingress-controller/issues/309 We don't have any documents to tell users the compatibility between APISIX and apisix-ingress-controller. It's better to keep a record of this relationship between them, so people won't

[GitHub] [apisix-docker] gxthrj commented on a change in pull request #152: feat: add apisix-dashboard dockerfile & CI

2021-03-19 Thread GitBox
gxthrj commented on a change in pull request #152: URL: https://github.com/apache/apisix-docker/pull/152#discussion_r597449561 ## File path: compose/dashboard-compose.yaml ## @@ -0,0 +1,35 @@ +version: "3" Review comment: docker-compose.yaml already have dashboard

[GitHub] [apisix] juzhiyuan commented on issue #3851: The upstrem configuration rewrite and upstrem_host in the traffic-split plug-in did not take effect correctly

2021-03-19 Thread GitBox
juzhiyuan commented on issue #3851: URL: https://github.com/apache/apisix/issues/3851#issuecomment-802606898 We Apache community build software shared by the global world, and welcome anyone to use and give feedback. -- This is an automated message from the Apache Git Service. To

[GitHub] [apisix-dashboard] LiteSun commented on pull request #1597: test: add the create and delete plugin in drawer

2021-03-19 Thread GitBox
LiteSun commented on pull request #1597: URL: https://github.com/apache/apisix-dashboard/pull/1597#issuecomment-802603911 ping~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [apisix] Firstsawyou opened a new pull request #3870: feat(traffic-split): the upstream pass_host needs to support IP mode

2021-03-19 Thread GitBox
Firstsawyou opened a new pull request #3870: URL: https://github.com/apache/apisix/pull/3870 fix #3851 ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been

[GitHub] [apisix] juzhiyuan commented on issue #3865: bug: Routing priority matching bug

2021-03-19 Thread GitBox
juzhiyuan commented on issue #3865: URL: https://github.com/apache/apisix/issues/3865#issuecomment-802600363 @Firstsawyou https://github.com/apache/apisix/issues/3865#issuecomment-802452402 is exported as `OpenAPI v3`. -- This is an automated message from the Apache Git Service.

[GitHub] [apisix] juzhiyuan commented on issue #3865: bug: Routing priority matching bug

2021-03-19 Thread GitBox
juzhiyuan commented on issue #3865: URL: https://github.com/apache/apisix/issues/3865#issuecomment-802599858 @ShaoZeMing Hi, thanks for your report, let's try to resolve your issue. And please try the following steps: In dashboard 2.4, we don't support showing route configuration

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1615: feat: manual deletion of apisix node data

2021-03-19 Thread GitBox
juzhiyuan commented on pull request #1615: URL: https://github.com/apache/apisix-dashboard/pull/1615#issuecomment-802595331 Hi, @bisakhmondal, what do you think of this solution? https://github.com/apache/apisix-dashboard/issues/1482#issuecomment-802523508 -- This is an automated

[GitHub] [apisix] ShaoZeMing commented on issue #3865: bug: Routing priority matching bug

2021-03-19 Thread GitBox
ShaoZeMing commented on issue #3865: URL: https://github.com/apache/apisix/issues/3865#issuecomment-802589320 > > > Your configuration data looks strange. It seems that the field names of apisix have been modified? > > > > > > Sorry i didn't understand you too much > >

[GitHub] [apisix] nanamikon closed issue #3858: bug: When using traffic-split , the key of chash is missing in the upstream of traffic-split

2021-03-19 Thread GitBox
nanamikon closed issue #3858: URL: https://github.com/apache/apisix/issues/3858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #308: feat: traffic split

2021-03-19 Thread GitBox
codecov-io edited a comment on pull request #308: URL: https://github.com/apache/apisix-ingress-controller/pull/308#issuecomment-802563470 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/308?src=pr=h1) Report > Merging

[GitHub] [apisix] Firstsawyou removed a comment on issue #3865: bug: Routing priority matching bug

2021-03-19 Thread GitBox
Firstsawyou removed a comment on issue #3865: URL: https://github.com/apache/apisix/issues/3865#issuecomment-802582618 > > Your configuration data looks strange. It seems that the field names of apisix have been modified? > > Sorry i didn't understand you too much There are

[GitHub] [apisix] Firstsawyou commented on issue #3865: bug: Routing priority matching bug

2021-03-19 Thread GitBox
Firstsawyou commented on issue #3865: URL: https://github.com/apache/apisix/issues/3865#issuecomment-802582617 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

<    1   2