[GitHub] [apisix] spacewander commented on issue #4177: request help: I need tcp upstream connection result as a response to tcp client

2021-05-03 Thread GitBox
spacewander commented on issue #4177: URL: https://github.com/apache/apisix/issues/4177#issuecomment-831722705 This feature is not supported by Nginx's stream subsystem's proxy_pass. But you can implement the proxy feature in Lua via `ngx.socket.tcp` and achieve it. -- This is an auto

[GitHub] [apisix] iamayushdas edited a comment on issue #4150: bug: Inconsistent behavior of schema check for response-rewrite plugin between AdminAPI and ManagerAPI

2021-05-03 Thread GitBox
iamayushdas edited a comment on issue #4150: URL: https://github.com/apache/apisix/issues/4150#issuecomment-831675431 @imjoey i guess the issue is resolved now, you can close the issue now -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [apisix] spacewander commented on a change in pull request #4175: docs: fix broken links and ids in plugins

2021-05-03 Thread GitBox
spacewander commented on a change in pull request #4175: URL: https://github.com/apache/apisix/pull/4175#discussion_r625542469 ## File path: docs/en/latest/config.json ## @@ -162,6 +162,13 @@ "discovery/eureka" ] }, +{ + "type":

[GitHub] [apisix] tokers commented on issue #4150: bug: Inconsistent behavior of schema check for response-rewrite plugin between AdminAPI and ManagerAPI

2021-05-03 Thread GitBox
tokers commented on issue #4150: URL: https://github.com/apache/apisix/issues/4150#issuecomment-831718141 ping @imjoey -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [apisix] spacewander commented on a change in pull request #4175: docs: fix broken links and ids in plugins

2021-05-03 Thread GitBox
spacewander commented on a change in pull request #4175: URL: https://github.com/apache/apisix/pull/4175#discussion_r625541979 ## File path: docs/en/latest/config.json ## @@ -162,6 +162,13 @@ "discovery/eureka" ] }, +{ + "type":

[GitHub] [apisix] KishaniKandasamy commented on a change in pull request #4175: docs: fix broken links and ids in plugins

2021-05-03 Thread GitBox
KishaniKandasamy commented on a change in pull request #4175: URL: https://github.com/apache/apisix/pull/4175#discussion_r625540565 ## File path: docs/en/latest/config.json ## @@ -162,6 +162,13 @@ "discovery/eureka" ] }, +{ + "t

[GitHub] [apisix-website] netlify[bot] commented on pull request #328: docs: fixed kubernetes service api broken link

2021-05-03 Thread GitBox
netlify[bot] commented on pull request #328: URL: https://github.com/apache/apisix-website/pull/328#issuecomment-831715603 Deploy preview for *apisix* processing. Building with commit b70a6a33beacc4747b94ac25ed8a5801e1da688c https://app.netlify.com/sites/apisix/deploys/6090ec02

[GitHub] [apisix-website] xdshivani opened a new pull request #328: docs: fixed kubernetes service api broken link

2021-05-03 Thread GitBox
xdshivani opened a new pull request #328: URL: https://github.com/apache/apisix-website/pull/328 Fixes: #326 Changes: fixed kubernetes service api broken link Thankyou @iamayushdas for making me understand architecture of apisix-website. Here is my first PR Have a

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor

2021-05-03 Thread GitBox
netlify[bot] edited a comment on pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997 Deploy preview for *apisix-dashboard* processing. Building with commit 82933979330ff234b9dc20c2e3b7812e178323ec https://app.netlify.com/sites/a

[GitHub] [apisix-dashboard] tokers commented on a change in pull request #1814: fix: store init error from etcd and deferred execution of closers

2021-05-03 Thread GitBox
tokers commented on a change in pull request #1814: URL: https://github.com/apache/apisix-dashboard/pull/1814#discussion_r625537043 ## File path: api/cmd/managerapi.go ## @@ -65,6 +66,14 @@ func printVersion() { // NewManagerAPICommand creates the manager-api command. func

[GitHub] [apisix] zhangwenjian opened a new issue #4177: request help: I need tcp upstream connection result as a response to tcp client

2021-05-03 Thread GitBox
zhangwenjian opened a new issue #4177: URL: https://github.com/apache/apisix/issues/4177 ### Issue description I use openresty as my tcp protocol gateway, you can imagine that is a rdp gateway. The tcp client will send final server ip address after connected with gateway, and the bal

[GitHub] [apisix-website] iamayushdas commented on issue #326: docs: many broken links our residing in website

2021-05-03 Thread GitBox
iamayushdas commented on issue #326: URL: https://github.com/apache/apisix-website/issues/326#issuecomment-831698099 @xdshivani would you like to work in this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix] iamayushdas removed a comment on pull request #4175: docs: fix broken links and ids in plugins

2021-05-03 Thread GitBox
iamayushdas removed a comment on pull request #4175: URL: https://github.com/apache/apisix/pull/4175#issuecomment-831686349 @KishaniKandasamy what do you think about adding or nesting it into authentication -> hmac-auth -> Signature generate example, or you can add a section of example

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1816: feat: Use monaco editor

2021-05-03 Thread GitBox
codecov-commenter edited a comment on pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-826045073 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix] spacewander commented on a change in pull request #4175: docs: fix broken links and ids in plugins

2021-05-03 Thread GitBox
spacewander commented on a change in pull request #4175: URL: https://github.com/apache/apisix/pull/4175#discussion_r625513277 ## File path: docs/en/latest/config.json ## @@ -162,6 +162,13 @@ "discovery/eureka" ] }, +{ + "type":

[GitHub] [apisix] iamayushdas edited a comment on pull request #4175: docs: fix broken links and ids in plugins

2021-05-03 Thread GitBox
iamayushdas edited a comment on pull request #4175: URL: https://github.com/apache/apisix/pull/4175#issuecomment-831686349 @KishaniKandasamy what do you think about adding or nesting it into authentication -> hmac-auth -> Signature generate example, or you can add a section of example a

[GitHub] [apisix] iamayushdas commented on pull request #4175: docs: fix broken links and ids in plugins

2021-05-03 Thread GitBox
iamayushdas commented on pull request #4175: URL: https://github.com/apache/apisix/pull/4175#issuecomment-831686349 @KishaniKandasamy what do you think about adding or nesting it into authentication -> hmac-auth -> Signature generate example -- This is an automated message from the Apach

[GitHub] [apisix] spacewander commented on a change in pull request #4175: docs: fix broken links and ids in plugins

2021-05-03 Thread GitBox
spacewander commented on a change in pull request #4175: URL: https://github.com/apache/apisix/pull/4175#discussion_r625512291 ## File path: docs/en/latest/plugins/authz-keycloak.md ## @@ -42,9 +42,9 @@ For more information on Keycloak, refer to [Keycloak Authorization Docs](h

[GitHub] [apisix] spacewander closed issue #3719: I switched the resolver to lua-resty-dns-client, I found a problem. At present, after using this dns client, upstream services can implement dns searc

2021-05-03 Thread GitBox
spacewander closed issue #3719: URL: https://github.com/apache/apisix/issues/3719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [apisix] spacewander merged pull request #4114: feat: patch tcp.sock.connect to use our DNS resolver

2021-05-03 Thread GitBox
spacewander merged pull request #4114: URL: https://github.com/apache/apisix/pull/4114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[apisix] branch master updated: feat: patch tcp.sock.connect to use our DNS resolver (#4114)

2021-05-03 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new f914807 feat: patch tcp.sock.connect to us

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor

2021-05-03 Thread GitBox
netlify[bot] edited a comment on pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997 Deploy preview for *apisix-dashboard* processing. Building with commit 9e0f7cbbda126e23d67ef8b811174a647e1bc71b https://app.netlify.com/sites/a

[GitHub] [apisix] KishaniKandasamy commented on a change in pull request #4175: docs: fix broken links and ids in plugins

2021-05-03 Thread GitBox
KishaniKandasamy commented on a change in pull request #4175: URL: https://github.com/apache/apisix/pull/4175#discussion_r625503789 ## File path: docs/en/latest/config.json ## @@ -162,6 +162,13 @@ "discovery/eureka" ] }, +{ + "t

[GitHub] [apisix] iamayushdas commented on issue #4150: bug: Inconsistent behavior of schema check for response-rewrite plugin between AdminAPI and ManagerAPI

2021-05-03 Thread GitBox
iamayushdas commented on issue #4150: URL: https://github.com/apache/apisix/issues/4150#issuecomment-831675431 i guess the issue is resolved now, you can close the issue now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix] KishaniKandasamy commented on a change in pull request #4175: docs: fix broken links and ids in plugins

2021-05-03 Thread GitBox
KishaniKandasamy commented on a change in pull request #4175: URL: https://github.com/apache/apisix/pull/4175#discussion_r625500678 ## File path: docs/en/latest/plugins/skywalking.md ## @@ -101,7 +101,7 @@ plugin_attr: skywalking: service_name: APISIX service_insta

[GitHub] [apisix] KishaniKandasamy commented on a change in pull request #4175: docs: fix broken links and ids in plugins

2021-05-03 Thread GitBox
KishaniKandasamy commented on a change in pull request #4175: URL: https://github.com/apache/apisix/pull/4175#discussion_r625500422 ## File path: docs/en/latest/plugins/authz-keycloak.md ## @@ -42,9 +42,9 @@ For more information on Keycloak, refer to [Keycloak Authorization Do

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1816: feat: Use monaco editor

2021-05-03 Thread GitBox
codecov-commenter edited a comment on pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-826045073 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] qian0817 commented on a change in pull request #1816: feat: Use monaco editor

2021-05-03 Thread GitBox
qian0817 commented on a change in pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#discussion_r625499416 ## File path: web/src/components/Plugin/PluginDetail.tsx ## @@ -190,49 +188,53 @@ const PluginDetail: React.FC = ({ }); }); }; -

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor

2021-05-03 Thread GitBox
netlify[bot] edited a comment on pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997 Deploy preview for *apisix-dashboard* processing. Building with commit 041ece3912df45eff04b7a2ac75a3f36eeecb86a https://app.netlify.com/sites/a

[GitHub] [apisix-dashboard] qian0817 commented on a change in pull request #1816: feat: Use monaco editor

2021-05-03 Thread GitBox
qian0817 commented on a change in pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#discussion_r625496911 ## File path: web/package.json ## @@ -131,7 +132,8 @@ "prettier": "^2.0.1", "pro-download": "1.0.1", "puppeteer-core": "^4.0.1",

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor

2021-05-03 Thread GitBox
netlify[bot] edited a comment on pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997 Deploy preview for *apisix-dashboard* processing. Building with commit c46fb025971884142ac9c6ca490cdba162527d0a https://app.netlify.com/sites/a

[GitHub] [apisix] membphis merged pull request #4163: feat: step 3, manage the plugin runner

2021-05-03 Thread GitBox
membphis merged pull request #4163: URL: https://github.com/apache/apisix/pull/4163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[apisix] branch master updated: feat: step 3, manage the plugin runner (#4163)

2021-05-03 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 624f59f feat: step 3, manage the plugin runne

[GitHub] [apisix] juzhiyuan commented on pull request #4155: docs: improve plugins' documentation (Chinese)

2021-05-03 Thread GitBox
juzhiyuan commented on pull request #4155: URL: https://github.com/apache/apisix/pull/4155#issuecomment-831648865 After reviewing Chinese versions, I will submit PRs to update EN. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [apisix] juzhiyuan commented on a change in pull request #4155: docs: improve plugins' documentation (Chinese)

2021-05-03 Thread GitBox
juzhiyuan commented on a change in pull request #4155: URL: https://github.com/apache/apisix/pull/4155#discussion_r625475491 ## File path: docs/zh/latest/plugins/api-breaker.md ## @@ -21,98 +21,69 @@ title: api-breaker # --> -## 目录 +## 简介 -- [**定义**](#定义) -- [**属性列表**](#属

[GitHub] [apisix] juzhiyuan commented on pull request #4155: docs: improve plugins' documentation (Chinese)

2021-05-03 Thread GitBox
juzhiyuan commented on pull request #4155: URL: https://github.com/apache/apisix/pull/4155#issuecomment-831641900 > Please fix English doc first @moonming Please review Chinese docs first. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [apisix] juzhiyuan commented on pull request #4155: docs: improve plugins' documentation (Chinese)

2021-05-03 Thread GitBox
juzhiyuan commented on pull request #4155: URL: https://github.com/apache/apisix/pull/4155#issuecomment-831641725 > Is it necessary to use docusaurus special syntax? Why not use directly? Those contents are used in the docs site, this syntax will be rendered as `Admonitions Box

[GitHub] [apisix] juzhiyuan commented on a change in pull request #4155: docs: improve plugins' documentation (Chinese)

2021-05-03 Thread GitBox
juzhiyuan commented on a change in pull request #4155: URL: https://github.com/apache/apisix/pull/4155#discussion_r625469631 ## File path: docs/zh/latest/plugins/api-breaker.md ## @@ -21,98 +21,69 @@ title: api-breaker # --> -## 目录 +## 简介 -- [**定义**](#定义) -- [**属性列表**](#属

[GitHub] [apisix] juzhiyuan commented on a change in pull request #4155: docs: improve plugins' documentation (Chinese)

2021-05-03 Thread GitBox
juzhiyuan commented on a change in pull request #4155: URL: https://github.com/apache/apisix/pull/4155#discussion_r625469378 ## File path: docs/zh/latest/plugins/basic-auth.md ## @@ -21,128 +21,154 @@ title: basic-auth # --> -## 目录 +## 简介 -- [**名字**](#名字) -- [**属性**](#属性)

[GitHub] [apisix] spacewander commented on issue #4176: request help:

2021-05-03 Thread GitBox
spacewander commented on issue #4176: URL: https://github.com/apache/apisix/issues/4176#issuecomment-831638280 You can use ip-restriction and consumer-restriction plugin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [apisix] moonming commented on pull request #4155: docs: improve plugins' documentation (Chinese)

2021-05-03 Thread GitBox
moonming commented on pull request #4155: URL: https://github.com/apache/apisix/pull/4155#issuecomment-831638101 > For docs in English, I would prefer submitting a new PR ✌️ English doc first -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [apisix] spacewander commented on a change in pull request #4155: docs: improve plugins' documentation (Chinese)

2021-05-03 Thread GitBox
spacewander commented on a change in pull request #4155: URL: https://github.com/apache/apisix/pull/4155#discussion_r625459642 ## File path: docs/zh/latest/plugins/api-breaker.md ## @@ -21,98 +21,69 @@ title: api-breaker # --> -## 目录 +## 简介 -- [**定义**](#定义) -- [**属性列表**](

[GitHub] [apisix] juzhiyuan edited a comment on pull request #4155: docs: improve plugins' documentation (Chinese)

2021-05-03 Thread GitBox
juzhiyuan edited a comment on pull request #4155: URL: https://github.com/apache/apisix/pull/4155#issuecomment-831629657 @iamayushdas, after discussing with @Yiyiyimu, I agree with him, this is more challenge for a non-CN speaker, you could pick other issues like `Web Test` or `Featrures`

[GitHub] [apisix] juzhiyuan commented on pull request #4155: docs: improve plugins' documentation (Chinese)

2021-05-03 Thread GitBox
juzhiyuan commented on pull request #4155: URL: https://github.com/apache/apisix/pull/4155#issuecomment-831629657 After discuss with @Yiyiyimu, I agree with him, this is more challenge for a non-CN speaker, you could pick other issues like `Web Test` or `Featrures` or `bugfix` issues. --

[GitHub] [apisix] spacewander commented on pull request #4175: docs: fix broken links and ids in plugins

2021-05-03 Thread GitBox
spacewander commented on pull request #4175: URL: https://github.com/apache/apisix/pull/4175#issuecomment-831628212 Would you put similar changes into one PR instead of submitting them one by one? Thanks! -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [apisix] spacewander commented on a change in pull request #4175: docs: fix broken links and ids in plugins

2021-05-03 Thread GitBox
spacewander commented on a change in pull request #4175: URL: https://github.com/apache/apisix/pull/4175#discussion_r625455517 ## File path: docs/en/latest/config.json ## @@ -162,6 +162,13 @@ "discovery/eureka" ] }, +{ + "type":

[GitHub] [apisix] hozaifaaoud opened a new issue #4176: request help:

2021-05-03 Thread GitBox
hozaifaaoud opened a new issue #4176: URL: https://github.com/apache/apisix/issues/4176 ### Issue description ### Environment * apisix version (cmd: `apisix version`): APISIX/2.3 * OS (cmd: `uname -a`): #60-Ubuntu * OpenResty / Nginx version (cmd: `nginx -V` or `openresty

[GitHub] [apisix] Yiyiyimu commented on pull request #4155: docs: improve plugins' documentation (Chinese)

2021-05-03 Thread GitBox
Yiyiyimu commented on pull request #4155: URL: https://github.com/apache/apisix/pull/4155#issuecomment-831568914 > okay i will be working on EN docs in next PR, will take help from @guoqqqi or @Yiyiyimu if i do wrong > while understanding chinese Hi @iamayushdas Thanks for the vol

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1816: feat: Use monaco editor

2021-05-03 Thread GitBox
juzhiyuan commented on a change in pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#discussion_r625377805 ## File path: web/package.json ## @@ -131,7 +132,8 @@ "prettier": "^2.0.1", "pro-download": "1.0.1", "puppeteer-core": "^4.0.1",

[GitHub] [apisix] iamayushdas edited a comment on pull request #4175: docs: fix broken links and ids in plugins

2021-05-03 Thread GitBox
iamayushdas edited a comment on pull request #4175: URL: https://github.com/apache/apisix/pull/4175#issuecomment-831275128 @Yiyiyimu @tokers have a look to this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1816: feat: Use monaco editor

2021-05-03 Thread GitBox
guoqqqi commented on pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-831384729 Cool! Thanks~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1836: build: using curl command instead of wget

2021-05-03 Thread GitBox
juzhiyuan merged pull request #1836: URL: https://github.com/apache/apisix-dashboard/pull/1836 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this serv

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1837: docs: fix Chinese typos in the `retries.tooltip` field of upstream component

2021-05-03 Thread GitBox
juzhiyuan merged pull request #1837: URL: https://github.com/apache/apisix-dashboard/pull/1837 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this serv

[apisix-dashboard] branch master updated: docs: fix Chinese typos in the `retries.tooltip` field of upstream component (#1837)

2021-05-03 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 16dfb4d docs: fix Chinese typos in

[apisix-dashboard] branch master updated (e89665f -> d7e08cb)

2021-05-03 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from e89665f feat: add the service page upstream select option (#1633) add d7e08cb chore: using curl c

[GitHub] [apisix] juzhiyuan commented on pull request #4155: docs: improve plugins' documentation (Chinese)

2021-05-03 Thread GitBox
juzhiyuan commented on pull request #4155: URL: https://github.com/apache/apisix/pull/4155#issuecomment-831345303 @iamayushdas ok! Once this PR is merged without incorrect contents, then you could start doing it :) -- This is an automated message from the Apache Git Service. To respond

[GitHub] [apisix] iamayushdas commented on pull request #4175: docs: fix broken links and ids in plugins

2021-05-03 Thread GitBox
iamayushdas commented on pull request #4175: URL: https://github.com/apache/apisix/pull/4175#issuecomment-831275128 @guoqqi @tokers have a look to this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [apisix] iamayushdas commented on pull request #4155: docs: improve plugins' documentation (Chinese)

2021-05-03 Thread GitBox
iamayushdas commented on pull request #4155: URL: https://github.com/apache/apisix/pull/4155#issuecomment-831273389 > For docs in English, I would prefer submitting a new PR okay i will be working on EN docs in next PR, will take help from @guoqqqi or @Yiyiyimu if i do wrong whil

[GitHub] [apisix-dashboard] dmsolr commented on pull request #1836: build: using curl command instead of wget

2021-05-03 Thread GitBox
dmsolr commented on pull request #1836: URL: https://github.com/apache/apisix-dashboard/pull/1836#issuecomment-831248444 > @dmsolr Please check the failuer case Hi @juzhiyuan It is fixed, please recheck. -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1836: build: using curl command instead of wget

2021-05-03 Thread GitBox
codecov-commenter edited a comment on pull request #1836: URL: https://github.com/apache/apisix-dashboard/pull/1836#issuecomment-830278564 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1836?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1836: build: using curl command instead of wget

2021-05-03 Thread GitBox
netlify[bot] edited a comment on pull request #1836: URL: https://github.com/apache/apisix-dashboard/pull/1836#issuecomment-830275093 Deploy preview for *apisix-dashboard* ready! Built with commit 880349de3fdae8a95682c43db3ec6e46667596b4 https://deploy-preview-1836--apisix-dash

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1836: build: using curl command instead of wget

2021-05-03 Thread GitBox
codecov-commenter edited a comment on pull request #1836: URL: https://github.com/apache/apisix-dashboard/pull/1836#issuecomment-830278564 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1836?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1836: build: using curl command instead of wget

2021-05-03 Thread GitBox
codecov-commenter edited a comment on pull request #1836: URL: https://github.com/apache/apisix-dashboard/pull/1836#issuecomment-830278564 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1836?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1836: build: using curl command instead of wget

2021-05-03 Thread GitBox
netlify[bot] edited a comment on pull request #1836: URL: https://github.com/apache/apisix-dashboard/pull/1836#issuecomment-830275093 Deploy preview for *apisix-dashboard* processing. Building with commit 880349de3fdae8a95682c43db3ec6e46667596b4 https://app.netlify.com/sites/a

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1837: docs: fix Chinese typos in the `retries.tooltip` field of upstream component

2021-05-03 Thread GitBox
codecov-commenter commented on pull request #1837: URL: https://github.com/apache/apisix-dashboard/pull/1837#issuecomment-831115796 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1837?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comm

[GitHub] [apisix-dashboard] imjoey commented on issue #1832: bug: apisix-dashboard v2.5 make build failed on Huawei Kunpeng system

2021-05-03 Thread GitBox
imjoey commented on issue #1832: URL: https://github.com/apache/apisix-dashboard/issues/1832#issuecomment-831103618 @Molio-tan the logs seem not very helpful. So could you please show us more information from the `/var/log/message` and `dmesg` command during the installation? I believe th

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1832: bug: apisix-dashboard v2.5 make build failed on Huawei Kunpeng system

2021-05-03 Thread GitBox
juzhiyuan commented on issue #1832: URL: https://github.com/apache/apisix-dashboard/issues/1832#issuecomment-831102895 noted, thanks for clarification! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1830: feat: add switch of online debug

2021-05-03 Thread GitBox
juzhiyuan commented on pull request #1830: URL: https://github.com/apache/apisix-dashboard/pull/1830#issuecomment-831102555 I have replied in the mailing list, do we really need a Switcher to fix this issue? -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1798: the problem of empty vars expressions in "Advanced Routing Matching Conditions"

2021-05-03 Thread GitBox
juzhiyuan commented on issue #1798: URL: https://github.com/apache/apisix-dashboard/issues/1798#issuecomment-831102159 @belongwqz no, wait for #1799 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [apisix-dashboard] imjoey commented on issue #1832: bug: apisix-dashboard v2.5 make build failed on Huawei Kunpeng system

2021-05-03 Thread GitBox
imjoey commented on issue #1832: URL: https://github.com/apache/apisix-dashboard/issues/1832#issuecomment-831101775 > Hi @imjoey, do you have other solutions to resolve this issue? Should we file an issue to Yarn or NPM? @juzhiyuan Sorry, I'm afraid not yet as the logs did not show

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1788: feat: embed assets in api binary

2021-05-03 Thread GitBox
juzhiyuan commented on pull request #1788: URL: https://github.com/apache/apisix-dashboard/pull/1788#issuecomment-831101776 and the conflicts too :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1765: docs: Update api documentation

2021-05-03 Thread GitBox
juzhiyuan commented on pull request #1765: URL: https://github.com/apache/apisix-dashboard/pull/1765#issuecomment-831101571 😳 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1835: docs: add the visit the dashboard

2021-05-03 Thread GitBox
juzhiyuan commented on pull request #1835: URL: https://github.com/apache/apisix-dashboard/pull/1835#issuecomment-831100849 @stu01509 Would you mind updating the CN docs too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [apisix-ingress-controller] sober-wang commented on issue #356: request help: KubeSphere setup

2021-05-03 Thread GitBox
sober-wang commented on issue #356: URL: https://github.com/apache/apisix-ingress-controller/issues/356#issuecomment-831100552 > > > > But when I entry apisix pod request my http server is connect. see ... > > ``` > > [root@k8smaster01 ~]# kubectl -n ws get pods -owide > >

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1836: build: using curl command instead of wget

2021-05-03 Thread GitBox
juzhiyuan commented on pull request #1836: URL: https://github.com/apache/apisix-dashboard/pull/1836#issuecomment-831100459 @dmsolr Please check the failuer case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1834: fix: configuration file link broken

2021-05-03 Thread GitBox
juzhiyuan commented on a change in pull request #1834: URL: https://github.com/apache/apisix-dashboard/pull/1834#discussion_r624939351 ## File path: docs/en/latest/deploy-with-docker.md ## @@ -52,7 +52,7 @@ $ docker build -t apisix-dashboard:$tag . --build-arg APISIX_DASHBOARD

[GitHub] [apisix-website] juzhiyuan merged pull request #327: docs: Update Integration page

2021-05-03 Thread GitBox
juzhiyuan merged pull request #327: URL: https://github.com/apache/apisix-website/pull/327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[apisix-website] branch master updated: docs: update integration page (#327)

2021-05-03 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new 33e60c2 docs: update integration pag

[GitHub] [apisix-website] juzhiyuan commented on issue #288: bug: hidableSidebar does not behave correctly

2021-05-03 Thread GitBox
juzhiyuan commented on issue #288: URL: https://github.com/apache/apisix-website/issues/288#issuecomment-831097666 I would prefer keeping it the same line if we could, the sudden jump makes me feel not good.. ![image](https://user-images.githubusercontent.com/2106987/116854029-9f3ac

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1832: bug: apisix-dashboard v2.5 make build failed on Huawei Kunpeng system

2021-05-03 Thread GitBox
juzhiyuan commented on issue #1832: URL: https://github.com/apache/apisix-dashboard/issues/1832#issuecomment-831095222 Hi @imjoey, do you have other solutions to resolve this issue? Should we file an issue to Yarn or NPM? -- This is an automated message from the Apache Git Service. To r

[apisix-dashboard] branch master updated: feat: add the service page upstream select option (#1633)

2021-05-03 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new e89665f feat: add the service page

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1633: feat: add the service page upstream select option

2021-05-03 Thread GitBox
juzhiyuan merged pull request #1633: URL: https://github.com/apache/apisix-dashboard/pull/1633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this serv

[GitHub] [apisix-dashboard] juzhiyuan closed issue #1616: when creating a `Service`, `Select Upstream` should be optional, not required

2021-05-03 Thread GitBox
juzhiyuan closed issue #1616: URL: https://github.com/apache/apisix-dashboard/issues/1616 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1711: The name rule is not applied to every name input

2021-05-03 Thread GitBox
juzhiyuan commented on issue #1711: URL: https://github.com/apache/apisix-dashboard/issues/1711#issuecomment-831091790 Hi, @stu01509 I'm back, this issue will be resolved by https://github.com/apache/apisix-dashboard/pull/1799 -- This is an automated message from the Apache Git Service.

[GitHub] [apisix-dashboard] juzhiyuan closed issue #1711: The name rule is not applied to every name input

2021-05-03 Thread GitBox
juzhiyuan closed issue #1711: URL: https://github.com/apache/apisix-dashboard/issues/1711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1828: fix:When create the upstream, some properties can still be edited on …

2021-05-03 Thread GitBox
juzhiyuan merged pull request #1828: URL: https://github.com/apache/apisix-dashboard/pull/1828 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this serv

[apisix-dashboard] branch master updated: fix:When create the upstream, some properties can still be edited on … (#1828)

2021-05-03 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 6b997d1 fix:When create the upstre

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1828: fix:When create the upstream, some properties can still be edited on …

2021-05-03 Thread GitBox
juzhiyuan commented on a change in pull request #1828: URL: https://github.com/apache/apisix-dashboard/pull/1828#discussion_r624930705 ## File path: web/cypress/integration/service/create-service-with-not-select-upstream.spec.js ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apac

[GitHub] [apisix] juzhiyuan closed issue #4161: bug: sls-logger 没有日志了

2021-05-03 Thread GitBox
juzhiyuan closed issue #4161: URL: https://github.com/apache/apisix/issues/4161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please con

[GitHub] [apisix] juzhiyuan commented on issue #4161: bug: sls-logger 没有日志了

2021-05-03 Thread GitBox
juzhiyuan commented on issue #4161: URL: https://github.com/apache/apisix/issues/4161#issuecomment-831089728 fine, it seems that those 2 issues are resolved, feel free to reopen this one if needed. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [apisix] juzhiyuan commented on pull request #4155: docs: improve plugins' documentation (Chinese)

2021-05-03 Thread GitBox
juzhiyuan commented on pull request #4155: URL: https://github.com/apache/apisix/pull/4155#issuecomment-831087183 For docs in English, I would prefer submitting a new PR ✌️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix] juzhiyuan commented on pull request #4155: docs: improve plugins' documentation

2021-05-03 Thread GitBox
juzhiyuan commented on pull request #4155: URL: https://github.com/apache/apisix/pull/4155#issuecomment-831085744 > I mean you should change `Access-Controll-Max-Age` to `Access-Control-Max-Age` Done -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [apisix] KishaniKandasamy opened a new pull request #4175: docs: fix broken links and ids in plugins

2021-05-03 Thread GitBox
KishaniKandasamy opened a new pull request #4175: URL: https://github.com/apache/apisix/pull/4175 ### What this PR does / why we need it: fix: [#325](https://github.com/apache/apisix-website/issues/325) ### Pre-submission checklist: * [x] Did you explain what problem does th