Jaycean commented on pull request #2415:
URL: https://github.com/apache/apisix/pull/2415#issuecomment-716268938
> LGTM, except minor things in the test cases.
done.
This is an automated message from the Apache Git
Jaycean commented on pull request #2415:
URL: https://github.com/apache/apisix/pull/2415#issuecomment-715663919
> @Jaycean I think we can add a checkpoint for confirming if we fetched a
correct `consumer_name`.
>
>
Jaycean commented on pull request #2415:
URL: https://github.com/apache/apisix/pull/2415#issuecomment-715225486
@membphis Done. PTAL
This is an automated message from the Apache Git Service.
To respond to the message, please
Jaycean commented on pull request #2415:
URL: https://github.com/apache/apisix/pull/2415#issuecomment-712538398
> @Jaycean
>
>
https://github.com/apache/apisix/blob/d63f3e068c0d54ab7b2b3acec8e5f4914da0a4b7/apisix/plugins/limit-conn.lua#L71
>
> we can print the
Jaycean commented on pull request #2415:
URL: https://github.com/apache/apisix/pull/2415#issuecomment-711972389
> @Jaycean
>
>
https://github.com/apache/apisix/blob/d63f3e068c0d54ab7b2b3acec8e5f4914da0a4b7/apisix/plugins/limit-conn.lua#L71
>
> we can print the
Jaycean commented on pull request #2415:
URL: https://github.com/apache/apisix/pull/2415#issuecomment-711883326
> we need to print the value of the `limit key`, and check it in error log.
I'm sorry that I didn't understand what you meant. I added the test error
value of the key and
Jaycean commented on pull request #2415:
URL: https://github.com/apache/apisix/pull/2415#issuecomment-711484039
@spacewander PTAL
This is an automated message from the Apache Git Service.
To respond to the message, please
