Change in asterixdb[master]: ASTERIXDB-1804: update AsterixDB servlets

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1804: update AsterixDB servlets
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1954/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1519
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id48a4753775a19094b28876ef3544bda989f918d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1804: update AsterixDB servlets

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1804: update AsterixDB servlets
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4374/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1519
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id48a4753775a19094b28876ef3544bda989f918d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1804: update AsterixDB servlets

2017-02-21 Thread Till Westmann (Code Review)
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1519

to look at the new patch set (#2).

Change subject: ASTERIXDB-1804: update AsterixDB servlets
..

ASTERIXDB-1804: update AsterixDB servlets

Change-Id: Id48a4753775a19094b28876ef3544bda989f918d
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ConnectorApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DiagnosticsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/FeedServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NodeControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryStatusApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryWebInterfaceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ShutdownApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/VersionApiServlet.java
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/server/RSSFeedServlet.java
M asterixdb/asterix-experiments/pom.xml
16 files changed, 62 insertions(+), 148 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/19/1519/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1519
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id48a4753775a19094b28876ef3544bda989f918d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 


[jira] [Commented] (ASTERIXDB-1369) Add the Java driver for Asterix

2017-02-21 Thread Siddhesh Rane (JIRA)

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877508#comment-15877508
 ] 

Siddhesh Rane commented on ASTERIXDB-1369:
--

[~javierjia] Can you elaborate what you mean by Java driver. Is it a jdbc 
driver or a Java API that will return domain objects that wont need any JSON or 
HTML parsing?

> Add the Java driver for Asterix
> ---
>
> Key: ASTERIXDB-1369
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1369
> Project: Apache AsterixDB
>  Issue Type: Improvement
>  Components: Adapters
>Reporter: Jianfeng Jia
>Priority: Minor
>  Labels: gsoc2017
>
> Add a java driver for AsterixDB. It will be easier for the developer to talk 
> to the Asterixdb through API than send http request.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Change in asterixdb[master]: ASTERIXDB-1804: update AsterixDB servlets

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1804: update AsterixDB servlets
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1954/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1519
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id48a4753775a19094b28876ef3544bda989f918d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Various fixes for Windows NCService

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Various fixes for Windows NCService
..


Patch Set 4: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1953/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1518
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7af80292bddd5191d83bac18f0a518621d7db71
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1791, ASTERIXDB-1796: fix failure handling in runt...

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1791, ASTERIXDB-1796: fix failure handling in runtime 
operator.
..


Patch Set 8: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1952/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1513
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I203168171e6dac16b57d2eda960823e3810e22a3
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: WIP: Configuration Revamp

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: WIP: Configuration Revamp
..


Patch Set 16:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: WIP: Configuration Revamp

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: WIP: Configuration Revamp
..


Patch Set 16:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4373/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: WIP: Configuration Revamp

2017-02-21 Thread Michael Blow (Code Review)
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1487

to look at the new patch set (#16).

Change subject: WIP: Configuration Revamp
..

WIP: Configuration Revamp

- Ini section of node / cc details now returns ini param names instead of
  managix option names
- Normalized command line -vs- ini file configuration parameter names
- Eliminated unused parameters
- IN PROGRESS: Fix ncservice documentation issues, including to reflect
  which configuration that belongs in [app] section, [ncservice] config
- Ini validation
- Migrate *DB parameters out of [app] and into nc / cc sections where
  appropriate
- Eliminate [app] section.  Cluster-wide configuration lives in [common]

Also, add 'ClusterControllerService' to RAT exclude list, as these still
seem to get generated outside of 'target' in some cases...

Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
---
M asterixdb/asterix-app/pom.xml
M asterixdb/asterix-app/scripts/asterix/startnc.sh
M asterixdb/asterix-app/scripts/idefix/startnc1.sh
M asterixdb/asterix-app/scripts/idefix/startnc2.sh
M asterixdb/asterix-app/scripts/rainbow/startnc.sh
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DiagnosticsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NodeControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/VersionApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ServletConstants.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M asterixdb/asterix-app/src/main/resources/asterix-build-configuration.xml
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestHelper.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ClusterStateDefaultParameterTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/OptimizerParserTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestUtil.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/SmokeParserTest.java
M asterixdb/asterix-app/src/test/resources/runtimets/queries/api/APIQueries.xml
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.adm
M asterixdb/asterix-client-helper/pom.xml
M asterixdb/asterix-common/pom.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AbstractProperties.java
C 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixCCConfig.java
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixNCConfig.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/BuildProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CompilerProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/FeedProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/MessagingProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/MetadataProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/PropertiesAccessor.java
D 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/PropertyInterpreters.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ReplicationProperties.java
M 

Change in asterixdb[master]: ASTERIXDB-1804: update AsterixDB servlets

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1804: update AsterixDB servlets
..


Patch Set 1: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1951/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1519
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id48a4753775a19094b28876ef3544bda989f918d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Various fixes for Windows NCService

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Various fixes for Windows NCService
..


Patch Set 4: BAD-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/595/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1518
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7af80292bddd5191d83bac18f0a518621d7db71
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: Various fixes for Windows NCService

2017-02-21 Thread Yingyi Bu (Code Review)
Yingyi Bu has posted comments on this change.

Change subject: Various fixes for Windows NCService
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1518
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7af80292bddd5191d83bac18f0a518621d7db71
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: Various fixes for Windows NCService

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Various fixes for Windows NCService
..


Patch Set 4:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1953/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1518
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7af80292bddd5191d83bac18f0a518621d7db71
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: Various fixes for Windows NCService

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Various fixes for Windows NCService
..


Patch Set 4:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1518
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7af80292bddd5191d83bac18f0a518621d7db71
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: Various fixes for Windows NCService

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Various fixes for Windows NCService
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4372/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1518
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7af80292bddd5191d83bac18f0a518621d7db71
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1791, ASTERIXDB-1796: fix failure handling in runt...

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1791, ASTERIXDB-1796: fix failure handling in runtime 
operator.
..


Patch Set 8: BAD-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/594/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1513
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I203168171e6dac16b57d2eda960823e3810e22a3
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Various fixes for Windows NCService

2017-02-21 Thread Ian Maxon (Code Review)
Hello Yingyi Bu, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1518

to look at the new patch set (#4).

Change subject: Various fixes for Windows NCService
..

Various fixes for Windows NCService

- Fix RESOURCE_PATH
- Use windows platform in appassembler instead of booter-windows for 
client-helper
- Fix a few redirection bugs in sample start/stop batch files

Change-Id: If7af80292bddd5191d83bac18f0a518621d7db71
---
M asterixdb/asterix-client-helper/pom.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.bat
M asterixdb/asterix-server/src/main/opt/local/bin/stop-sample-cluster.bat
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
5 files changed, 7 insertions(+), 41 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/18/1518/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1518
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If7af80292bddd5191d83bac18f0a518621d7db71
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 


Change in asterixdb[master]: ASTERIXDB-1791, ASTERIXDB-1796: fix failure handling in runt...

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1791, ASTERIXDB-1796: fix failure handling in runtime 
operator.
..


Patch Set 8:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/594/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1513
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I203168171e6dac16b57d2eda960823e3810e22a3
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1791, ASTERIXDB-1796: fix failure handling in runt...

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1791, ASTERIXDB-1796: fix failure handling in runtime 
operator.
..


Patch Set 8:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1952/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1513
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I203168171e6dac16b57d2eda960823e3810e22a3
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix RESOURCE_PATH in ErrorCode

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix RESOURCE_PATH in ErrorCode
..


Patch Set 3: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1949/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1518
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7af80292bddd5191d83bac18f0a518621d7db71
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1804: update AsterixDB servlets

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1804: update AsterixDB servlets
..


Patch Set 1: BAD-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/593/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1519
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id48a4753775a19094b28876ef3544bda989f918d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1804: update AsterixDB servlets

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1804: update AsterixDB servlets
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/593/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1519
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id48a4753775a19094b28876ef3544bda989f918d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1804: update AsterixDB servlets

2017-02-21 Thread Till Westmann (Code Review)
Till Westmann has abandoned this change.

Change subject: ASTERIXDB-1804: update AsterixDB servlets
..


Abandoned

superseded by https://asterix-gerrit.ics.uci.edu/#/c/1519/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1517
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I0787abed4d5ae81eea24bf14560d8bbfcac5a798
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 


Change in asterixdb[master]: ASTERIXDB-1791, ASTERIXDB-1796: fix failure handling in runt...

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1791, ASTERIXDB-1796: fix failure handling in runtime 
operator.
..


Patch Set 8:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4371/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1513
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I203168171e6dac16b57d2eda960823e3810e22a3
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1791, ASTERIXDB-1796: fix failure handling in runt...

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1791, ASTERIXDB-1796: fix failure handling in runtime 
operator.
..


Patch Set 8:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1513
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I203168171e6dac16b57d2eda960823e3810e22a3
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1804: update AsterixDB servlets

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1804: update AsterixDB servlets
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1948/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1517
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0787abed4d5ae81eea24bf14560d8bbfcac5a798
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1791, ASTERIXDB-1796: fix failure handling in runt...

2017-02-21 Thread Yingyi Bu (Code Review)
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1513

to look at the new patch set (#8).

Change subject: ASTERIXDB-1791, ASTERIXDB-1796: fix failure handling in runtime 
operator.
..

ASTERIXDB-1791, ASTERIXDB-1796: fix failure handling in runtime operator.

This change includes the following parts:
- Fix the implementation of fail() and close() in the join probe activity
  so as to avoid file leakage and hanging job;
- Fix OptimizedHybridHashJoin to close files before deleting them in order
  to make the holding disk space available;
- Call RunFileWriter.close() and RunFileReader.close() in "finally" blocks.
- Fix RunFileReader to not truncate files to be deleted - it is not the root
  cause of un-released disk space - open deleted files are the root cuase;

Change-Id: I203168171e6dac16b57d2eda960823e3810e22a3
---
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/ConnectorDescriptorWithMessagingTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/LangExecutionUtil.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/failure/q01_pricing_summary_report_failure/q01_pricing_summary_report_failure.3.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/failure/group_by_failure/group_by_failure.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/failure/group_by_failure/group_by_failure.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/failure/group_by_failure/group_by_failure.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/failure/group_by_hash_failure/group_by_hash_failure.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/failure/group_by_hash_failure/group_by_hash_failure.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/failure/group_by_hash_failure/group_by_hash_failure.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/failure/order_by_failure/order_by_failure.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/failure/order_by_failure/order_by_failure.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/failure/order_by_failure/order_by_failure.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/failure/q01_pricing_summary_report_failure/q01_pricing_summary_report_failure.1.ddl.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/failure/q01_pricing_summary_report_failure/q01_pricing_summary_report_failure.2.update.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/failure/q01_pricing_summary_report_failure/q01_pricing_summary_report_failure.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/failure/q18_large_volume_customer_failure/q18_large_volume_customer_failure.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/failure/q18_large_volume_customer_failure/q18_large_volume_customer_failure.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/failure/q18_large_volume_customer_failure/q18_large_volume_customer_failure.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/q18_large_volume_customer_failure/q18_large_volume_customer_failure.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/q18_large_volume_customer_failure/q18_large_volume_customer_failure.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/q18_large_volume_customer_failure/q18_large_volume_customer_failure.3.query.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataset/adapter/LookupAdapter.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedIntakeOperatorNodePushable.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/std/NoTupleSourceRuntimeFactory.java
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/runtime/CommitRuntime.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/base/AbstractOneInputOneOutputOneFramePushRuntime.java
M 

Change in asterixdb[master]: ASTERIXDB-1804: update AsterixDB servlets

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1804: update AsterixDB servlets
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4370/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1519
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id48a4753775a19094b28876ef3544bda989f918d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1804: update AsterixDB servlets

2017-02-21 Thread Till Westmann (Code Review)
Till Westmann has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1519

Change subject: ASTERIXDB-1804: update AsterixDB servlets
..

ASTERIXDB-1804: update AsterixDB servlets

Change-Id: Id48a4753775a19094b28876ef3544bda989f918d
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ConnectorApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DiagnosticsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/FeedServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NodeControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryStatusApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryWebInterfaceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ShutdownApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/VersionApiServlet.java
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/server/RSSFeedServlet.java
15 files changed, 31 insertions(+), 95 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/19/1519/1

diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
index 395365a..40c7f2c 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
@@ -83,7 +83,8 @@
 this.componentProvider = componentProvider;
 }
 
-public void doPost(IServletRequest request, IServletResponse response) {
+@Override
+protected void post(IServletRequest request, IServletResponse response) {
 // Query language
 ILangCompilationProvider compilationProvider = 
"AQL".equals(request.getParameter("query-language"))
 ? aqlCompilationProvider : sqlppCompilationProvider;
@@ -157,7 +158,8 @@
 }
 }
 
-public void doGet(IServletRequest request, IServletResponse response) {
+@Override
+protected void get(IServletRequest request, IServletResponse response) {
 String resourcePath = null;
 String requestURI = request.getHttpRequest().uri();
 
@@ -226,17 +228,4 @@
 private static boolean isSet(String requestParameter) {
 return requestParameter != null && "true".equals(requestParameter);
 }
-
-@Override
-public void handle(IServletRequest request, IServletResponse response) {
-response.setStatus(HttpResponseStatus.OK);
-if (request.getHttpRequest().method() == HttpMethod.GET) {
-doGet(request, response);
-} else if (request.getHttpRequest().method() == HttpMethod.POST) {
-doPost(request, response);
-} else {
-response.setStatus(HttpResponseStatus.METHOD_NOT_ALLOWED);
-}
-}
-
 }
diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
index 71559b1..1d37baf 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
@@ -65,7 +65,8 @@
 super(ctx, paths);
 }
 
-protected void getUnsafe(IServletRequest request, IServletResponse 
response) throws IOException {
+@Override
+protected void get(IServletRequest request, IServletResponse response) 
throws IOException {
 HttpUtil.setContentType(response, 
HttpUtil.ContentType.APPLICATION_JSON, HttpUtil.Encoding.UTF8);
 PrintWriter responseWriter = response.writer();
 try {
@@ -173,18 +174,4 @@
 }
 return clusterURL;
 }
-
-@Override
-public void handle(IServletRequest request, IServletResponse response) {
-if (request.getHttpRequest().method() != HttpMethod.GET) {
-response.setStatus(HttpResponseStatus.METHOD_NOT_ALLOWED);
-return;
-  

Change in asterixdb[master]: ASTERIXDB-1786: Remove Hyracks Servlets.

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1786: Remove Hyracks Servlets.
..


Patch Set 12: BAD-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/592/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1508
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcd240591d12baab2db4ce3163c635a1dde5c4ba
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1786: Remove Hyracks Servlets.

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1786: Remove Hyracks Servlets.
..


Patch Set 12:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/592/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1508
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcd240591d12baab2db4ce3163c635a1dde5c4ba
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1791, ASTERIXDB-1796: fix failure handling in runt...

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1791, ASTERIXDB-1796: fix failure handling in runtime 
operator.
..


Patch Set 7:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1513
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I203168171e6dac16b57d2eda960823e3810e22a3
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1786: Remove Hyracks Servlets.

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1786: Remove Hyracks Servlets.
..


Patch Set 12:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1950/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1508
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcd240591d12baab2db4ce3163c635a1dde5c4ba
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1791, ASTERIXDB-1796: fix failure handling in runt...

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1791, ASTERIXDB-1796: fix failure handling in runtime 
operator.
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4369/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1513
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I203168171e6dac16b57d2eda960823e3810e22a3
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1791, ASTERIXDB-1796: fix failure handling in runt...

2017-02-21 Thread Yingyi Bu (Code Review)
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1513

to look at the new patch set (#7).

Change subject: ASTERIXDB-1791, ASTERIXDB-1796: fix failure handling in runtime 
operator.
..

ASTERIXDB-1791, ASTERIXDB-1796: fix failure handling in runtime operator.

This change includes the following parts:
- Fix the implementation of fail() and close() in the join probe activity
  so as to avoid file leakage and hanging job;
- Fix OptimizedHybridHashJoin to close files before deleting them in order
  to make the holding disk space available;
- Call RunFileWriter.close() and RunFileReader.close() in "finally" blocks.
- Fix RunFileReader to not truncate files to be deleted - it is not the root
  cause of un-released disk space - open deleted files are the root cuase;

Change-Id: I203168171e6dac16b57d2eda960823e3810e22a3
---
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/ConnectorDescriptorWithMessagingTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/LangExecutionUtil.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/failure/q01_pricing_summary_report_failure/q01_pricing_summary_report_failure.3.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/failure/group_by_failure/group_by_failure.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/failure/group_by_failure/group_by_failure.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/failure/group_by_failure/group_by_failure.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/failure/group_by_hash_failure/group_by_hash_failure.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/failure/group_by_hash_failure/group_by_hash_failure.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/failure/group_by_hash_failure/group_by_hash_failure.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/failure/order_by_failure/order_by_failure.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/failure/order_by_failure/order_by_failure.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/failure/order_by_failure/order_by_failure.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/failure/q01_pricing_summary_report_failure/q01_pricing_summary_report_failure.1.ddl.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/failure/q01_pricing_summary_report_failure/q01_pricing_summary_report_failure.2.update.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/failure/q01_pricing_summary_report_failure/q01_pricing_summary_report_failure.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/failure/q18_large_volume_customer_failure/q18_large_volume_customer_failure.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/failure/q18_large_volume_customer_failure/q18_large_volume_customer_failure.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/failure/q18_large_volume_customer_failure/q18_large_volume_customer_failure.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/q18_large_volume_customer_failure/q18_large_volume_customer_failure.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/q18_large_volume_customer_failure/q18_large_volume_customer_failure.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/q18_large_volume_customer_failure/q18_large_volume_customer_failure.3.query.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataset/adapter/LookupAdapter.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedIntakeOperatorNodePushable.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/std/NoTupleSourceRuntimeFactory.java
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/runtime/CommitRuntime.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/base/AbstractOneInputOneOutputOneFramePushRuntime.java
M 

Change in asterixdb[master]: ASTERIXDB-1711: Move test infra from test.aql

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1711: Move test infra from test.aql
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4368/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1512
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d631a2028fb80c823fbaafb7269f15d07685dc9
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1711: Move test infra from test.aql

2017-02-21 Thread Till Westmann (Code Review)
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1512

to look at the new patch set (#4).

Change subject: ASTERIXDB-1711: Move test infra from test.aql
..

ASTERIXDB-1711: Move test infra from test.aql

Change-Id: I5d631a2028fb80c823fbaafb7269f15d07685dc9
---
M asterixdb/asterix-app/pom.xml
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/external/TestLibrarian.java
R 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/ComparisonException.java
R 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/ITestLibrarian.java
R 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/ResultExtractor.java
R 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/SingleLinePrettyPrinter.java
R 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dml/DmlTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/metadata/MetadataTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/LangExecutionUtil.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/RuntimeParserTest.java
M asterixdb/asterix-common/pom.xml
M 
asterixdb/asterix-installer/src/test/java/org/apache/asterix/installer/test/AbstractExecutionIT.java
M 
asterixdb/asterix-installer/src/test/java/org/apache/asterix/installer/test/AsterixClusterLifeCycleIT.java
M 
asterixdb/asterix-installer/src/test/java/org/apache/asterix/installer/test/AsterixExternalLibraryIT.java
M 
asterixdb/asterix-installer/src/test/java/org/apache/asterix/installer/test/AsterixLifecycleIT.java
M 
asterixdb/asterix-installer/src/test/java/org/apache/asterix/installer/test/AsterixRestartIT.java
M 
asterixdb/asterix-installer/src/test/java/org/apache/asterix/installer/test/ClusterExecutionIT.java
M 
asterixdb/asterix-installer/src/test/java/org/apache/asterix/installer/test/ReplicationIT.java
M 
asterixdb/asterix-installer/src/test/java/org/apache/asterix/installer/transaction/DmlRecoveryIT.java
M 
asterixdb/asterix-installer/src/test/java/org/apache/asterix/installer/transaction/RecoveryIT.java
M 
asterixdb/asterix-server/src/test/java/org/apache/asterix/server/test/NCServiceExecutionIT.java
M 
asterixdb/asterix-server/src/test/java/org/apache/asterix/server/test/SampleLocalClusterIT.java
M asterixdb/asterix-yarn/pom.xml
M 
asterixdb/asterix-yarn/src/test/java/org/apache/asterix/aoya/test/AsterixYARNLibraryTestIT.java
26 files changed, 37 insertions(+), 54 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/12/1512/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1512
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5d631a2028fb80c823fbaafb7269f15d07685dc9
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 


Change in asterixdb[master]: ASTERIXDB-1786: Remove Hyracks Servlets.

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1786: Remove Hyracks Servlets.
..


Patch Set 12:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1508
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcd240591d12baab2db4ce3163c635a1dde5c4ba
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1786: Remove Hyracks Servlets.

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1786: Remove Hyracks Servlets.
..


Patch Set 12:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4367/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1508
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcd240591d12baab2db4ce3163c635a1dde5c4ba
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1786: Remove Hyracks Servlets.

2017-02-21 Thread Till Westmann (Code Review)
Hello abdullah alamoudi, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1508

to look at the new patch set (#12).

Change subject: ASTERIXDB-1786: Remove Hyracks Servlets.
..

ASTERIXDB-1786: Remove Hyracks Servlets.

Change-Id: Ifcd240591d12baab2db4ce3163c635a1dde5c4ba
---
M asterixdb/asterix-app/pom.xml
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryWebInterfaceServlet.java
M asterixdb/asterix-common/pom.xml
M asterixdb/pom.xml
M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerService.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/web/ApplicationInstallationHandler.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/web/JobsRESTAPIFunction.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/web/WebServer.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/web/util/JSONOutputRequestHandler.java
M hyracks-fullstack/hyracks/hyracks-http/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/AbstractServlet.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServerHandler.java
A 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/StaticResourceServlet.java
M hyracks-fullstack/pom.xml
16 files changed, 309 insertions(+), 237 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/08/1508/12
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1508
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifcd240591d12baab2db4ce3163c635a1dde5c4ba
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 


Change in asterixdb[master]: Fix RESOURCE_PATH in ErrorCode

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix RESOURCE_PATH in ErrorCode
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1949/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1518
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7af80292bddd5191d83bac18f0a518621d7db71
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix RESOURCE_PATH in ErrorCode

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix RESOURCE_PATH in ErrorCode
..


Patch Set 3:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/591/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1518
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7af80292bddd5191d83bac18f0a518621d7db71
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1804: update AsterixDB servlets

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1804: update AsterixDB servlets
..


Patch Set 1: BAD-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/590/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1517
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0787abed4d5ae81eea24bf14560d8bbfcac5a798
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1804: support more HTTP verbs

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1804: support more HTTP verbs
..


Patch Set 3:

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1946/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1516
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d14ce9c3c34d345fe71a44518b1e95b79c37dab
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1804: update AsterixDB servlets

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1804: update AsterixDB servlets
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/590/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1517
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0787abed4d5ae81eea24bf14560d8bbfcac5a798
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1786: Remove Hyracks Servlets.

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1786: Remove Hyracks Servlets.
..


Patch Set 11: BAD-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/589/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1508
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcd240591d12baab2db4ce3163c635a1dde5c4ba
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1804: update AsterixDB servlets

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1804: update AsterixDB servlets
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1948/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1517
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0787abed4d5ae81eea24bf14560d8bbfcac5a798
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix RESOURCE_PATH in ErrorCode

2017-02-21 Thread Yingyi Bu (Code Review)
Yingyi Bu has posted comments on this change.

Change subject: Fix RESOURCE_PATH in ErrorCode
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1518
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7af80292bddd5191d83bac18f0a518621d7db71
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix RESOURCE_PATH in ErrorCode

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix RESOURCE_PATH in ErrorCode
..


Patch Set 3:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1518
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7af80292bddd5191d83bac18f0a518621d7db71
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1786: Remove Hyracks Servlets.

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1786: Remove Hyracks Servlets.
..


Patch Set 11:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1947/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1508
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcd240591d12baab2db4ce3163c635a1dde5c4ba
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix RESOURCE_PATH in ErrorCode

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix RESOURCE_PATH in ErrorCode
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4366/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1518
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7af80292bddd5191d83bac18f0a518621d7db71
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix RESOURCE_PATH in ErrorCode

2017-02-21 Thread Ian Maxon (Code Review)
Ian Maxon has uploaded a new patch set (#3).

Change subject: Fix RESOURCE_PATH in ErrorCode
..

Fix RESOURCE_PATH in ErrorCode

Also update appassembler version

Change-Id: If7af80292bddd5191d83bac18f0a518621d7db71
---
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-server/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
3 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/18/1518/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1518
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If7af80292bddd5191d83bac18f0a518621d7db71
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 


Change in asterixdb[master]: Fix RESOURCE_PATH in ErrorCode

2017-02-21 Thread Yingyi Bu (Code Review)
Yingyi Bu has posted comments on this change.

Change subject: Fix RESOURCE_PATH in ErrorCode
..


Patch Set 2:

Can you fix ErrorCode in hyracks as well?

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1518
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7af80292bddd5191d83bac18f0a518621d7db71
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: Fix RESOURCE_PATH in ErrorCode

2017-02-21 Thread Ian Maxon (Code Review)
Ian Maxon has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1518

Change subject: Fix RESOURCE_PATH in ErrorCode
..

Fix RESOURCE_PATH in ErrorCode

Also update appassembler version

Change-Id: If7af80292bddd5191d83bac18f0a518621d7db71
---
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-server/pom.xml
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/18/1518/1

diff --git 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
index 5ae313d..3ca2254 100644
--- 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
+++ 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
@@ -31,7 +31,7 @@
 // 3000  3999: feed errors
 // 4000  4999: lifecycle management errors
 public class ErrorCode {
-private static final String RESOURCE_PATH = "asx_errormsg" + 
File.separator + "en.properties";
+private static final String RESOURCE_PATH = "asx_errormsg/en.properties";
 public static final String ASTERIX = "ASX";
 
 // Extension errors
diff --git a/asterixdb/asterix-server/pom.xml b/asterixdb/asterix-server/pom.xml
index 7d74903..82e7516 100644
--- a/asterixdb/asterix-server/pom.xml
+++ b/asterixdb/asterix-server/pom.xml
@@ -224,7 +224,7 @@
   
 org.codehaus.mojo
 appassembler-maven-plugin
-1.10
+2.0.0
 
   
 ${project.build.directory}/appassembler

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1518
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If7af80292bddd5191d83bac18f0a518621d7db71
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 


Change in asterixdb[master]: ASTERIXDB-1786: Remove Hyracks Servlets.

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1786: Remove Hyracks Servlets.
..


Patch Set 11:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1508
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcd240591d12baab2db4ce3163c635a1dde5c4ba
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1786: Remove Hyracks Servlets.

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1786: Remove Hyracks Servlets.
..


Patch Set 11:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4364/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1508
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcd240591d12baab2db4ce3163c635a1dde5c4ba
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1786: Remove Hyracks Servlets.

2017-02-21 Thread abdullah alamoudi (Code Review)
abdullah alamoudi has posted comments on this change.

Change subject: ASTERIXDB-1786: Remove Hyracks Servlets.
..


Patch Set 11: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1508
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcd240591d12baab2db4ce3163c635a1dde5c4ba
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1804: update AsterixDB servlets

2017-02-21 Thread Till Westmann (Code Review)
Till Westmann has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1517

Change subject: ASTERIXDB-1804: update AsterixDB servlets
..

ASTERIXDB-1804: update AsterixDB servlets

Change-Id: I0787abed4d5ae81eea24bf14560d8bbfcac5a798
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ConnectorApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DiagnosticsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/FeedServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NodeControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryStatusApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryWebInterfaceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ShutdownApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/VersionApiServlet.java
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/server/RSSFeedServlet.java
15 files changed, 31 insertions(+), 91 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/17/1517/1

diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
index 395365a..40c7f2c 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
@@ -83,7 +83,8 @@
 this.componentProvider = componentProvider;
 }
 
-public void doPost(IServletRequest request, IServletResponse response) {
+@Override
+protected void post(IServletRequest request, IServletResponse response) {
 // Query language
 ILangCompilationProvider compilationProvider = 
"AQL".equals(request.getParameter("query-language"))
 ? aqlCompilationProvider : sqlppCompilationProvider;
@@ -157,7 +158,8 @@
 }
 }
 
-public void doGet(IServletRequest request, IServletResponse response) {
+@Override
+protected void get(IServletRequest request, IServletResponse response) {
 String resourcePath = null;
 String requestURI = request.getHttpRequest().uri();
 
@@ -226,17 +228,4 @@
 private static boolean isSet(String requestParameter) {
 return requestParameter != null && "true".equals(requestParameter);
 }
-
-@Override
-public void handle(IServletRequest request, IServletResponse response) {
-response.setStatus(HttpResponseStatus.OK);
-if (request.getHttpRequest().method() == HttpMethod.GET) {
-doGet(request, response);
-} else if (request.getHttpRequest().method() == HttpMethod.POST) {
-doPost(request, response);
-} else {
-response.setStatus(HttpResponseStatus.METHOD_NOT_ALLOWED);
-}
-}
-
 }
diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
index 71559b1..1d37baf 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
@@ -65,7 +65,8 @@
 super(ctx, paths);
 }
 
-protected void getUnsafe(IServletRequest request, IServletResponse 
response) throws IOException {
+@Override
+protected void get(IServletRequest request, IServletResponse response) 
throws IOException {
 HttpUtil.setContentType(response, 
HttpUtil.ContentType.APPLICATION_JSON, HttpUtil.Encoding.UTF8);
 PrintWriter responseWriter = response.writer();
 try {
@@ -173,18 +174,4 @@
 }
 return clusterURL;
 }
-
-@Override
-public void handle(IServletRequest request, IServletResponse response) {
-if (request.getHttpRequest().method() != HttpMethod.GET) {
-response.setStatus(HttpResponseStatus.METHOD_NOT_ALLOWED);
-return;
-  

Change in asterixdb[master]: ASTERIXDB-1786: Remove Hyracks Servlets.

2017-02-21 Thread Till Westmann (Code Review)
Hello abdullah alamoudi, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1508

to look at the new patch set (#11).

Change subject: ASTERIXDB-1786: Remove Hyracks Servlets.
..

ASTERIXDB-1786: Remove Hyracks Servlets.

Change-Id: Ifcd240591d12baab2db4ce3163c635a1dde5c4ba
---
M asterixdb/asterix-app/pom.xml
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryWebInterfaceServlet.java
M asterixdb/asterix-common/pom.xml
M asterixdb/pom.xml
M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerService.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/web/ApplicationInstallationHandler.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/web/JobsRESTAPIFunction.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/web/WebServer.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/web/util/JSONOutputRequestHandler.java
M hyracks-fullstack/hyracks/hyracks-http/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/AbstractServlet.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServerHandler.java
A 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/PutRequest.java
A 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/StaticResourceServlet.java
M hyracks-fullstack/pom.xml
17 files changed, 361 insertions(+), 237 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/08/1508/11
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1508
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifcd240591d12baab2db4ce3163c635a1dde5c4ba
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 


[jira] [Commented] (ASTERIXDB-1804) HTTP framework does not handle all HTTP verbs

2017-02-21 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876783#comment-15876783
 ] 

ASF subversion and git services commented on ASTERIXDB-1804:


Commit 6fc1f7b31ee6d2c86c5478e6a0d0cf4d2b711bf0 in asterixdb's branch 
refs/heads/master from [~alamoudi]
[ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=6fc1f7b ]

ASTERIXDB-1804: support more HTTP verbs

- add verb-based routing to AbstractServlet.handle (subclasses implement
  verb-specific methods like get, post, ...)
- move construction logic for IServletRequests from HttpUtil to request
  classes
- remove verb-checking from HttpServerHandler

Change-Id: I2d14ce9c3c34d345fe71a44518b1e95b79c37dab
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1516
Reviewed-by: abdullah alamoudi 
Tested-by: Jenkins 


> HTTP framework does not handle all HTTP verbs
> -
>
> Key: ASTERIXDB-1804
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1804
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: HTTP API, Hyracks
>Reporter: Till
>Assignee: Till
>
> The HTTP framework in org.apache.hyracks.http currently only supports GET and 
> POST requests. It needs to be extended to support all HTTP verbs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Change in asterixdb[master]: ASTERIXDB-1804: support more HTTP verbs

2017-02-21 Thread Till Westmann (Code Review)
Till Westmann has submitted this change and it was merged.

Change subject: ASTERIXDB-1804: support more HTTP verbs
..


ASTERIXDB-1804: support more HTTP verbs

- add verb-based routing to AbstractServlet.handle (subclasses implement
  verb-specific methods like get, post, ...)
- move construction logic for IServletRequests from HttpUtil to request
  classes
- remove verb-checking from HttpServerHandler

Change-Id: I2d14ce9c3c34d345fe71a44518b1e95b79c37dab
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1516
Reviewed-by: abdullah alamoudi 
Tested-by: Jenkins 
---
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/AbstractServlet.java
R 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/BaseRequest.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedResponse.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServerHandler.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/PostRequest.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/utils/HttpUtil.java
6 files changed, 129 insertions(+), 69 deletions(-)

Approvals:
  abdullah alamoudi: Looks good to me, approved
  Jenkins: Verified

Objections:
  Jenkins: Violations found; Violations found



diff --git 
a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/AbstractServlet.java
 
b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/AbstractServlet.java
index 7d24994..2795549 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/AbstractServlet.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/AbstractServlet.java
@@ -19,11 +19,19 @@
 package org.apache.hyracks.http.server;
 
 import java.util.concurrent.ConcurrentMap;
+import java.util.logging.Level;
+import java.util.logging.Logger;
 
 import org.apache.hyracks.http.api.IServlet;
 import org.apache.hyracks.http.api.IServletRequest;
+import org.apache.hyracks.http.api.IServletResponse;
+
+import io.netty.handler.codec.http.HttpMethod;
+import io.netty.handler.codec.http.HttpResponseStatus;
 
 public abstract class AbstractServlet implements IServlet {
+private static final Logger LOGGER = 
Logger.getLogger(AbstractServlet.class.getName());
+
 protected final String[] paths;
 protected final ConcurrentMap ctx;
 private final int[] trims;
@@ -54,6 +62,67 @@
 return ctx;
 }
 
+@Override
+public void handle(IServletRequest request, IServletResponse response) {
+try {
+final HttpMethod method = request.getHttpRequest().method();
+if (HttpMethod.GET.equals(method)) {
+get(request, response);
+} else if (HttpMethod.HEAD.equals(method)) {
+head(request, response);
+} else if (HttpMethod.POST.equals(method)) {
+post(request, response);
+} else if (HttpMethod.PUT.equals(method)) {
+put(request, response);
+} else if (HttpMethod.DELETE.equals(method)) {
+delete(request, response);
+} else if (HttpMethod.OPTIONS.equals(method)) {
+options(request, response);
+} else {
+response.setStatus(HttpResponseStatus.METHOD_NOT_ALLOWED);
+}
+} catch (Exception e) {
+LOGGER.log(Level.WARNING, "Unhandled exception", e);
+response.setStatus(HttpResponseStatus.INTERNAL_SERVER_ERROR);
+}
+}
+
+@SuppressWarnings("squid:S1172")
+protected void get(IServletRequest request, IServletResponse response) 
throws Exception {
+// designed to be extended but an error in standard case
+response.setStatus(HttpResponseStatus.METHOD_NOT_ALLOWED);
+}
+
+@SuppressWarnings("squid:S1172")
+protected void head(IServletRequest request, IServletResponse response) 
throws Exception {
+// designed to be extended but an error in standard case
+response.setStatus(HttpResponseStatus.METHOD_NOT_ALLOWED);
+}
+
+@SuppressWarnings("squid:S1172")
+protected void post(IServletRequest request, IServletResponse response) 
throws Exception {
+// designed to be extended but an error in standard case
+response.setStatus(HttpResponseStatus.METHOD_NOT_ALLOWED);
+}
+
+@SuppressWarnings("squid:S1172")
+protected void put(IServletRequest request, IServletResponse response) 
throws Exception {
+// designed to be extended but an error in standard case
+response.setStatus(HttpResponseStatus.METHOD_NOT_ALLOWED);
+}
+
+

Change in asterixdb[master]: ASTERIXDB-1804: support more HTTP verbs

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1804: support more HTTP verbs
..


Patch Set 3: BAD-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/588/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1516
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d14ce9c3c34d345fe71a44518b1e95b79c37dab
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1804: support more HTTP verbs

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1804: support more HTTP verbs
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1946/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1516
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d14ce9c3c34d345fe71a44518b1e95b79c37dab
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1804: support more HTTP verbs

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1804: support more HTTP verbs
..


Patch Set 3:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/588/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1516
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d14ce9c3c34d345fe71a44518b1e95b79c37dab
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1804: support more HTTP verbs

2017-02-21 Thread abdullah alamoudi (Code Review)
abdullah alamoudi has posted comments on this change.

Change subject: ASTERIXDB-1804: support more HTTP verbs
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1516
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d14ce9c3c34d345fe71a44518b1e95b79c37dab
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1804: support more HTTP verbs

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1804: support more HTTP verbs
..


Patch Set 2: BAD-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/587/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1516
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d14ce9c3c34d345fe71a44518b1e95b79c37dab
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1804: support more HTTP verbs

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1804: support more HTTP verbs
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4363/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1516
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d14ce9c3c34d345fe71a44518b1e95b79c37dab
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1804: support more HTTP verbs

2017-02-21 Thread abdullah alamoudi (Code Review)
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1516

to look at the new patch set (#3).

Change subject: ASTERIXDB-1804: support more HTTP verbs
..

ASTERIXDB-1804: support more HTTP verbs

- add verb-based routing to AbstractServlet.handle (subclasses implement
  verb-specific methods like get, post, ...)
- move construction logic for IServletRequests from HttpUtil to request
  classes
- remove verb-checking from HttpServerHandler

Change-Id: I2d14ce9c3c34d345fe71a44518b1e95b79c37dab
---
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/AbstractServlet.java
R 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/BaseRequest.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedResponse.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServerHandler.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/PostRequest.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/utils/HttpUtil.java
6 files changed, 129 insertions(+), 69 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/16/1516/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1516
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2d14ce9c3c34d345fe71a44518b1e95b79c37dab
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 


Change in asterixdb[master]: ASTERIXDB-1804: support more HTTP verbs

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1804: support more HTTP verbs
..


Patch Set 2:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/587/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1516
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d14ce9c3c34d345fe71a44518b1e95b79c37dab
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1804: support more HTTP verbs

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1804: support more HTTP verbs
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1945/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1516
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d14ce9c3c34d345fe71a44518b1e95b79c37dab
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1804: support more HTTP verbs

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1804: support more HTTP verbs
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4362/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1516
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d14ce9c3c34d345fe71a44518b1e95b79c37dab
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1804: support more HTTP verbs

2017-02-21 Thread Till Westmann (Code Review)
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1516

to look at the new patch set (#2).

Change subject: ASTERIXDB-1804: support more HTTP verbs
..

ASTERIXDB-1804: support more HTTP verbs

- add verb-based routing to AbstractServlet.handle (subclasses implement
  verb-specific methods like get, post, ...)
- move construction logic for IServletRequests from HttpUtil to request
  classes
- remove verb-checking from HttpServerHandler

Change-Id: I2d14ce9c3c34d345fe71a44518b1e95b79c37dab
---
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/AbstractServlet.java
R 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/BaseRequest.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServerHandler.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/PostRequest.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/utils/HttpUtil.java
5 files changed, 125 insertions(+), 69 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/16/1516/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1516
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2d14ce9c3c34d345fe71a44518b1e95b79c37dab
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 


Change in asterixdb[master]: ASTERIXDB-1804: support more HTTP verbs

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1804: support more HTTP verbs
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1944/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1516
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d14ce9c3c34d345fe71a44518b1e95b79c37dab
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1804: support more HTTP verbs

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1804: support more HTTP verbs
..


Patch Set 1: BAD-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/586/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1516
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d14ce9c3c34d345fe71a44518b1e95b79c37dab
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1804: support more HTTP verbs

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1804: support more HTTP verbs
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/586/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1516
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d14ce9c3c34d345fe71a44518b1e95b79c37dab
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1804: support more HTTP verbs

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1804: support more HTTP verbs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4361/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1516
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d14ce9c3c34d345fe71a44518b1e95b79c37dab
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1804: support more HTTP verbs

2017-02-21 Thread Till Westmann (Code Review)
Till Westmann has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1516

Change subject: ASTERIXDB-1804: support more HTTP verbs
..

ASTERIXDB-1804: support more HTTP verbs

Change-Id: I2d14ce9c3c34d345fe71a44518b1e95b79c37dab
---
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/AbstractServlet.java
R 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/BaseRequest.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServerHandler.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/PostRequest.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/utils/HttpUtil.java
5 files changed, 113 insertions(+), 67 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/16/1516/1

diff --git 
a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/AbstractServlet.java
 
b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/AbstractServlet.java
index 7d24994..93bdb38 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/AbstractServlet.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/AbstractServlet.java
@@ -19,11 +19,19 @@
 package org.apache.hyracks.http.server;
 
 import java.util.concurrent.ConcurrentMap;
+import java.util.logging.Level;
+import java.util.logging.Logger;
 
 import org.apache.hyracks.http.api.IServlet;
 import org.apache.hyracks.http.api.IServletRequest;
+import org.apache.hyracks.http.api.IServletResponse;
+
+import io.netty.handler.codec.http.HttpMethod;
+import io.netty.handler.codec.http.HttpResponseStatus;
 
 public abstract class AbstractServlet implements IServlet {
+private static final Logger LOGGER = 
Logger.getLogger(AbstractServlet.class.getName());
+
 protected final String[] paths;
 protected final ConcurrentMap ctx;
 private final int[] trims;
@@ -54,6 +62,55 @@
 return ctx;
 }
 
+@Override
+public void handle(IServletRequest request, IServletResponse response) {
+try {
+final HttpMethod method = request.getHttpRequest().method();
+if (HttpMethod.GET.equals(method)) {
+get(request, response);
+} else if (HttpMethod.HEAD.equals(method)) {
+head(request, response);
+} else if (HttpMethod.POST.equals(method)) {
+post(request, response);
+} else if (HttpMethod.PUT.equals(method)) {
+put(request, response);
+} else if (HttpMethod.DELETE.equals(method)) {
+delete(request, response);
+} else if (HttpMethod.OPTIONS.equals(method)) {
+options(request, response);
+} else {
+response.setStatus(HttpResponseStatus.METHOD_NOT_ALLOWED);
+}
+} catch (Exception e) {
+LOGGER.log(Level.WARNING, "Unhandled exception", e);
+response.setStatus(HttpResponseStatus.INTERNAL_SERVER_ERROR);
+}
+}
+
+protected void get(IServletRequest request, IServletResponse response) 
throws Exception {
+response.setStatus(HttpResponseStatus.METHOD_NOT_ALLOWED);
+}
+
+protected void head(IServletRequest request, IServletResponse response) 
throws Exception {
+response.setStatus(HttpResponseStatus.METHOD_NOT_ALLOWED);
+}
+
+protected void post(IServletRequest request, IServletResponse response) 
throws Exception {
+response.setStatus(HttpResponseStatus.METHOD_NOT_ALLOWED);
+}
+
+protected void put(IServletRequest request, IServletResponse response) 
throws Exception {
+response.setStatus(HttpResponseStatus.METHOD_NOT_ALLOWED);
+}
+
+protected void delete(IServletRequest request, IServletResponse response) 
throws Exception {
+response.setStatus(HttpResponseStatus.METHOD_NOT_ALLOWED);
+}
+
+protected void options(IServletRequest request, IServletResponse response) 
throws Exception {
+response.setStatus(HttpResponseStatus.METHOD_NOT_ALLOWED);
+}
+
 public String path(IServletRequest request) {
 int trim = -1;
 if (paths.length > 1) {
diff --git 
a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/GetRequest.java
 
b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/BaseRequest.java
similarity index 74%
rename from 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/GetRequest.java
rename to 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/BaseRequest.java
index e666c0a..d271177 100644
--- 

[jira] [Created] (ASTERIXDB-1806) IllegalStateException from BTreeAccessMethod

2017-02-21 Thread Yingyi Bu (JIRA)
Yingyi Bu created ASTERIXDB-1806:


 Summary: IllegalStateException from BTreeAccessMethod
 Key: ASTERIXDB-1806
 URL: https://issues.apache.org/jira/browse/ASTERIXDB-1806
 Project: Apache AsterixDB
  Issue Type: Bug
  Components: Compiler
Reporter: Yingyi Bu
Assignee: Taewoo Kim


DDL:

{noformat}
drop  dataverse tpch if exists;
create  dataverse tpch;

use tpch;


create type LineItemType as
 closed {
  l_orderkey : integer,
  l_partkey : integer,
  l_suppkey : integer,
  l_linenumber : integer,
  l_quantity : double,
  l_extendedprice : double,
  l_discount : double,
  l_tax : double,
  l_returnflag : string,
  l_linestatus : string,
  l_shipdate : string,
  l_commitdate : string,
  l_receiptdate : string,
  l_shipinstruct : string,
  l_shipmode : string,
  l_comment : string
}

create  dataset LineItem(LineItemType) primary key l_orderkey,l_linenumber;
{noformat}

Query:
{noformat}
USE tpch;

SET `import-private-functions` "true";

SELECT  l_returnflag,
l_linestatus,
sum(l_quantity) AS sum_qty,
sum(l_extendedprice) AS sum_base_price,
sum(l_extendedprice * (1 - l_discount)) AS sum_disc_price,
sum(l_extendedprice * (1 - l_discount) * (1 + l_tax)) AS sum_charge,
avg(l_quantity) AS ave_qty,
avg(l_extendedprice) AS ave_price,
avg(l_discount) AS ave_disc,
count(1) AS count_order
FROM  LineItem l
WHERE inject_failure(l.l_shipdate <= '1998-09-02', l.l_orderkey=5988)
GROUP BY l_returnflag, l_linestatus
ORDER BY l_returnflag, l_linestatus
;
{noformat}


Exception:
{noformat}
java.lang.IllegalStateException
at 
org.apache.asterix.optimizer.rules.am.BTreeAccessMethod.getNewConditionExprs(BTreeAccessMethod.java:651)
at 
org.apache.asterix.optimizer.rules.am.BTreeAccessMethod.createSecondaryToPrimaryPlan(BTreeAccessMethod.java:544)
at 
org.apache.asterix.optimizer.rules.am.BTreeAccessMethod.applySelectPlanTransformation(BTreeAccessMethod.java:129)
at 
org.apache.asterix.optimizer.rules.am.IntroduceSelectAccessMethodRule.intersectAllSecondaryIndexes(IntroduceSelectAccessMethodRule.java:221)
at 
org.apache.asterix.optimizer.rules.am.IntroduceSelectAccessMethodRule.checkAndApplyTheSelectTransformationRule(IntroduceSelectAccessMethodRule.java:176)
at 
org.apache.asterix.optimizer.rules.am.IntroduceSelectAccessMethodRule.checkAndApplyTheSelectTransformationRule(IntroduceSelectAccessMethodRule.java:195)
at 
org.apache.asterix.optimizer.rules.am.IntroduceSelectAccessMethodRule.checkAndApplyTheSelectTransformationRule(IntroduceSelectAccessMethodRule.java:195)
at 
org.apache.asterix.optimizer.rules.am.IntroduceSelectAccessMethodRule.checkAndApplyTheSelectTransformationRule(IntroduceSelectAccessMethodRule.java:195)
at 
org.apache.asterix.optimizer.rules.am.IntroduceSelectAccessMethodRule.checkAndApplyTheSelectTransformationRule(IntroduceSelectAccessMethodRule.java:195)
at 
org.apache.asterix.optimizer.rules.am.IntroduceSelectAccessMethodRule.checkAndApplyTheSelectTransformationRule(IntroduceSelectAccessMethodRule.java:195)
at 
org.apache.asterix.optimizer.rules.am.IntroduceSelectAccessMethodRule.checkAndApplyTheSelectTransformationRule(IntroduceSelectAccessMethodRule.java:195)
at 
org.apache.asterix.optimizer.rules.am.IntroduceSelectAccessMethodRule.rewritePost(IntroduceSelectAccessMethodRule.java:130)
at 
org.apache.hyracks.algebricks.core.rewriter.base.AbstractRuleController.rewriteOperatorRef(AbstractRuleController.java:126)
at 
org.apache.hyracks.algebricks.compiler.rewriter.rulecontrollers.SequentialFixpointRuleController.rewriteWithRuleCollection(SequentialFixpointRuleController.java:53)
at 
org.apache.hyracks.algebricks.core.rewriter.base.HeuristicOptimizer.runOptimizationSets(HeuristicOptimizer.java:102)
at 
org.apache.hyracks.algebricks.core.rewriter.base.HeuristicOptimizer.optimize(HeuristicOptimizer.java:82)
at 
org.apache.hyracks.algebricks.compiler.api.HeuristicCompilerFactoryBuilder$1$1.optimize(HeuristicCompilerFactoryBuilder.java:90)
at 
org.apache.asterix.api.common.APIFramework.compileQuery(APIFramework.java:251)
at 
org.apache.asterix.app.translator.QueryTranslator.rewriteCompileQuery(QueryTranslator.java:1920)
at 
org.apache.asterix.app.translator.QueryTranslator.lambda$handleQuery$1(QueryTranslator.java:2393)
at 
org.apache.asterix.app.translator.QueryTranslator$$Lambda$67/2055910122.compile(Unknown
 Source)
at 
org.apache.asterix.app.translator.QueryTranslator.createAndRunJob(QueryTranslator.java:2459)
at 
org.apache.asterix.app.translator.QueryTranslator.deliverResult(QueryTranslator.java:2438)
at 
org.apache.asterix.app.translator.QueryTranslator.handleQuery(QueryTranslator.java:2405)
at 

Change in asterixdb[master]: ASTERIXDB-1786: Remove Hyracks Servlets.

2017-02-21 Thread abdullah alamoudi (Code Review)
abdullah alamoudi has posted comments on this change.

Change subject: ASTERIXDB-1786: Remove Hyracks Servlets.
..


Patch Set 10:

That is a longer discussion. and who should decide that and how. Just wanted to 
point that out :)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1508
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcd240591d12baab2db4ce3163c635a1dde5c4ba
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


[jira] [Created] (ASTERIXDB-1805) Sporadic failure in BufferCacheRegressionTest testFlushBehaviorOnFileEviction

2017-02-21 Thread Till (JIRA)
Till created ASTERIXDB-1805:
---

 Summary: Sporadic failure in BufferCacheRegressionTest 
testFlushBehaviorOnFileEviction
 Key: ASTERIXDB-1805
 URL: https://issues.apache.org/jira/browse/ASTERIXDB-1805
 Project: Apache AsterixDB
  Issue Type: Bug
  Components: Hyracks, Storage
 Environment: macOS
Reporter: Till


Saw this in a run of `mvn verify`:
{noformat}
Running org.apache.hyracks.storage.common.BufferCacheRegressionTest
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.201 sec <<< 
FAILURE! - in org.apache.hyracks.storage.common.BufferCacheRegressionTest
testFlushBehaviorOnFileEviction(org.apache.hyracks.storage.common.BufferCacheRegressionTest)
  Time elapsed: 0.03 sec  <<< FAILURE!
java.lang.AssertionError: Page 0 of deleted file was fazily flushed in 
openFile(), corrupting the data of a newly created file with the same name.
at org.junit.Assert.fail(Assert.java:88)
at 
org.apache.hyracks.storage.common.BufferCacheRegressionTest.flushBehaviorTest(BufferCacheRegressionTest.java:131)
at 
org.apache.hyracks.storage.common.BufferCacheRegressionTest.testFlushBehaviorOnFileEviction(BufferCacheRegressionTest.java:71)
{noformat}

Git master was at 
https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;a=commit;h=55dd6ff1e821909b9bab447a10bcb50d4dbcc132



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Change in asterixdb[master]: ASTERIXDB-1786: Remove Hyracks Servlets.

2017-02-21 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1786: Remove Hyracks Servlets.
..


Patch Set 10:

Created ASTERIXDB-1804 to address the issue of non-supported verbs.

I'm not sure I understand the suggestion regarding the EventLoopGroups. Should 
we aim to expose the Hyracks WebServer and/or WebManager to Hyracks 
applications (like AsterixDB) so that they can share resources?

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1508
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcd240591d12baab2db4ce3163c635a1dde5c4ba
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


[jira] [Created] (ASTERIXDB-1804) HTTP framework does not handle all HTTP verbs

2017-02-21 Thread Till (JIRA)
Till created ASTERIXDB-1804:
---

 Summary: HTTP framework does not handle all HTTP verbs
 Key: ASTERIXDB-1804
 URL: https://issues.apache.org/jira/browse/ASTERIXDB-1804
 Project: Apache AsterixDB
  Issue Type: Bug
  Components: HTTP API, Hyracks
Reporter: Till
Assignee: Till


The HTTP framework in org.apache.hyracks.http currently only supports GET and 
POST requests. It needs to be extended to support all HTTP verbs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Change in asterixdb[master]: ASTERIXDB-1786: Remove Hyracks Servlets.

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1786: Remove Hyracks Servlets.
..


Patch Set 10: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1943/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1508
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcd240591d12baab2db4ce3163c635a1dde5c4ba
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: WIP: Configuration Revamp

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: WIP: Configuration Revamp
..


Patch Set 15: Integration-Tests-1

Integration Tests Timed Out

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1942/ 
: ABORTED

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1786: Remove Hyracks Servlets.

2017-02-21 Thread abdullah alamoudi (Code Review)
abdullah alamoudi has posted comments on this change.

Change subject: ASTERIXDB-1786: Remove Hyracks Servlets.
..


Patch Set 10: Code-Review+2

(3 comments)

Few comments. Feel free to ignore the renaming ones (Your call). as for the 
third one, you can either address it or create a JIRA, or a todo comment for it.

https://asterix-gerrit.ics.uci.edu/#/c/1508/10/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/web/ApplicationInstallationHandler.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/web/ApplicationInstallationHandler.java:

PS10, Line 43: ApplicationInstallationHandler
this should be renamed to match the convention for servlets?


https://asterix-gerrit.ics.uci.edu/#/c/1508/10/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/web/WebServer.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/web/WebServer.java:

PS10, Line 70: JSONOutputRequestHandler
not sure anymore if we should rename to match the servlet naming convention. 
your call till


https://asterix-gerrit.ics.uci.edu/#/c/1508/10/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServerHandler.java
File 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServerHandler.java:

PS10, Line 70: HttpMethod.POST
need to understand how this affect existing servlets as they were written with 
the assumption that a non Get and non Post request will not get through.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1508
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcd240591d12baab2db4ce3163c635a1dde5c4ba
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes


Change in asterixdb[master]: Fix Race Condition in Hyracks/AlgebricksException

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix Race Condition in Hyracks/AlgebricksException
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1941/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1515
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2879e293af78ec54b3201a748981c32faa481f1a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1786: Remove Hyracks Servlets.

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1786: Remove Hyracks Servlets.
..


Patch Set 10:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1943/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1508
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcd240591d12baab2db4ce3163c635a1dde5c4ba
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1786: Remove Hyracks Servlets.

2017-02-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1786: Remove Hyracks Servlets.
..


Patch Set 10: BAD-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/585/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1508
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcd240591d12baab2db4ce3163c635a1dde5c4ba
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No