Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
abdullah alamoudi has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
abdullah alamoudi has submitted this change and it was merged. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. [NO ISSUE] Only close the index in the close of the Upsert Operator - user model changes: no - storage format changes: no - interface changes: no details: - Previously, a failure in the opening of the upsert operator will cause the index to be closed twice. - After this change, we only close the index in the close call of the operator. Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Reviewed-on: https://asterix-gerrit.ics.uci.edu/2378 Sonar-Qube: Jenkins Tested-by: Jenkins Contrib: Jenkins Integration-Tests: Jenkins Reviewed-by: abdullah alamoudi --- M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Anon. E. Moose #1000171: abdullah alamoudi: Looks good to me, approved Jenkins: Verified; No violations found; ; Verified diff --git a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java index 6bd9d99..e33dfb6 100644 --- a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java +++ b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java @@ -244,10 +244,8 @@ appender.write(writer, true); } }; - -} catch (Exception e) { -indexHelper.close(); -throw new HyracksDataException(e); +} catch (Throwable e) { // NOSONAR: Re-thrown +throw HyracksDataException.create(e); } } -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5597/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 2: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/Z6Grf6 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 2: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2679/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 2: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2679/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3194/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 2: Analytics Compatibility Compilation Successful https://goo.gl/FfPjJ7 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5597/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/682/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2627/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3166/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3206/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2653/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6625/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8131/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3421/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2581/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/2892/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2633/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5571/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 1: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2658/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2658/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3165/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3139/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3394/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5571/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2615/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 1: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/R845RH : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/gBWP3X : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/2866/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6599/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8105/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2607/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2614/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2593/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/656/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3180/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2552/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Only close the index in the close of the Upsert O...
abdullah alamoudi has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/2378 Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator .. [NO ISSUE] Only close the index in the close of the Upsert Operator - user model changes: no - storage format changes: no - interface changes: no details: - Previously, a failure in the opening of the upsert operator will cause the index to be closed twice. - After this change, we only close the index in the close call of the operator. Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 --- M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/78/2378/1 diff --git a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java index 21259cc..91bb9c8 100644 --- a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java +++ b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java @@ -241,10 +241,8 @@ appender.write(writer, true); } }; - -} catch (Exception e) { -indexHelper.close(); -throw new HyracksDataException(e); +} catch (Throwable e) { // NOSONAR: Re-thrown +throw HyracksDataException.create(e); } } -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi