Change in asterixdb[master]: [NO ISSUE] Pass Request Parameters to DDLs
Murtadha Hubail has submitted this change and it was merged. Change subject: [NO ISSUE] Pass Request Parameters to DDLs .. [NO ISSUE] Pass Request Parameters to DDLs - user model changes: no - storage format changes: no - interface changes: no Details: - Pass RequestParameters to create/drop dataset/index to allow QueryTranslator extensions to consume them. Change-Id: I044e97d001fc42caa137de0a89fb27c47a88ef3c Reviewed-on: https://asterix-gerrit.ics.uci.edu/2053 Integration-Tests: JenkinsTested-by: Jenkins Reviewed-by: Till Westmann --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java 1 file changed, 10 insertions(+), 10 deletions(-) Approvals: Till Westmann: Looks good to me, approved Jenkins: Verified; Verified Objections: Anon. E. Moose #1000171: Jenkins: Violations found; diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java index 454b501..6b4483c 100644 --- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java +++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java @@ -300,10 +300,10 @@ handleCreateDataverseStatement(metadataProvider, stmt); break; case Statement.Kind.DATASET_DECL: -handleCreateDatasetStatement(metadataProvider, stmt, hcc); +handleCreateDatasetStatement(metadataProvider, stmt, hcc, requestParameters); break; case Statement.Kind.CREATE_INDEX: -handleCreateIndexStatement(metadataProvider, stmt, hcc); +handleCreateIndexStatement(metadataProvider, stmt, hcc, requestParameters); break; case Statement.Kind.TYPE_DECL: handleCreateTypeStatement(metadataProvider, stmt); @@ -315,10 +315,10 @@ handleDataverseDropStatement(metadataProvider, stmt, hcc); break; case Statement.Kind.DATASET_DROP: -handleDatasetDropStatement(metadataProvider, stmt, hcc); +handleDatasetDropStatement(metadataProvider, stmt, hcc, requestParameters); break; case Statement.Kind.INDEX_DROP: -handleIndexDropStatement(metadataProvider, stmt, hcc); +handleIndexDropStatement(metadataProvider, stmt, hcc, requestParameters); break; case Statement.Kind.TYPE_DROP: handleTypeDropStatement(metadataProvider, stmt); @@ -512,7 +512,7 @@ } public void handleCreateDatasetStatement(MetadataProvider metadataProvider, Statement stmt, -IHyracksClientConnection hcc) throws CompilationException, Exception { +IHyracksClientConnection hcc, IRequestParameters requestParameters) throws CompilationException, Exception { MutableObject progress = new MutableObject<>(ProgressState.NO_PROGRESS); DatasetDecl dd = (DatasetDecl) stmt; String dataverseName = getActiveDataverse(dd.getDataverse()); @@ -741,7 +741,7 @@ } protected void handleCreateIndexStatement(MetadataProvider metadataProvider, Statement stmt, -IHyracksClientConnection hcc) throws Exception { +IHyracksClientConnection hcc, IRequestParameters requestParameters) throws Exception { CreateIndexStatement stmtCreateIndex = (CreateIndexStatement) stmt; String dataverseName = getActiveDataverse(stmtCreateIndex.getDataverseName()); String datasetName = stmtCreateIndex.getDatasetName().getValue(); @@ -1338,7 +1338,7 @@ } public void handleDatasetDropStatement(MetadataProvider metadataProvider, Statement stmt, -IHyracksClientConnection hcc) throws Exception { +IHyracksClientConnection hcc, IRequestParameters requestParameters) throws Exception { DropDatasetStatement stmtDelete = (DropDatasetStatement) stmt; String dataverseName = getActiveDataverse(stmtDelete.getDataverseName()); String datasetName = stmtDelete.getDatasetName().getValue(); @@ -1409,7 +1409,7 @@ } protected void handleIndexDropStatement(MetadataProvider metadataProvider, Statement stmt, -IHyracksClientConnection hcc) throws Exception { +IHyracksClientConnection hcc, IRequestParameters requestParameters) throws Exception { IndexDropStatement stmtIndexDrop = (IndexDropStatement)
Change in asterixdb[master]: [NO ISSUE] Pass Request Parameters to DDLs
Till Westmann has posted comments on this change. Change subject: [NO ISSUE] Pass Request Parameters to DDLs .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2053 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I044e97d001fc42caa137de0a89fb27c47a88ef3c Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Pass Request Parameters to DDLs
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE] Pass Request Parameters to DDLs .. Patch Set 1: Analytics Compatibility Tests Failed Build 2711 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2053 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I044e97d001fc42caa137de0a89fb27c47a88ef3c Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Pass Request Parameters to DDLs
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE] Pass Request Parameters to DDLs .. Patch Set 1: Contrib-1 Analytics Compatibility Tests Failed Build 2710 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2053 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I044e97d001fc42caa137de0a89fb27c47a88ef3c Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Pass Request Parameters to DDLs
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Pass Request Parameters to DDLs .. Patch Set 1: Contrib-1 BAD Compatibility Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1893/ : FAILURE -- To view, visit https://asterix-gerrit.ics.uci.edu/2053 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I044e97d001fc42caa137de0a89fb27c47a88ef3c Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Pass Request Parameters to DDLs
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Pass Request Parameters to DDLs .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1893/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2053 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I044e97d001fc42caa137de0a89fb27c47a88ef3c Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Pass Request Parameters to DDLs
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Pass Request Parameters to DDLs .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4183/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2053 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I044e97d001fc42caa137de0a89fb27c47a88ef3c Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Pass Request Parameters to DDLs
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Pass Request Parameters to DDLs .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1800/ (10/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2053 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I044e97d001fc42caa137de0a89fb27c47a88ef3c Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Pass Request Parameters to DDLs
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Pass Request Parameters to DDLs .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4183/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2053 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I044e97d001fc42caa137de0a89fb27c47a88ef3c Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Pass Request Parameters to DDLs
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Pass Request Parameters to DDLs .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1134/ (4/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2053 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I044e97d001fc42caa137de0a89fb27c47a88ef3c Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Pass Request Parameters to DDLs
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Pass Request Parameters to DDLs .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5182/ (2/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2053 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I044e97d001fc42caa137de0a89fb27c47a88ef3c Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Pass Request Parameters to DDLs
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Pass Request Parameters to DDLs .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1799/ (7/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2053 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I044e97d001fc42caa137de0a89fb27c47a88ef3c Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Pass Request Parameters to DDLs
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Pass Request Parameters to DDLs .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1741/ (9/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2053 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I044e97d001fc42caa137de0a89fb27c47a88ef3c Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Pass Request Parameters to DDLs
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Pass Request Parameters to DDLs .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1133/ (6/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2053 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I044e97d001fc42caa137de0a89fb27c47a88ef3c Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Pass Request Parameters to DDLs
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Pass Request Parameters to DDLs .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1463/ (5/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2053 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I044e97d001fc42caa137de0a89fb27c47a88ef3c Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Pass Request Parameters to DDLs
Murtadha Hubail has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/2053 Change subject: [NO ISSUE] Pass Request Parameters to DDLs .. [NO ISSUE] Pass Request Parameters to DDLs - user model changes: no - storage format changes: no - interface changes: no Details: - Pass RequestParameters to create/drop dataset/index to allow QueryTranslator extensions to consume them. Change-Id: I044e97d001fc42caa137de0a89fb27c47a88ef3c --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java 1 file changed, 10 insertions(+), 10 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/53/2053/1 diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java index 454b501..6b4483c 100644 --- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java +++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java @@ -300,10 +300,10 @@ handleCreateDataverseStatement(metadataProvider, stmt); break; case Statement.Kind.DATASET_DECL: -handleCreateDatasetStatement(metadataProvider, stmt, hcc); +handleCreateDatasetStatement(metadataProvider, stmt, hcc, requestParameters); break; case Statement.Kind.CREATE_INDEX: -handleCreateIndexStatement(metadataProvider, stmt, hcc); +handleCreateIndexStatement(metadataProvider, stmt, hcc, requestParameters); break; case Statement.Kind.TYPE_DECL: handleCreateTypeStatement(metadataProvider, stmt); @@ -315,10 +315,10 @@ handleDataverseDropStatement(metadataProvider, stmt, hcc); break; case Statement.Kind.DATASET_DROP: -handleDatasetDropStatement(metadataProvider, stmt, hcc); +handleDatasetDropStatement(metadataProvider, stmt, hcc, requestParameters); break; case Statement.Kind.INDEX_DROP: -handleIndexDropStatement(metadataProvider, stmt, hcc); +handleIndexDropStatement(metadataProvider, stmt, hcc, requestParameters); break; case Statement.Kind.TYPE_DROP: handleTypeDropStatement(metadataProvider, stmt); @@ -512,7 +512,7 @@ } public void handleCreateDatasetStatement(MetadataProvider metadataProvider, Statement stmt, -IHyracksClientConnection hcc) throws CompilationException, Exception { +IHyracksClientConnection hcc, IRequestParameters requestParameters) throws CompilationException, Exception { MutableObject progress = new MutableObject<>(ProgressState.NO_PROGRESS); DatasetDecl dd = (DatasetDecl) stmt; String dataverseName = getActiveDataverse(dd.getDataverse()); @@ -741,7 +741,7 @@ } protected void handleCreateIndexStatement(MetadataProvider metadataProvider, Statement stmt, -IHyracksClientConnection hcc) throws Exception { +IHyracksClientConnection hcc, IRequestParameters requestParameters) throws Exception { CreateIndexStatement stmtCreateIndex = (CreateIndexStatement) stmt; String dataverseName = getActiveDataverse(stmtCreateIndex.getDataverseName()); String datasetName = stmtCreateIndex.getDatasetName().getValue(); @@ -1338,7 +1338,7 @@ } public void handleDatasetDropStatement(MetadataProvider metadataProvider, Statement stmt, -IHyracksClientConnection hcc) throws Exception { +IHyracksClientConnection hcc, IRequestParameters requestParameters) throws Exception { DropDatasetStatement stmtDelete = (DropDatasetStatement) stmt; String dataverseName = getActiveDataverse(stmtDelete.getDataverseName()); String datasetName = stmtDelete.getDatasetName().getValue(); @@ -1409,7 +1409,7 @@ } protected void handleIndexDropStatement(MetadataProvider metadataProvider, Statement stmt, -IHyracksClientConnection hcc) throws Exception { +IHyracksClientConnection hcc, IRequestParameters requestParameters) throws Exception { IndexDropStatement stmtIndexDrop = (IndexDropStatement) stmt; String datasetName = stmtIndexDrop.getDatasetName().getValue(); @@ -2850,7 +2850,7 @@ // Cleans up the sink dataset -- Drop and then Create. DropDatasetStatement dropStmt = new
Change in asterixdb[master]: [NO ISSUE] Pass Request Parameters to DDLs
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Pass Request Parameters to DDLs .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1123/ (10/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2053 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I044e97d001fc42caa137de0a89fb27c47a88ef3c Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Pass Request Parameters to DDLs
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Pass Request Parameters to DDLs .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2022/ (8/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2053 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I044e97d001fc42caa137de0a89fb27c47a88ef3c Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Pass Request Parameters to DDLs
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Pass Request Parameters to DDLs .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1842/ (3/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2053 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I044e97d001fc42caa137de0a89fb27c47a88ef3c Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Pass Request Parameters to DDLs
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Pass Request Parameters to DDLs .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6678/ (1/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/2053 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I044e97d001fc42caa137de0a89fb27c47a88ef3c Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No