Change in asterixdb[master]: Fix Race Condition in Hyracks/AlgebricksException
Michael Blow has submitted this change and it was merged. Change subject: Fix Race Condition in Hyracks/AlgebricksException .. Fix Race Condition in Hyracks/AlgebricksException Instantiation of message must be synchronized Change-Id: I2879e293af78ec54b3201a748981c32faa481f1a Reviewed-on: https://asterix-gerrit.ics.uci.edu/1515 Sonar-Qube: JenkinsTested-by: Jenkins Integration-Tests: Jenkins Reviewed-by: Till Westmann --- M hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksException.java 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Till Westmann: Looks good to me, approved Jenkins: Verified; No violations found; Verified Objections: Jenkins: Violations found diff --git a/hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java b/hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java index 774c4d9..b1f0892 100644 --- a/hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java +++ b/hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java @@ -122,7 +122,9 @@ @Override public String getMessage() { if (msgCache == null) { -msgCache = ErrorMessageUtil.formatMessage(component, errorCode, super.getMessage(), params); +synchronized (this) { +msgCache = ErrorMessageUtil.formatMessage(component, errorCode, super.getMessage(), params); +} } return msgCache; } diff --git a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksException.java b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksException.java index 5d13212..559468d 100644 --- a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksException.java +++ b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksException.java @@ -129,7 +129,9 @@ @Override public String getMessage() { if (msgCache == null) { -msgCache = ErrorMessageUtil.formatMessage(component, errorCode, super.getMessage(), params); +synchronized (this) { +msgCache = ErrorMessageUtil.formatMessage(component, errorCode, super.getMessage(), params); +} } return msgCache; } -- To view, visit https://asterix-gerrit.ics.uci.edu/1515 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2879e293af78ec54b3201a748981c32faa481f1a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: Fix Race Condition in Hyracks/AlgebricksException
Till Westmann has posted comments on this change. Change subject: Fix Race Condition in Hyracks/AlgebricksException .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1515 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2879e293af78ec54b3201a748981c32faa481f1a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael BlowGerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Fix Race Condition in Hyracks/AlgebricksException
Jenkins has posted comments on this change. Change subject: Fix Race Condition in Hyracks/AlgebricksException .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1941/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1515 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2879e293af78ec54b3201a748981c32faa481f1a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael BlowGerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Fix Race Condition in Hyracks/AlgebricksException
Jenkins has posted comments on this change. Change subject: Fix Race Condition in Hyracks/AlgebricksException .. Patch Set 1: BAD-1 BAD Compatibility Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/583/ : FAILURE -- To view, visit https://asterix-gerrit.ics.uci.edu/1515 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2879e293af78ec54b3201a748981c32faa481f1a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael BlowGerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Fix Race Condition in Hyracks/AlgebricksException
Jenkins has posted comments on this change. Change subject: Fix Race Condition in Hyracks/AlgebricksException .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/583/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1515 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2879e293af78ec54b3201a748981c32faa481f1a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael BlowGerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Fix Race Condition in Hyracks/AlgebricksException
Jenkins has posted comments on this change. Change subject: Fix Race Condition in Hyracks/AlgebricksException .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1941/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1515 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2879e293af78ec54b3201a748981c32faa481f1a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael BlowGerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Fix Race Condition in Hyracks/AlgebricksException
Jenkins has posted comments on this change. Change subject: Fix Race Condition in Hyracks/AlgebricksException .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4358/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1515 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2879e293af78ec54b3201a748981c32faa481f1a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael BlowGerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Fix Race Condition in Hyracks/AlgebricksException
Jenkins has posted comments on this change. Change subject: Fix Race Condition in Hyracks/AlgebricksException .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4349/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1515 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2879e293af78ec54b3201a748981c32faa481f1a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael BlowGerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Fix Race Condition in Hyracks/AlgebricksException
Michael Blow has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/1515 Change subject: Fix Race Condition in Hyracks/AlgebricksException .. Fix Race Condition in Hyracks/AlgebricksException Instantiation of message must be synchronized Change-Id: I2879e293af78ec54b3201a748981c32faa481f1a --- M hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksException.java 2 files changed, 6 insertions(+), 2 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/15/1515/1 diff --git a/hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java b/hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java index 774c4d9..b1f0892 100644 --- a/hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java +++ b/hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java @@ -122,7 +122,9 @@ @Override public String getMessage() { if (msgCache == null) { -msgCache = ErrorMessageUtil.formatMessage(component, errorCode, super.getMessage(), params); +synchronized (this) { +msgCache = ErrorMessageUtil.formatMessage(component, errorCode, super.getMessage(), params); +} } return msgCache; } diff --git a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksException.java b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksException.java index 5d13212..559468d 100644 --- a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksException.java +++ b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksException.java @@ -129,7 +129,9 @@ @Override public String getMessage() { if (msgCache == null) { -msgCache = ErrorMessageUtil.formatMessage(component, errorCode, super.getMessage(), params); +synchronized (this) { +msgCache = ErrorMessageUtil.formatMessage(component, errorCode, super.getMessage(), params); +} } return msgCache; } -- To view, visit https://asterix-gerrit.ics.uci.edu/1515 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2879e293af78ec54b3201a748981c32faa481f1a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow