Change in asterixdb[master]: Fix for integer numeric overflow in int* constructors

[Ian Maxon (Code Review)]

Ian Maxon has posted comments on this change.

Change subject: Fix for integer numeric overflow in int* constructors
..


Patch Set 1:

Also if we could replace that instance of Long.MAX_VALUE in 
AInt64ConstructorDescriptor with the actual static variable that would be good 
to do as part of this change, no idea why it was put in manually

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1509
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cb3411bf9a808ee87f4938c60804a8d267c36d0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix for integer numeric overflow in int* constructors

[Ian Maxon (Code Review)]

Ian Maxon has posted comments on this change.

Change subject: Fix for integer numeric overflow in int* constructors
..


Patch Set 1:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1509/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/constructors/AInt16ConstructorDescriptor.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/constructors/AInt16ConstructorDescriptor.java:

PS1, Line 92:  short limit = -Short.MAX_VALUE
Why's there a difference now in limit, aren't we always accumulating in the 
negative domain?


PS1, Line 113: value < limit)
Why does this signify an overflow?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1509
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cb3411bf9a808ee87f4938c60804a8d267c36d0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Fix for integer numeric overflow in int* constructors

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix for integer numeric overflow in int* constructors
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1908/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1509
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cb3411bf9a808ee87f4938c60804a8d267c36d0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix for integer numeric overflow in int* constructors

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix for integer numeric overflow in int* constructors
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1908/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1509
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cb3411bf9a808ee87f4938c60804a8d267c36d0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix for integer numeric overflow in int* constructors

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix for integer numeric overflow in int* constructors
..


Patch Set 1: Integration-Tests-1

Integration Tests Timed Out

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1905/ 
: ABORTED

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1509
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cb3411bf9a808ee87f4938c60804a8d267c36d0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix for integer numeric overflow in int* constructors

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix for integer numeric overflow in int* constructors
..


Patch Set 1: BAD-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/551/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1509
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cb3411bf9a808ee87f4938c60804a8d267c36d0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix for integer numeric overflow in int* constructors

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix for integer numeric overflow in int* constructors
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1905/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1509
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cb3411bf9a808ee87f4938c60804a8d267c36d0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix for integer numeric overflow in int* constructors

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix for integer numeric overflow in int* constructors
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/551/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1509
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cb3411bf9a808ee87f4938c60804a8d267c36d0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix for integer numeric overflow in int* constructors

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix for integer numeric overflow in int* constructors
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4300/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1509
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cb3411bf9a808ee87f4938c60804a8d267c36d0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix for integer numeric overflow in int* constructors

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix for integer numeric overflow in int* constructors
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4296/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1509
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cb3411bf9a808ee87f4938c60804a8d267c36d0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix for integer numeric overflow in int* constructors

[Ildar Absalyamov (Code Review)]

Ildar Absalyamov has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1509

Change subject: Fix for integer numeric overflow in int* constructors
..

Fix for integer numeric overflow in int* constructors

Change-Id: I0cb3411bf9a808ee87f4938c60804a8d267c36d0
---
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/types/domain_boundaries/domain_boundaries.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/types/domain_boundaries/domain_boundaries.2.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/types/domain_boundaries/domain_boundaries.3.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/types/domain_boundaries_error/domain_boundaries_error.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/types/domain_boundaries_error/domain_boundaries_error.2.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/types/domain_boundaries_error/domain_boundaries_error.3.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/types/domain_boundaries_error/domain_boundaries_error.4.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/types/domain_boundaries_error/domain_boundaries_error.5.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/types/domain_boundaries/domain_boundaries.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/constructors/AInt16ConstructorDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/constructors/AInt32ConstructorDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/constructors/AInt8ConstructorDescriptor.java
13 files changed, 338 insertions(+), 9 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/09/1509/1

diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/types/domain_boundaries/domain_boundaries.1.ddl.aql
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/types/domain_boundaries/domain_boundaries.1.ddl.aql
new file mode 100644
index 000..0885da1
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/types/domain_boundaries/domain_boundaries.1.ddl.aql
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+drop dataverse test if exists;
+create dataverse test;
+
+use dataverse test;
+
+create type Type as open {
+  id: int64,
+  int8: int8,
+  int16: int16,
+  int32: int32,
+  int64: int64
+}
+
+create dataset TestDS(Type) primary key id;
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/types/domain_boundaries/domain_boundaries.2.ddl.aql
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/types/domain_boundaries/domain_boundaries.2.ddl.aql
new file mode 100644
index 000..551f658
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/types/domain_boundaries/domain_boundaries.2.ddl.aql
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+use dataverse test;
+
+insert into dataset TestDS(
+{
+   "id": 1,
+   "int8": int8("-128"),
+   "int16": int16("-32768"),
+   "int32": int32("-2147483648"),
+   "int64": int64("-9223372036854775808")
+})
+
+insert