[GitHub] eiri commented on issue #533: Whait db close a little bit before failing test

eiri commented on issue #533: Whait db close a little bit before failing test URL: https://github.com/apache/couchdb/pull/533#issuecomment-302770333 @iilyak hard to guess, to be honest, 500 or 1000 both looks good to me. test_util's `wait` default is 5000, but it's more fitting for the

[GitHub] wohali commented on issue #533: Whait db close a little bit before failing test

wohali commented on issue #533: Whait db close a little bit before failing test URL: https://github.com/apache/couchdb/pull/533#issuecomment-302786585 @iilyak Hey I'm just glad people are starting to help ;) This is an

[jira] [Commented] (COUCHDB-3312) Error on Make Release

[ https://issues.apache.org/jira/browse/COUCHDB-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017859#comment-16017859 ] Joan Touzet commented on COUCHDB-3312: -- CentOS 6 ships with js-1.7.0. CouchDB dropped support for

[jira] [Resolved] (COUCHDB-3312) Error on Make Release

[ https://issues.apache.org/jira/browse/COUCHDB-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joan Touzet resolved COUCHDB-3312. -- Resolution: Not A Problem > Error on Make Release > -- > >

[GitHub] couchdb-config issue #15: Fix eunit tests

Github user iilyak commented on the issue: https://github.com/apache/couchdb-config/pull/15 test_util is in monorepository. However we can fix it in separate PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] couchdb-config pull request #15: Fix eunit tests

Github user iilyak commented on a diff in the pull request: https://github.com/apache/couchdb-config/pull/15#discussion_r117546796 --- Diff: test/config_tests.erl --- @@ -69,34 +67,36 @@ setup({persistent, Chain}) -> setup(Chain) -> ok =

[GitHub] couchdb-config pull request #15: Fix eunit tests

Github user iilyak commented on a diff in the pull request: https://github.com/apache/couchdb-config/pull/15#discussion_r117546645 --- Diff: test/config_tests.erl --- @@ -69,34 +67,36 @@ setup({persistent, Chain}) -> setup(Chain) -> ok =

[GitHub] eiri commented on a change in pull request #496: Couchdb 3287 pluggable storage engines

eiri commented on a change in pull request #496: Couchdb 3287 pluggable storage engines URL: https://github.com/apache/couchdb/pull/496#discussion_r117546219 ## File path: src/couch/src/couch_server.erl ## @@ -559,6 +591,110 @@ db_closed(Server, Options) -> true

[GitHub] iilyak commented on issue #533: Whait db close a little bit before failing test

iilyak commented on issue #533: Whait db close a little bit before failing test URL: https://github.com/apache/couchdb/pull/533#issuecomment-302775567 @wohali: Sorry for the delay. This is an automated message from the

[GitHub] iilyak closed pull request #533: Whait db close a little bit before failing test

iilyak closed pull request #533: Whait db close a little bit before failing test URL: https://github.com/apache/couchdb/pull/533 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] eiri commented on issue #533: Whait db close a little bit before failing test

eiri commented on issue #533: Whait db close a little bit before failing test URL: https://github.com/apache/couchdb/pull/533#issuecomment-302770333 @iilyak hard to guess, to be honest, 500 or 1000 both looks good to me. test_util's `wait` default is 5000, but it's more fitting for the

[GitHub] iilyak commented on issue #533: Whait db close a little bit before failing test

iilyak commented on issue #533: Whait db close a little bit before failing test URL: https://github.com/apache/couchdb/pull/533#issuecomment-302768049 @eiri: What timeout value would you recommend? I am considering 500. This

[GitHub] eiri commented on issue #533: Whait db close a little bit before failing test

eiri commented on issue #533: Whait db close a little bit before failing test URL: https://github.com/apache/couchdb/pull/533#issuecomment-302766562 Looks good to me, didn't know we have `test_util:wait/1,2,3` function. Except maybe pass timeout explicitly? " 'wait' for how long?" was my

[GitHub] iilyak opened a new pull request #533: Whait db close a little bit before failing test

iilyak opened a new pull request #533: Whait db close a little bit before failing test URL: https://github.com/apache/couchdb/pull/533 ## Overview Databases are closed asynchronously. However it was not accounted for in the test case. This commit waits database to close before it

[GitHub] eiri commented on a change in pull request #496: Couchdb 3287 pluggable storage engines

eiri commented on a change in pull request #496: Couchdb 3287 pluggable storage engines URL: https://github.com/apache/couchdb/pull/496#discussion_r117531210 ## File path: src/couch/src/couch_server.erl ## @@ -559,6 +591,110 @@ db_closed(Server, Options) -> true

[GitHub] davisp commented on issue #496: Couchdb 3287 pluggable storage engines

davisp commented on issue #496: Couchdb 3287 pluggable storage engines URL: https://github.com/apache/couchdb/pull/496#issuecomment-302760914 Aha! Good catch. On Fri, May 19, 2017 at 11:06 AM, Eric Avdey wrote: > *@eiri* commented on this pull

[jira] [Commented] (COUCHDB-3312) Error on Make Release

[ https://issues.apache.org/jira/browse/COUCHDB-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017636#comment-16017636 ] Qing XU commented on COUCHDB-3312: -- Same issue seen with RHEL 6.7. Is there an ETA to the fix? Or any

[GitHub] eiri commented on a change in pull request #496: Couchdb 3287 pluggable storage engines

eiri commented on a change in pull request #496: Couchdb 3287 pluggable storage engines URL: https://github.com/apache/couchdb/pull/496#discussion_r117517242 ## File path: src/couch/src/couch_server.erl ## @@ -559,6 +591,110 @@ db_closed(Server, Options) -> true

[GitHub] iilyak closed pull request #532: Filter out non replicator tasks in test case

iilyak closed pull request #532: Filter out non replicator tasks in test case URL: https://github.com/apache/couchdb/pull/532 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] nickva closed pull request #529: Revert couch_lru to use gb_trees

nickva closed pull request #529: Revert couch_lru to use gb_trees URL: https://github.com/apache/couchdb/pull/529 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] davisp commented on a change in pull request #496: Couchdb 3287 pluggable storage engines

davisp commented on a change in pull request #496: Couchdb 3287 pluggable storage engines URL: https://github.com/apache/couchdb/pull/496#discussion_r117492587 ## File path: src/couch/src/couch_db_engine.erl ## @@ -0,0 +1,877 @@ +% Licensed under the Apache License,

[GitHub] davisp commented on a change in pull request #496: Couchdb 3287 pluggable storage engines

davisp commented on a change in pull request #496: Couchdb 3287 pluggable storage engines URL: https://github.com/apache/couchdb/pull/496#discussion_r117492149 ## File path: src/couch/src/couch_server.erl ## @@ -559,6 +591,110 @@ db_closed(Server, Options) ->

[GitHub] davisp commented on issue #529: Revert couch_lru to use gb_trees

davisp commented on issue #529: Revert couch_lru to use gb_trees URL: https://github.com/apache/couchdb/pull/529#issuecomment-302713537 +1. We'll keep investigating this but for now worse in real life is still worse. My only theory is that ets calls bump reductions faster which causes

[GitHub] nickva commented on issue #532: Filter out non replicator tasks in test case

nickva commented on issue #532: Filter out non replicator tasks in test case URL: https://github.com/apache/couchdb/pull/532#issuecomment-302711625 +1 This is an automated message from the Apache Git Service. To respond to

[GitHub] iilyak opened a new pull request #532: Filter out non replicator tasks in test case

iilyak opened a new pull request #532: Filter out non replicator tasks in test case URL: https://github.com/apache/couchdb/pull/532 ## Overview Previously the test relied in the assumption that there are no couch_tasks which are running concurrently. This commit fixes that

[GitHub] tonysun83 commented on a change in pull request #496: Couchdb 3287 pluggable storage engines

tonysun83 commented on a change in pull request #496: Couchdb 3287 pluggable storage engines URL: https://github.com/apache/couchdb/pull/496#discussion_r117441392 ## File path: src/couch/src/couch_db_engine.erl ## @@ -0,0 +1,877 @@ +% Licensed under the Apache License,

[GitHub] tonysun83 commented on a change in pull request #496: Couchdb 3287 pluggable storage engines

tonysun83 commented on a change in pull request #496: Couchdb 3287 pluggable storage engines URL: https://github.com/apache/couchdb/pull/496#discussion_r117441392 ## File path: src/couch/src/couch_db_engine.erl ## @@ -0,0 +1,877 @@ +% Licensed under the Apache License,

[GitHub] tonysun83 commented on a change in pull request #496: Couchdb 3287 pluggable storage engines

tonysun83 commented on a change in pull request #496: Couchdb 3287 pluggable storage engines URL: https://github.com/apache/couchdb/pull/496#discussion_r117441392 ## File path: src/couch/src/couch_db_engine.erl ## @@ -0,0 +1,877 @@ +% Licensed under the Apache License,

[GitHub] tonysun83 commented on a change in pull request #496: Couchdb 3287 pluggable storage engines

tonysun83 commented on a change in pull request #496: Couchdb 3287 pluggable storage engines URL: https://github.com/apache/couchdb/pull/496#discussion_r117441392 ## File path: src/couch/src/couch_db_engine.erl ## @@ -0,0 +1,877 @@ +% Licensed under the Apache License,

[GitHub] garrensmith commented on issue #15: Add/update contribution guidelines, issue/PR templates for GH Issues

garrensmith commented on issue #15: Add/update contribution guidelines, issue/PR templates for GH Issues URL: https://github.com/apache/couchdb-docker/pull/15#issuecomment-302638457 Sorry. I saw a PR and just pushed the merge button