[GitHub] jaydoane opened a new pull request #1206: Add error tuple return type to replicator auth spec and callback

jaydoane opened a new pull request #1206: Add error tuple return type to replicator auth spec and callback URL: https://github.com/apache/couchdb/pull/1206 ## Overview The `{error, term()}` return type is added to both the `initialize/1` callback and spec, which

[GitHub] adamsaeid opened a new pull request #78: Return error if nano.db.get called with empty doc name (Fixes issue #70)

adamsaeid opened a new pull request #78: Return error if nano.db.get called with empty doc name (Fixes issue #70) URL: https://github.com/apache/couchdb-nano/pull/78 ## Overview Return an error instead of of db info when nano.db.get is called with an empty docName. ([Issue

[Jenkins] SUCCESS: CouchDB » master #209

Yay, we passed. https://builds.apache.org/job/CouchDB/job/master/209/

[GitHub] iilyak closed pull request #1193: Use `chttpd:send_error/2` in mango_httpd

iilyak closed pull request #1193: Use `chttpd:send_error/2` in mango_httpd URL: https://github.com/apache/couchdb/pull/1193 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[Jenkins] SUCCESS: CouchDB » master #208

Yay, we passed. https://builds.apache.org/job/CouchDB/job/master/208/

[GitHub] iilyak commented on issue #1193: Use `chttpd:send_error/2` in mango_httpd

iilyak commented on issue #1193: Use `chttpd:send_error/2` in mango_httpd URL: https://github.com/apache/couchdb/pull/1193#issuecomment-370957348 > Using chttpd:send_error/4 seems to be closer to the original intent? It's public func as well. `chttpd:send_error/4` doesn't support

[GitHub] davisp closed pull request #1205: Switching `couch_stats_process_tracker:track/2` argument names

davisp closed pull request #1205: Switching `couch_stats_process_tracker:track/2` argument names URL: https://github.com/apache/couchdb/pull/1205 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] guess-burger opened a new pull request #1205: Switching `couch_stats_process_tracker:track/2` argument names

guess-burger opened a new pull request #1205: Switching `couch_stats_process_tracker:track/2` argument names URL: https://github.com/apache/couchdb/pull/1205 ## Overview The argument names in `couch_stats_process_tracker:track/2` where the wrong way around leading to

[GitHub] jjrodrig commented on issue #1139: Fix for issue #1136 - Error 500 deleting DB without quorum

jjrodrig commented on issue #1139: Fix for issue #1136 - Error 500 deleting DB without quorum URL: https://github.com/apache/couchdb/pull/1139#issuecomment-370928857 Thanks @kocolosk for your comments. I see that the orphaned files question is a different issue. We are facing it

[GitHub] couchdb-couch-stats issue #8: Add unit test to verify the new metric bulk_re...

Github user wohali commented on the issue: https://github.com/apache/couchdb-couch-stats/pull/8 Hi @brkolla , This code has moved into the main repository: https://github.com/apache/couchdb/blob/master/src/couch_stats/ This repository is only here for historical

[GitHub] couchdb-couch-stats pull request #9: Switching variable names for `couch_sta...

Github user guess-burger closed the pull request at: https://github.com/apache/couchdb-couch-stats/pull/9 ---

[GitHub] couchdb-couch-stats issue #9: Switching variable names for `couch_stats_proc...

Github user wohali commented on the issue: https://github.com/apache/couchdb-couch-stats/pull/9 Hi @guess-burger, This code has moved into the main repository: https://github.com/apache/couchdb/blob/master/src/couch_stats/src/couch_stats_process_tracker.erl This

[GitHub] couchdb-couch-stats pull request #9: Switching variable names for `couch_sta...

GitHub user guess-burger opened a pull request: https://github.com/apache/couchdb-couch-stats/pull/9 Switching variable names for `couch_stats_process_tracker:track/2` It seems that `couch_stats_process_tracker:track/2` has the variables `Name` and `Pid` erroneously switched. This

[GitHub] wohali commented on issue #1204: view queries default to map unless a reduce is defined and then they run reduce

wohali commented on issue #1204: view queries default to map unless a reduce is defined and then they run reduce URL: https://github.com/apache/couchdb/issues/1204#issuecomment-370904610 Compare with http://docs.couchdb.org/en/latest/api/ddoc/views.html Looks like @flimzy is ahead

[GitHub] Antonio-Maranhao closed pull request #1058: Allow setting the protocol of the couchdb URL for nightwatch tests

Antonio-Maranhao closed pull request #1058: Allow setting the protocol of the couchdb URL for nightwatch tests URL: https://github.com/apache/couchdb-fauxton/pull/1058 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] Antonio-Maranhao commented on issue #1058: Allow setting the protocol of the couchdb URL for nightwatch tests

Antonio-Maranhao commented on issue #1058: Allow setting the protocol of the couchdb URL for nightwatch tests URL: https://github.com/apache/couchdb-fauxton/pull/1058#issuecomment-370898701 Thanks for the review @popojargo

[GitHub] AlexanderKaraberov commented on issue #1164: Fix: Proper error handling for file:open() call in couch_file.erl

AlexanderKaraberov commented on issue #1164: Fix: Proper error handling for file:open() call in couch_file.erl URL: https://github.com/apache/couchdb/pull/1164#issuecomment-370873945 @davisp Thanks for review. Will address this in a few days when I have access to my laptop.

[GitHub] alxndrsn commented on issue #1204: view queries default to map unless a reduce is defined and then they run reduce

alxndrsn commented on issue #1204: view queries default to map unless a reduce is defined and then they run reduce URL: https://github.com/apache/couchdb/issues/1204#issuecomment-370856675 > reduce (boolean) ? Use the reduction function. Default is true when a reduce function is defined.

[GitHub] wohali commented on issue #1204: view queries default to map unless a reduce is defined and then they run reduce

wohali commented on issue #1204: view queries default to map unless a reduce is defined and then they run reduce URL: https://github.com/apache/couchdb/issues/1204#issuecomment-370855065 I would say it's better to mention this in the gentle intro to views

[GitHub] wohali commented on issue #1097: CouchDB 2.1.1: Compaction daemon - unable to calculate free space for `/run/user/0`: `enoent`

wohali commented on issue #1097: CouchDB 2.1.1: Compaction daemon - unable to calculate free space for `/run/user/0`: `enoent` URL: https://github.com/apache/couchdb/issues/1097#issuecomment-370851376 OK. Adding to the 2.2.0 milestone as well.

[GitHub] jvegaseg opened a new issue #1097: CouchDB 2.1.1: Compaction daemon - unable to calculate free space for `/run/user/0`: `enoent`

jvegaseg opened a new issue #1097: CouchDB 2.1.1: Compaction daemon - unable to calculate free space for `/run/user/0`: `enoent` URL: https://github.com/apache/couchdb/issues/1097 We have a 6-node cluster and we receive this warning in one of the servers (only in one). CouchDB

[GitHub] alxndrsn commented on issue #1204: view queries default to map unless a reduce is defined and then they run reduce

alxndrsn commented on issue #1204: view queries default to map unless a reduce is defined and then they run reduce URL: https://github.com/apache/couchdb/issues/1204#issuecomment-370848322 @wohali Any opinion on the documentation update suggestions?

[GitHub] popojargo commented on issue #1045: Migrate couchdb setup to Redux

popojargo commented on issue #1045: Migrate couchdb setup to Redux URL: https://github.com/apache/couchdb-fauxton/pull/1045#issuecomment-370847114 @garrensmith It's green ? This is an automated message from the Apache Git

[GitHub] wohali commented on issue #1204: view queries default to map unless a reduce is defined and then they run reduce

wohali commented on issue #1204: view queries default to map unless a reduce is defined and then they run reduce URL: https://github.com/apache/couchdb/issues/1204#issuecomment-370846612 This is a backwards-compatibility breaking change and can not be introduced easily. The earliest such

[GitHub] wohali closed pull request #253: Remove mention of Fauxton on port 5986

wohali closed pull request #253: Remove mention of Fauxton on port 5986 URL: https://github.com/apache/couchdb-documentation/pull/253 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] davisp commented on issue #253: Remove mention of Fauxton on port 5986

davisp commented on issue #253: Remove mention of Fauxton on port 5986 URL: https://github.com/apache/couchdb-documentation/pull/253#issuecomment-370844474 +1 This is an automated message from the Apache Git Service. To

[GitHub] Antonio-Maranhao commented on a change in pull request #1059: use npm ci on travis

Antonio-Maranhao commented on a change in pull request #1059: use npm ci on travis URL: https://github.com/apache/couchdb-fauxton/pull/1059#discussion_r172547874 ## File path: .travis.yml ## @@ -9,7 +9,8 @@ git: before_script: - travis_retry

[GitHub] Antonio-Maranhao commented on a change in pull request #1059: use npm ci on travis

Antonio-Maranhao commented on a change in pull request #1059: use npm ci on travis URL: https://github.com/apache/couchdb-fauxton/pull/1059#discussion_r172547874 ## File path: .travis.yml ## @@ -9,7 +9,8 @@ git: before_script: - travis_retry

[GitHub] rnewson commented on issue #1164: Fix: Proper error handling for file:open() call in couch_file.erl

rnewson commented on issue #1164: Fix: Proper error handling for file:open() call in couch_file.erl URL: https://github.com/apache/couchdb/pull/1164#issuecomment-370813319 if @davisp is happy, I'm happy. This is an automated

[GitHub] Antonio-Maranhao commented on a change in pull request #1059: use npm ci on travis

Antonio-Maranhao commented on a change in pull request #1059: use npm ci on travis URL: https://github.com/apache/couchdb-fauxton/pull/1059#discussion_r172545121 ## File path: .travis.yml ## @@ -9,7 +9,8 @@ git: before_script: - travis_retry

[GitHub] davisp commented on issue #1164: Fix: Proper error handling for file:open() call in couch_file.erl

davisp commented on issue #1164: Fix: Proper error handling for file:open() call in couch_file.erl URL: https://github.com/apache/couchdb/pull/1164#issuecomment-370807541 @rnewson yes and no. The issue is where we want that badmatch to happen and with what as the badmatch. For the init

[GitHub] davisp commented on a change in pull request #1164: Fix: Proper error handling for file:open() call in couch_file.erl

davisp commented on a change in pull request #1164: Fix: Proper error handling for file:open() call in couch_file.erl URL: https://github.com/apache/couchdb/pull/1164#discussion_r172540093 ## File path: src/couch/src/couch_file.erl ## @@ -213,8 +213,12 @@ truncate(Fd,

[GitHub] davisp commented on a change in pull request #1164: Fix: Proper error handling for file:open() call in couch_file.erl

davisp commented on a change in pull request #1164: Fix: Proper error handling for file:open() call in couch_file.erl URL: https://github.com/apache/couchdb/pull/1164#discussion_r172540019 ## File path: src/couch/src/couch_file.erl ## @@ -213,8 +213,12 @@ truncate(Fd,

[GitHub] jiangphcn commented on issue #1186: [WIP] Clustered purge mixed cluster upgrade

jiangphcn commented on issue #1186: [WIP] Clustered purge mixed cluster upgrade URL: https://github.com/apache/couchdb/pull/1186#issuecomment-370790664 Thanks Paul @davisp for your reply. I understand. For completeness, we need to consider downgrade when there is purge request between

[GitHub] janl commented on issue #1200: [DISCUSS] CouchDB Request Size Limits

janl commented on issue #1200: [DISCUSS] CouchDB Request Size Limits URL: https://github.com/apache/couchdb/pull/1200#issuecomment-370789361 @elistevens thanks, this convinces me that `max_attachments_per_doc` is not a good idea and the proposed alternative is the way to go.

[Jenkins] FAILURE: CouchDB » master #207

Boo, we failed. https://builds.apache.org/job/CouchDB/job/master/207/

[Jenkins] FAILURE: CouchDB » master #206

Boo, we failed. https://builds.apache.org/job/CouchDB/job/master/206/

[GitHub] rnewson commented on issue #1164: Fix: Proper error handling for file:open() call in couch_file.erl

rnewson commented on issue #1164: Fix: Proper error handling for file:open() call in couch_file.erl URL: https://github.com/apache/couchdb/pull/1164#issuecomment-370775651 @davisp if you would like to comment on the init portions.

[GitHub] rnewson commented on issue #1164: Fix: Proper error handling for file:open() call in couch_file.erl

rnewson commented on issue #1164: Fix: Proper error handling for file:open() call in couch_file.erl URL: https://github.com/apache/couchdb/pull/1164#issuecomment-370775511 -1. We assert that we get the `ok` we expect. If we don't, we want the process to crash, which it does.

[GitHub] janl closed pull request #1165: Fix: validate_doc_update behaviour for Erlang functions

janl closed pull request #1165: Fix: validate_doc_update behaviour for Erlang functions URL: https://github.com/apache/couchdb/pull/1165 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] janl commented on issue #1165: Fix: validate_doc_update behaviour for Erlang functions

janl commented on issue #1165: Fix: validate_doc_update behaviour for Erlang functions URL: https://github.com/apache/couchdb/pull/1165#issuecomment-370772551 Thanks! This is an automated message from the Apache Git Service.

[Jenkins] FAILURE: CouchDB » master #205

Boo, we failed. https://builds.apache.org/job/CouchDB/job/master/205/

[GitHub] janl closed pull request #1192: Fix dialyzer warning on `couch_key_tree:merge/2`

janl closed pull request #1192: Fix dialyzer warning on `couch_key_tree:merge/2` URL: https://github.com/apache/couchdb/pull/1192 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] janl commented on issue #1193: Use `chttpd:send_error/2` in mango_httpd

janl commented on issue #1193: Use `chttpd:send_error/2` in mango_httpd URL: https://github.com/apache/couchdb/pull/1193#issuecomment-370759594 *bump* This is an automated message from the Apache Git Service. To respond to

[GitHub] janl closed pull request #1199: Prevent access to Fauxton on node-local port (5986)

janl closed pull request #1199: Prevent access to Fauxton on node-local port (5986) URL: https://github.com/apache/couchdb/pull/1199 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] janl closed issue #1198: Fauxton should not be available on port 5986

janl closed issue #1198: Fauxton should not be available on port 5986 URL: https://github.com/apache/couchdb/issues/1198 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] SCdF commented on issue #1204: view queries default to map unless a reduce is defined and then they run reduce

SCdF commented on issue #1204: view queries default to map unless a reduce is defined and then they run reduce URL: https://github.com/apache/couchdb/issues/1204#issuecomment-370734359 I also found this very confusing. I think because (at least for me) the vast majority of view usage is

[GitHub] adrienverge commented on issue #1097: CouchDB 2.1.1: Compaction daemon - unable to calculate free space for `/run/user/0`: `enoent`

adrienverge commented on issue #1097: CouchDB 2.1.1: Compaction daemon - unable to calculate free space for `/run/user/0`: `enoent` URL: https://github.com/apache/couchdb/issues/1097#issuecomment-370740318 We experience the same problem: lots of free disk space, lots of free RAM, and:

[GitHub] adrienverge commented on issue #1097: CouchDB 2.1.1: Compaction daemon - unable to calculate free space for `/run/user/0`: `enoent`

adrienverge commented on issue #1097: CouchDB 2.1.1: Compaction daemon - unable to calculate free space for `/run/user/0`: `enoent` URL: https://github.com/apache/couchdb/issues/1097#issuecomment-370740318 We experience the same problem: lots of free disk space, lots of free RAM, and:

[GitHub] SCdF commented on issue #1204: view queries default to map unless a reduce is defined and then they run reduce

SCdF commented on issue #1204: view queries default to map unless a reduce is defined and then they run reduce URL: https://github.com/apache/couchdb/issues/1204#issuecomment-370734359 I also found this very confusing. I think because (at least for me) the vast majority of view usage is

[GitHub] garrensmith opened a new pull request #1059: use npm ci on travis

garrensmith opened a new pull request #1059: use npm ci on travis URL: https://github.com/apache/couchdb-fauxton/pull/1059 Use npm ci on travis for faster builds and stricter package management This is an automated message

[GitHub] alxndrsn opened a new issue #1204: view queries default to map unless a reduce is defined and then they run reduce

alxndrsn opened a new issue #1204: view queries default to map unless a reduce is defined and then they run reduce URL: https://github.com/apache/couchdb/issues/1204 ## Expected Behavior View queries should _always_ default to responding with a map if no value for the `reduce`

[GitHub] janl commented on issue #1199: Prevent access to Fauxton on node-local port (5986)

janl commented on issue #1199: Prevent access to Fauxton on node-local port (5986) URL: https://github.com/apache/couchdb/pull/1199#issuecomment-370730342 @wohali good call, with a load balancer it gets even worse. This is

[Jenkins] SUCCESS: CouchDB » master #204

Yay, we passed. https://builds.apache.org/job/CouchDB/job/master/204/

[GitHub] janl closed pull request #1203: Compaction Daemon & db-per-user

janl closed pull request #1203: Compaction Daemon & db-per-user URL: https://github.com/apache/couchdb/pull/1203 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and