[GitHub] couchdb-couch issue #221: Improve errors on invalid "count" parameter in /_u...

2017-03-17 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch/pull/221 @rnewson Good reminder. Thanks! Sorry that I missed that moment /: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] couchdb-couch-replicator issue #64: 63012 scheduler

2017-03-14 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch-replicator/pull/64 THATS. AN. EPIC. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] couchdb-couch issue #229: Return error row instead of crashing

2017-02-24 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch/pull/229 @tonysun83 Good, thanks . I worried about to get there all the map data or some else large batch which could cause a troubles to receive, parse, load and process. Glad that this won't

[GitHub] couchdb-couch issue #229: Return error row instead of crashing

2017-02-24 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch/pull/229 @tonysun83 Nice work! One more little question: how much number of items will be in `caused_by` list? Everything what map function produced to reduce or just those ones which had caused

[GitHub] couchdb-couch issue #229: Return error row instead of crashing

2017-02-21 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch/pull/229 For map functions errors we return the response in the following format: ``` {"total_rows":14,"offset":0,"rows":[ {"key":1,"error&qu

[GitHub] couchdb-couch issue #229: Return error row instead of crashing

2017-02-21 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch/pull/229 How the clients should handle such kind of response? It has the result data and it has some errons. Should the result be handled? Or an exception being throw? I think there should

[GitHub] couchdb-couch issue #226: Allow limiting length of document ID

2017-02-08 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch/pull/226 @nickva Nice! +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] couchdb-couch-replicator issue #55: Switch replicator max_document_id_length...

2017-02-08 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch-replicator/pull/55 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-couch issue #226: Allow limiting length of document ID

2017-02-07 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch/pull/226 @nickva I think this would be a nice helper. For quite specific cases, but nice. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] couchdb-couch issue #226: Allow limiting length of document ID

2017-02-07 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch/pull/226 Good point. The `max_replication_retry_count` option is an example where the value is an integer, but the `infinity` is used for no limit value. --- If your project is set up for it, you can

[GitHub] couchdb-couch-replicator issue #54: Allow configuring maximum document ID le...

2017-02-04 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch-replicator/pull/54 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-couch issue #223: Remove 8kB read-ahead from couch_file

2017-01-30 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch/pull/223 @davisp No, I'm waiting to have this merged (: I wrote first post without knowledge about graphs, which are impressive - that's why reverting optimization for another optimization I

[GitHub] couchdb-couch issue #224: Don't crash on unexpected validation's error type

2017-01-30 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch/pull/224 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-couch issue #223: Remove 8kB read-ahead from couch_file

2017-01-28 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch/pull/223 Hm...just checked your graphs in JIRA. They looks very nice. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] couchdb-couch issue #223: Remove 8kB read-ahead from couch_file

2017-01-28 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch/pull/223 @nickva You're going to revert [this optimization](https://github.com/apache/couchdb-couch/commit/c7b30071ac1a4166d44fc10f760a1a8ae2a8ae5c). Won't this impact on something else

[GitHub] couchdb-couch-replicator issue #52: Use mem3 to discover all _replicator sha...

2017-01-24 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch-replicator/pull/52 @nickva I hope these values should be read as "after" and "before", not in reverse? --- If your project is set up for it, you can reply to this email and ha

[GitHub] couchdb-couch issue #221: Improve errors on invalid "count" parameter in /_u...

2017-01-18 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch/pull/221 I think we need some tests on this, because that's not a first time we fixing handling this parameter right. But in anyway, +1. --- If your project is set up for it, you can reply

[GitHub] couchdb-couch pull request #221: Improve errors on invalid "count" parameter...

2017-01-18 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/221#discussion_r96643313 --- Diff: src/couch_httpd_misc_handlers.erl --- @@ -129,7 +129,9 @@ handle_uuids_req(#httpd{method='GET'}=Req) -> Max = list_to_inte

[GitHub] couchdb-documentation issue #97: Update python versions to 2.7/3.4

2017-01-10 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-documentation/pull/97 @padyx It's fine. Thanks you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-documentation issue #97: Update python versions to 2.7/3.4

2017-01-09 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-documentation/pull/97 Since it comes from Makefile, just replace it with `latex_elements.papersize` - this should works. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] couchdb-documentation issue #97: Update python versions to 2.7/3.4

2017-01-09 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-documentation/pull/97 @padyx [latex_paper_size is deprecated](http://www.sphinx-doc.org/en/1.5.1/config.html#confval-latex_paper_size), so be brave to it rid (: --- If your project is set up

[GitHub] couchdb-fabric issue #81: Include conflicts parameter in doc_options

2017-01-03 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-fabric/pull/81 @willholley Thanks, that looks better (: +1. Happy New Year! 🎉 🎄 🎅 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] couchdb-fabric pull request #81: Include conflicts parameter in doc_options

2017-01-03 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-fabric/pull/81#discussion_r94382214 --- Diff: src/fabric_view_all_docs.erl --- @@ -56,12 +56,17 @@ go(DbName, Options, QueryArgs, Callback, Acc0) -> include_docs = IncludeD

[GitHub] couchdb-config issue #14: Features API and implementation.

2016-10-06 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-config/pull/14 @nickva After good sleep time I think there is no conflicts here. Yes, features need to be discovered, but yes, user need to have an option to turn on/off them easily without doing fancy

[GitHub] couchdb-config issue #14: Features API and implementation.

2016-10-06 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-config/pull/14 Don't get me wrong about your effort for pushing this feature forward. I worry about all future oblivious improvements for this feature which aren't fit into current implementation. So it'll

[GitHub] couchdb-chttpd issue #144: Add ability to return a "features" list in the se...

2016-10-05 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-chttpd/pull/144 @nickva It's logical issue and it may leads to conflicts. Say, we have a feature FTS (full text search) which could be both provided by couchdb-lucene and dreyfus. Both acts differently

[GitHub] couchdb-chttpd issue #144: Add ability to return a "features" list in the se...

2016-10-05 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-chttpd/pull/144 @nickva > This commit shouldn't prevent it, the comment about the features being a list of binaries is just a suggestion. A feature could be an object as well. Yea, I see

[GitHub] couchdb-chttpd issue #144: Add ability to return a "features" list in the se...

2016-10-05 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-chttpd/pull/144 @nickva no, I mean `features` feature (: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-chttpd issue #144: Add ability to return a "features" list in the se...

2016-10-05 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-chttpd/pull/144 Probably, in this case it's better to have `features` an object of objects rather than list of things. Because we couldn't have any feature mentioned there twice, but would like to have quick

[GitHub] couchdb-chttpd issue #144: Add ability to return a "features" list in the se...

2016-10-05 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-chttpd/pull/144 @nickva Ok, thanks. How it will not be abandoned (: As for replicator I see here case when this list will be not list of strings, but objects, since replicator may provide own set

[GitHub] couchdb-chttpd issue #144: Add ability to return a "features" list in the se...

2016-10-05 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-chttpd/pull/144 @nickva How would this features list get filled? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-couch-log issue #16: a systemd-journald compatible log output on std...

2016-10-03 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch-log/pull/16 LGFM, but I'm not systemd user. @gdamjan may be name it journald to direct match with the service name without leaving a room for confusion? --- If your project is set up

[GitHub] couchdb-couch-mrview issue #56: Make Query Limit Results Configurable

2016-10-03 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch-mrview/pull/56 @tonysun83 > I still think we should make all our index limits configurable, starting with views. That's a good position while requesting indexes is not cheap.

[GitHub] couchdb-chttpd issue #135: Handle empty "Access-Control-Request-Headers" hea...

2016-09-23 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-chttpd/pull/135 @barbalex Yes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-couch pull request #200: Adding test suite for trancated _update

2016-09-22 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/200#discussion_r80184463 --- Diff: test/couchdb_mrview_tests.erl --- @@ -0,0 +1,165 @@ +% Licensed under the Apache License, Version 2.0 (the "License"

[GitHub] couchdb-chttpd issue #135: Handle empty "Access-Control-Request-Headers" hea...

2016-09-22 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-chttpd/pull/135 cc @rnewson @davisp @iilyak --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] couchdb-couch-replicator pull request #48: Port HTTP 429 Commits

2016-09-22 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch-replicator/pull/48#discussion_r79905411 --- Diff: src/couch_replicator_httpc.erl --- @@ -27,6 +27,9 @@ -define(replace(L, K, V), lists:keystore(K, 1, L, {K, V

[GitHub] couchdb-couch issue #199: Define couch version

2016-09-16 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch/pull/199 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-fabric issue #68: End continuous changes feeds cleanly if database i...

2016-09-07 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-fabric/pull/68 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-fabric issue #67: clarify error when all_or_nothing attempted

2016-09-07 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-fabric/pull/67 There was a hope... +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] couchdb-couch-mrview pull request #56: Make Query Limit Results Configurable

2016-09-06 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch-mrview/pull/56#discussion_r77662244 --- Diff: test/couch_mrview_all_docs_tests.erl --- @@ -107,6 +107,21 @@ should_query_with_limit_and_skip(Db

[GitHub] couchdb-couch-replicator issue #47: Validate boolean parameters in /_replica...

2016-09-06 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch-replicator/pull/47 @rnewson Why not to create a branch for 2.0 and prepare release from there while people still can work on new features and master? Sounds like gitflow-ish. --- If your project

[GitHub] couchdb-couch-mrview pull request #56: Make Query Limit Results Configurable

2016-09-06 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch-mrview/pull/56#discussion_r77600225 --- Diff: src/couch_mrview_http.erl --- @@ -469,10 +469,16 @@ parse_params(Props, Keys, #mrargs{}=Args0, Options) -> IsDeco

[GitHub] couchdb-couch-mrview pull request #56: Make Query Limit Results Configurable

2016-09-06 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch-mrview/pull/56#discussion_r77600024 --- Diff: src/couch_mrview_http.erl --- @@ -469,10 +469,16 @@ parse_params(Props, Keys, #mrargs{}=Args0, Options) -> IsDeco

[GitHub] couchdb-couch-mrview pull request #56: Make Query Limit Results Configurable

2016-09-06 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch-mrview/pull/56#discussion_r77590186 --- Diff: src/couch_mrview_http.erl --- @@ -469,10 +469,16 @@ parse_params(Props, Keys, #mrargs{}=Args0, Options) -> IsDeco

[GitHub] couchdb-couch-mrview pull request #56: Make Query Limit Results Configurable

2016-09-06 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch-mrview/pull/56#discussion_r77590126 --- Diff: src/couch_mrview_http.erl --- @@ -469,10 +469,16 @@ parse_params(Props, Keys, #mrargs{}=Args0, Options) -> IsDeco

[GitHub] couchdb-couch-mrview issue #56: Make Query Limit Results Configurable

2016-09-05 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch-mrview/pull/56 If it still planned to be accepted, for the lesser surprise there should be: 1) The way to return good old behaviour back. 2) The warning in the logs that by default we do limit

[GitHub] couchdb-couch-mrview issue #56: Make Query Limit Results Configurable

2016-09-05 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch-mrview/pull/56 Good points, @rnewson. Changing my to -1. I think this need for more wide discussion. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] couchdb-couch issue #194: Trigger cookie renewal on /_session

2016-09-02 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch/pull/194 @adrienverge There will be more problem: authed user may eventually request `GET /_session` for the information about himself: username, roles etc. According the code, each time he'll do

[GitHub] couchdb-couch pull request #194: Trigger cookie renewal on /_session

2016-09-02 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/194#discussion_r77340925 --- Diff: src/couch_httpd_auth.erl --- @@ -240,13 +242,21 @@ cookie_authentication_handler(#httpd{mochi_req=MochiReq}=Req, AuthModule

[GitHub] couchdb-documentation issue #55: API documentation for _find and _index endp...

2016-09-02 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-documentation/pull/55 Hm...indeed. Ok. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] couchdb-documentation issue #55: API documentation for _find and _index endp...

2016-09-02 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-documentation/pull/55 @wohali linter wasn't fixed /: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] couchdb issue #439: Update default/local ini files with new settings

2016-09-02 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb/pull/439 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] couchdb-chttpd issue #139: Drop logging level for "no record of user %s"

2016-09-01 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-chttpd/pull/139 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-documentation issue #55: API documentation for _find and _index endp...

2016-09-01 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-documentation/pull/55 Nice! But need to fix the linter failures. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-couch issue #177: Add optional `fields` to change feed selectors

2016-09-01 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch/pull/177 LGFM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-couch pull request #177: Add optional `fields` to change feed select...

2016-09-01 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/177#discussion_r77217313 --- Diff: src/couch_changes.erl --- @@ -377,6 +379,21 @@ check_selector(_Selector) -> throw({bad_request, "Selector error: expecte

[GitHub] couchdb-couch pull request #177: Add optional `fields` to change feed select...

2016-09-01 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/177#discussion_r77217227 --- Diff: src/couch_changes.erl --- @@ -377,6 +379,21 @@ check_selector(_Selector) -> throw({bad_request, "Selector error: expecte

[GitHub] couchdb-couch issue #193: Fix validation for ddoc and _local id

2016-09-01 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch/pull/193 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb issue #437: Use ibrowse 4.3

2016-08-22 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb/pull/437 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] couchdb-couch-index pull request #18: Update handle_config_terminate API

2016-08-19 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch-index/pull/18#discussion_r75572589 --- Diff: src/couch_index.erl --- @@ -344,25 +340,19 @@ handle_info({'DOWN', _, _, _Pid, _}, #st{mod=Mod, idx_state=IdxState}=State

[GitHub] couchdb-couch-replicator issue #45: Fix replicator manager `stop` change fee...

2016-08-15 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch-replicator/pull/45 Our tests in sad state yeah /: But good that they are green now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] couchdb-couch-replicator issue #45: Fix replicator manager `stop` change fee...

2016-08-15 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch-replicator/pull/45 @nickva Good. Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] couchdb-couch-replicator issue #45: Fix replicator manager `stop` change fee...

2016-08-15 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch-replicator/pull/45 +1. But failed tests worries me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fabric issue #66: Implement clustered compaction functions

2016-08-11 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-fabric/pull/66 @rnewson may be also pick https://github.com/apache/couchdb-fabric/pull/26 ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] couchdb-fabric issue #66: Implement clustered compaction functions

2016-08-11 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-fabric/pull/66 Seems like you changed your mind on this (: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] couchdb-config issue #10: 3096 fix config listener accumulation

2016-08-08 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-config/pull/10 Wow! Nice found! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] couchdb-config issue #9: Consult default.d/local.d for ini files

2016-08-05 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-config/pull/9 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb issue #436: Fix dev/run: "content" should be "contents"

2016-08-03 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb/pull/436 /o\ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb issue #436: Fix dev/run: "content" should be "contents"

2016-08-03 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb/pull/436 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] couchdb issue #436: Fix dev/run: "content" should be "contents"

2016-08-03 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb/pull/436 o.O --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb issue #435: Change default to log to a file, not stderr

2016-08-02 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb/pull/435 Why not to keep default stderr, while allow to provide a path to logfile on configure? This will satisfy both groups needs. --- If your project is set up for it, you can reply to this email

[GitHub] couchdb issue #425: Improve reduce function overlow handling

2016-08-01 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb/pull/425 @nickva Hmmok. I still don't like it, but cannot propose anything better and the > For example reduce reduce_limit_debug would only work with reduce_limit = false, wh

[GitHub] couchdb-chttpd issue #135: Handle empty "Access-Control-Request-Headers" hea...

2016-08-01 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-chttpd/pull/135 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-couch-replicator issue #44: Inject random delays in scan_all_dbs

2016-08-01 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch-replicator/pull/44 Ok. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-couch-replicator issue #44: Inject random delays in scan_all_dbs

2016-08-01 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch-replicator/pull/44 @iilyak Just a side thought: would move scan_all_dbs from init give any benefit? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] couchdb-couch-replicator issue #44: Inject random delays in scan_all_dbs

2016-07-29 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch-replicator/pull/44 That is the [second](https://github.com/apache/couchdb-couch-replicator/pull/37) jitter implementation within the same module. May be generalize somehow that concept? --- If your

[GitHub] couchdb-documentation issue #53: COUCHDB-3068 - Fixes to make docs build wit...

2016-07-29 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-documentation/pull/53 @katsel awesome! thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] couchdb-documentation issue #53: COUCHDB-3068 - Fixes to make docs build wit...

2016-07-23 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-documentation/pull/53 @katsel > Using the local lexer for http seems like a possible workaround, but how would you do that in an elegant way? Just use local one all the t

[GitHub] couchdb-documentation pull request #53: COUCHDB-3068 - Fixes to make docs bu...

2016-07-22 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-documentation/pull/53#discussion_r71916762 --- Diff: src/api/document/common.rst --- @@ -1167,7 +1167,7 @@ for the target document by appending the ``rev`` parameter

[GitHub] couchdb-chttpd issue #133: In a view multi-query request, set view type for ...

2016-07-22 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-chttpd/pull/133 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-couch pull request #185: 3061 adaptive header search

2016-07-20 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/185#discussion_r71470204 --- Diff: src/couch_file.erl --- @@ -524,6 +525,99 @@ handle_info({'EXIT', _, Reason}, Fd) -> {stop, Reason, Fd}. +%% first

[GitHub] couchdb-couch issue #187: use couch epi decide

2016-07-18 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch/pull/187 @rnewson Soon...thanks! (: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] couchdb-couch issue #187: 70457 use couch epi decide

2016-07-18 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch/pull/187 +1 P.S. What is 70457 is? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] couchdb-couch pull request #185: 3061 adaptive header search

2016-07-18 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/185#discussion_r71205429 --- Diff: src/couch_file.erl --- @@ -524,6 +525,99 @@ handle_info({'EXIT', _, Reason}, Fd) -> {stop, Reason, Fd}. +%% first

[GitHub] couchdb-couch pull request #185: 3061 adaptive header search

2016-07-18 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/185#discussion_r71203761 --- Diff: src/couch_file.erl --- @@ -524,6 +525,99 @@ handle_info({'EXIT', _, Reason}, Fd) -> {stop, Reason, Fd}. +%% first

[GitHub] couchdb issue #434: Clean up ./dev/run output

2016-07-18 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb/pull/434 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] couchdb pull request #434: Clean up ./dev/run output

2016-07-18 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb/pull/434#discussion_r71105493 --- Diff: dev/run --- @@ -355,6 +355,7 @@ def check_node_alive(url): try: with contextlib.closing(urlopen(url

[GitHub] couchdb-couch-mrview pull request #50: Fix sorted=false feature

2016-07-15 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch-mrview/pull/50#discussion_r7182 --- Diff: include/couch_mrview.hrl --- @@ -98,7 +98,8 @@ should_close = false, buffer = [], bufsize = 0

[GitHub] couchdb issue #431: build: support OTP-19.0 for 1.6.x

2016-07-11 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb/pull/431 @dch you miss something here --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] couchdb issue #431: build: support OTP-19.0

2016-07-11 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb/pull/431 @gmile Hm, right. Probably I used `rm -f` which always returns success whenever file exists or not. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] couchdb-fabric pull request #61: Ignore already received replies for same sh...

2016-07-09 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-fabric/pull/61#discussion_r70165869 --- Diff: src/fabric_group_info.erl --- @@ -58,17 +58,23 @@ handle_message({rexi_EXIT, Reason}, Shard, {Counters, Acc, Ushards}) ->

[GitHub] couchdb-fabric pull request #61: Ignore already received replies for same sh...

2016-07-08 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-fabric/pull/61#discussion_r70134929 --- Diff: src/fabric_group_info.erl --- @@ -58,17 +58,23 @@ handle_message({rexi_EXIT, Reason}, Shard, {Counters, Acc, Ushards}) ->

[GitHub] couchdb-fabric pull request #61: Ignore already received replies for same sh...

2016-07-08 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-fabric/pull/61#discussion_r70132063 --- Diff: src/fabric_group_info.erl --- @@ -58,17 +58,23 @@ handle_message({rexi_EXIT, Reason}, Shard, {Counters, Acc, Ushards}) ->

[GitHub] couchdb-fabric pull request #61: Ignore already received replies for same sh...

2016-07-08 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-fabric/pull/61#discussion_r70131900 --- Diff: src/fabric_group_info.erl --- @@ -58,17 +58,23 @@ handle_message({rexi_EXIT, Reason}, Shard, {Counters, Acc, Ushards}) ->

[GitHub] couchdb-chttpd issue #130: 3049 fix sockname

2016-07-07 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-chttpd/pull/130 @rnewson yes, you're right here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] couchdb-chttpd issue #130: 3049 fix sockname

2016-07-07 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-chttpd/pull/130 But it's too late anyway, so ok. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] couchdb-chttpd issue #130: 3049 fix sockname

2016-07-07 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-chttpd/pull/130 @rnewson that doesn't means that it couldn't be improved (; --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] couchdb-chttpd issue #130: 3049 fix sockname

2016-07-07 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-chttpd/pull/130 /: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-chttpd issue #130: 3049 fix sockname

2016-07-07 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-chttpd/pull/130 So technically the fix of existed code should be: ``` sockname({ssl, Socket}) -> ssl:sockname(Socket). ``` ? --- If your project is set up for it, you can re

  1   2   3   4   5   6   7   8   9   10   >