kocolosk commented on issue #1377: Fix _approx_count_distinct on non-clustered
interface, optimize _stats
URL: https://github.com/apache/couchdb/pull/1377#issuecomment-395393172
Ah yeah @nickva added JS tests to my original PR for the feature.
When I run `make check` locally it
kocolosk commented on issue #1377: Fix _approx_count_distinct on non-clustered
interface, optimize _stats
URL: https://github.com/apache/couchdb/pull/1377#issuecomment-395278681
@wohali not 100% sure what you mean. Travis is running the automated tests
for both of those and catching where
kocolosk commented on issue #1377: Fix _approx_count_distinct on non-clustered
interface, optimize _stats
URL: https://github.com/apache/couchdb/pull/1377#issuecomment-395272747
OK I think that's sorted now. Tested both `_stats` and
`_approx_count_distinct` on both 5984 and 5986. Not the
kocolosk commented on issue #1377: Fix _approx_count_distinct on non-clustered
interface, optimize _stats
URL: https://github.com/apache/couchdb/pull/1377#issuecomment-395263060
Hah, whoops! That's clearly not right. In general we can't call `rereduce`
after `finalize`, and that's exactly