nickva merged PR #4627:
URL: https://github.com/apache/couchdb/pull/4627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
nickva commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1601002604
##
src/couch_quickjs/src/couch_quickjs_scanner_plugin.erl:
##
@@ -0,0 +1,493 @@
+% Licensed under the Apache License, Version 2.0 (the "License"); you may not
+% use
nickva commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1600878117
##
src/couch_quickjs/src/couch_quickjs_scanner_plugin.erl:
##
@@ -0,0 +1,493 @@
+% Licensed under the Apache License, Version 2.0 (the "License"); you may not
+% use
jaydoane commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1600715531
##
src/couch_quickjs/src/couch_quickjs_scanner_plugin.erl:
##
@@ -0,0 +1,493 @@
+% Licensed under the Apache License, Version 2.0 (the "License"); you may not
+% use
nickva commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1599243497
##
rel/overlay/etc/default.ini:
##
@@ -931,6 +934,11 @@ url = {{nouveau_url}}
;max_idle = 60
;enable = true
+[quickjs]
+; Memory limit in bytes. Default is
jaydoane commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1599170929
##
rel/overlay/etc/default.ini:
##
@@ -931,6 +934,11 @@ url = {{nouveau_url}}
;max_idle = 60
;enable = true
+[quickjs]
+; Memory limit in bytes. Default is
nickva commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1599007142
##
LICENSE:
##
@@ -2308,3 +2308,56 @@ distributed under the License is distributed on an "AS
IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
nickva commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1598983697
##
LICENSE:
##
@@ -2308,3 +2308,56 @@ distributed under the License is distributed on an "AS
IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
jaydoane commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1598928015
##
LICENSE:
##
@@ -2308,3 +2308,56 @@ distributed under the License is distributed on an "AS
IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
nickva closed pull request #5052: Add QuickJS as a Javascript engine option
URL: https://github.com/apache/couchdb/pull/5052
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
nickva opened a new pull request, #5052:
URL: https://github.com/apache/couchdb/pull/5052
Test PR to run the full CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
nickva commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1597477745
##
src/couch/src/couch_os_process.erl:
##
@@ -92,7 +92,7 @@ readjson(OsProc) when is_record(OsProc, os_proc) ->
case ?JSON_DECODE(Line) of
nickva commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1597477465
##
src/couch/src/couch_os_process.erl:
##
@@ -92,7 +92,7 @@ readjson(OsProc) when is_record(OsProc, os_proc) ->
case ?JSON_DECODE(Line) of
jaydoane commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1597476110
##
src/couch/src/couch_os_process.erl:
##
@@ -92,7 +92,7 @@ readjson(OsProc) when is_record(OsProc, os_proc) ->
case ?JSON_DECODE(Line) of
nickva closed pull request #5049: Add QuickJS as a Javascript engine option
URL: https://github.com/apache/couchdb/pull/5049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
nickva opened a new pull request, #5049:
URL: https://github.com/apache/couchdb/pull/5049
This is a test PR to run the full CI to check quickjs on other arches/os
versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
nickva commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1591574543
##
src/docs/src/config/quickjs.rst:
##
@@ -0,0 +1,122 @@
+.. Licensed under the Apache License, Version 2.0 (the "License"); you may not
+.. use this file except in
big-r81 commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1591573085
##
src/docs/src/config/quickjs.rst:
##
@@ -0,0 +1,122 @@
+.. Licensed under the Apache License, Version 2.0 (the "License"); you may not
+.. use this file except in
nickva commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1591467410
##
src/couch_quickjs/test/couch_quickjs_tests.erl:
##
@@ -0,0 +1,71 @@
+% Licensed under the Apache License, Version 2.0 (the "License"); you may not
+% use this file
nickva commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1591466774
##
test/elixir/test/view_errors_test.exs:
##
@@ -190,7 +190,12 @@ defmodule ViewErrorsTest do
# fires first. The first timeout is the couch_os_process
#
nickva commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1591455045
##
src/docs/src/config/quickjs.rst:
##
@@ -0,0 +1,122 @@
+.. Licensed under the Apache License, Version 2.0 (the "License"); you may not
+.. use this file except in
nickva commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1591397616
##
test/elixir/test/view_errors_test.exs:
##
@@ -190,7 +190,12 @@ defmodule ViewErrorsTest do
# fires first. The first timeout is the couch_os_process
#
nickva commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1591396043
##
src/couch_quickjs/test/couch_quickjs_tests.erl:
##
@@ -0,0 +1,71 @@
+% Licensed under the Apache License, Version 2.0 (the "License"); you may not
+% use this file
jaydoane commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1587027700
##
test/elixir/test/view_errors_test.exs:
##
@@ -190,7 +190,12 @@ defmodule ViewErrorsTest do
# fires first. The first timeout is the couch_os_process
#
nickva commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1591263357
##
src/chttpd/src/chttpd_node.erl:
##
@@ -51,6 +51,17 @@ handle_node_req(#httpd{method = 'GET', path_parts = [_,
_Node, <<"_versions">>]}
UcaVer =
nickva commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1591263357
##
src/chttpd/src/chttpd_node.erl:
##
@@ -51,6 +51,17 @@ handle_node_req(#httpd{method = 'GET', path_parts = [_,
_Node, <<"_versions">>]}
UcaVer =
big-r81 commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1591258323
##
src/docs/src/config/quickjs.rst:
##
@@ -0,0 +1,122 @@
+.. Licensed under the Apache License, Version 2.0 (the "License"); you may not
+.. use this file except in
nickva commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1591202387
##
src/docs/src/config/quickjs.rst:
##
@@ -0,0 +1,122 @@
+.. Licensed under the Apache License, Version 2.0 (the "License"); you may not
+.. use this file except in
big-r81 commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1591198224
##
src/chttpd/src/chttpd_node.erl:
##
@@ -51,6 +51,17 @@ handle_node_req(#httpd{method = 'GET', path_parts = [_,
_Node, <<"_versions">>]}
UcaVer =
nickva commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1591193736
##
src/couch_quickjs/test/couch_quickjs_tests.erl:
##
@@ -0,0 +1,71 @@
+% Licensed under the Apache License, Version 2.0 (the "License"); you may not
+% use this file
nickva commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1591192925
##
src/docs/src/config/quickjs.rst:
##
@@ -0,0 +1,122 @@
+.. Licensed under the Apache License, Version 2.0 (the "License"); you may not
+.. use this file except in
nickva commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1591189278
##
src/docs/src/config/couchdb.rst:
##
@@ -247,3 +247,13 @@ Base CouchDB Options
[couchdb]
write_xxhash_checksums = false
+
+..
nickva commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1591173251
##
src/chttpd/src/chttpd_node.erl:
##
@@ -51,6 +51,17 @@ handle_node_req(#httpd{method = 'GET', path_parts = [_,
_Node, <<"_versions">>]}
UcaVer =
nickva commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1591164934
##
configure.ps1:
##
@@ -145,6 +150,17 @@ $WithClouseau = $(If ($EnableClouseau) {1} else {0})
$Hostname = [System.Net.Dns]::GetHostEntry([string]"localhost").HostName
big-r81 commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1590933133
##
configure.ps1:
##
@@ -145,6 +150,17 @@ $WithClouseau = $(If ($EnableClouseau) {1} else {0})
$Hostname =
nickva commented on PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#issuecomment-2090674505
Thanks for checking, Ronny!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
big-r81 commented on PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#issuecomment-2089942205
Hey Nick,
thats really great work. I installed the MSYS2 choco package to the Win-CI
and was able to compile CouchDB with QuickJS on Windows.
We need an additional small
nickva commented on PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#issuecomment-2089141941
After another update ready for review:
* Added Windows support using MSYS2 glazier
[PR](https://github.com/apache/couchdb-glazier/pull/32)
* A
nickva commented on PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#issuecomment-2019336436
Another update:
* The scanner app moved to it's own PR
https://github.com/apache/couchdb/pull/5014. With a sample plugin to detect
CouchDB 4.x planned deprecated ddoc features.
nickva commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1538552664
##
configure:
##
@@ -298,7 +318,7 @@ if [ "${ARCH}" = "aarch64" ] && [ "${SM_VSN}" = "60" ]; then
exit 1
fi
-if [ "${ERLANG_OS}" = "unix" ]; then
+if [
nickva commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1521549968
##
configure:
##
@@ -298,7 +318,7 @@ if [ "${ARCH}" = "aarch64" ] && [ "${SM_VSN}" = "60" ]; then
exit 1
fi
-if [ "${ERLANG_OS}" = "unix" ]; then
+if [
pgj commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1521395723
##
configure:
##
@@ -298,7 +318,7 @@ if [ "${ARCH}" = "aarch64" ] && [ "${SM_VSN}" = "60" ]; then
exit 1
fi
-if [ "${ERLANG_OS}" = "unix" ]; then
+if [
nickva commented on PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#issuecomment-1972150681
Some progress update:
* Updated QuickJS with the latest from upstream. We carried a few patches
(a CVE patch, FreeBSD compat, and some others). All those have been merged
upstream
43 matches
Mail list logo
