Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-fabric/pull/81#discussion_r94382214
--- Diff: src/fabric_view_all_docs.erl ---
@@ -56,12 +56,17 @@ go(DbName, Options, QueryArgs, Callback, Acc0) ->
include_docs =
[
https://issues.apache.org/jira/browse/COUCHDB-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15794869#comment-15794869
]
Sinan Gabel commented on COUCHDB-3029:
--
I had the same experience on a Ubuntu 16.04 server, and did
Github user willholley commented on the issue:
https://github.com/apache/couchdb-fabric/pull/81
thanks for the swift review @kxepal. I've made a few changes based on your
comments - the naming matches the existing conventions in the module (perhaps
not ideal, but consistent).
---
[
https://issues.apache.org/jira/browse/COUCHDB-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15794684#comment-15794684
]
ASF GitHub Bot commented on COUCHDB-3264:
-
GitHub user willholley opened a pull request:
GitHub user willholley opened a pull request:
https://github.com/apache/couchdb-fabric/pull/81
Include conflicts parameter in doc_options
When a keys array is passed to _all_docs, fabric translates this
to individual open_doc calls. The conflicts=true query parameter is
Github user kxepal commented on the issue:
https://github.com/apache/couchdb-fabric/pull/81
@willholley Thanks, that looks better (:
+1. Happy New Year! ð ð ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user rnewson commented on the issue:
https://github.com/apache/couchdb-fabric/pull/81
+1 also.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
[
https://issues.apache.org/jira/browse/COUCHDB-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795054#comment-15795054
]
ASF subversion and git services commented on COUCHDB-3264:
--
Commit
[
https://issues.apache.org/jira/browse/COUCHDB-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795055#comment-15795055
]
ASF GitHub Bot commented on COUCHDB-3264:
-
Github user asfgit closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-fabric/pull/81
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user nickva commented on the issue:
https://github.com/apache/couchdb-couch/pull/219
Right, right. I initially thought it was about doing something before
exiting anyway then handling thing in terminate might have worked, but if we
continue working terminate handling won't
Github user davisp commented on the issue:
https://github.com/apache/couchdb-couch/pull/219
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user davisp commented on the issue:
https://github.com/apache/couchdb-couch/pull/219
A note on the earlier conversation, the point of the original 'EXIT'
handling code was so that couch_file could outlive its parent. But that's not
possible because even if we trap exits,
Github user rnewson commented on the issue:
https://github.com/apache/couchdb-couch/pull/219
That we're in terminate means we didn't trap it. :)
Sent from my iPhone
> On 3 Jan 2017, at 15:59, Nick Vatamaniuc wrote:
>
> It should be
Github user nickva commented on the issue:
https://github.com/apache/couchdb-couch/pull/219
touché
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Nick Vatamaniuc created COUCHDB-3267:
Summary: Don't exit on timeout callback in cassim fabric:changes
feed
Key: COUCHDB-3267
URL: https://issues.apache.org/jira/browse/COUCHDB-3267
Project:
GitHub user padyx opened a pull request:
https://github.com/apache/couchdb-documentation/pull/96
Inline comments: Improve phrasing
The wording of the paragraph about inline comments is not optimal.
I suggest rephrasing it.
You can merge this pull request into a Git repository
17 matches
Mail list logo