[GitHub] couchdb-fabric pull request #81: Include conflicts parameter in doc_options

2017-01-03 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-fabric/pull/81#discussion_r94382214 --- Diff: src/fabric_view_all_docs.erl --- @@ -56,12 +56,17 @@ go(DbName, Options, QueryArgs, Callback, Acc0) -> include_docs =

[jira] [Commented] (COUCHDB-3029) make install - problem - Ubuntu 16.04 Desktop - wrong file version?

2017-01-03 Thread Sinan Gabel (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15794869#comment-15794869 ] Sinan Gabel commented on COUCHDB-3029: -- I had the same experience on a Ubuntu 16.04 server, and did

[GitHub] couchdb-fabric issue #81: Include conflicts parameter in doc_options

2017-01-03 Thread willholley
Github user willholley commented on the issue: https://github.com/apache/couchdb-fabric/pull/81 thanks for the swift review @kxepal. I've made a few changes based on your comments - the naming matches the existing conventions in the module (perhaps not ideal, but consistent). ---

[jira] [Commented] (COUCHDB-3264) POST to _all_docs does not respect conflicts=true

2017-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15794684#comment-15794684 ] ASF GitHub Bot commented on COUCHDB-3264: - GitHub user willholley opened a pull request:

[GitHub] couchdb-fabric pull request #81: Include conflicts parameter in doc_options

2017-01-03 Thread willholley
GitHub user willholley opened a pull request: https://github.com/apache/couchdb-fabric/pull/81 Include conflicts parameter in doc_options When a keys array is passed to _all_docs, fabric translates this to individual open_doc calls. The conflicts=true query parameter is

[GitHub] couchdb-fabric issue #81: Include conflicts parameter in doc_options

2017-01-03 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-fabric/pull/81 @willholley Thanks, that looks better (: +1. Happy New Year! 🎉 🎄 🎅 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] couchdb-fabric issue #81: Include conflicts parameter in doc_options

2017-01-03 Thread rnewson
Github user rnewson commented on the issue: https://github.com/apache/couchdb-fabric/pull/81 +1 also. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[jira] [Commented] (COUCHDB-3264) POST to _all_docs does not respect conflicts=true

2017-01-03 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795054#comment-15795054 ] ASF subversion and git services commented on COUCHDB-3264: -- Commit

[jira] [Commented] (COUCHDB-3264) POST to _all_docs does not respect conflicts=true

2017-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795055#comment-15795055 ] ASF GitHub Bot commented on COUCHDB-3264: - Github user asfgit closed the pull request at:

[GitHub] couchdb-fabric pull request #81: Include conflicts parameter in doc_options

2017-01-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/couchdb-fabric/pull/81 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] couchdb-couch issue #219: Don't trap exits in couch_file

2017-01-03 Thread nickva
Github user nickva commented on the issue: https://github.com/apache/couchdb-couch/pull/219 Right, right. I initially thought it was about doing something before exiting anyway then handling thing in terminate might have worked, but if we continue working terminate handling won't

[GitHub] couchdb-couch issue #219: Don't trap exits in couch_file

2017-01-03 Thread davisp
Github user davisp commented on the issue: https://github.com/apache/couchdb-couch/pull/219 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] couchdb-couch issue #219: Don't trap exits in couch_file

2017-01-03 Thread davisp
Github user davisp commented on the issue: https://github.com/apache/couchdb-couch/pull/219 A note on the earlier conversation, the point of the original 'EXIT' handling code was so that couch_file could outlive its parent. But that's not possible because even if we trap exits,

[GitHub] couchdb-couch issue #219: Don't trap exits in couch_file

2017-01-03 Thread rnewson
Github user rnewson commented on the issue: https://github.com/apache/couchdb-couch/pull/219 That we're in terminate means we didn't trap it. :) Sent from my iPhone > On 3 Jan 2017, at 15:59, Nick Vatamaniuc wrote: > > It should be

[GitHub] couchdb-couch issue #219: Don't trap exits in couch_file

2017-01-03 Thread nickva
Github user nickva commented on the issue: https://github.com/apache/couchdb-couch/pull/219 touché --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[jira] [Created] (COUCHDB-3267) Don't exit on timeout callback in cassim fabric:changes feed

2017-01-03 Thread Nick Vatamaniuc (JIRA)
Nick Vatamaniuc created COUCHDB-3267: Summary: Don't exit on timeout callback in cassim fabric:changes feed Key: COUCHDB-3267 URL: https://issues.apache.org/jira/browse/COUCHDB-3267 Project:

[GitHub] couchdb-documentation pull request #96: Inline comments: Improve phrasing

2017-01-03 Thread padyx
GitHub user padyx opened a pull request: https://github.com/apache/couchdb-documentation/pull/96 Inline comments: Improve phrasing The wording of the paragraph about inline comments is not optimal. I suggest rephrasing it. You can merge this pull request into a Git repository