[GitHub] garrensmith opened a new pull request #73: Update cloudant-follow and request

2018-02-27 Thread GitBox
garrensmith opened a new pull request #73: Update cloudant-follow and request URL: https://github.com/apache/couchdb-nano/pull/73 ## Overview Updates cloudant-follow to 0.16.3 and request to 2.83 ## Overview ## Testing recommendations Unit tests should

[GitHub] obi458 commented on issue #1182: fixed race is_idle

2018-02-27 Thread GitBox
obi458 commented on issue #1182: fixed race is_idle URL: https://github.com/apache/couchdb/pull/1182#issuecomment-368962363 One solution may be: If we are going to close the Db(couch_file) we try: ``` is_idle() -> andalso ets:insert_new(couch_dbs,self()). ```

[GitHub] obi458 commented on issue #1182: fixed race is_idle

2018-02-27 Thread GitBox
obi458 commented on issue #1182: fixed race is_idle URL: https://github.com/apache/couchdb/pull/1182#issuecomment-368998747 The motivation we thinking about the problem is: a lot of noproc errors in changes! Following by a lot of timeouts! Maybe we could better handle the badmatch!

[GitHub] wohali commented on issue #1174: shared secrete for proxy authentication

2018-02-27 Thread GitBox
wohali commented on issue #1174: shared secrete for proxy authentication URL: https://github.com/apache/couchdb/issues/1174#issuecomment-369000882 You should review the former `proxy_use_secret` functionality, which has not been working since 2.0.0, and determine if you can address your

[GitHub] davisp commented on issue #1182: fixed race is_idle

2018-02-27 Thread GitBox
davisp commented on issue #1182: fixed race is_idle URL: https://github.com/apache/couchdb/pull/1182#issuecomment-368977110 Aha! I was reading back through history and staring at this code to remind myself how this fits together and I realized that this isn't actually the right bug. The

[GitHub] wohali commented on issue #1160: Add support for Bcrypt password hashing

2018-02-27 Thread GitBox
wohali commented on issue #1160: Add support for Bcrypt password hashing URL: https://github.com/apache/couchdb/pull/1160#issuecomment-369009872 Great work here. I'm unable to comment on the code quality, but if @janl and @rnewson are happy, you've pleased the right people. As

[GitHub] nickva commented on issue #1176: Implement pluggable authentication and session support for replicator

2018-02-27 Thread GitBox
nickva commented on issue #1176: Implement pluggable authentication and session support for replicator URL: https://github.com/apache/couchdb/pull/1176#issuecomment-368998123 Debating whether to make this an opt-in feature at first and make the default plugin list =

[GitHub] pierrekilly commented on issue #1160: Add support for Bcrypt password hashing

2018-02-27 Thread GitBox
pierrekilly commented on issue #1160: Add support for Bcrypt password hashing URL: https://github.com/apache/couchdb/pull/1160#issuecomment-369019525 Very well! Just one precision about this: in case of PBKDF2, with `iterations` set to 10, there will be 10 iterations. In case of

[GitHub] t0nylai opened a new issue #1183: Proxy Authentication doesn't work when proxy_use_secret=true

2018-02-27 Thread GitBox
t0nylai opened a new issue #1183: Proxy Authentication doesn't work when proxy_use_secret=true URL: https://github.com/apache/couchdb/issues/1183 ## Expected Behavior When proxy_use_secret = true, I should be "authorized" with the correct password from

[GitHub] garrensmith closed pull request #73: Update cloudant-follow and request

2018-02-27 Thread GitBox
garrensmith closed pull request #73: Update cloudant-follow and request URL: https://github.com/apache/couchdb-nano/pull/73 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] obi458 commented on issue #1182: fixed race is_idle

2018-02-27 Thread GitBox
obi458 commented on issue #1182: fixed race is_idle URL: https://github.com/apache/couchdb/pull/1182#issuecomment-368768760 After some times on the couch and thinking about the problem i guess is_idle is wrong using monitored_by. I simulate scheduler(pause) always with an debug

[GitHub] garrensmith opened a new pull request #74: add notes on how to release

2018-02-27 Thread GitBox
garrensmith opened a new pull request #74: add notes on how to release URL: https://github.com/apache/couchdb-nano/pull/74 A short note on how to release This is an automated message from the Apache Git Service. To respond to

[GitHub] janl closed pull request #74: add notes on how to release

2018-02-27 Thread GitBox
janl closed pull request #74: add notes on how to release URL: https://github.com/apache/couchdb-nano/pull/74 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] jiangphcn commented on issue #496: Couchdb 3287 pluggable storage engines

2018-02-27 Thread GitBox
jiangphcn commented on issue #496: Couchdb 3287 pluggable storage engines URL: https://github.com/apache/couchdb/pull/496#issuecomment-368786394 +1 from my side. All tests passed locally. This is an automated message from

[GitHub] danielspang opened a new pull request #251: Use the correct node-local port

2018-02-27 Thread GitBox
danielspang opened a new pull request #251: Use the correct node-local port URL: https://github.com/apache/couchdb-documentation/pull/251 ## Overview Document the correct node-local port. ## Checklist - [ ] Documentation is written and is accurate; - [x ]

[GitHub] garrensmith closed issue #28: Please, consider using "follow" library with the following patch

2018-02-27 Thread GitBox
garrensmith closed issue #28: Please, consider using "follow" library with the following patch URL: https://github.com/apache/couchdb-nano/issues/28 This is an automated message from the Apache Git Service. To respond to

[GitHub] garrensmith commented on issue #71: Or-Clauses

2018-02-27 Thread GitBox
garrensmith commented on issue #71: Or-Clauses URL: https://github.com/apache/couchdb-nano/issues/71#issuecomment-368871855 I'm going to close this. Since its not an actual issue. It would be great if you could send us a PR for this @sbatururimi

[GitHub] garrensmith closed issue #71: Or-Clauses

2018-02-27 Thread GitBox
garrensmith closed issue #71: Or-Clauses URL: https://github.com/apache/couchdb-nano/issues/71 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above

[GitHub] garrensmith opened a new pull request #75: add basic license details

2018-02-27 Thread GitBox
garrensmith opened a new pull request #75: add basic license details URL: https://github.com/apache/couchdb-nano/pull/75 Add NOTICE and LICENSE files This is an automated message from the Apache Git Service. To respond to the

[GitHub] garrensmith closed pull request #75: add basic license details

2018-02-27 Thread GitBox
garrensmith closed pull request #75: add basic license details URL: https://github.com/apache/couchdb-nano/pull/75 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] garrensmith opened a new pull request #76: Travis update

2018-02-27 Thread GitBox
garrensmith opened a new pull request #76: Travis update URL: https://github.com/apache/couchdb-nano/pull/76 ## Overview Update travis to use newer version of node.js. Remove underscore.js and use built in function instead. Use `lodash/isEmpty` ## Testing recommendations If

[GitHub] garrensmith commented on issue #34: Couch DB 2 compatibilty

2018-02-27 Thread GitBox
garrensmith commented on issue #34: Couch DB 2 compatibilty URL: https://github.com/apache/couchdb-nano/issues/34#issuecomment-368871386 Nano should be compatible with CouchDB 2.0. Are there any specific api's you require?

[GitHub] garrensmith closed issue #34: Couch DB 2 compatibilty

2018-02-27 Thread GitBox
garrensmith closed issue #34: Couch DB 2 compatibilty URL: https://github.com/apache/couchdb-nano/issues/34 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] garrensmith commented on issue #28: Please, consider using "follow" library with the following patch

2018-02-27 Thread GitBox
garrensmith commented on issue #28: Please, consider using "follow" library with the following patch URL: https://github.com/apache/couchdb-nano/issues/28#issuecomment-368871040 We now using the cloudant-follow library. It should have all required fixes

[GitHub] garrensmith closed pull request #76: Travis update

2018-02-27 Thread GitBox
garrensmith closed pull request #76: Travis update URL: https://github.com/apache/couchdb-nano/pull/76 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL

[GitHub] garrensmith opened a new issue #77: Add the typescript definitions into nano repo

2018-02-27 Thread GitBox
garrensmith opened a new issue #77: Add the typescript definitions into nano repo URL: https://github.com/apache/couchdb-nano/issues/77 Typescript is a pretty popular programming language now and it is important to keep the type definitions up to date. I think it would be a lot easier to

[GitHub] wohali commented on issue #251: Use the correct node-local port

2018-02-27 Thread GitBox
wohali commented on issue #251: Use the correct node-local port URL: https://github.com/apache/couchdb-documentation/pull/251#issuecomment-368908067 +1, thank you for your contribution to CouchDB! This is an automated

[GitHub] wohali closed pull request #251: Use the correct node-local port

2018-02-27 Thread GitBox
wohali closed pull request #251: Use the correct node-local port URL: https://github.com/apache/couchdb-documentation/pull/251 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] davisp commented on issue #1182: fixed race is_idle

2018-02-27 Thread GitBox
davisp commented on issue #1182: fixed race is_idle URL: https://github.com/apache/couchdb/pull/1182#issuecomment-368908940 I thought about something similar the other day however I didn't go too far down that route as the cost of a message pass through couch_file would be quite a

[GitHub] oliverdain opened a new pull request #252: Suggested edit to make clear what a quorum actually represents.

2018-02-27 Thread GitBox
oliverdain opened a new pull request #252: Suggested edit to make clear what a quorum actually represents. URL: https://github.com/apache/couchdb-documentation/pull/252 ## Overview I found the documentation about read and write quorums for a cluster mode DB confusing. I think this

[GitHub] kocolosk commented on issue #1139: Fix for issue #1136 - Error 500 deleting DB without quorum

2018-02-27 Thread GitBox
kocolosk commented on issue #1139: Fix for issue #1136 - Error 500 deleting DB without quorum URL: https://github.com/apache/couchdb/pull/1139#issuecomment-369037334 Thanks for this PR @jjrodrig, very well done. The orphaned files are a known condition. They are OK from the

[GitHub] nickva commented on issue #1160: Add support for Bcrypt password hashing

2018-02-27 Thread GitBox
nickva commented on issue #1160: Add support for Bcrypt password hashing URL: https://github.com/apache/couchdb/pull/1160#issuecomment-369039661 @pierrekilly good point on it being a different types of parameter. It's not just linear difference. Maybe call it `bcrypt_work_factor`. In other

[GitHub] rnewson commented on issue #1160: Add support for Bcrypt password hashing

2018-02-27 Thread GitBox
rnewson commented on issue #1160: Add support for Bcrypt password hashing URL: https://github.com/apache/couchdb/pull/1160#issuecomment-369066063 definitely a separate parameter as they are not comparable. This is an