[GitHub] janl commented on issue #353: Add 2.3.x release notes

2018-11-15 Thread GitBox
janl commented on issue #353: Add 2.3.x release notes
URL: 
https://github.com/apache/couchdb-documentation/pull/353#issuecomment-439305788
 
 
   +1
   
   @wohali would you be up for rebasing my #328 which already included the 2.3 
plumbing?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] nickva edited a comment on issue #1734: Stop replications on target document write failures

2018-11-15 Thread GitBox
nickva edited a comment on issue #1734: Stop replications on target document 
write failures
URL: https://github.com/apache/couchdb/pull/1734#issuecomment-438377284
 
 
   @rnewson 
   
   > there are many legitimate reasons for a document write to fail and for the 
replication to continue regardless. 
   
   The `continue regardless` thing is what this is mostly about, it configures 
whether continuing should happen or shouldn't happen. Once it continues and 
checkpoints it's a headache to retry it (delete checkpoints on target and 
source, create / update the replication document, get another error, do the 
same thing again, etc). A replication "successfully" completing is misleading 
the user as well in  a way and can be perceived as a "data loss".
   
   >  If the count of failed writes is not persisted, it should be. 
   
   We fixed that recently and now is persisted between job runs (before it 
wasn't) but persisting it to the replication doc would invite more updates to 
doc which were trying to move away from, especially with continuous 
replications. We could persist it to the the checkpoint history, we already 
save it there. But we'd have to checkpoint and retrying the replication would 
involve all the hassle as described above. We could invent some other, new 
place to persist replication state (new type of local replicator docs).
   
   I am not against adding more detailed counts, but that could be orthogonal 
to the idea of stopping a replication job on failure. The downside is that it 
doesn't help with knowing which document failed and why. So even then, fixing 
it means doing a diff between databases or scouring log files.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali commented on issue #353: Add 2.3.x release notes

2018-11-15 Thread GitBox
wohali commented on issue #353: Add 2.3.x release notes
URL: 
https://github.com/apache/couchdb-documentation/pull/353#issuecomment-439273782
 
 
   Want to wait to merge until @janl has had a chance to review, but not sure 
if he has time. Will merge tomorrow either way.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] nickva commented on a change in pull request #1639: Switch to python 3

2018-11-15 Thread GitBox
nickva commented on a change in pull request #1639: Switch to python 3
URL: https://github.com/apache/couchdb/pull/1639#discussion_r234079719
 
 

 ##
 File path: src/mango/Makefile
 ##
 @@ -39,7 +39,7 @@ help:
 .PHONY: test
 # target: test - Runs test suite
 test:
-   nosetests
+   ./venv/bin/nosetests
 
 Review comment:
   I'll try to make it use a venv and remove this Makefile altogether. This was 
probably more useful when mango was a separate repo


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] nickva commented on a change in pull request #1639: Switch to python 3

2018-11-15 Thread GitBox
nickva commented on a change in pull request #1639: Switch to python 3
URL: https://github.com/apache/couchdb/pull/1639#discussion_r234079656
 
 

 ##
 File path: README-DEV.rst
 ##
 @@ -70,14 +67,14 @@ Gentoo-based Systems
 sudo emerge gnupg coreutils pkgconfig help2man sphinx python
 sudo pip install hypothesis requests nose
 
-RedHat-based (Fedora, Centos, RHEL) Systems
-~~~
+Centos 7 and RHEL 7
+~~~
 
 ::
 
 sudo yum install help2man python-sphinx python-docutils \
-python-pygments gnupg nodejs npm python-nose python-requests \
-python-hypothesis
+python-pygments gnupg nodejs npm python34-pip python-virtualenv
 
 Review comment:
   Yeah that's why I think it would be good to move to venvs


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[Jenkins] SUCCESS: CouchDB » master #403

2018-11-15 Thread Apache Jenkins Server
Yay, we passed. https://builds.apache.org/job/CouchDB/job/master/403/

[jira] [Commented] (COUCHDB-3326) Implement clustered purge API: _purge

2018-11-15 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/COUCHDB-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688827#comment-16688827
 ] 

ASF subversion and git services commented on COUCHDB-3326:
--

Commit 6da9b71ecc05e958f08c8aed59137d3765bbd22c in couchdb's branch 
refs/heads/master from jiangph
[ https://gitbox.apache.org/repos/asf?p=couchdb.git;h=6da9b71 ]

Avoid badmatch when getting fabric timeout

   - Avoid badmatch when putting set_purge_infos_limit
 and getting fabric timeout

COUCHDB-3326


> Implement clustered purge API: _purge
> -
>
> Key: COUCHDB-3326
> URL: https://issues.apache.org/jira/browse/COUCHDB-3326
> Project: CouchDB
>  Issue Type: New Feature
>  Components: Database Core, Documentation, HTTP Interface
>Reporter: Mayya Sharipova
>Priority: Major
>
> This implements the clustered purge API:
> {code:}
> curl -H 'Content-Type: application/json' -X POST 
> "http://adm:pass@127.0.0.1:5984/test1/_purge; -d 
> '{"d1":["3-410e46c04b51b4c3304ed232790a49da", 
> "3-420e46c04b51b4c3304ed232790a35db"],"d2":["2-a39d6d63f29a956ae39930f84dd71ec3"],
>  "d3":["1-bdca7a3ac9503bf6e46d7d7a782e8f03"]}'
> {code}
> Response: status_code 201 or 202
> {code:javascript}
> {
>   "purged": [
> {
>   "ok": true, //Quorum was reached, at least W nodes 
> successfully purged doc
>   "id": "d1",
>   "revs": [
> "3-410e46c04b51b4c3304ed232790a49da",
>"3-420e46c04b51b4c3304ed232790a35db"
>   ]
> },
> {
>   "accepted": true,  //Quorum was NOT reached, but request was 
> accepted
>   "id": "d2",   
>   "revs": [
> "2-a39d6d63f29a956ae39930f84dd71ec3"
>   ]
> },
> {
>   "ok": true,   
>   "id": "d3",
>   "revs": []//(DocId or Revs missing) OR (Revs are not leaf 
> revisions) 
> }  ],
>   "purge_seq": 
> "6-g1BMeJzLYWBgYMpgTmHgz8tPSTV2MDQy1zMAQsMckEQiQ5L8sxKZ4UoMcSrJAgC9PRRl"
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] jiangphcn closed pull request #1739: Avoid badmatch when getting fabric timeout

2018-11-15 Thread GitBox
jiangphcn closed pull request #1739: Avoid badmatch when getting fabric timeout
URL: https://github.com/apache/couchdb/pull/1739
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (COUCHDB-3326) Implement clustered purge API: _purge

2018-11-15 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/COUCHDB-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688766#comment-16688766
 ] 

ASF subversion and git services commented on COUCHDB-3326:
--

Commit 6da9b71ecc05e958f08c8aed59137d3765bbd22c in couchdb's branch 
refs/heads/timeout-_purged_infos_limit from jiangph
[ https://gitbox.apache.org/repos/asf?p=couchdb.git;h=6da9b71 ]

Avoid badmatch when getting fabric timeout

   - Avoid badmatch when putting set_purge_infos_limit
 and getting fabric timeout

COUCHDB-3326


> Implement clustered purge API: _purge
> -
>
> Key: COUCHDB-3326
> URL: https://issues.apache.org/jira/browse/COUCHDB-3326
> Project: CouchDB
>  Issue Type: New Feature
>  Components: Database Core, Documentation, HTTP Interface
>Reporter: Mayya Sharipova
>Priority: Major
>
> This implements the clustered purge API:
> {code:}
> curl -H 'Content-Type: application/json' -X POST 
> "http://adm:pass@127.0.0.1:5984/test1/_purge; -d 
> '{"d1":["3-410e46c04b51b4c3304ed232790a49da", 
> "3-420e46c04b51b4c3304ed232790a35db"],"d2":["2-a39d6d63f29a956ae39930f84dd71ec3"],
>  "d3":["1-bdca7a3ac9503bf6e46d7d7a782e8f03"]}'
> {code}
> Response: status_code 201 or 202
> {code:javascript}
> {
>   "purged": [
> {
>   "ok": true, //Quorum was reached, at least W nodes 
> successfully purged doc
>   "id": "d1",
>   "revs": [
> "3-410e46c04b51b4c3304ed232790a49da",
>"3-420e46c04b51b4c3304ed232790a35db"
>   ]
> },
> {
>   "accepted": true,  //Quorum was NOT reached, but request was 
> accepted
>   "id": "d2",   
>   "revs": [
> "2-a39d6d63f29a956ae39930f84dd71ec3"
>   ]
> },
> {
>   "ok": true,   
>   "id": "d3",
>   "revs": []//(DocId or Revs missing) OR (Revs are not leaf 
> revisions) 
> }  ],
>   "purge_seq": 
> "6-g1BMeJzLYWBgYMpgTmHgz8tPSTV2MDQy1zMAQsMckEQiQ5L8sxKZ4UoMcSrJAgC9PRRl"
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] ahayes commented on issue #353: Add 2.3.x release notes

2018-11-15 Thread GitBox
ahayes commented on issue #353: Add 2.3.x release notes
URL: 
https://github.com/apache/couchdb-documentation/pull/353#issuecomment-439224344
 
 
   Looks like it will be a good release! I like narwhal.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (COUCHDB-1380) logrotate doesn't work correctly with couchdb 1.2.x

2018-11-15 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/COUCHDB-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688765#comment-16688765
 ] 

ASF subversion and git services commented on COUCHDB-1380:
--

Commit 269224b8d3c2199643a0500076f4250c7d75 in couchdb's branch 
refs/heads/timeout-_purged_infos_limit from [~jiangph]
[ https://gitbox.apache.org/repos/asf?p=couchdb.git;h=269224b ]

Merge pull request #1717 from cloudant/COUCHDB-1380-fix-nasty-error

Fix nasty 500 error on POST to /_config

> logrotate doesn't work correctly with couchdb 1.2.x
> ---
>
> Key: COUCHDB-1380
> URL: https://issues.apache.org/jira/browse/COUCHDB-1380
> Project: CouchDB
>  Issue Type: Bug
>Affects Versions: 1.2
> Environment: CentOS 5.6 x64, couchdb 1.2.x (13th Jan 2012 - 
> 1.2.0a-08d8f89-git), logrotate 3.7.4
>Reporter: Alex Markham
>Assignee: Robert Newson
>Priority: Blocker
>  Labels: logging, logrotate
> Fix For: 1.2, 1.3
>
>
> Running logrotate -f with couchdb 1.2.x leaves null data at the start of the 
> couch.log file, I'm guessing equal to the size of data that should have been 
> removed and rotated into the log.1 (eg "head -c 10 couch.log" is 
> blank)
> This does not happen on couchdb 1.1.1, 1.0.2 or 1.0.3
> The log files then stay large, and when trying to grep or less them, they are 
> reported as binary.
> This seems to have happened to another user, but no details of OS or version 
> were reported: http://comments.gmane.org/gmane.comp.db.couchdb.user/16049 
> The logrotate config used is very similar to the one installed with couchdb -
> /var/log/couchdb/*.log {
>size=150M
>rotate 5
>copytruncate
>compress
>delaycompress
>notifempty
>missingok
> }
> Has there been any changes to the interaction with log files/file handles 
> since 1.1.1? Does couchdb need to receive a SIGHUP? Or can anyone reproduce 
> this?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] wohali closed pull request #352: Remove broken links to wiki.apache.org

2018-11-15 Thread GitBox
wohali closed pull request #352: Remove broken links to wiki.apache.org
URL: https://github.com/apache/couchdb-documentation/pull/352
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/ddocs/ddocs.rst b/src/ddocs/ddocs.rst
index 0aa0684..345948a 100644
--- a/src/ddocs/ddocs.rst
+++ b/src/ddocs/ddocs.rst
@@ -429,10 +429,6 @@ the `xml` provider in our function needs more care to 
handle nested objects
 correctly, and keys with invalid characters, but you've got the idea!
 
 .. seealso::
-CouchDB Wiki:
-- `Showing Documents
-  
`_
-
 CouchDB Guide:
 - `Show Functions `_
 
@@ -486,10 +482,6 @@ be a string when used inside a list function, so you'll 
need to use
 returning it.
 
 .. seealso::
-CouchDB Wiki:
-- `Listing Views with CouchDB 0.10 and later
-  
`_
-
 CouchDB Guide:
 - `Transforming Views with List Functions
   `_
@@ -541,11 +533,6 @@ A basic example that demonstrates all use-cases of update 
handlers:
 return [doc, 'Edited World!']
 }
 
-.. seealso::
-CouchDB Wiki:
-- `Document Update Handlers
-  `_
-
 .. _filterfun:
 
 Filter Functions
@@ -684,10 +671,6 @@ parameters to the :ref:`changes feed`::
 - `Guide to filter change notification
   `_
 
-CouchDB Wiki:
-- `Filtered replication
-  `_
-
 .. _vdufun:
 
 Validate Document Update Functions
@@ -871,7 +854,3 @@ modified by a user with the ``_admin`` role:
 CouchDB Guide:
 - `Validation Functions
   `_
-
-CouchDB Wiki:
-- `Document Update Validation
-  `_
diff --git a/src/install/unix.rst b/src/install/unix.rst
index b2b66df..5c7c08a 100644
--- a/src/install/unix.rst
+++ b/src/install/unix.rst
@@ -151,10 +151,6 @@ Python and Sphinx are only required for building the 
online documentation.
 Documentation build can be disabled by adding the ``--disable-docs`` flag to
 the ``configure`` script.
 
-.. seealso::
-
-* `Installing CouchDB 
`_
-
 Debian-based Systems
 
 
diff --git a/src/replication/protocol.rst b/src/replication/protocol.rst
index 8b62527..27d963c 100644
--- a/src/replication/protocol.rst
+++ b/src/replication/protocol.rst
@@ -1891,7 +1891,6 @@ Reference
 
 * `Refuge RCouch wiki 
`_
 * `CouchBase Lite IOS wiki 
`_
-* `CouchDB documentation `_
 
 .. _ECMA-262: 
http://www.ecma-international.org/publications/files/ecma-st/ECMA-262.pdf
 .. _MVCC: http://en.wikipedia.org/wiki/Multiversion_concurrency_control


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali commented on issue #352: Remove broken links to wiki.apache.org

2018-11-15 Thread GitBox
wohali commented on issue #352: Remove broken links to wiki.apache.org
URL: 
https://github.com/apache/couchdb-documentation/pull/352#issuecomment-439219001
 
 
   Thank you @jjrodrig !


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali closed issue #351: Broken Links to wiki.apache.org

2018-11-15 Thread GitBox
wohali closed issue #351: Broken Links to wiki.apache.org
URL: https://github.com/apache/couchdb-documentation/issues/351
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali opened a new pull request #353: Add 2.3.x release notes

2018-11-15 Thread GitBox
wohali opened a new pull request #353: Add 2.3.x release notes
URL: https://github.com/apache/couchdb-documentation/pull/353
 
 
   ## Overview
   
   Time to add the 2.3.x release notes.
   
   ## Testing recommendations
   
   Read them and make comments!
   
   ## Checklist
   
   - [X] Documentation is written and is accurate;
   - [X] `make check` passes with no errors
   - [ ] Update 
[rebar.config.script](https://github.com/apache/couchdb/blob/master/rebar.config.script)
 with the commit hash once this PR is rebased and merged
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] jjrodrig opened a new pull request #352: Remove broken links to wiki.apache.org

2018-11-15 Thread GitBox
jjrodrig opened a new pull request #352: Remove broken links to wiki.apache.org
URL: https://github.com/apache/couchdb-documentation/pull/352
 
 
   
   
   ## Overview
   Remove broken links to previous CouchDB wiki (wiki.apache.org).
   
   ## Testing recommendations
   affected docs:
   - src/ddocs/ddocs.rst 
   - src/install/unix.rst
   - src/replication/protocol.rst
   
   ## GitHub issue number
   Fixes #351 
   
   ## Related Pull Requests
   
   ## Checklist
   
   - [] Documentation is written and is accurate;
   - [X] `make check` passes with no errors
   - [ ] Update 
[rebar.config.script](https://github.com/apache/couchdb/blob/master/rebar.config.script)
 with the commit hash once this PR is rebased and merged
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali closed pull request #282: Clarify use of relevant [admins] section

2018-11-15 Thread GitBox
wohali closed pull request #282: Clarify use of relevant [admins] section
URL: https://github.com/apache/couchdb-documentation/pull/282
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/config/auth.rst b/src/config/auth.rst
index 8a22a2a..4d2cc51 100644
--- a/src/config/auth.rst
+++ b/src/config/auth.rst
@@ -29,9 +29,12 @@ Server Administrators
 users. This configuration is known as `Admin Party`, and is not recommended
 for in-production usage. You can crash the party simply by creating the
 first admin account. CouchDB server administrators and passwords are not
-stored in the ``_users`` database, but in the ``local.ini`` file, which
-should be appropriately secured and readable only by system
-administrators::
+stored in the ``_users`` database, but in the last ``[admins]`` section
+that CouchDB finds when loading its ini files. See :config:intro for
+details on config file order and behaviour. This file (which could be
+something like ``etc/local.ini`` or ``etc/local.d/10-admins.ini`` on a
+Debian/Ubuntu system installed from packages) should be appropriately
+secured and readable only by system administrators::
 
 [admins]
 ;admin = mysecretpassword
@@ -69,9 +72,8 @@ Server Administrators
 }
 
 If you already have a salted, encrypted password string (for example, from
-an old ``local.ini`` file, or from a different CouchDB server), then you
-can store the "raw" encrypted string, without having CouchDB doubly encrypt
-it.
+an old ini file, or from a different CouchDB server), then you can store
+the "raw" encrypted string, without having CouchDB doubly encrypt it.
 
 .. code-block:: http
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali commented on issue #282: Clarify use of relevant [admins] section

2018-11-15 Thread GitBox
wohali commented on issue #282: Clarify use of relevant [admins] section
URL: 
https://github.com/apache/couchdb-documentation/pull/282#issuecomment-439204244
 
 
   Perfect @ahayes  - thanks again for your contribution!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali commented on a change in pull request #335: Update responses and UI copy in Getting Started Guide

2018-11-15 Thread GitBox
wohali commented on a change in pull request #335: Update responses and UI copy 
in Getting Started Guide
URL: 
https://github.com/apache/couchdb-documentation/pull/335#discussion_r234022390
 
 

 ##
 File path: src/intro/tour.rst
 ##
 @@ -58,7 +63,7 @@ All we added to the previous request is the _all_dbs string.
 
 The response should look like::
 
-["_replicator","_users"]
+[]
 
 Review comment:
   Yes, sorry, `_global_changes` can be added to the response. Its creation is 
optional, but useful to highlight.
   
   The Docker container doesn't do the initial creation of databases because 
that cannot be done until all nodes are joined to the cluster. If you're using 
Docker to create a 3-node cluster, you wouldn't want it to incorrectly create 
those databases locally on each node before you have a chance to merge the 
nodes together into a single cluster. It's a chicken-and-egg problem ;)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] ahayes commented on issue #282: Clarify use of relevant [admins] section

2018-11-15 Thread GitBox
ahayes commented on issue #282: Clarify use of relevant [admins] section
URL: 
https://github.com/apache/couchdb-documentation/pull/282#issuecomment-439194767
 
 
   I think I have managed to resolve all your suggestions and make TravisCI 
happy too. (I have filed a feature request with GitHub to display cursor 
position in their text editor so small fixes on the web are easier!)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] m90 commented on a change in pull request #335: Update responses and UI copy in Getting Started Guide

2018-11-15 Thread GitBox
m90 commented on a change in pull request #335: Update responses and UI copy in 
Getting Started Guide
URL: 
https://github.com/apache/couchdb-documentation/pull/335#discussion_r234007878
 
 

 ##
 File path: src/intro/tour.rst
 ##
 @@ -58,7 +63,7 @@ All we added to the previous request is the _all_dbs string.
 
 The response should look like::
 
-["_replicator","_users"]
+[]
 
 Review comment:
   Ok, I see. What I did is just pull `couchdb:2.2.0` from docker hub, `run` 
it, and since I was able to read and write data, I assumed things were setup 
correctly, so adding a link to the setup page would definitely be a good idea I 
think.
   
   That being said, after doing what I have been advised to in the setup 
doucment I will see the following:
   
   ```
   ➜  ~ curl http://127.0.0.1:5984/_all_dbs
   ["_global_changes","_replicator","_users"]
   ```
   
   which still does not match the documented response. Should this be edited in 
order to contain the `_global_changes`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] ahayes commented on issue #282: Clarify use of relevant [admins] section

2018-11-15 Thread GitBox
ahayes commented on issue #282: Clarify use of relevant [admins] section
URL: 
https://github.com/apache/couchdb-documentation/pull/282#issuecomment-439184408
 
 
   I'm a n00b! I need to figure out how to merge. Am happy to. Give me an hour.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] manobi commented on issue #1539: Multi-tenancy support

2018-11-15 Thread GitBox
manobi commented on issue #1539: Multi-tenancy support
URL: https://github.com/apache/couchdb/issues/1539#issuecomment-439181017
 
 
   @wohali Thanks for sharing, I will be following your recommendation.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali commented on issue #282: Clarify use of relevant [admins] section

2018-11-15 Thread GitBox
wohali commented on issue #282: Clarify use of relevant [admins] section
URL: 
https://github.com/apache/couchdb-documentation/pull/282#issuecomment-439171836
 
 
   @ahayes I'd love to close this out and get this merged in, but your PR needs 
a few small changes. Would you have time to get these cleaned up soon? If not, 
I'm afraid I'll have to close this PR without merging it. :(
   
   Thanks again for your contributions, they are most welcome!!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali commented on issue #1605: Feature/user partitioned databases

2018-11-15 Thread GitBox
wohali commented on issue #1605: Feature/user partitioned databases
URL: https://github.com/apache/couchdb/pull/1605#issuecomment-439171476
 
 
   Please note, we are moving swiftly now into the 2.3.0 release cycle. Until 
2.3.x has branched, _**do not merge this PR into `master`**_.
   
   I will update this PR when that has happened. Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali commented on issue #323: Update purging.rst

2018-11-15 Thread GitBox
wohali commented on issue #323: Update purging.rst
URL: 
https://github.com/apache/couchdb-documentation/pull/323#issuecomment-439171058
 
 
   @zacharylawson thank you for your FIRST TIME contribution to CouchDB! 
:gorilla: :baby: :zap:
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali closed pull request #323: Update purging.rst

2018-11-15 Thread GitBox
wohali closed pull request #323: Update purging.rst
URL: https://github.com/apache/couchdb-documentation/pull/323
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/cluster/purging.rst b/src/cluster/purging.rst
index 996ef86..3b54501 100644
--- a/src/cluster/purging.rst
+++ b/src/cluster/purging.rst
@@ -129,7 +129,7 @@ consistency within the main database.
 
 Config Settings
 
-These settings ca be updated in the default.ini or local.ini:
+These settings can be updated in the default.ini or local.ini:
 
 .. code-block:: text
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali commented on issue #328: feat: update docs for new query server config

2018-11-15 Thread GitBox
wohali commented on issue #328: feat: update docs for new query server config
URL: 
https://github.com/apache/couchdb-documentation/pull/328#issuecomment-439170714
 
 
   @janl please don't forget about this one, needs to land before 2.3.0 can go 
out the door. thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali commented on a change in pull request #335: Update responses and UI copy in Getting Started Guide

2018-11-15 Thread GitBox
wohali commented on a change in pull request #335: Update responses and UI copy 
in Getting Started Guide
URL: 
https://github.com/apache/couchdb-documentation/pull/335#discussion_r233984228
 
 

 ##
 File path: src/intro/tour.rst
 ##
 @@ -58,7 +63,7 @@ All we added to the previous request is the _all_dbs string.
 
 The response should look like::
 
-["_replicator","_users"]
+[]
 
 Review comment:
   This means you didn't finish installation correctly. See 
http://docs.couchdb.org/en/stable/install/setup.html for the steps you missed.
   
   Absolutely the response should be `["_replicator","_users"]`. If you want to 
put an admonishment in here with a link to the doc page I mentioned above, go 
for it. ([Use the RST syntax for 
linking](http://www.sphinx-doc.org/en/master/usage/restructuredtext/roles.html#ref-role),
 not a link to the URL, please.)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] Antonio-Maranhao opened a new pull request #1158: Partitioned dbs index editor updates

2018-11-15 Thread GitBox
Antonio-Maranhao opened a new pull request #1158: Partitioned dbs index editor 
updates
URL: https://github.com/apache/couchdb-fauxton/pull/1158
 
 
   ## Overview
   
   Seventh (and last ) in a series of PRs that will be submitted in support of 
the new user-defined partitioned databases feature (apache/couchdb#1605).
   
   Summary:
   
- Add 'Partitioned' checkbox to Index Editor
 - Checkbox is read-only for existing ddocs and is updated to reflect the 
selected ddoc
 - Checkbox is editable when choosing to create a new ddoc
 - CUSTOM reducer option is not shown when editing/creating partitioned 
views
- Add 'Partitioned' checkbox to Clone Index modal
   
   ## Testing recommendations
   
   On a partitioned database: 
   - Click on 'New view'
  - Select 'New Document', name the new ddoc, and make sure 'Partitioned' 
is checked
  - Verify the 'CUSTOM' reducer is not listed
  - Click the button to create the view
  - Verify the new view is partitioned
   - Use the menu to clone the view you just created
 - Select 'New Document', name the new ddoc and view, and uncheck 
'Partitioned'
  - Click the button to clone the view
  - Verify the new view is global
  - Verify the original view still exists
   - Click on 'New view'
  - Select 'New Document', name the new ddoc, and uncheck 'Partitioned' 
  - Verify the 'CUSTOM' reducer is listed
  - Click the button to create the view
  - Verify the new view is global
   
   ## Related Pull Requests
   
   apache/couchdb#1605
   
   ## Checklist
   
   - [x] Code is written and works correctly;
   - [x] Changes are covered by tests;
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali commented on a change in pull request #348: Improve clustered purge documentation

2018-11-15 Thread GitBox
wohali commented on a change in pull request #348: Improve clustered purge 
documentation
URL: 
https://github.com/apache/couchdb-documentation/pull/348#discussion_r233982704
 
 

 ##
 File path: src/cluster/purging.rst
 ##
 @@ -129,45 +131,52 @@ consistency within the main database.
 
 Config Settings
 
-These settings ca be updated in the default.ini or local.ini:
+These settings can be updated in the default.ini or local.ini:
+
++---++--+
+| Field | Description| Default 
 |
++===++==+
+| max_document_id_number| Allowed maximum number of documents in one | 100 
 |
+|   | purge request  | 
 |
++---++--+
+| max_revisions_number  | Allowed maximum number of accumulated  | 1000
 |
+|   | revisions in one purge request | 
 |
++---++--+
+| allowed_purge_seq_lag | Beside purged_infos_limit, allowed | 100 
 |
+|   | additional buffer to store purge requests  | 
 |
++---++--+
+| index_lag_warn_seconds| Allowed durations when index is not| 
 |
+|   | updated for local purge checkpoint document| 86400   
 |
 
 Review comment:
   Top-align 86400 to the previous line (line 148) please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali commented on a change in pull request #348: Improve clustered purge documentation

2018-11-15 Thread GitBox
wohali commented on a change in pull request #348: Improve clustered purge 
documentation
URL: 
https://github.com/apache/couchdb-documentation/pull/348#discussion_r233982991
 
 

 ##
 File path: src/cluster/purging.rst
 ##
 @@ -129,45 +131,52 @@ consistency within the main database.
 
 Config Settings
 
-These settings ca be updated in the default.ini or local.ini:
+These settings can be updated in the default.ini or local.ini:
+
++---++--+
+| Field | Description| Default 
 |
++===++==+
+| max_document_id_number| Allowed maximum number of documents in one | 100 
 |
+|   | purge request  | 
 |
++---++--+
+| max_revisions_number  | Allowed maximum number of accumulated  | 1000
 |
+|   | revisions in one purge request | 
 |
++---++--+
+| allowed_purge_seq_lag | Beside purged_infos_limit, allowed | 100 
 |
+|   | additional buffer to store purge requests  | 
 |
++---++--+
+| index_lag_warn_seconds| Allowed durations when index is not| 
 |
+|   | updated for local purge checkpoint document| 86400   
 |
++---++--+
+
+During a database compaction,  we check all checkpoint purge docs. A client (an
+index or internal replication job) is allowed to have the last reported
+``purge_seq`` to be smaller than the current database shard's ``purge_seq`` by
+the value of ``(purged_infos_limit + allowed_purge_seq_lag)``.  If the client's
+``purge_seq`` is even smaller, and the client has not checkpointed within
+``index_lag_warn_seconds``, it prevents compaction of purge trees and we have 
to
+issue the following log warning for this client:
+
+.. code-block:: text
+
+Purge checkpoint '_local/purge-mrview-9152d15c12011288629bcffba7693fd4’
+not updated in 86400 seconds in
+<<"shards/-1fff/testdb12.1491979089">>
+
+If this type of log warnings occurs, check the client to see why the processing
 
 Review comment:
   Should be "types of log warnings" or "type of log warning" - plurality 
agreement :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali commented on a change in pull request #348: Improve clustered purge documentation

2018-11-15 Thread GitBox
wohali commented on a change in pull request #348: Improve clustered purge 
documentation
URL: 
https://github.com/apache/couchdb-documentation/pull/348#discussion_r233982570
 
 

 ##
 File path: src/cluster/purging.rst
 ##
 @@ -93,6 +93,7 @@ Internal Replication
 
 Purge requests are replayed across all nodes in an eventually consistent 
manner.
 Internal replication of purges consists of two steps:
+
 
 Review comment:
   If spacing doesn't render well, don't add blank lines here and on line 105. 
These will prevent RST/Sphinx from recognizing this as a numbered list.
   
   Instead add the following text:
   
   ```rst
   .. rst-class:: open
   ```
   
   just after your section header on line 93. Check the output, but it should 
give you the effect you're  looking for.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali commented on a change in pull request #348: Improve clustered purge documentation

2018-11-15 Thread GitBox
wohali commented on a change in pull request #348: Improve clustered purge 
documentation
URL: 
https://github.com/apache/couchdb-documentation/pull/348#discussion_r233983335
 
 

 ##
 File path: src/cluster/purging.rst
 ##
 @@ -129,45 +131,52 @@ consistency within the main database.
 
 Config Settings
 
-These settings ca be updated in the default.ini or local.ini:
+These settings can be updated in the default.ini or local.ini:
+
++---++--+
+| Field | Description| Default 
 |
++===++==+
+| max_document_id_number| Allowed maximum number of documents in one | 100 
 |
+|   | purge request  | 
 |
++---++--+
+| max_revisions_number  | Allowed maximum number of accumulated  | 1000
 |
+|   | revisions in one purge request | 
 |
++---++--+
+| allowed_purge_seq_lag | Beside purged_infos_limit, allowed | 100 
 |
+|   | additional buffer to store purge requests  | 
 |
++---++--+
+| index_lag_warn_seconds| Allowed durations when index is not| 
 |
+|   | updated for local purge checkpoint document| 86400   
 |
++---++--+
+
+During a database compaction,  we check all checkpoint purge docs. A client (an
+index or internal replication job) is allowed to have the last reported
+``purge_seq`` to be smaller than the current database shard's ``purge_seq`` by
+the value of ``(purged_infos_limit + allowed_purge_seq_lag)``.  If the client's
+``purge_seq`` is even smaller, and the client has not checkpointed within
+``index_lag_warn_seconds``, it prevents compaction of purge trees and we have 
to
+issue the following log warning for this client:
+
+.. code-block:: text
+
+Purge checkpoint '_local/purge-mrview-9152d15c12011288629bcffba7693fd4’
+not updated in 86400 seconds in
+<<"shards/-1fff/testdb12.1491979089">>
+
+If this type of log warnings occurs, check the client to see why the processing
+of purge requests is stalled in it.
+
+There is a mapping relationship between a design document of indexes and local
+checkpoint docs. If a design document of indexes is updated or deleted, the
+corresponding local checkpoint document should be also automatically deleted.
+But in an unexpected case, when a design doc was updated/deleted, but its
+checkpoint document still exists in a database, the following warning will be
+issued:
 
 .. code-block:: text
 
-[purge]
-max_document_id_number = 100
-max_revisions_number = 1000
-allowed_purge_seq_lag = 100
-index_lag_warn_seconds =  86400
-
-1. ``max_document_id_number`` (default 100)
-Allowed maximum number of documents in one purge request
-2. ``max_revisions_number`` (default 1000)
-Allowed maximum number of accumulated revisions in one purge request.
-3. ``index_lag_warn_seconds`` (default 86400 sec or 1 day)
-During a database compaction,  we check all checkpoint purge docs. A 
client (an
-index or internal replication job) is allowed to have the last reported
-``purge_seq`` to be smaller than the current database shard's 
``purge_seq`` by
-the value of ``(purged_infos_limit + index_lag_warn_seconds)``.  If 
the client's
-``purge_seq`` is even smaller, and the client has not checkpointed 
within
-``index_lag_warn_seconds``, it prevents compaction of purge trees and 
we have to
-issue the following log warning for this client:
-
-::
-Purge checkpoint '<<"_design/bar">>' not updated in 86400 
seconds
-
-If this type of log warnings occurs, check the client to see why the 
processing
-of purge requests is stalled in it.
-
-There is a mapping relationship between design document of indexes and 
local
-checkpoint docs. If a design document of indexes is updated or 
deleted, the
-corresponding local checkpoint document should be also automatically 
deleted.
-But in an unexpected case, when a design doc was updated/deleted, but 
its
-checkpoint document still exist in a database, the following warning 
will be
-issued:
-
-::
-"Invalid purge doc '<<"_design/bar">>' on database
-<<"shards/-1fff/testdb12.1491979089">>
-with purge_seq '50'"
-
-If this type of log warnings occur, remove the local purge doc 

[GitHub] wohali commented on issue #336: 2.3.x

2018-11-15 Thread GitBox
wohali commented on issue #336: 2.3.x
URL: 
https://github.com/apache/couchdb-documentation/pull/336#issuecomment-439164642
 
 
   @dch I'm going to take over on release notes for 2.3.0 now, so I'm closing 
this out - but stealing your work. Thank you!!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali closed pull request #336: 2.3.x

2018-11-15 Thread GitBox
wohali closed pull request #336: 2.3.x
URL: https://github.com/apache/couchdb-documentation/pull/336
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/conf.py b/src/conf.py
index 34ef1bd..39a40da 100644
--- a/src/conf.py
+++ b/src/conf.py
@@ -28,8 +28,8 @@
 nitpicky = True
 
 # should be over-written using rebar-inherited settings
-version = '2.2'
-release = '2.2.0'
+version = '2.3'
+release = '2.3.0'
 
 project = 'Apache CouchDB'
 
diff --git a/src/whatsnew/2.3.rst b/src/whatsnew/2.3.rst
new file mode 100644
index 000..9584af7
--- /dev/null
+++ b/src/whatsnew/2.3.rst
@@ -0,0 +1,67 @@
+.. Licensed under the Apache License, Version 2.0 (the "License"); you may not
+.. use this file except in compliance with the License. You may obtain a copy 
of
+.. the License at
+..
+..   http://www.apache.org/licenses/LICENSE-2.0
+..
+.. Unless required by applicable law or agreed to in writing, software
+.. distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+.. WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+.. License for the specific language governing permissions and limitations 
under
+.. the License.
+
+.. _release/2.3.x:
+
+
+2.3.x Branch
+
+
+.. contents::
+:depth: 1
+:local:
+
+.. _release/2.3.x/upgrade:
+
+Upgrade Notes
+=
+
+.. rst-class:: open
+
+.. _release/2.3.0:
+
+Version 2.3.0
+=
+
+Features
+
+
+.. rst-class:: open
+
+* Much improved documentation. Highlights include:
+
+Performance
+---
+
+.. rst-class:: open
+
+
+Bugfixes
+
+
+.. rst-class:: open
+
+
+Mango
+-
+
+.. rst-class:: open
+
+Other
+-
+
+The 2.3.0 release also includes the following minor improvements:
+
+.. rst-class:: open
+
+* Replication supports ipv6-only peers after updating ibrowse dependency.
+* A narwhal! OK, no, not really. If you got this far...thank you for reading.
diff --git a/src/whatsnew/index.rst b/src/whatsnew/index.rst
index ade0988..3620588 100644
--- a/src/whatsnew/index.rst
+++ b/src/whatsnew/index.rst
@@ -19,6 +19,7 @@ Release History
 .. toctree::
 :glob:
 
+2.3
 2.2
 2.1
 2.0


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali commented on issue #38: local.ini sourced from tree on installation

2018-11-15 Thread GitBox
wohali commented on issue #38: local.ini sourced from tree on installation
URL: https://github.com/apache/couchdb-pkg/pull/38#issuecomment-439162364
 
 
   Hi @sklassen , sorry I haven't had time to look at this. I'm moving into 
2.3.0 release activities and don't have much time free for other issues. I am 
going to do my best to get this sorted and merged before then, but I'm still 
not 100% sure I want to promote a snap as an official thing for 2.3.0 - more 
likely it'll be a beta channel snap until we're sure we have all the issues 
ironed out.
   
   The soonest I'll be able to look at this ticket again is Saturday. Sorry 
about that.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali commented on issue #351: Broken Links to wiki.apache.org

2018-11-15 Thread GitBox
wohali commented on issue #351: Broken Links to wiki.apache.org
URL: 
https://github.com/apache/couchdb-documentation/issues/351#issuecomment-439161899
 
 
   @jjrodrig Good catch - we are indeed moving all of the old (ancient, really) 
wiki content into the docs proper, but haven't yet scrubbed the links back to 
the wiki from the docs.
   
   Would you be so kind as to submit a PR removing these? Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali commented on a change in pull request #1639: Switch to python 3

2018-11-15 Thread GitBox
wohali commented on a change in pull request #1639: Switch to python 3
URL: https://github.com/apache/couchdb/pull/1639#discussion_r233965858
 
 

 ##
 File path: README-DEV.rst
 ##
 @@ -70,14 +67,14 @@ Gentoo-based Systems
 sudo emerge gnupg coreutils pkgconfig help2man sphinx python
 sudo pip install hypothesis requests nose
 
-RedHat-based (Fedora, Centos, RHEL) Systems
-~~~
+Centos 7 and RHEL 7
+~~~
 
 ::
 
 sudo yum install help2man python-sphinx python-docutils \
-python-pygments gnupg nodejs npm python-nose python-requests \
-python-hypothesis
+python-pygments gnupg nodejs npm python34-pip python-virtualenv
 
 Review comment:
   Same problem as above. You're going to have to be careful though:
   
   https://pkgs.org/download/python-nose
   
   the package name changes depending on the version of python that ships with 
that release AND it requires a custom repo. Might be easier to use a global 
`pip` or `pip3` here - you'll need to see what the distro calls it at the CLI. 
Sorry about that.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali commented on a change in pull request #1639: Switch to python 3

2018-11-15 Thread GitBox
wohali commented on a change in pull request #1639: Switch to python 3
URL: https://github.com/apache/couchdb/pull/1639#discussion_r233964507
 
 

 ##
 File path: README-DEV.rst
 ##
 @@ -60,7 +57,7 @@ Debian-based (inc. Ubuntu) Systems
 ::
 
 sudo apt-get install help2man python-sphinx gnupg nodejs npm \
- python-hypothesis python-requests python-nose
+ python3-pip python-virtualenv
 
 Review comment:
   You can't remove hypothesis and nose here since the instructions lower down 
to use pip to install system versions is only for OSX.
   
   There are `python3-hypothesis` and `python3-nose` and `python3-requests` 
packages. Check https://packages.debian.org/ and https://packages.ubuntu.com/ 
to ensure these are available for our supported OSes:
   
   * Debian stretch
   * Debian jessie
   * Ubuntu trusty
   * Ubuntu xenial
   * Ubuntu bionic
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali commented on a change in pull request #1639: Switch to python 3

2018-11-15 Thread GitBox
wohali commented on a change in pull request #1639: Switch to python 3
URL: https://github.com/apache/couchdb/pull/1639#discussion_r233967095
 
 

 ##
 File path: src/mango/Makefile
 ##
 @@ -39,7 +39,7 @@ help:
 .PHONY: test
 # target: test - Runs test suite
 test:
-   nosetests
+   ./venv/bin/nosetests
 
 Review comment:
   I thought we agreed we wouldn't use a virtualenv for this.
   
   Besides, you haven't even `pip install`ed the prerequisites necessary into 
that venv.
   
   Finally, the top level `Makefile` is unchanged in this PR, meaning when you 
do a `make check` or `make mango-test` you execute:
   
   ```makefile
   .PHONY: mango-test
   # target: mango-test - Run Mango tests
   mango-test: devclean all
   @cd src/mango && ../../dev/run -n 1 --admin=testuser:testpass nosetests
   ```
   
   Would like to see consistency here, one way or the other.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] jjrodrig opened a new issue #351: Broken Links to wiki.apache.org

2018-11-15 Thread GitBox
jjrodrig opened a new issue #351: Broken Links to wiki.apache.org
URL: https://github.com/apache/couchdb-documentation/issues/351
 
 
   
   
   Checking the doc I've noticed that all links to the content in the old wiki 
seems to be broken. 
   
   Currently, there are the following references to the wiki.
   
   ```
   src/ddocs/ddocs.rst:  
`_
   src/ddocs/ddocs.rst:  
`_
   src/ddocs/ddocs.rst:  
`_
   src/ddocs/ddocs.rst:  
`_
   src/ddocs/ddocs.rst:  
`
   
   src/install/unix.rst:* `Installing CouchDB 
`_
   src/replication/protocol.rst:* `CouchDB documentation 
`_
   
   ```
   In this situation could be better to remove them from the doc. 
   There is any reason for keeping them in the doc?
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] sklassen commented on issue #38: local.ini sourced from tree on installation

2018-11-15 Thread GitBox
sklassen commented on issue #38: local.ini sourced from tree on installation
URL: https://github.com/apache/couchdb-pkg/pull/38#issuecomment-438994858
 
 
   @wohali , If you're uncomfortable with the 'snap set' for couchdb 
configuration files then I can remove it. (I will leave 'snap set' for 
vm.args). CouchDB configure can be modified manually or via HTTP configure. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] tudordumitriu commented on issue #1712: Validate Document Update oldDoc in ddoc is null after doc PUT for n=1 server

2018-11-15 Thread GitBox
tudordumitriu commented on issue #1712: Validate Document Update oldDoc in ddoc 
is null after doc PUT for n=1 server
URL: https://github.com/apache/couchdb/issues/1712#issuecomment-438967526
 
 
   @wohali Thanks,
   We'll be waiting then


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services