[GitHub] [couchdb] nickva commented on a diff in pull request #4718: enhance smoosh to cleanup search indexes when ddocs change

2023-08-18 Thread via GitHub
nickva commented on code in PR #4718: URL: https://github.com/apache/couchdb/pull/4718#discussion_r1298530399 ## src/fabric/src/fabric.erl: ## @@ -590,25 +590,38 @@ cleanup_index_files(DbName) -> cleanup_local_indices_and_purge_checkpoints([]) -> ok;

[GitHub] [couchdb] rnewson commented on pull request #4729: Fabric workers should exit if the client exits

2023-08-18 Thread via GitHub
rnewson commented on PR #4729: URL: https://github.com/apache/couchdb/pull/4729#issuecomment-1683488124 good point on `fabric_doc_update` and possibly others. I confirmed directly and via haproxy that a client that disconnects (curl and CTRL-C in the first case and simply doing

[GitHub] [couchdb] rnewson commented on a diff in pull request #4729: Fabric workers should exit if the client exits

2023-08-18 Thread via GitHub
rnewson commented on code in PR #4729: URL: https://github.com/apache/couchdb/pull/4729#discussion_r1298106491 ## rel/haproxy.cfg: ## @@ -25,9 +25,9 @@ defaults option redispatch retries 4 option http-server-close -timeout client 15 -

[GitHub] [couchdb-fauxton] YakovL opened a new issue, #1411: Don't throw from Mango Query tab after doc edit

2023-08-18 Thread via GitHub
YakovL opened a new issue, #1411: URL: https://github.com/apache/couchdb-fauxton/issues/1411 ## Expected Behavior When I'm in the Mango Query tab (/_utils/#/database/db_name/_find), after running a query I can click on a document to see its contents or to edit it. When I leave the doc

[GitHub] [couchdb] rnewson commented on a diff in pull request #4718: enhance smoosh to cleanup search indexes when ddocs change

2023-08-18 Thread via GitHub
rnewson commented on code in PR #4718: URL: https://github.com/apache/couchdb/pull/4718#discussion_r1298337833 ## src/fabric/src/fabric.erl: ## @@ -590,25 +590,38 @@ cleanup_index_files(DbName) -> cleanup_local_indices_and_purge_checkpoints([]) -> ok;

[Jenkins] SUCCESS: CouchDB » Full Platform Builds » main #818

2023-08-18 Thread Apache Jenkins Server
Yay, we passed. https://ci-couchdb.apache.org/job/jenkins-cm1/job/FullPlatformMatrix/job/main/818/display/redirect

[GitHub] [couchdb] nickva commented on a diff in pull request #4729: Fabric workers should exit if the client exits

2023-08-18 Thread via GitHub
nickva commented on code in PR #4729: URL: https://github.com/apache/couchdb/pull/4729#discussion_r1298913972 ## rel/haproxy.cfg: ## @@ -25,9 +25,9 @@ defaults option redispatch retries 4 option http-server-close -timeout client 15 -

[GitHub] [couchdb] nickva commented on pull request #4729: Fabric workers should exit if the client exits

2023-08-18 Thread via GitHub
nickva commented on PR #4729: URL: https://github.com/apache/couchdb/pull/4729#issuecomment-1684533075 > I confirmed directly and via haproxy that a client that disconnects (curl and CTRL-C in the first case and simply doing something that hits haproxy's server timeout like